From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70ACEC636CD for ; Fri, 10 Feb 2023 04:26:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC2EB6B00E2; Thu, 9 Feb 2023 23:26:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D73B16B00E3; Thu, 9 Feb 2023 23:26:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3ABA6B00E4; Thu, 9 Feb 2023 23:26:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B66E96B00E2 for ; Thu, 9 Feb 2023 23:26:26 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 801AEABB28 for ; Fri, 10 Feb 2023 04:26:26 +0000 (UTC) X-FDA: 80450095572.07.0C3B684 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf10.hostedemail.com (Postfix) with ESMTP id BDF1EC000C for ; Fri, 10 Feb 2023 04:26:24 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=g+HDZLcb; spf=pass (imf10.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676003184; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pt8I2gDFGkJc89VFttBAWrczFbW6HxF9sU3Iiy4h4oU=; b=rzd/AfqyavDCr2bGDqigaN6AoFA/0NQ9hES7FHUxlEiAYcUn+jZuwSKynv1icZeEzFZMFA lH+wklhMWRmwVrXr6KcB9NGGXft7Ao9k31G9ADvh8FjLUPbBzXCELD40fMMmWvUm4SFMAf q/p8rSjL/W0eLYo7Xzzb/hKWs/beGLc= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=g+HDZLcb; spf=pass (imf10.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676003184; a=rsa-sha256; cv=none; b=UwanGnhvLRwpRx9JC7KloT1lPhHr9h5cAWxryeS3MZlySgeazyC8/OjSZ/QEpm94QqdUKr XBHD6a8NYh5yL7+NotkIS8ofrYDTtfxMxL03J6ZAFGKgkATs1JA1vS2+N1hh0Ko/BqhgXG biI2/1yeyjfZUINUUbz7xA8QfPdBM2E= Received: by mail-ed1-f46.google.com with SMTP id c1so7443edt.4 for ; Thu, 09 Feb 2023 20:26:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=pt8I2gDFGkJc89VFttBAWrczFbW6HxF9sU3Iiy4h4oU=; b=g+HDZLcbqkc9l7r/SLkHf3MTXGwy+3wwTPT71E8FfYc4mybXqO31ghDAQDsbZu2uHl FzPJVeyM/Dtz86hUSokx0iYG6ISvjb47q/T7V2C701u1Hm2gVdr206fksdEI16y0koOt VQ7t0ehgPcNQ5dLAx57Yx1V8VyT9QSMa9UI7ezuM6ISnrWVqPrpkRtoeZg7oXWVI+GzA CwR4o8SjPLqhBeBO6QXPgxcJDLwzgh/gSRnXu9VskUolt2xM1le5UQbOwd/0aXCstTKi ASCeUFtRHSqANPkim7ChOKtQa9+TLYf3/GN2G3TnMQbjwx/yDBHThSPlmwcLIOngov6m 6Yng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pt8I2gDFGkJc89VFttBAWrczFbW6HxF9sU3Iiy4h4oU=; b=B/KpZzhT5waeYiiBlqjpJr/3vPIZKMxy3CDkA1cjIjah0rmuOyFnFsZr+mB4DVyvtB VzlnYlwnb8zkIDLQmL/OB04DIP8J0g0kMqbORWr4lBorhsv1WQYJ30UAchgRkSkUuWwF Zi+NCwCQj7ODv86o4c2uj7zN4Z0JYb4ZeCDDxFiTPyoHzoxEaF63axqPaD04IAAEahlu rfB4KRWXL8DmDrKiR4Nx1JGLQi6jbTvjoOLelz0VgKNXSEdoHoIemotizG8RYqsvyW0w 52JnVNPTXEi8XxUckakah3NPL7ZHfB1wphpQeyj+vrrJ1ezRsn8BbZeOTrkQO8cR9FbZ K/dQ== X-Gm-Message-State: AO0yUKWINup4oVF4FLMI1r3lAd5xS785z5OqEix/c20B09cDFRy3QrQH 8dNkU0tlxuInVlpeuO2rjWvFoX3+IJWbd7yPvJfA1Q== X-Google-Smtp-Source: AK7set+5s1St957AtsOtZg/2SckKqwY/chLNneXVWybGFKOK6P3inMJFiq1XrtosXZruQD2pn4FVdVbIyB5/AHPCIzk= X-Received: by 2002:a50:d542:0:b0:4ab:4d4d:73fc with SMTP id f2-20020a50d542000000b004ab4d4d73fcmr9449edj.5.1676003182975; Thu, 09 Feb 2023 20:26:22 -0800 (PST) MIME-Version: 1.0 References: <20230206092559.2722946-1-senozhatsky@chromium.org> <20230206092559.2722946-3-senozhatsky@chromium.org> In-Reply-To: From: Yosry Ahmed Date: Thu, 9 Feb 2023 20:25:46 -0800 Message-ID: Subject: Re: [PATCH 2/2] zsmalloc: fine-grained inuse ratio based fullness grouping To: Sergey Senozhatsky Cc: Minchan Kim , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BDF1EC000C X-Rspam-User: X-Stat-Signature: j4zw6tr7isb87fjwnaz8t9wnhwpwoijs X-HE-Tag: 1676003184-623550 X-HE-Meta: U2FsdGVkX1+3IPCDIFb3TmDXS8TcUCTrWQLY5tj+nLt9YamNsGnTOT+U3COh5P2AW7gU/qybJBlwQAYVSBPiwt7EdB+yUQA1yp6yKJESMX3/lxFbSGhFJ47mQ2KwePNgtszh4FJGE3k6UleUMB9n1yC9ZgQYHKSfZ6PDMgdE5cdUxmJwHa/NomsVLjkuqc71xBBEOql8pGYu9EFvFkiWdFLDoBNVnWwS+62VmZVaZQ/TvtNVTK0X1XRA0REQQgpDx7Ly9qqTMGv6r2IHrmTMLh2mENzhVNQr+V9/X486Md0E3PjcZpZh3YLVElLsZooPlde6D4PhtIBFgCP3BCrs4BMCQjSPMAg6PfDMU1wzkwrj86EFDiVWgrc6WgfyfMynmeg2/WXAKX+LCla8jMTl3lwKf9srncEuhp878scAMiB3TnLNup8zgOi104wQyt3YuGtblTf3ZHV9syWSjzpv34mOqv4naaVX5i5m0UeJr7VgrPn7+qXo4LWynHxZ/NTyQ3uXLMJsqZKEQvxOKDjjTo0uSbToQIH/uEMq1QKdQFLZ4MbAZKBn3dtHWo6iqULMCr6vBtJqTU86s383bha88zgBDUpQ182Bg9qrv0ocnOHDKA9FDt9jQILdAox6xxmxBJpWWODGQfbp+lq1NsRXDHztt+B+kuPGIRQkp43/ahpyoRLUnxyUGQzU7LdnGoByKUumwOITDbiXSCQ/I6wbokHHDCD8uP97YR912O2dPZ7oxtaixJ2F4+g8/Tsef/Lb+lq9JZzYc4bEp6PHsF0ZtAGQmBZ4OuH68/Wd+5oXjuEeGly+pdOjNoL+Dp/ALIQI/KHOIYLO79LW0qoz86nArI6NdQi75r/rZVOSsH9jFdaxrjRrF3LBujIHR41U/HZmAzs3xazAIfnetpZbuc9VZhYVIcelfdWQVMX71/6cHAWFdZyK08nLqRi83jQWjIcPn5PVzltloVkXit758L1 ijesqkVI bWhlqPfIjjUiiIhxZ3mzTAEdKJagiWiY6AA7OQemsxbm9tIfSCBoJi+LJ+zoXWxcFT9oHS2KSD9UkI1IqLXJVEVbfsjTpX3uBXl3KsnOqBY4DECIKp5+AiOMxgDFdKpShM8xQOsutAZtFPqvhlYiW54I6fb4JDuByTg/QYw0fXFxgzRcH8NccZngx40ky4c4pJwKEM7Lep64GU8491fgwB+uzru9WCfStaLgPMzhv6jfCESbjgBfXUqTABfweBEKfEgcjHpRzAyHKhjfIk0IwawYdKePucfopX948X96QkNlFkuM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000109, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 9, 2023 at 8:24 PM Sergey Senozhatsky wrote: > > On (23/02/07 10:47), Sergey Senozhatsky wrote: > > > > enum fullness_group { > > > > - ZS_EMPTY, > > > > - ZS_ALMOST_EMPTY, > > > > - ZS_ALMOST_FULL, > > > > - ZS_FULL, > > > > + ZS_USAGE_0, > > > > + ZS_USAGE_10, > > > > + ZS_USAGE_20, > > > > + ZS_USAGE_30, > > > > + ZS_USAGE_40, > > > > + ZS_USAGE_50, > > > > + ZS_USAGE_60, > > > > + ZS_USAGE_70, > > > > + ZS_USAGE_80, > > > > + ZS_USAGE_90, > > > > + ZS_USAGE_99, > > > > + ZS_USAGE_100, > > > > NR_ZS_FULLNESS, > > > > }; > > > > > > > > > > Is there a reason why this can't be done with something like #define > > > FULLNESS_GROUPS 10? We can make sure during build that (100 % > > > FULLNESS_GROUPS == 0) to make our lives easier. I feel like the code > > > will be much more concise and easier to navigate, instead of multiple > > > enums and static arrays. > > > > I wanted to keep things the way they are to make reviews simpler. > > We probably can do something more "disruptive" in a separate patch. > > Forgot to mention, I was also thinking about extending zsmalloc stats > file and providing values for each fullness group per class, as opposed > to current ALMOST_EMPTY and ALMOST_FULL stats, which don't tell much. Makes sense. > > I can get rid of static const arrays and pass "begin / end" group IDs to > functions that iterate fullness lists and pick the first head page, but > I think that enum values will stay. Do they have to stay for a technical reason or just to make reviews simpler?