From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 113D0C47258 for ; Mon, 15 Jan 2024 16:48:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7EB7E6B006E; Mon, 15 Jan 2024 11:48:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 773CE6B0071; Mon, 15 Jan 2024 11:48:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5ED996B0072; Mon, 15 Jan 2024 11:48:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4A0E66B006E for ; Mon, 15 Jan 2024 11:48:23 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AD13480956 for ; Mon, 15 Jan 2024 16:48:21 +0000 (UTC) X-FDA: 81682128402.26.50F6DEA Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf17.hostedemail.com (Postfix) with ESMTP id D989E40010 for ; Mon, 15 Jan 2024 16:48:18 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=QliPO+rM; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705337298; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ceLGL0enl6PfAsopv7AJI+nA+EII0JrlzYSMhyq0em8=; b=bAyuMU10qtLzzkTTHlLHgJ7ngLGnBf+/x3QnClvgamkhJrFp/t72M2JJuyofSzSq3HFywt 9/kP78HaLRK1mI1xzTOD2mH6CEgWxBaUYgiB5erDIiJKi9G0S+mzmy5ns3wWKXdM1/M5BN 1WOlhQMCavK/G0Zgh7bYw/DuyM1oZgQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=QliPO+rM; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705337298; a=rsa-sha256; cv=none; b=J9pLf7wTGCoVE8MkZKFhi4pNsMxzhmc87+dR4pv734neuj5kE5ynmrfRp+KoaHo5FXjF7m H4MUEkdsPh2FdVtgDO+ZaJ4RPGx0ZlsndEaQlt1W4IcKftDp04xk/K0Xh551e58rkF5Bvl 7qMreIzMj9fCR4VpU8OAB+8ooxu2WBQ= Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a2cad931c50so341567066b.1 for ; Mon, 15 Jan 2024 08:48:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1705337297; x=1705942097; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ceLGL0enl6PfAsopv7AJI+nA+EII0JrlzYSMhyq0em8=; b=QliPO+rM69dSNusKwPoH44ZCGyQ6N0+arBKFLXPKffqXdHIrb9Dx6Kicowm5nz+Mjx ikQAX10/oXBI+MOfwe/Qej3kZs54GwOcMQEZiC/ClJlIhAgFrzrPKfYWQ0XRQQLs7XOO QgMGEPpU6U6FgbLh1p+wHOallzzTFQaPWuUc5KGMU3ROSFUBb6AYqWGUh9fgg9H3Kk+s OGtefKmABW82kDpaX59lPGC/cshTElFMKQiXWfxG/cSMlmmhA6pNygm/hhA51PYEh/ut gXn6v6d+KnqwzDf46RxsaYl0j4WCHWWBrVmDgUtphhdj77+1pSWVcXqvPyAKPgzvUdqW 92bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705337297; x=1705942097; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ceLGL0enl6PfAsopv7AJI+nA+EII0JrlzYSMhyq0em8=; b=JfWzYtjF+pPQjttZ9QlyrFM+2pIz1hPaOyyRBAYYLw9FWFroAzjgFuDq8zLLVqNwWh I45UlDrgyzeh7mK3W7tx24ce6J428OVp4xUqva/ETM666xF0aEznXGZcApunk8Hh8/4p Wr1O5t8oD/jNQLVe1CsdbfNAOVIfLddNXmVOqgIVNBm7zpDO2mUAZL6keI7MX4Ub0g7g UuUTcfi1TaxS6czNDw0LYtTi0nCJ6tY1s8QtDohTU+oFyUoKjW1L+EQnWpQQJuS/LL62 7XMKYBaFyHuqeqfruBdZaSJp8AnIOZyE4nuFd8wayqk3ZrRQ00DstgpA1l99RH7o5BgN 7iHQ== X-Gm-Message-State: AOJu0Yy4s2Cs8cwJ1WvfWrmb4aA8PPsnmzilo0PH72H7NkaqvF8QSJbw VudLYg/eguQv9HaESZcnzYFelF2U8muo/3m/F2iUzxkzdp0o X-Google-Smtp-Source: AGHT+IHNV4MCloqcrGH6S7WU4i7/ZBSuL75kLy09XQg3jP02TmtwtjBL5T0bywpvmu4Eca6GWIIogf7mqkbyC37kOnA= X-Received: by 2002:a17:907:a08f:b0:a2c:b0a6:8ab with SMTP id hu15-20020a170907a08f00b00a2cb0a608abmr3275465ejc.7.1705337297039; Mon, 15 Jan 2024 08:48:17 -0800 (PST) MIME-Version: 1.0 References: <20240112193103.3798287-1-yosryahmed@google.com> In-Reply-To: From: Yosry Ahmed Date: Mon, 15 Jan 2024 08:47:39 -0800 Message-ID: Subject: Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED To: Vitaly Wool Cc: Andrew Morton , Miaohe Lin , Johannes Weiner , Nhat Pham , Huacai Chen , WANG Xuerui , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , linux-mm@kvack.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: D989E40010 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: qejxet9e9q7y6s6ihm4i7unbbk8mjdw8 X-HE-Tag: 1705337298-947653 X-HE-Meta: U2FsdGVkX18akwEHw6tgiD5QWJSz3zsW9jSxjgdbNNemS1cYxFxM7kh5HEKhooRkFcjjC9/4RJCDvjprsSR7dvfKKDF+GowUvVFqivFUwHQO51bKROnu/AfUGFB01TBxC84z+7uf0XWCaOlej2PcjFlFB6FmzA+b7KlIOXDkw+TB9Tn8Lg9h2quheYi0gnHsjnoueOThs9rAuGLK4859oD1P4irUigGyHW0xl+Ixj+ZNP1FpYeVo81FkGiiWdFCsIpx4cpPzF2iYJrNW0bsfd0rB/446y6+ETqzX395DrSlTmv7KJ+GqDiyYcV/Xclm68XaOdErm7VUOM6OsC+Rr8IFPrygdR0dSVzIxxIgA0Jj6ZTX5/ZJdKp5DuKUvzptX8+HtqDGMEbKzU0isC5yT8XL92DY3SX2xNriQgCXP74KoIuddRrm3MQrk3ROnYujsHXJfuCtZ/3EjO8NBAix58vRHCZGttAITARb2Ypv43qWjBdZrpHomsr9wKA+Jq5oKVHMTgGkVzb4rOllWqwEB1F6LUFMHC//IsFYVOw5XvCP6hEOcrTrXZBKn6aHu0/sYu3fKv2sfQ7FCgirM/HPSkGAyxwxfKVwBYZ+AhED1/VQ3zBKUWQFvntfCGRWEbs8PxtNqci1eEdcNkYVyE1vlEhfGB7iIuS2BYHnQ8/EaA6h9Yw9wrWd/y8kyX/+ykRPew6E8xfdczHf/liKzJn6n1UM4rrJer+TmJxAPRPE/P5nIUWKEIXJU2hHdjYE/9gST3YcOp3PDj9TqnsaGJEMyEpaizihgSMH/eHj3Vt1gbQCm2f6KOTCRKHjEbfWdXdZaeTw/akkX0XQimIb7p6NeCVwWRpN4/8WOrNQMKOeJVoR/UvdMqNsFslJxinhdbDC/nF/LokevRPsGdqk9rTp/nMqbXuNGS6/JN3WbZHo82wHG+NrJrRBiLbKx1TJrOJa4x5PM4mZS5OePmx4I7HZ dpHjUqll GBHoXztfw/hWHQ2y0uN/YBR2NFU3CSEXTNHwbYR8TcTDeOUoMzHfl7Tv6LXiDyjvxXFqMnHtW1p+fEPzDLWhoVRJQPzT0cwPHGFnmW+cor16S5hsYMQBxV4cHDbHAWH2yyE5AVoLTUJ+PgX2vN/JViFobTa3OHUey6xKBUbA2iqEGgY6/sMTSHl3KAy5ZMEJSnZO8X5rGV5t+bok8dx3WTEeY0drMZrZCDXBWzrrnIbIeG2swblAyZ3827o/qFQSCJTscnEG7myli8fdblLRqUWw/hTMJxL+x8YPwpJQFGAf0QDQErmHQXr6QRcYehH8ONz3/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 15, 2024 at 4:27=E2=80=AFAM Vitaly Wool wrote: > > On Fri, Jan 12, 2024 at 8:31=E2=80=AFPM Yosry Ahmed wrote: > > > > The z3fold compressed pages allocator is not widely used, most users us= e > > zsmalloc. The only disadvantage of zsmalloc in comparison is the > > dependency on MMU, and zbud is a more common option for !MMU as it was > > the default zswap allocator for a long time. > > > > In hopes of having a single compressed pages allocator at some point, > > and following in the footsteps of SLAB, deprecate z3fold. Rename the > > user-visible option so that users with CONFIG_Z3FOLD=3Dy get a new prom= pt > > with explanation during make oldconfig. Remove CONFIG_Z3FOLD=3Dy from > > defconfigs. > > I believe that having a single compressed pages allocator is a false goal= . It's not a goal in itself for sure, but when most users use one allocator that is mostly superior, it makes sense to try to deprecate others. > > > Existing users, if any, should voice their objections. Otherwise, we ca= n > > remove z3fold in a few releases. > > At this point I NACK this patch. We're about to submit an allocator > which is clearly better that z3fold and is faster that zsmalloc in > most cases and that submission will mark z3fold as deprecated. But for > now this move is premature. I think unless there are current users of z3fold that cannot use zsmalloc, the introduction of a new allocator should be irrelevant to deprecating z3fold. Do you know of such users? Can you explain why zsmalloc is not usable for them?