From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5711FC433EF for ; Fri, 1 Apr 2022 09:24:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC4568D0002; Fri, 1 Apr 2022 05:24:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E72E48D0001; Fri, 1 Apr 2022 05:24:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D61258D0002; Fri, 1 Apr 2022 05:24:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0113.hostedemail.com [216.40.44.113]) by kanga.kvack.org (Postfix) with ESMTP id CA0758D0001 for ; Fri, 1 Apr 2022 05:24:21 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 95272182B0496 for ; Fri, 1 Apr 2022 09:24:11 +0000 (UTC) X-FDA: 79307773902.16.36FC07A Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf20.hostedemail.com (Postfix) with ESMTP id 271F31C0009 for ; Fri, 1 Apr 2022 09:24:11 +0000 (UTC) Received: by mail-pl1-f174.google.com with SMTP id y6so2008532plg.2 for ; Fri, 01 Apr 2022 02:24:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eqHcENevlipVpLwJzXjFe9d3oZf1LHDk3dciHpBysEs=; b=SE0wj13yNQUKOLM7y5D13X3QyLAcWrPwhqQndeixZUJj6q9pgA456c8KR80+WD0J4T 0B29QRq5HhGLr5tyU1zOJD/4zhyujrn1COBvQHyQG0IkF+B7lhHruTepHwDZ6y0Dyqdf udoZQegWVZWcu+U+gY66/nsmhnOOOqWbZ3bsB0CLnxC+FTaiugBCHOBpEr/IvU87nfid ng87Quwf+lM88JUvep0VBVmphTmD6/NdezPovc4WuobQb42jRkZ7P9qMVe+O9TuFF3RL geu+SYCVcB0i0i/mVYgCqw80holeY6GYkG2zo8XI2CVyJ8+ZRn2wD0Aa1RbFQmuCT/gO npFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eqHcENevlipVpLwJzXjFe9d3oZf1LHDk3dciHpBysEs=; b=CNtWDPWuPyu7XBstox9G0f3T+TzXf6GCcSwjk3KHtSbjA5ALw4kEwli2iXZwCaV7RW PV4x0pbeHCpE+wIscHSYuS703ELuGdZozkRpIcx9AQ/wo4wVEd6uigWmjxUR8U6YcGUH NoX46XY7DPbyCwfgBJ5ZdfAKkDgm5HeaWyiXNlNagiww86FfANuOU0HG9Iz02GPwzrZv D2ZnfcqBIBIQppbertKzj8ISo9M1nXJ94YgaR8oa2xd2UZ1SkCYiqFoEC+nnwLulIfVw yCAgCUDwotKq6A40Zc4X6veso33+jI9ihFZ22V4M17oX5rV/94XmQSXya0EJ/g6y+WxU OhkA== X-Gm-Message-State: AOAM533JcWOz5RmxztnLYYuhRkfpJQnInK9Ac8boMkyPbNe3mRQ0ZuVW 9S696pLdEXO3q/mOH5eTUwSBFLHHpjIKibqobOY8Lg== X-Google-Smtp-Source: ABdhPJyH95f+uF5qt0Sg+nXhMwNGNDRbUvVYUqz2vCJG9jFsEU4WrvTARHYgoWhnQP5k0RrMO50potZ/qEls6eMvXl8= X-Received: by 2002:a17:902:f24b:b0:154:de5:a24c with SMTP id j11-20020a170902f24b00b001540de5a24cmr9550361plc.162.1648805049999; Fri, 01 Apr 2022 02:24:09 -0700 (PDT) MIME-Version: 1.0 References: <20220331084151.2600229-1-yosryahmed@google.com> <874k3d6vuq.fsf@vajain21.in.ibm.com> In-Reply-To: <874k3d6vuq.fsf@vajain21.in.ibm.com> From: Yosry Ahmed Date: Fri, 1 Apr 2022 02:23:33 -0700 Message-ID: Subject: Re: [PATCH resend] memcg: introduce per-memcg reclaim interface To: Vaibhav Jain Cc: Johannes Weiner , Michal Hocko , Shakeel Butt , Andrew Morton , David Rientjes , Tejun Heo , Zefan Li , Roman Gushchin , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Linux-MM , Jonathan Corbet , Yu Zhao , Dave Hansen , Wei Xu , Greg Thelen Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 271F31C0009 X-Stat-Signature: rtr1tkw5nsrmegn1jtjk8tyg533s1hzj Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=SE0wj13y; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of yosryahmed@google.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=yosryahmed@google.com X-Rspam-User: X-HE-Tag: 1648805051-859836 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 1, 2022 at 1:39 AM Vaibhav Jain wrote: > > > Yosry Ahmed writes: > > From: Shakeel Butt > > > > Introduce an memcg interface to trigger memory reclaim on a memory cgroup. > > > > + > > + while (nr_reclaimed < nr_to_reclaim) { > > + unsigned long reclaimed; > > + > > + if (signal_pending(current)) > > + break; > > + > > + reclaimed = try_to_free_mem_cgroup_pages(memcg, > > + nr_to_reclaim - nr_reclaimed, > > + GFP_KERNEL, true); > > + > > + if (!reclaimed && !nr_retries--) > > + break; > > + > > + nr_reclaimed += reclaimed; > > I think there should be a cond_resched() in this loop before > try_to_free_mem_cgroup_pages() to have better chances of reclaim > succeding early. > Thanks for taking the time to look at this! I believe this loop is modeled after the loop in memory_high_write() for the memory.high interface. Is there a reason why it should be needed here but not there? > > > -- > Cheers > ~ Vaibhav