From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84690C001DE for ; Tue, 8 Aug 2023 06:36:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E01F96B0071; Tue, 8 Aug 2023 02:36:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB1626B0074; Tue, 8 Aug 2023 02:36:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7A4E8D0001; Tue, 8 Aug 2023 02:36:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B60EF6B0071 for ; Tue, 8 Aug 2023 02:36:57 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 82F56A05BA for ; Tue, 8 Aug 2023 06:36:57 +0000 (UTC) X-FDA: 81099979674.27.AE27FE9 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf09.hostedemail.com (Postfix) with ESMTP id A41F8140023 for ; Tue, 8 Aug 2023 06:36:55 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=3ZYV5uY7; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691476615; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rbr+mBUy5oY0m7w28NQsfuQPCt8vE1BCk/020qW2+m4=; b=g3As3pFyLjINbp0IWZ16YgWDVHl3QGzG5tTl19vo81RR12zEfY24JJrqreq9Tuk10aAQZU vWthjKmdI1JkaVLOn7tNrbqa5o/DTe9TBr0vV7DHZ73N5nRcPBr+bcpsn9wfgWVvpVDuuD VQNN4J3yY/HpjmJEka5aRN4gmwTT5Ww= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=3ZYV5uY7; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691476615; a=rsa-sha256; cv=none; b=2On1BLWtrIwwyiTKX+Y9L2cMEKc/7RZp7CQGD6mPjB5zE87M6qilt1cSgMPib1WvunpTpz w/hZDWjrOyfsU+o8JGRq399C1qRwh0IaUZtSl7mFWlgigdsSwfHsz0+NH4KUaNNJydkujJ rkpK45O623Y1rfUedTbCfuGgJ15nwtI= Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-99bf9252eddso794524366b.3 for ; Mon, 07 Aug 2023 23:36:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691476614; x=1692081414; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rbr+mBUy5oY0m7w28NQsfuQPCt8vE1BCk/020qW2+m4=; b=3ZYV5uY7m298//fZHonaX0uDqtzL9YhXm22fgsqXBhGodbQgYE7FLfGogTV3dx5VkD pwuJUmlgDa5dDU9SG+hLqpbYCEaTUkup7WwI7dXNfOKI0U9BF6wbfCCU+hOG8BpNOfr6 clpui6NXS3Gn3qJZjPCLACoXWiUPxcPTcjI/PmvIrW2FlO4g+yi+EWDfk01vgSVldhpM V7eQJ6lyKYvnmBhs8n/bmGr+Ukg272MQynTKyrAQT81ImcYFdnpdVhfVYt312hSWn5Yv tR16wLJPCrzk0Ppy/O2cV/YqUJZfHldoN1EVyPcnvVai0l+uslVGZsUtfE7LHNa275CL eBrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691476614; x=1692081414; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rbr+mBUy5oY0m7w28NQsfuQPCt8vE1BCk/020qW2+m4=; b=eNoC++av+qJY29DPgpEv8c5YWeCP1VzcL1XvhBZIO2X/i+DNByCR4AVqqbsOq5dyjf v6xe1vyaj5V7L2H4se1NYxcfx682qv0CvN8vARoGP8pSZCx3193CHR5PzWWdS+KVqsDy QATRBJs4VD8eGeCxzs0RqLvwmOhuo7rvv65EQX/oFmJ1Ri+pmyAYbXfnCJ1viS1hTeZB JE7Rd9wd51MJ7JAGjfI/8dmYkE8f8wfve8LPHyIB6/fUevkxGp+kRBXwNSv1YbVnFcTv 6xkZyEUJUZB6ljIwcNrFo7sh4iTE1btnCj75Y5QtRlMqNna+9jtuXE1Pj/5febKLiYp0 rNVw== X-Gm-Message-State: AOJu0Yx3mIjcjj2Hln+lLJCn+E38mAFxWAoXA/OQiTTQ73/TfUmF9gnC PKnIbQ3ALWe9Nld3hYMwbNnZn1F9TIFjlF2+aiJJXg== X-Google-Smtp-Source: AGHT+IHRb0v1WhruC76K8apASvPM5Q+lRsf7PNhWrUUxQ6fLuyP+uiub0TaRRkQwURr1fKatbXahTCn2ET/MKA1IvGE= X-Received: by 2002:a17:906:1045:b0:98d:f4a7:71cf with SMTP id j5-20020a170906104500b0098df4a771cfmr11843316ejj.62.1691476614014; Mon, 07 Aug 2023 23:36:54 -0700 (PDT) MIME-Version: 1.0 References: <20230808024714.292048-1-xiujianfeng@huaweicloud.com> <62f24e5d-195f-411b-26f9-9f0b92bd0406@huawei.com> In-Reply-To: <62f24e5d-195f-411b-26f9-9f0b92bd0406@huawei.com> From: Yosry Ahmed Date: Mon, 7 Aug 2023 23:36:17 -0700 Message-ID: Subject: Re: [PATCH -next] mm: zswap: update comment for struct zswap_entry To: xiujianfeng Cc: Xiu Jianfeng , sjenning@redhat.com, ddstreet@ieee.org, akpm@linux-foundation.org, vitaly.wool@konsulko.com, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: A41F8140023 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: mhu7ue7wt84t1wqhms5n81c4jhqyya86 X-HE-Tag: 1691476615-741807 X-HE-Meta: U2FsdGVkX1+FL7B9nVZq86R7m4eyN3UpvHsoAWDz6BMtlckN+D0sjHa6dcMp8TavxuiXhObWEC3WJTn42L7W/qHJDy9DG1FRjyhLL7vanaOo3vehOLFtMkK0+2GTyH8rCqG23a3adVR0fg4q+G7KIGH+MewQa4X27cm2RxhJbjaH4d0UBiX52e2GIHaJEl5sBAHVFCP1g+jxWY1aCbP6b9Bu2dVIAb63Le1dFW56jcfQlaAtMlTQFdfMX8IMqQAqI4hPmpa+ghssKWv0euwI6NFxV6S7+5dqN2tbfkcIhvJ/EdDCRc6S3Dzbg3JZND8/+gFdOAoHwliTMqMy1QYXKog942BnWFKRoDnZV9CXBENvadQAXcUgnkGaRabSxOVrLCsWBQEthchjHcJuU0sbrMF3g3ixWPWgJ0H/iWsZvlFk9GxeVWNJl1VrQ5djmqsKwGdck94ihmF7qCm/GgvbOMd68xqr5KhMqrgyMj1V5Marm25g2Imr7Ypnzb/v08J0j4KVNKo9YFlDrT7HLm0L6IM/GiqrpGsRM2cIvT+bUxPYbBlsnakNnNQH8AiwBNT0dEs8J8zNwJYRb7oL38GzCTaR7nLq9LnnPJreaA5BfN01/XL9Ow84kb1KgWOz2DlmCAl6S/JiDvkG0MsHXx1zop0eXntiaPkpqz8ozzKu+s9W8h2AlrWQOw8c9akPWoDR4pdiIri4P2ehmlO0hupHVtbxAQxzZKpcZ1H9CIsuLFIxTAAmePJ+1eoxf0IiP0+MNflMmXYpC1oB5L+EgBs7s4sUR7diKFhnbvuI7RkAMYdGsDs0LAoN5pDXeJlswl58wUkRazaGgSBfPyUtuqeoCSG3Kdcal5RmTdEUq8qDtsYoJXZl2nrc/dvGZ/CbZkj1D9dObLGC3YS/Rq0TJbCFru/6JBI6Rf86m69TnrKZsRBe09IW649Sie6xQCLUBeY9tBGUFaf9x3WDsluH6zT SbuiN97T ugAF1BvweeKyHWyDLvFoxT1E7kEs3ObJ6kk5hPiaYag4fiS4dkrnHz4vBWfn6QOv3hvR0hDggsZfFMUvDRzWdc2Et/KRNJc8nPNYoxTNgwYGcllPL64zw0IfwcfMNpjeWTjj7A5qaesellrFB8vSuCCJPr728m2XxzPIpbFzeAIduNLSJQhL7ZoCvXzLqCuV2FrKlcCb97jwh5WIsF45YMzuDA1phL9UlmJ9/JUJzZo0gXT8qGVtepIMJxOdoun1NQBuWwj7QqN2UQNUaL730mOSuyAvBCjsAU06Gdwc96tOBLwbodct0QTqtExGN6zavFEqWYgiJRXF2NvygNnH2lqUgsbcK8Wk2jRob X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 7, 2023 at 11:26=E2=80=AFPM xiujianfeng wrote: > > Hi Yosry, > > On 2023/8/8 13:59, Yosry Ahmed wrote: > > Hi Xiu, > > > > On Mon, Aug 7, 2023 at 7:49=E2=80=AFPM Xiu Jianfeng wrote: > >> > >> From: Xiu Jianfeng > >> > >> Since commit 0bb488498c98 ("mm: zswap: remove zswap_header"), the > >> 'offset' has been replaced by swpentry, update the comment for it, > >> and also add comment for 'objcg'. > >> > >> Signed-off-by: Xiu Jianfeng > >> --- > >> mm/zswap.c | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/mm/zswap.c b/mm/zswap.c > >> index 5b56d38e7339..d7863c139c82 100644 > >> --- a/mm/zswap.c > >> +++ b/mm/zswap.c > >> @@ -182,7 +182,7 @@ struct zswap_pool { > >> * page within zswap. > >> * > >> * rbnode - links the entry into red-black tree for the appropriate s= wap type > >> - * offset - the swap offset for the entry. Index into the red-black = tree. > >> + * swpentry - the swap entry for the entry, include 'type' and 'offse= t' fields > > > > > > This is not the place to document that a swap entry has 'type' and > > 'offset' fields. > > > > I would also avoid the repetitive 'entry'. Maybe something like: > > swpentry - associated swap entry, the offset indexes into the red-black= tree > > > >> > >> * refcount - the number of outstanding reference to the entry. This = is needed > >> * to protect against premature freeing of the entry by co= de > >> * concurrent calls to load, invalidate, and writeback. T= he lock > >> @@ -195,6 +195,7 @@ struct zswap_pool { > >> * pool - the zswap_pool the entry's data is in > >> * handle - zpool allocation handle that stores the compressed page d= ata > >> * value - value of the same-value filled pages which have same conte= nt > >> + * objcg - the obj_cgroup(actually memcg) this entry belongs to > > > > > > Again, not the place to document that objcg is an abstraction layer > > above a memcg. > > > > I would do something like: > > objcg - the obj_cgroup that the compressed memory is charged to > > Thanks for your review, I've just sent out the v2 patch. I will take a look, thanks. (a CC would have been convenient ;) ) > > > > >> > >> * lru - handle to the pool's lru used to evict pages. > >> */ > >> struct zswap_entry { > >> -- > >> 2.34.1 > >> > >>