From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0952E69E81 for ; Mon, 2 Dec 2024 19:11:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3BABC6B0089; Mon, 2 Dec 2024 14:11:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 36A1A6B008A; Mon, 2 Dec 2024 14:11:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 231C76B008C; Mon, 2 Dec 2024 14:11:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F33EC6B0089 for ; Mon, 2 Dec 2024 14:11:51 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B686B1A025B for ; Mon, 2 Dec 2024 19:11:51 +0000 (UTC) X-FDA: 82850963286.22.44B138E Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) by imf28.hostedemail.com (Postfix) with ESMTP id 93BC5C001C for ; Mon, 2 Dec 2024 19:11:34 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Kk02XJ0+; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of yosryahmed@google.com designates 209.85.219.42 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733166704; a=rsa-sha256; cv=none; b=tBDKjJczHC/Y/c8sRT79O7DO8mVKLjHH+PiBrSLVNV7isf0gAmEzhug0PUlZlMmrreFZXQ XIkMciLs8I4SPPanQALRWSp9orb7Fo3AqkYT3WuhX/rQvPnHntwMIMK80fIiBmBKSphHLG FZde6V78AFyZnbzqFA948noQBUZP3EE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Kk02XJ0+; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of yosryahmed@google.com designates 209.85.219.42 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733166704; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GzYyjGx3ReEQgnID5PrS6FlfDBtezYVlcauxU9d5N2Q=; b=p4gryPORBU4kH3+IvaGmL4ejXoeF/VODzL8TwExiUJW78UwAwOeNX9b00Lyraw76U7BxrU tX9vauH9VuQNi8kxsUC3mDeiQ4WLN+Bn9/OwrTdrQW3mkc/G9FWCHndpQt7SLJapu028Zb RUPNwPlVXdXCkIDXKKDKZTcO+MSs8C4= Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-6d8a7c1a579so8978246d6.1 for ; Mon, 02 Dec 2024 11:11:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1733166709; x=1733771509; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GzYyjGx3ReEQgnID5PrS6FlfDBtezYVlcauxU9d5N2Q=; b=Kk02XJ0+ZtGo8BOA0bZ3UDTM0BBX5SuAxGZsrDpBvDD0MTSeQTeT5QoR57g+j5DelC nIlSWXxM3Xv+kFRTrwToL5suYA//Fm9Dx7P+m2K/I2Hxos3Oxc303TmR7Ccx5J0Fv0ox 85g/pEGT9VPP6NZTuLFdnOjdP3LwBg2t6QZ2gFG3Nlh9nSB2RxvvR1MlX0t9Q0pVCf7q Sx2w05y3M2HYY5WUXfRr/+hjy2V16MwOzkw+Wj0b83cWbjFqayuWRezp+lF/So/QNLkh M9RcLCyxh/XKabP1czB+e/SJ7SmKZu51/FiwbhIK9O/joK8k/2XEedCKEyjCpwzcRDvz BMqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733166709; x=1733771509; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GzYyjGx3ReEQgnID5PrS6FlfDBtezYVlcauxU9d5N2Q=; b=eiQue2TyL88TBBHKVOaxm5UcDFnrlSvUp/MbSSk6RfcSNxO18s6iG7dD0TzbHgcfpl EcWc55bW4+6qEEdeWOcqg7Nt2OONzaLPfnzDWRXacxPaMhwa15kIRQ211M+mopPpNouc 7u5/paVlXsMlR8CeWbVptfun1w1END2eShue0IGs21Ldsg39R99wr+USr9b/pLVVThqv sllGzi1ddbeEUSC1oys/5mgn6c6T8Ynfk1ysFscG2TV62VbAHqbMYy/SH5c64Nb6g1vK JWCSws5Q1v2A0nCusOZK2XKjgHnQilGWkh6V377QSY2gmXzJP7w/nTvqOy7KnMylCMFU m+fA== X-Gm-Message-State: AOJu0YzxwTxvIgnyMOv1Ed6K6DE2E2DbnxkUhaW/hijMBYRS7J5iYuzT dcz+CQqzF7mVnJT7QgcLuumKUwm02amWP+vhOPTXdXlEJ/tL10IBxvQ9bqnoD6u/q8NtESkaONB avAblQqvvVbZ7hpnHMl6g4nq4ZFaWviZIhBeC X-Gm-Gg: ASbGncvEXJkkID8TIJpBGhVJ585fzIOs2Y9knJAqm69JWgt+OG4MxRXTxR88/tParz3 KE4yLyPtpGWNissrVRYiFYP6ORsm4 X-Google-Smtp-Source: AGHT+IH8Gv/Uqr/mCJl1g5oYLrGu5z9Qvkhd0hlZVMtO/Rs3pYyxYlYftlv6RtwVAu5kF541H04heeMtU4AMl6eNvnM= X-Received: by 2002:a05:6214:1244:b0:6d3:b936:60d1 with SMTP id 6a1803df08f44-6d864d892aemr364467746d6.33.1733166708816; Mon, 02 Dec 2024 11:11:48 -0800 (PST) MIME-Version: 1.0 References: <20241202184154.19321-1-ryncsn@gmail.com> <20241202184154.19321-3-ryncsn@gmail.com> In-Reply-To: <20241202184154.19321-3-ryncsn@gmail.com> From: Yosry Ahmed Date: Mon, 2 Dec 2024 11:11:12 -0800 Message-ID: Subject: Re: [PATCH 2/4] mm/swap_cgroup: remove swap_cgroup_cmpxchg To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , Chris Li , Hugh Dickins , "Huang, Ying" , Roman Gushchin , Shakeel Butt , Johannes Weiner , Barry Song , Michal Hocko , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 93BC5C001C X-Stat-Signature: c9jm3yctj9s76qnrij39jz78bwg7k5xk X-HE-Tag: 1733166694-369927 X-HE-Meta: U2FsdGVkX1//qqiuu5XR567IwnSiNGb03lakcJdiVcVyUUjuhz4JkhTt8ImA9C457hL4/6mLiaymFAnKqWD71LlGu1cW8aQ9ba3nfpdAUNLgV3kEIdVnS8iVZZ6vzatklpYOd/YSKwqa6WYg0LfCiJVShUSSf23M1DVDG016D9K38ucOYiNLIKQn1CC4Wn0Y2vjFZlakF2wVYwLjQwvBqhpNY4p5IQFhxSAnwRi0IpVw3fIEr+5q8oeaAk7Is5KHsyE66emK1d15LOkAnqitjkkQRSrCY2B2olKNNVL/zl9xp1JInVgO8RaiJ5wEdsmTyG7mRcIUGSDpDO0GKt+WyEwgCpoOYe9H1TSd+dZfEtsGqqmdLFHbKmtFSadZnEURXMLG6ByWQf4Qd34bnKlalMENtRpkePuPip5V+VFkygmDPtXiQDXsbDLOo1WE2QMvdF/1RgLBwgGvo32pWlp+FlDab7fQHXJER0xR9xiA+or37c00RGkRm6D3tWEFenWalKglVMul/i8/5cJ+Gtb4xPmCTku3HCJ4j/2mlTSEn3LUeboLEtjDM0ZVfUenh+zY0TmbQUyooFyNKT79NDCgxLZLuXPO1yXukYhpjjzyg7qM0GKkeNyubPylzqD0KoZMxAZ7EsDjMGVol4gJymVWGCJwx+/vIXBiYZA9BPOKdo4LcRh7xnCcb80xzEcTEYUQ8lRalONlpz9EfGcKc4DvXZABDtHAh8Bj06tbufn+boF4crl4jND5plXhgGq/+x/bqAteStbwqZ1RszLMssL7mPZs8NQsEYmjewW8nXasOW1zsTjBGMJUiulVw8v0UapSz200+W94AmnIzRSitpVpMHaCaUawx0fPvtdLmFDV0KXLKFGa9qrt2dqRvothg0SjFyHLd0rHe7wxbXleCUflyPM4yvuwwC7NW15x/W7ITHj3oj0zIC9BjbF3NKc/8rSHKWZt5OVb27jh/ssf/4N 4yWOInni dC4Dvn8+ENu/dBPljTngB5t6rpzo/bPfKxkB/x+fhRtFhr1p9s7jd3MOGvPn1d1mpyj8G8QxL9q7CxSuac4FZ0jb/L1n79aMwgZVzEoxsYjkEGJe4HuqVXs+yeR4iG/DYgu0GusMt042LN0bKGe5pO87mc4x668A+F2OJ9G5N9lI+owECpMJFclTLSZUAnU1hQ/kM+RX6Oah9y/B01M3ZeLdsX9/ZOH0gE77J/u0+8MLzdCaIqA1S4RDI2ZE+4xAk16nVRHdI3RUt8ikfed46o7k49ONoPwidFX5X4zHUgRwqWRcwZ2oY401hdg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 2, 2024 at 10:42=E2=80=AFAM Kairui Song wrot= e: > > From: Kairui Song > > This function is never used after commit 6b611388b626 > ("memcg-v1: remove charge move code"). > > Signed-off-by: Kairui Song Reviewed-by: Yosry Ahmed > --- > include/linux/swap_cgroup.h | 2 -- > mm/swap_cgroup.c | 29 ----------------------------- > 2 files changed, 31 deletions(-) > > diff --git a/include/linux/swap_cgroup.h b/include/linux/swap_cgroup.h > index ae73a87775b3..d521ad1c4164 100644 > --- a/include/linux/swap_cgroup.h > +++ b/include/linux/swap_cgroup.h > @@ -6,8 +6,6 @@ > > #if defined(CONFIG_MEMCG) && defined(CONFIG_SWAP) > > -extern unsigned short swap_cgroup_cmpxchg(swp_entry_t ent, > - unsigned short old, unsigned shor= t new); > extern unsigned short swap_cgroup_record(swp_entry_t ent, unsigned short= id, > unsigned int nr_ents); > extern unsigned short lookup_swap_cgroup_id(swp_entry_t ent); > diff --git a/mm/swap_cgroup.c b/mm/swap_cgroup.c > index f63d1aa072a1..1770b076f6b7 100644 > --- a/mm/swap_cgroup.c > +++ b/mm/swap_cgroup.c > @@ -45,35 +45,6 @@ static struct swap_cgroup *lookup_swap_cgroup(swp_entr= y_t ent, > return &ctrl->map[offset]; > } > > -/** > - * swap_cgroup_cmpxchg - cmpxchg mem_cgroup's id for this swp_entry. > - * @ent: swap entry to be cmpxchged > - * @old: old id > - * @new: new id > - * > - * Returns old id at success, 0 at failure. > - * (There is no mem_cgroup using 0 as its id) > - */ > -unsigned short swap_cgroup_cmpxchg(swp_entry_t ent, > - unsigned short old, unsigned shor= t new) > -{ > - struct swap_cgroup_ctrl *ctrl; > - struct swap_cgroup *sc; > - unsigned long flags; > - unsigned short retval; > - > - sc =3D lookup_swap_cgroup(ent, &ctrl); > - > - spin_lock_irqsave(&ctrl->lock, flags); > - retval =3D sc->id; > - if (retval =3D=3D old) > - sc->id =3D new; > - else > - retval =3D 0; > - spin_unlock_irqrestore(&ctrl->lock, flags); > - return retval; > -} > - > /** > * swap_cgroup_record - record mem_cgroup for a set of swap entries > * @ent: the first swap entry to be recorded into > -- > 2.47.0 >