From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0287C64ED6 for ; Tue, 28 Feb 2023 17:19:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD8BD6B0071; Tue, 28 Feb 2023 12:19:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B87EE6B0073; Tue, 28 Feb 2023 12:19:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A76EA6B0074; Tue, 28 Feb 2023 12:19:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 993326B0071 for ; Tue, 28 Feb 2023 12:19:00 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 45118A2FB8 for ; Tue, 28 Feb 2023 17:19:00 +0000 (UTC) X-FDA: 80517360840.08.54C033F Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by imf08.hostedemail.com (Postfix) with ESMTP id 7073B160021 for ; Tue, 28 Feb 2023 17:18:58 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=G7Lehqzo; spf=pass (imf08.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.44 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677604738; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VLoVWdqrXACCM2GouapKLA9JL96p1Na7WBfaOoEKQxA=; b=jStY1XoIbb+OXkXdbaXC/e0oJZEfb5K4XjTU+tMnZ3KL6Y2g5dZEDaROk+fAePart6m3Ma lFSSQC/YQ+TvRnAxWM0uBk+wWoDnBBOuJ3GtT8wG/ic0g8CWGeozOKCve1c8t60Ctqgo36 vKwRPzPW6NDe8QNHUZswaW87GjK6Fm4= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=G7Lehqzo; spf=pass (imf08.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.44 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677604738; a=rsa-sha256; cv=none; b=lHszii6HbjsWs7IVgx07zOMCQN8gAY5a1D+CX/1PEerFXKy1LMKswWTL8k6dhVQtk2tedh G0t53Dg5DTX4GgChvON6wamhou4LJftZwK8S0sojGrs2eww26O3sNTk1vAdNQ1ZEWha0mB jKft8Zgz/8tfpn0WEL5S0hoi1s8NUu8= Received: by mail-ed1-f44.google.com with SMTP id s26so42910850edw.11 for ; Tue, 28 Feb 2023 09:18:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1677604737; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VLoVWdqrXACCM2GouapKLA9JL96p1Na7WBfaOoEKQxA=; b=G7LehqzooPd8BCbeVlFg+jPMKCKGZ/IaHR/YO9AaRRat3p9+dKtcz4sRNFa1rulDtP cDvvp8FdhyThlOUkEulw+aqyrbHsMr0nvvCC/teWJI395UJCOZsBn70eMJfkACmFTyB9 bffi1DJEyls1hUkdU1a6D54Ixfo2+5vsUIFyFXSz5fmFMLdJkkRTOYPNVGAY4g1A74q5 twd08sGthmaUN5PtZ06HgrBvOWqJC7Vvnrznivo0Pmo5Z1Z1sg7xjC+1AYR0oCTXfHZ6 Y9O+Qe/RBmHl4PBkXjs1gdazqNRDWm/BYz38LYItv5LAWsxcxlTJoFHabbJ3KtzqTS04 JMJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677604737; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VLoVWdqrXACCM2GouapKLA9JL96p1Na7WBfaOoEKQxA=; b=Kb0Ew0bqIW1vdkfyIz1FaViYYgvn/5dH/t2jG0RUY99j0RQyzP+23ynwe+Gcr54Afu dTYkEEbws9MeuIKxjIdZl0qn1ze5JGsup7R9/TjZFCitmeH4cHSi2LoZnGj9QuwbMUkW 1TBIdteBHKX1jIlMqMTSfOZEbnKQDELRB54O+FFsDXw/5YAR6z41j1kh6jBZpuQMVPaR 1JZ05LsT7JAO6ot9ORQS5EAUYJCiK+9wb1LeJH1SyfX5JV2MTgnWBvt5dTSkIcn+AdEl 7UhL0GpWI7TSVyVrHx1D90EtknRMWIeYEeKvDbxJ+0qKyzhRuN8rpAv6iTfMCTqbZ1G5 rR7Q== X-Gm-Message-State: AO0yUKWHaGtYhZlpdnkAavujlzRCurT9t+N17T3Yt1m7vkJTw47p7lqn Y1WlPexIGWNmOs1VUViVwMbPp7mvMscwFAA7Kpkkhw== X-Google-Smtp-Source: AK7set/vaTqJWeJXi/PEHEc/NmmBXXfMfDTI+pq1bMDgth7G7QT71O0RPAOZmRrFprNOY8p2ozFAFihCdZMUz1x/Rn0= X-Received: by 2002:a50:8e5b:0:b0:4ab:3a49:68b9 with SMTP id 27-20020a508e5b000000b004ab3a4968b9mr2136811edx.5.1677604736513; Tue, 28 Feb 2023 09:18:56 -0800 (PST) MIME-Version: 1.0 References: <20230228085002.2592473-3-yosryahmed@google.com> <202302281933.vU1PHuZr-lkp@intel.com> In-Reply-To: <202302281933.vU1PHuZr-lkp@intel.com> From: Yosry Ahmed Date: Tue, 28 Feb 2023 09:18:19 -0800 Message-ID: Subject: Re: [PATCH v1 2/2] mm: vmscan: ignore non-LRU-based reclaim in memcg reclaim To: kernel test robot Cc: Alexander Viro , "Darrick J. Wong" , Christoph Lameter , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Matthew Wilcox (Oracle)" , Miaohe Lin , David Hildenbrand , Johannes Weiner , Peter Xu , NeilBrown , Shakeel Butt , Michal Hocko , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7073B160021 X-Stat-Signature: yo4y4xhfbpu69tb17qwx3k35xtyykum3 X-Rspam-User: X-HE-Tag: 1677604738-931511 X-HE-Meta: U2FsdGVkX19mvrazMYwqFq2/cood/N59wCMoGkuLf12rHVBTzJ6SeH/TStcheWwr1lOiiSIxmS6IE5s0GnXRmHUOE097d86q/OWsZvO0hAzedl2lgIY63onSM8WO9MBFwSsQ1PAclsjuLOYLDh2lXqhfeazlk1RoIQ2XzJDK/7RxDu5dUuOoUA1dQqqr7+7nU9PtyV8uoo29nCabxQnZMlGhdj4413vHniSzg4ii1cydZ4A3epju0bTqFFEfbXy4umc4GYd/KFip92HJiulEyF2+Swdhta9jc+GYz3w1c+BWNTQI4p8TgMYaKnb/y66Nl+ysplq2CCSLy4qm5TguuVRy05l1TxhyKgsDyiwv5W0O1HezVlFiyTiURAl8sQkKmyvmnA6jZIW/P/IPDtmNOj7t+mbsdU3dyg/KHTlCql3SZUFswgdAgkgUTqoOHRyD345nRDPfO2ijZtIOZINVlBS/0T4oDkdv2Ligyrgrw5XG198n2Mqf3T7CADC5pSVpFxuNa87VHV6QKAVmJ+2lx6kFmQiXA11hRtYS8kCV2u+UVGm0mNpCRrBPfkYGcwkiWciCQnEYgUsVtm/QyEMWN45ZJJBKYuR999SJrVjENwSK0gcEiNnmMomDzp3CT87XYJ69YRF3nEkpGD4SVRQLTzrqqNg/zup0MMVVH+nZRYWgOIV5XaYKIGUhbDOc5uOMTuLf6mDJMYNoLESA78uLi7MJuUcYmpCgVi3DjZ95wbvCWwRb5JxgdTulejHx9gsYuh0g05b8IjcBVUOOahzkQd23hK11blwKC1zh6J3ndwj2Z3tSz+yd8lABkHBd5Vtc83JY/D4QwqP1kHkShdeJ4GEyloft3q0FjZNRDjamPCUK4a8EDWMsyl4jwzZhgp2Yr5xK36uIfaD82itLEWhnAlAUHCXBURgS9I+jTrutxbVBQNMMB90BYvMh7dy0Yu+lTsdgszX8UauzeRdFxrD lRkllTvN kslf8hxJ1ik/mFYKYMYYORPezpXW+zz9GF8/wx1I37hyWFrj4QrUh1Wzkl2uI8E7OfMcCcYXLPDzQvYWfNzRDLJCJABpUGmBKkBrpXsw70L2aTZLNtWpLH83qFpD6FJatbBCfbRvRZGM4SSzDEFHCgUPVRPQga9AmDu9wbRgq/geeoJPYKXeCwqjSorEoy3hFAIoWpA3eptxMRcseN7+LxNYAALTpxymFXZmC+4T6BqMjSY9Mg6E1mLrv6/kluxfFS8HS5EmC/qjZkWGwBgaC8Fa6925WB1BhAAciDK8rekVfhvgyCd279wpxg60sZJDTRZl2HRKIOR+hTio3aqIKpmfrAm25o4fXu2OYzd8BFefPfrP3c+B4fDt75gE1HlvaRCb9o/PPb/gjYakvlelzJ+guNtoU86aCHdUDWW7B5Hx+h/K2bUwMNtlY0ETBtoiBVSxaq2QRG1FIGihhBIJ0Laa33PodsU2toIbiw2WRspwE+DS880lZTuDKhkHALlRhqS6PxKO5lUH4HgElcwUFWhe0XC8CEiqZ2CUmH6jx240VUE3I0YohlMBrRMe58ghEuXA7LvGqCH1LcMCk2O+z+ySM1hgL3gtSszI6kQr0Y9m+dyXHQEkG6USsNg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 28, 2023 at 3:56 AM kernel test robot wrote: > > Hi Yosry, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on akpm-mm/mm-everything] > [also build test ERROR on linus/master next-20230228] > [cannot apply to vbabka-slab/for-next xfs-linux/for-next v6.2] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Yosry-Ahmed/mm-vmscan-refactor-updating-reclaimed-pages-in-reclaim_state/20230228-165214 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > patch link: https://lore.kernel.org/r/20230228085002.2592473-3-yosryahmed%40google.com > patch subject: [PATCH v1 2/2] mm: vmscan: ignore non-LRU-based reclaim in memcg reclaim > config: i386-randconfig-a002-20230227 (https://download.01.org/0day-ci/archive/20230228/202302281933.vU1PHuZr-lkp@intel.com/config) > compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/f6d2b849f186a927925a29e289d60895048550f5 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Yosry-Ahmed/mm-vmscan-refactor-updating-reclaimed-pages-in-reclaim_state/20230228-165214 > git checkout f6d2b849f186a927925a29e289d60895048550f5 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot > | Link: https://lore.kernel.org/oe-kbuild-all/202302281933.vU1PHuZr-lkp@intel.com/ > > All errors (new ones prefixed by >>): > > >> mm/vmscan.c:549:13: error: redefinition of 'cgroup_reclaim' > static bool cgroup_reclaim(struct scan_control *sc) > ^ > mm/vmscan.c:191:13: note: previous definition is here > static bool cgroup_reclaim(struct scan_control *sc) > ^ > >> mm/vmscan.c:554:13: error: redefinition of 'global_reclaim' > static bool global_reclaim(struct scan_control *sc) > ^ > mm/vmscan.c:196:13: note: previous definition is here > static bool global_reclaim(struct scan_control *sc) > ^ > 2 errors generated. Ugh yeah I didn't realize I am moving the definitions from within an #ifdef CONFIG_MEMCG. I will just leave the definitions as-is and add a forward declaration before the definition of add_non_vmscan_reclaimed(), should also reduce the churn in the diff. Will wait for a bit before re-spinning to gather some feedback on the current version first. > > > vim +/cgroup_reclaim +549 mm/vmscan.c > > 86750830468506 Yang Shi 2021-05-04 548 > b5ead35e7e1d34 Johannes Weiner 2019-11-30 @549 static bool cgroup_reclaim(struct scan_control *sc) > 89b5fae5368f6a Johannes Weiner 2012-01-12 550 { > b5ead35e7e1d34 Johannes Weiner 2019-11-30 551 return false; > 89b5fae5368f6a Johannes Weiner 2012-01-12 552 } > 97c9341f727105 Tejun Heo 2015-05-22 553 > a579086c99ed70 Yu Zhao 2022-12-21 @554 static bool global_reclaim(struct scan_control *sc) > a579086c99ed70 Yu Zhao 2022-12-21 555 { > a579086c99ed70 Yu Zhao 2022-12-21 556 return true; > a579086c99ed70 Yu Zhao 2022-12-21 557 } > a579086c99ed70 Yu Zhao 2022-12-21 558 > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests