From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B435C48260 for ; Tue, 13 Feb 2024 08:07:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B43DA6B0072; Tue, 13 Feb 2024 03:07:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AF4476B0074; Tue, 13 Feb 2024 03:07:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BBF86B0075; Tue, 13 Feb 2024 03:07:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 88C2C6B0072 for ; Tue, 13 Feb 2024 03:07:10 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5B152C0416 for ; Tue, 13 Feb 2024 08:07:10 +0000 (UTC) X-FDA: 81786050220.13.E419B93 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf24.hostedemail.com (Postfix) with ESMTP id C142F180027 for ; Tue, 13 Feb 2024 08:07:08 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=U4VrRdOB; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707811628; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LM3PLNa4pucVyvqbCFjlcqsnFs490n0u+F+9CuzGuec=; b=PJxAfKqRjKqNp3yK9785NSvKl8/OvZ0HzEMqeNSM0uVnJjmpBzq1S05jrD1XLSrVnizVDJ 3CHq0sonYrEDlce0yR3KSaNjaE4Oiz0dHtG74EUkhBItG5b9cOvJnkfLAbZcZU0uJ8IVhb L8jFS12B1VPA/zdOdP76FEQUTatS34o= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=U4VrRdOB; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707811628; a=rsa-sha256; cv=none; b=akmlOuNtiYyMH8N+lPY6w1yEN1Ivy2yZDH4zSursgRr4xm+HSXm/l2MnK4vrQwtMuuGjQ+ l4CoCXzizT6fx4y6e6WFekLYnefW3c1PyaR9oId94dcOuPTuDmoufyAdifeWlrEm8pO4vH vpcmqT1GtDAhFyc29sxhQ3MwQY22MKE= Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5610cc8cc1aso4402589a12.1 for ; Tue, 13 Feb 2024 00:07:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707811627; x=1708416427; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LM3PLNa4pucVyvqbCFjlcqsnFs490n0u+F+9CuzGuec=; b=U4VrRdOBg2bZ91oJavowc3Z6mUsrz+/wVuZCL+nrAgIJEqt+i/nM7pZ4jpDmDFt4YF cH6DM7XMlq7SUMykGMhAKaltA5by/UA+RjRbY7ouYG6u6UPB/YF5FUZwVm5VkyolviSp lpkDSTi2fVoAV+P1vmTRHJ5+Lyfou4Wac0N1K1hWMYmXmMpSWCQmF4TpN/EwGwUI6/2j Y2bKgB6IsI5b0Epd27f2vgQa8S9wAShpF3tZI4iGBhbtcGYBN0u4FyfBPvbwEzHZxiAN cgrGNm7a2OVgPAdRXW4A0OQf5dNc4gc/P4Ud8NEX9cX1l8bl5kZgXDLyBB2ZrKsprZQq qpHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707811627; x=1708416427; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LM3PLNa4pucVyvqbCFjlcqsnFs490n0u+F+9CuzGuec=; b=uBHLauSp8+rjvZmp1pSZ8m39G6dWW/UushNASGC+qf/ObjeRFI0ExHyCeaNtJL6hzQ IPEMYbszyD/l+4nPIR2JYcOKPWN9COZwIrZMQxLNkrl38zt5CI8dG0NQV8GERKwVFPRf lTrrqGKtnxgwNkyhKjhbuB7rFiovVjzECFJMbObfYuDOq/gfVnaQEeF8P4ZYdcNGSJr/ 0zjxkDqSk6RVRNBO6cM5D+wAOZ7TZ9fMiFMVEeuDIdco8qFrvwAdzllUfP1a85sKuf+6 sOY99PASVtlMn++nZ/XRo9SL4GlCQi5WzDFt/R0BwtIhmOoYzGDF52abM262UXsqYbom KkTg== X-Gm-Message-State: AOJu0Yw4hhUlVz7Ej5XWQQmvVw/ihwbamKTkWmAFeMYN5tX2Y3r717JF Awr27CWlWVR6JEjLJkCm1H4tioIrhmyKGrc4UH42CShgUJwtVW5/5U0KJ2xq8WfSp/ic/QeTCEh wCP0eb9JIE5cemcjh8djP/PBqi+9lmS3rZ+3r X-Google-Smtp-Source: AGHT+IHukH3nnW4wQOFd5zdW2IVbkXSqnBzcB9ZoIw6LyOoD/R2E+40xR6ew5ipbCkOSDtUcSdqXVb68lLuEBxDarlg= X-Received: by 2002:a17:906:3790:b0:a3c:edf6:a735 with SMTP id n16-20020a170906379000b00a3cedf6a735mr1311198ejc.47.1707811626925; Tue, 13 Feb 2024 00:07:06 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Yosry Ahmed Date: Tue, 13 Feb 2024 00:06:28 -0800 Message-ID: Subject: Re: swapaccount= commandline option To: Narcis Garcia Cc: linux-mm@kvack.org, Johannes Weiner , Michal Hocko , Roman Gushchin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C142F180027 X-Stat-Signature: 9qf6szkowy3bnittzfr4mo8txhk5tcot X-Rspam-User: X-HE-Tag: 1707811628-56343 X-HE-Meta: U2FsdGVkX1/H7aaGwSjCl/2yPiUOxC1ckMXpNhlSqgn2N6dsqiiBKO/dWdLiEIFw+Yw2AW8eIKMpzTn60DdOzKg4e94d/v0aWyNaRQiuzcFEHHczt5HtvwfsqGS52WnJ7tOhE05Z5x0PgEbYbv32ePPuvE2/xTwVzGoLHIAC+/dUGGH4TYe6kao3QmdqKl7l/b8undgik/RO3ZkoVuy+HDKNpMa3xCIW7pVxko9pEAi+6x7kwYjZdMc/pt9tsflXmac6oots7QMSI3yH1UEFS7GBYUU7eNJHOJuh2bMHs48v3lH2w4IfaSroNIbteY8FUA8tYH3RZYg8YICN2YcBLkNwa1czmzT0IIGLafdKWT67g5bI7CQ5OXV/XxatcxD4WYYeijeKBKvVfaqKV6am0ZCNhiCqC/79Isu/Z0XtWNhXMQvSYNUdIVrCGLCGkVN8RwkHtNUWo5/HlpwflfC//pFeJMqxU5E+6GhQia3XYJzBocHDI72uWvc1YZCFXrHNT5AEfAq6a8N9a1Qy/2AFpaaE9Cd4VbAbJlwWTrqivT6mYYYvllxP52AvsMVx3iULoQ6cZbjcwodpObdmjPWxk3kmA1kh70Zdg1wRm49rcbgyA6qMuX+3DoODF2r2E3SKS+CVhhZKW2eh92GGmdnYgF2k0lkP7wAjFSe8zOLmw+U8N62Q1p3c5t3UUJG9iztCfewthAJZdEs133sE3u/WEGPGuqHXJ+EZrdn0DTaSHcuWk/5rNsM5Uu8q3RxTDA6R2fzkMGgl8IP2s0tlrnUCuSKjNB2Qtq4oKbqb2JXYR7aZFMPzy9+fbbH6EObMirLuoDfRYteTkJ44RpsL0awmzGiOC4DhjWJDu5/u9S2OH9ag8+PBjhRmLecfSSzXSam91Jpv12X4IpFmktJBFe/0A5/ef1Pl+UO/MtkeYcxjV6quUFdKY5zmoAHLfqbjogsrFuh9+pz9Qe4VWgvrloi +Dw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000065, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 12, 2024 at 11:02=E2=80=AFPM Narcis Garcia wrote: > > El 12/2/24 a les 23:37, Yosry Ahmed ha escrit: > > On Sun, Feb 11, 2024 at 1:33=E2=80=AFAM Narcis Garcia wrote: > >> > >> Hello, > >> > >> I read this warning on Linux 6.1 boot: > >> The swapaccount=3D commandline option is deprecated. Please report you= r > >> usecase to linux-mm@kvack.org if you depend on this functionality. > >> > >> And I want to know if this impacts on LinuX Containers (LXC) swap > >> accounting. > > > > swapaccount=3D was deprecated in the sense that it is always on now > > (i.e. you cannot do swapaccount=3D0 anymore). I believe you are using > > swapaccount=3D1 and want to make sure that swap accounting will still > > work with v6.1, right? > > > > This is the second question we have had about this message [1]. I > > think we need to clarify the warning (and perhaps backport to stable > > kernels). > > > > [1]https://lore.kernel.org/linux-mm/2593755.Xrv9ptJ69j@sinistra.local/ > > > Thank you for answering this question, and sure this clarification is > needed both in documentation and warning message. > I've found deprecation message was commited on 26 Sep 2022. > From what Linux version release, this deprecation is included? I think v6.1 is the first kernel with the deprecation. > > I suggest this for setup_swap_account() code: > pr_warn_once("The swapaccount=3D commandline option is deprecated. " > "Swap accounting is always on. " > "Please report your usecase to linux-mm@kvack.org if you " > "depend on this functionality.\n"); Sure. Would you like to send a patch or would you like me to take care of i= t?