From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89DDFC77B6F for ; Tue, 11 Apr 2023 17:00:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EDCA9900003; Tue, 11 Apr 2023 13:00:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E8D0D900002; Tue, 11 Apr 2023 13:00:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5419900003; Tue, 11 Apr 2023 13:00:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C3595900002 for ; Tue, 11 Apr 2023 13:00:15 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8A11B806B8 for ; Tue, 11 Apr 2023 17:00:15 +0000 (UTC) X-FDA: 80669723190.16.5E861F9 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by imf26.hostedemail.com (Postfix) with ESMTP id 88B79140024 for ; Tue, 11 Apr 2023 17:00:13 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=ygamK3A3; spf=pass (imf26.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681232413; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l3nf45VfTna2qtmHbcyQx3azMJIZK67P9z9b6hMPmWY=; b=QgU0YEcnANsdV0FZ1+Z+ArREpoob4v6I/lCLNYxYoVT5I93MnDp1Bjnhkv8jxP35SRZubL ZuG4PW/i0ZW2L8MaCaABuf7A+z2iSyvqpdQgtw2XBVdAM8GOH+z6n88v+EC1SSnKya5rRa sAKDuM6xZAZmao7Cd4v/ClHu9SB2SAE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=ygamK3A3; spf=pass (imf26.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681232413; a=rsa-sha256; cv=none; b=fbObEwbgaI/94Z+gEzI/YClYue9n3efDAAAFu9gxkOOb+hacRrbSF0fB/Aion/iGrGJwKX 44ri5xHDAWqQ5aPP8wSkR5mrrQK4ghkGHrqiTJ7FNaiAuLz8BQBeFUZDTm1o9KuszTG6Gi W9hOCNI+/NhGvyYhUDTB8e6/Qr1LXcg= Received: by mail-ej1-f52.google.com with SMTP id j17so12448065ejs.5 for ; Tue, 11 Apr 2023 10:00:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1681232412; x=1683824412; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=l3nf45VfTna2qtmHbcyQx3azMJIZK67P9z9b6hMPmWY=; b=ygamK3A3NM1JD2kKgXRiue98TQPKvYM28SIh/wf7BXymkX7onuXLJL3zdwCTUe/eVe SIrwlFECWwZJJri9YnaDb7qj+p3Fx8mztu1CVpQMc/XKpJLJlWPcEMyzHAaCZxvxJUip 7FrcmhZzUhSkqU/9ce+HuOqM+20Y6naugqTmb3UDLmOMbosxkWeNqwmpF/mr+icSJFEA DkfsjBlrrbGUYgnxglGGrWrB3iI0El6Hk8tD6oRP64tYwrP2NsbfZPf5khW44kuDdufB HB1CpOLX1xMCVefNbt6lQkTWz8mUP82sqHSntwR7puMl5Pt+e551R9IduCfw125lUGRr smYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681232412; x=1683824412; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l3nf45VfTna2qtmHbcyQx3azMJIZK67P9z9b6hMPmWY=; b=dVwnZrEEOkC/swAIhCWwA6lXe3YZHEPqx2kByVDZ4pj4RDPki7+CFH0bP8R+OWpR9l eSf0n2uHQ5TRM7EbnZJhAOmed+2VQXp+zZ3aE9pkvafEveEHZoCeqq82JYEA6r0NBLPm uRzVuKmGzkxhgOu+TXZphZWSDtuFoNTetGWveeGboJ0shy6MO/3mtyEf/jUvZok7anTN svSsXexJmHiAwELJv5pIgHuE7sBVCtfdA6D14qGgPRgFXORLtYmh/vizFsYqUstM9sNl psk8BS5Tt20fAyqmoIykcoXhew9bKWoAePZGzs19j3E+UKwG+HuzTJ09AfidUBpKh0sy PgqA== X-Gm-Message-State: AAQBX9fJuuNusKPamrvQlwcSSyl8wordPTb6rUI+z7w02aD4s9JeEm3g CHGQS3orPDZX0lQ9GNU0PTF5RCJOQfe48bEndpZuVQ== X-Google-Smtp-Source: AKy350ZW8S84YwpJunppz3ww3yhitaeClTtiiyiJjfqra0sZdbCcVIjRXcLCOKK5B5VWEIh0bCIqB8Wu+sY8Gfrx4pU= X-Received: by 2002:a17:906:2556:b0:94b:d619:e773 with SMTP id j22-20020a170906255600b0094bd619e773mr1626314ejb.15.1681232411678; Tue, 11 Apr 2023 10:00:11 -0700 (PDT) MIME-Version: 1.0 References: <20230403220337.443510-1-yosryahmed@google.com> <20230403220337.443510-4-yosryahmed@google.com> In-Reply-To: From: Yosry Ahmed Date: Tue, 11 Apr 2023 09:59:35 -0700 Message-ID: Subject: Re: [PATCH mm-unstable RFC 3/5] memcg: calculate root usage from global state To: =?UTF-8?Q?Michal_Koutn=C3=BD?= Cc: Alexander Viro , Christian Brauner , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 88B79140024 X-Rspam-User: X-Stat-Signature: whfesb9dagx6mcxf1eicxiwji5pxwzxd X-HE-Tag: 1681232413-614097 X-HE-Meta: U2FsdGVkX19guWt4Ol5lAhGZ9NH+SHfujKVsTsk+GdokJFoCwpa9GQxU5JzLuEeKTawmM4RciowIv5WH+KgUmPQubRzOCO+xcfafHEwaIU0MEjTm+ToT1FUIvlZdCHdLBv/m+1FjSdCSn1FMGgbhURwR6/P8u7BcmlV3I1jadvaGOHZ8NI2J1JC/jZKbNIiVoZlNt3llvgvSod0RhD9dvYldWDFgP9F60Po3SlV/Q5zrGCob7IvZJn2KPtD2RXtqtK5FRSskPHXWBy7hgQYPkIiMG3NWg9U5RZ1vasYJOvcLlsEfJP3vsYdHRAP1ziAKEz2VxQt0on2sxcrJoF660Vl+rErL3ar3ZlgyneAHsBN3ftveCJxO1/KP2XP5ogRS30B0ubN9n7uFLERGpkqqd3sAUZuqYUdYWXFca5meB3dEdM99ZCwQN6bHFqjHZ9DCwGBq4QZU+V3pA0D9zZnFE6XmLwSB0nWCi9jBQrfP8GMSrOSCWKoFazm//kOC3ohP5qcmxTEK5qq+dnrsJum8sPe+gKhif5qUFrfrsbNQAj2HKnkjsH3uXWiw1G/tCC32XXZU7YWutiz8IdSEFwDB8Wju7gPq7rPHUu6nL8ITc1SSVeGqMZtBfjqI0XF1JvNIqCDiV1KwSBjKJlG8AlGMqU5XCcl2huYyfFAuQum/uhEeXn/qjKvG+CX78LQAZEi2WJG/RzBTNKdSee1fzcfjVoYLJPDs7iX1cR5dbLNwjYu4b4HtuOeqrIoZxTGq9tObbQW/0XJQ2Zw6+jYdno0gqu6Q2AlSBqd1XRrYKAnfomGIqL/5suOlEmtz4QpYf5th7PmuUTTjf9snolUF3KxcnrFz9WvSrDODqUeVao6pqz5Sn+xZl+98M6sx6C/2dhMI+JjOsPO8VdLEYiy9wJqHWOncUw2gFce/XaZ3AFtrFaTP7FDcIBInQpp/XIIF2cIJMeLSDws1uPXtYur1148 y8FptjrS /iub2kUz/W2bmPxSysmTL84zrLXvjCA2yoYEjzir08upRjldc/W0vk4hkuqb4OitseHVfXbe9Iw173m7vNNhCwr8tCPCllKAoQeu4LiemkFxklPOyfJU2l9Po15UbyhSl/PLBYjah5G1I/OeqOUgsyf+zr806rMdfLm7MVx/322wRNFzWJhA5B2lYgcMD8VnF7UMdGOwvNC/5y42phfy29KzzQQ6vurvmBtiiQZWbGOIGpysIX6YG1OFWvR/DuNcO0zpcXASrPvrl65ijMcnNq3ujetvFz1fvNpV6VjFExU0WFbG5vj8pCcGhYyWBoKuEGxMS01KlDKP2XrE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 11, 2023 at 5:53=E2=80=AFAM Michal Koutn=C3=BD wrote: > > On Mon, Apr 03, 2023 at 10:03:35PM +0000, Yosry Ahmed wrote: > > Instead, approximate the root usage from global state. This is not 100% > > accurate, but the root usage has always been ill-defined anyway. > > Technically, this approximation should be closer to truth because global > counters aren't subject to flushing "delay". It is a tiny bit different when some pages are in swap, probably because of swap slot caching and other swap specifics. At least in cgroup v1, the swap uncharging and freeing of the underlying swap entry may happen at different times. I think it practically doesn't really matter though. > > > > > Signed-off-by: Yosry Ahmed > > --- > > mm/memcontrol.c | 24 +++++------------------- > > 1 file changed, 5 insertions(+), 19 deletions(-) > > But feel free to add > Reviewed-by: Michal Koutn=C3=BD Thanks! >