From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28E66C4707B for ; Sun, 14 Jan 2024 23:14:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85F276B0075; Sun, 14 Jan 2024 18:14:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 80ED36B0078; Sun, 14 Jan 2024 18:14:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D66C6B007B; Sun, 14 Jan 2024 18:14:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5E4C46B0075 for ; Sun, 14 Jan 2024 18:14:51 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 291FD16038F for ; Sun, 14 Jan 2024 23:14:51 +0000 (UTC) X-FDA: 81679473582.20.C1FD62B Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf29.hostedemail.com (Postfix) with ESMTP id 5B496120026 for ; Sun, 14 Jan 2024 23:14:49 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=nV6rhJOR; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705274089; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6k76bVz3l5qhz2PG/FN1fCGCB8QPQrnTnxXAo7lmPrQ=; b=wTrHx7bhvdRuEpJCqq13hEFx3p32/sG387jkcbzir5gueALUuDAe/R108ynr3BlbYnD7bK vagWX+wS2kH15rrL8Oa9aUI6GUrUUrMGl9mc/LifnbJYaWlViB2t7mKMZgd3MJJ1ijVJSO ZoqrNhC88fapVWLgLazaaRPTRk1UuuY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=nV6rhJOR; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705274089; a=rsa-sha256; cv=none; b=Ih/fHcsNKg6EAbNuCtIulPZsxfTrPUe8bQb1xcnd76ohRmFZW5BFBp5IvPGThxfELWlfYn eELB3wQW1NhEWssZtOR9i3YVAed7ikaXo5OdcdHrhc7eG+ZckfFJr07x6stXxaHnyHZPMy 9T8vPrNP85RaLUFuss4EqqkgSoj0mss= Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a2cad931c50so255207966b.1 for ; Sun, 14 Jan 2024 15:14:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1705274088; x=1705878888; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6k76bVz3l5qhz2PG/FN1fCGCB8QPQrnTnxXAo7lmPrQ=; b=nV6rhJORQz8GeQPQBPEF/DOp1ltfCkCqNKHpQH6X6lSp1TGRDzwGqVzOpSJURDiX26 iuSvkVc+K60M9AmCLoTu8PvuY+z/knmdceqvPWp3uD7LqZDnZ6N6DxGfenTyjKQuUZw7 Q+1dS8heoD7I2OrnyjAqWW0uz03H6eghXVOMxCXrfAT0TyKtW3kCNuQxxShaaUg9dORV NBK35m4rqw/iqicg5Vwcv9Y56hnhX5Gps+pvojzLAvYsoe4ly1xlYbPvwx1QrE+Zgs0s aSGiGwtSaTTjSFCyiYpkGX4ggF2kO4jrQjiHi3coAQ6il8O1Cp9MTOD8Io7I7DqbOD74 3Jbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705274088; x=1705878888; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6k76bVz3l5qhz2PG/FN1fCGCB8QPQrnTnxXAo7lmPrQ=; b=TG61D/pMk4XVh/82ZNSmi+RPk7GhJ3vAqx/o7iDuAbd49/TMf/NPUzYqkMoABMPaq+ PehgGdOYJlmrtodLQ4vefDUQDX2AaeuAaxPTb3lMLHnRfN6To0SpwtVncuN+fSq1SWkx X6OXmH/2sQljHA2AS6vmFVRlZZdhzqfYi420F2ucw8v120YOGWn7sjs6hlJmCDC3hdCZ wuP4cw772imSlJsGf6+755kBCbEK8Y7gQWB8TWEYeUbP+bjc40qEPK3xtYXDhUWKQ8al 0WKhY3IU46pive6D8Vt9DLjQYH4weNnKuw5DssN3TpYOn3pcTzUbmU/RV3a30WO8ynxL foQg== X-Gm-Message-State: AOJu0Yx9ytUfl9gh+p9OlVjvT6xSBbZ/BgYl7GfgDjG4DetAf8w4kzoD L/jyQf2GJmaIwwK2G6oLVMWOuz/FrJQ7VmU8M3mPfnGJAi30 X-Google-Smtp-Source: AGHT+IGmzBUdoziLE2Tv88J9U2uChvlAVAX8Vas/pQSY8zMLgWkqGHOPaM3jX3KpJU3blLIwZXnH5YlhC/wo0MwjzgQ= X-Received: by 2002:a17:906:da8d:b0:a28:fab0:a88c with SMTP id xh13-20020a170906da8d00b00a28fab0a88cmr2519935ejb.78.1705274087622; Sun, 14 Jan 2024 15:14:47 -0800 (PST) MIME-Version: 1.0 References: <20240112193103.3798287-1-yosryahmed@google.com> In-Reply-To: From: Yosry Ahmed Date: Sun, 14 Jan 2024 15:14:09 -0800 Message-ID: Subject: Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED To: Nhat Pham Cc: Andrew Morton , Vitaly Wool , Miaohe Lin , Johannes Weiner , Huacai Chen , WANG Xuerui , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , linux-mm@kvack.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, Sergey Senozhatsky , Minchan Kim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 5B496120026 X-Stat-Signature: c9pmtx6irraqxcqc6dbmdhom8e4jhk58 X-Rspam-User: X-HE-Tag: 1705274089-291025 X-HE-Meta: U2FsdGVkX1+W19NGUurQzaTBIWhvoDSOyVhUyudhL9gdpEqtKzi6obTJy8fv82XtMT6dFzkK5sqmo5qousM7E7vU7JTw4e9qeVWmZ0+7zjvTYvMU0U7yuTQUt0Z97eCkDc/gtYdhT6xNiYVZHLaPLimQ7ZSdgyIiBNXyuHlt16cf8T7zGvQGSDrZqBaj21BidMgZU2VfOEyPOxQ0FM/x1G3sjdTCvlzm2YELtMK2osD3tYPzVp5zry4SnDDgNWLXA3XxsZ8Xn28JOfVeP10Z6WdbUoJ8Z1W2fYMTMCSihfn4vd8l6xEkfaW42GkNjJT5boFI07Yosl4xoCC3X/ma81LaEFK/lPlASK86QceH7yUH5EP7zPMSE369fYgm6vRtP0TpDgOfeuFG39AitJmifBL+kLpHtzf5k66E9c8BU/xKN5PwwGAjUVwZT8ndhnFqUi+oBm+BPZ4mEjBBJT7DJ9nN1Ak20s9dlPi+F2rcHbZwLEQRPiyqcgjn98hJDLfSQ5Ahy6ZTyvw7OPHYFw/Zz14A5ImqDEQwi17Ut0guDHuJpuQbunx6Pd2AjNpdIrlfauA0xjRHrur5Qsx+b4YJZDo9Fcm2Dw7B8bhk6w0QTUh3t5Ega3SY3pAerV7/riYGabamSTkUYcFb8vU93c2sh5Zec0Q80q8db9fWHOjIUztmKIv+QO88yLo8m6BUKkhv4XONOpALfee6FxY/lzuILhMIymIylSNYm9rxBOoonYVI8GgEqnqdN06Vpethgl2TJFxyV0Df7DBhIhLNqF/VtZJNNyHduMztAFsP4iLxTqt9LuZoppO+i/gEimXptKs/DG928EXLON1HHnRqdfWzKpWwcoTAHGU27jS66rPz0EYZxZKyKk3OqcCrxWHqcS5G28kE026z8VMF++4DHlwWJ/zk4o4IVkZ9zjk2cNxCGjPWVRWinRpekhpJVn6KTZIEf7bJDI0sq43ODz4fdUH 7dc08Mth hg79B8a7yU4Jc8tUhqPSihtMuzBLhEO2p0UBSIXJf2n3hHIiK1SQw5ADBf3Nxvlq366AROVd9d4VE+UE0UQBl+OJou/Ot0zp7bzHbBRT/RmYxT/WRarao89kSWyq5opPKVvsBv3j2+4LqbdCKKbuHKDcDEgkHOennSe3K7krZLqUvS4oqpE9XY9kU6jdd3H3+0WULMNsXRdcl2Wtjoe1U5UXjhHHcVpjfH6RjmsiJVU/UuXJYL6T5H39ZMKSLVrhfv4V2aVaEe7cp5lgejBqGQ1QdEQbYxLyFBMq++xz/VQU9+OSOb/AIEcYlEb+YPPjTxDYU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jan 14, 2024 at 2:42=E2=80=AFPM Nhat Pham wrote= : > > On Sun, Jan 14, 2024 at 10:49=E2=80=AFAM Yosry Ahmed wrote: > > > > On Fri, Jan 12, 2024 at 4:38=E2=80=AFPM Nhat Pham w= rote: > > > > > > On Fri, Jan 12, 2024 at 3:37=E2=80=AFPM Yosry Ahmed wrote: > > > > > > > > On Fri, Jan 12, 2024 at 11:42=E2=80=AFAM Nhat Pham wrote: > > > > > > > > > > On Fri, Jan 12, 2024 at 11:31=E2=80=AFAM Yosry Ahmed wrote: > > > > > > > > > > > > The z3fold compressed pages allocator is not widely used, most = users use > > > > > > zsmalloc. The only disadvantage of zsmalloc in comparison is th= e > > > > > > dependency on MMU, and zbud is a more common option for !MMU as= it was > > > > > > the default zswap allocator for a long time. > > > > > > > > > > Johannes and I were chatting about this the other day. We might b= e > > > > > able to disable certain zsmalloc behavior in the case of !MMU, ma= king > > > > > it available there too. Once that's happened, we can outright rem= ove > > > > > z3fold and zbud, and have one allocator to rule them all? :) > > > > > > > > (Adding Sergey and Minchan for visibility) > > > > > > > > I didn't want to bring up the zsmalloc MMU dependency in this threa= d > > > > to reduce noise, but that's also what I had in mind. Sergey and I w= ere > > > > also chatting about this the other day :) > > > > > > > > I thought deprecating z3fold is the low hanging fruit. Then, once w= e > > > > can sort out the MMU dependency in zsmalloc, we can go after zbud a= s > > > > well. > > > > > > Makes sense to me. Should we do the same thing to zbud? We probably > > > have even less of a case for it, no? > > > > Do you mean declare it as deprecated now? I initially thought that > > would only be appropriate to do after zsmalloc has no dependency on > > MMU, so that we can confidently say zbud has no practical use case. > > Ah, I misread your email. My bad. Personally, I'd like to declare both > (zbud and z3fold) as deprecated. That said, no strong feelings here - > as long as (eventually) we move towards retiring both of them. So my > original ACK still holds. > > Not entirely sure which should we remove first between zbud and z3fold > though. I was under the assumption that z3fold is slightly better, but > that could be my bias for shiny new things showing :) My rationale is that zbud was the default zswap allocator for a long time, so it's the one we should keep for now as it is more likely to have users. That said, I don't know of any users of either zbud or z3fold, and I am fine starting with deprecating either.