From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAB60C52D71 for ; Thu, 8 Aug 2024 17:18:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A20F6B008A; Thu, 8 Aug 2024 13:18:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 450A06B008C; Thu, 8 Aug 2024 13:18:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33ED66B0093; Thu, 8 Aug 2024 13:18:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 13AAD6B008A for ; Thu, 8 Aug 2024 13:18:59 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 882671C4D36 for ; Thu, 8 Aug 2024 17:18:58 +0000 (UTC) X-FDA: 82429738356.01.8106755 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by imf05.hostedemail.com (Postfix) with ESMTP id ABAC110001A for ; Thu, 8 Aug 2024 17:18:56 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VWiyne46; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723137483; a=rsa-sha256; cv=none; b=xuESOvtbobKiYr0snRUeWIhpcE+LSWauQkBdR2Zdm3bQhafnmzKbiiaYCeGacOUepT2RnE 6/fXzX70fFX2vqScvpSS0TSrusaNMttFBONCf9Y7CFG4PcbrNKvGET/TmblB+uWRAxumBN nAAoptoCpAsBW5sXeexeJCDsg2+Q/Kg= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VWiyne46; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723137483; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fBBEeQJbH1cIF1o5mQCVKPDzoYI1PKsH70ZVGIjSAII=; b=v2m0nrjEFRXHT3hlvXlmbhY8Fgt5r04Q8r5mVr4T48CrA+l18wETlWj6SkBy8twTCCNqge QOMmsZgGv/m23cOqgGvJgzmn9myY2O3UuBxVs88RdPMseMJRvv5VjMHw2iDOS4boAAyJ98 B6ddP2+K8KoTqpGWDsWw87PdA0wjoqw= Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a7ac469e4c4so196007966b.0 for ; Thu, 08 Aug 2024 10:18:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723137535; x=1723742335; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fBBEeQJbH1cIF1o5mQCVKPDzoYI1PKsH70ZVGIjSAII=; b=VWiyne464g28CkSK47bzDoKbOe+mVEALP+qd2hri50clO8hfT3OmF5mnInbICjf2iu WL1Aeb2JE5aLEDw7LefdmU5qIb/ObX7oCkOvDWC90PXxveqoXmy8nGyw4pcQy0rJP40X lcV7GMvmTno5lroD5dq1kHRaATSlf5gerPp1GrQck7LBk4P3J9AbDVbQZP+qnHzuCxev rviW9M9oxsWLqNBUBWvT6zcnsw2eYgNnh/jEmHqC22bx7mtsnQw93i5/0RhkyiZXDKgl 2xbZFeqYqDTAgb2QWDpfEPBnlH+5P7vXmaJT92DnoEUTyWnpLRBp7v74MndYkV7Sq5lm RYpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723137535; x=1723742335; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fBBEeQJbH1cIF1o5mQCVKPDzoYI1PKsH70ZVGIjSAII=; b=u1YPRK3Tij2fo8ZJfTr9X6b9ZlgegFXW5bmo2svc8ZxoX9H+yy3za2lEr0d2VSYYuk YIVcSmqq74udt4xCi28ufodd0fUG16eOWveq23pLSR6VooGHOppfTETqjE3MAu2uXUXw CNh9ObuqYFIovKc98XYeyfpmeLWUFUhMoWR3ZygbPeVPz71hDQkwHMwquP6RtgcgAAr9 skJNxdtUNlqM4c2VV03TRflQU9sO7ENv0wrNjmuzPxBucfPaK1nBXw3a3xG2jPOpw+2F hiWOO4VwyZECCD5PmN6JtJ51sXJlJkrV5N/icmNAFHwzPgd0Ukq+vGX9uc6/Mip07N5p 1LJg== X-Forwarded-Encrypted: i=1; AJvYcCXUPP0JrJ4M0cgo5biyzEx1wzbsCGNXlCPWUx12aDs+ml98ReiRq7DGgEG+Oq6keZOxN0JRDZaUjQ==@kvack.org X-Gm-Message-State: AOJu0YxKkm8Pn65ZuV7Gpm7N9kSeEHU9oVNG4pBiG/8jDyQQCg+Wt4cT 2r4AAYm9A6qxeqCxq5PWt8eD2lhVTclwBUVq8/n9LkoHFb/VM6VzFr5EIcWu/53KABgKe0fSxg5 aEEBjVL6F06K3Dw9LxIho4qY072cbFe/4Ip5n X-Google-Smtp-Source: AGHT+IGegQKLg0AVysDYuKUyLZQBsNuLTXHWokmFYlpa/UErmQ8lT83l5FIKtGvdtaqJ/+EOTiult52jrbHlbBrsR9c= X-Received: by 2002:a17:907:3f97:b0:a6f:e7a0:91cf with SMTP id a640c23a62f3a-a8092019fe8mr217691566b.24.1723137534485; Thu, 08 Aug 2024 10:18:54 -0700 (PDT) MIME-Version: 1.0 References: <20240808154237.220029-1-pasha.tatashin@soleen.com> <20240808154237.220029-3-pasha.tatashin@soleen.com> In-Reply-To: <20240808154237.220029-3-pasha.tatashin@soleen.com> From: Yosry Ahmed Date: Thu, 8 Aug 2024 10:18:18 -0700 Message-ID: Subject: Re: [PATCH v3 2/4] mm: don't account memmap on failure To: Pasha Tatashin Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-cxl@vger.kernel.org, cerasuolodomenico@gmail.com, hannes@cmpxchg.org, j.granados@samsung.com, lizhijian@fujitsu.com, muchun.song@linux.dev, nphamcs@gmail.com, rientjes@google.com, rppt@kernel.org, souravpanda@google.com, vbabka@suse.cz, willy@infradead.org, dan.j.williams@intel.com, yi.zhang@redhat.com, alison.schofield@intel.com, david@redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: ABAC110001A X-Stat-Signature: x6t7z6eskawypqozy13ofuyq9dwec9xu X-Rspam-User: X-HE-Tag: 1723137536-765533 X-HE-Meta: U2FsdGVkX195uYIMK1TnNVehwvb8V90xEtQts2LLWezoIGFFAT+0co0fkwQji4pULuNpF9AOy2l1N83Rl21VX3D3ol8+3k8Dqb7bLnaMgN5OROiyPbW2BeoJuCfFvXWpnR1+WZfAEHaZkpPXUT340kjP3RBzJSLo+rYgWnuhH/9ICz5k2B6qUeJv9px712hh7oAZ32XF4YdpglWzPJ1eBRKCR5yiKzHi57DcqSjS+JMVRDlZs2+5yTMO4CkwgDy0rUYGoV0DdEmnHLqrNsgVS9B5SGg9KyHFl8Nepv57etsJWc8xCFdrMtcJBBxiyEcfDKYUe8plrNsh9/IcaSa/I0RfLZSmUV5JvHZXdU8pFxFJtGnJUbClEmpzL42H6asETtFEz4Gd7brz1k8QmbVNX8vvv35Jn/+NosPgQi3V4ZHuuQrlDTODoOCARFaRQElY+u/AV0iDTbK6OO62lPmXI3bHLgY+fsacggurCX2A6fbfV1MXwAQn/kJF3TE2Eqgzy9ff0BF6l+bbbmAOhXAdF4ET9KXbFiRk1iQedyYBCsoziWRugCCfMe9guwexaGQM3vV9mNwDfjHxePKx4gOkQypRF69veHTWjkPeYWXbZN0le9rXh/xB5p0pHGZwOk45LvCYW7EBWd/Qbh5zz8nmsPUGmpPZ2dLL3NvWcWqDdBhX+2Cr94ypY0BKPjCL4vgKSbpvfQVmWSEyQ/IhBAwnVUU3TqEMEd5zOLgEgaXxzDByy+V99fZvneBi2BQIb7ZxRXBv413LiDfbbCr53dp5Kb9cMX5yYaGibBR2R1zYoAtc6kwqFHNztqu2cNtI9L/YGj0aBBQQ1ujqrs/e7+yRa1gMZbX9GqDnJRziE2zltT2HrP3C+QPotKTYRbr7xAt2XAhgkp/gSm49hX9g0BL7hRKjGGuQ8lYTcScN+eVJGsvHGu/JRUbfJFhQJ8eR7/VhJBp97wACsxTUguxuRSC VvW2kGyY GXJCLbxv9nAMIudwswmsH8xtABFcUsSXh3wgMp1B/X0uk4S+ybCvb+ts0HzgSJCIhL7NkFNRCNo5DSk8TX7mLMOGVZZSgyU/p4zhMxD97sSkvSGJBsI6ghxTVTu2D5z2XtqU7FZ9eiUnVl48dk7cmuiPhes+mj77a4iNBWK8Wc+hnL5xkfmcwBB7HhYg+6HCQcFyDQ89X+yGg5ChH2hKcDVOI+zzRvkIsPkiq+SSXwV7TJQysPBfW7gGdAhM1JPlFHTK3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000277, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 8, 2024 at 8:42=E2=80=AFAM Pasha Tatashin wrote: > > When in alloc_vmemmap_page_list() memmap is failed to allocate, do > not account, the memory is going to be release at the function exit. > > Fixes: 15995a352474 ("mm: report per-page metadata information") > Signed-off-by: Pasha Tatashin Reviewed-by: Yosry Ahmed > --- > mm/hugetlb_vmemmap.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c > index fa83a7b38199..70027869d844 100644 > --- a/mm/hugetlb_vmemmap.c > +++ b/mm/hugetlb_vmemmap.c > @@ -392,13 +392,10 @@ static int alloc_vmemmap_page_list(unsigned long st= art, unsigned long end, > > for (i =3D 0; i < nr_pages; i++) { > page =3D alloc_pages_node(nid, gfp_mask, 0); > - if (!page) { > - mod_node_page_state(NODE_DATA(nid), NR_MEMMAP, i)= ; > + if (!page) > goto out; > - } > list_add(&page->lru, list); > } > - > mod_node_page_state(NODE_DATA(nid), NR_MEMMAP, nr_pages); > > return 0; > -- > 2.46.0.76.ge559c4bf1a-goog >