From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82E7AC32772 for ; Tue, 16 Aug 2022 22:46:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C59898D0002; Tue, 16 Aug 2022 18:46:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C08F78D0001; Tue, 16 Aug 2022 18:46:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA9678D0002; Tue, 16 Aug 2022 18:46:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9B2348D0001 for ; Tue, 16 Aug 2022 18:46:11 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6D7F6140584 for ; Tue, 16 Aug 2022 22:46:11 +0000 (UTC) X-FDA: 79806940542.05.533E930 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by imf30.hostedemail.com (Postfix) with ESMTP id 20B9080035 for ; Tue, 16 Aug 2022 22:46:10 +0000 (UTC) Received: by mail-wr1-f45.google.com with SMTP id j7so14265850wrh.3 for ; Tue, 16 Aug 2022 15:46:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=s8pSl43fKh9JnCgmD3zX1WMUhwtcyLQMOInMOIHCWPM=; b=thGApBqcLsCEmh3pIRfPPTjA3/bLHUE0lVp6KZuhpZ8/XaxKjSsw2BgdMdYpP7ymnM ESvhyZMAMxvD3tRAEHWhsBP4GBQ7bWNSFVOiHm8hVtj7TtWfbSO7esaMlrJdPbZVLxNL CYhy1R0vjrjAWOGyIkBU1oDpc7QJ07rRnQEI96teV0fQ7kB206wfqAtWu/n5JTBwin+Y gfYvRzKW0pP5oI6tx+cfkf8sbbDsqbDcDAmH/p3uB1UdWO0XuhgPb1atJCwrJPXkl4ZR z7vyDT8KVdEDBNzSqmC9WOKYvYldB8VcollbxJa2iys4s4DTw12zi5MwFE7uJjE7PIWS 1jNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=s8pSl43fKh9JnCgmD3zX1WMUhwtcyLQMOInMOIHCWPM=; b=w46WI2/ve+y/jFuGdNjLCCCd057S+mVc3sL83JyaZwMX4UbNsSB4jtZGvKRY+D6AIY wG7Jo4C7JDsBDj46IPgHGPDOavqm8Aw1DuU/FMrC81hCt7lfmCiNwYZy36NGdKsyqaCT 2k8ywCNq3I8fQqwNiyYmhftkrZ3HtRytA4YAmM4pVcmd85lFZXf8NIWKrKGbUIRPQvRJ lChLCyiecWKKbOiqir4kLlI8UW3QOsqf3vdeazgFPeI8b024Vs0bpwy2HHA8cgLApflC is5BcpxPP+HL2dUYPeU2Vyp0vvpn8xJ0zxrbS0B4rDytkn1mJNqt4y0je2n9zeHVBdqy ld1A== X-Gm-Message-State: ACgBeo05yzTJjnAZXXz5PzaFrSgYvvqlnOfiO7dUWDW17CGBXbVSOxOj ufS97s+bnzQCJ0xfJOvD3gAuQxsw2KUPSbCuTtxqrQ== X-Google-Smtp-Source: AA6agR5YDZNX8BGW0we+ymcE37/vFJkAbxtvIx5oh+8aSvN3oBazJLky1o2ZU3nNXabaqECW4fCIGnOv1/Bxx2ETrTo= X-Received: by 2002:a05:6000:11d0:b0:225:1c12:65f8 with SMTP id i16-20020a05600011d000b002251c1265f8mr2254049wrx.80.1660689969725; Tue, 16 Aug 2022 15:46:09 -0700 (PDT) MIME-Version: 1.0 References: <20220816185801.651091-1-shy828301@gmail.com> In-Reply-To: From: Yosry Ahmed Date: Tue, 16 Aug 2022 15:45:33 -0700 Message-ID: Subject: Re: [PATCH] mm: memcg: export workingset refault stats for cgroup v1 To: Shakeel Butt Cc: Yang Shi , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , Cgroups , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660689971; a=rsa-sha256; cv=none; b=cVDua6bsLXKFThWjkZ1i3YdLUQy8NTWeEuWD+67cyZYSVpR1LMoQLKt0jc3QWwBqSUdbq/ NUvJN//7it+r81xRvs4MDMQ1pDFJRRekHawSok2EY0n+ce7fYJE0S/RP6oDq9i2cWoWZyL vWJ1TgmmzohvcWi1hTGhfCXOV+IuDv0= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=thGApBqc; spf=pass (imf30.hostedemail.com: domain of yosryahmed@google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660689971; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s8pSl43fKh9JnCgmD3zX1WMUhwtcyLQMOInMOIHCWPM=; b=w3BZvc0h0c6pPdL1pkiYTqhWVBehx+WeWgNDN0KrCeCHPEzrGNehIJz7IAB2r46JvCkZZd Kw6KkQmCtaBHlZ9ZnBeHc4wIYunQ5HdEG4v0fOaSTizSXWsnu5/9jWFHzk1jlUR4Fhks1s UcorEx8c1gDQU/yrbK07GTGlW/42Evc= Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=thGApBqc; spf=pass (imf30.hostedemail.com: domain of yosryahmed@google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Stat-Signature: 5epotosajpnaou1us8idhwnaqk13g5sz X-Rspamd-Queue-Id: 20B9080035 X-Rspamd-Server: rspam06 X-HE-Tag: 1660689970-580266 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 16, 2022 at 3:06 PM Shakeel Butt wrote: > > On Tue, Aug 16, 2022 at 11:58 AM Yang Shi wrote: > > > > Workingset refault stats are important and usefule metrics to measure > > how well reclaimer and swapping work and how healthy the services are, > > but they are just available for cgroup v2. There are still plenty users > > with cgroup v1, export the stats for cgroup v1. > > > > Signed-off-by: Yang Shi > > --- > > I do understand the development of cgroup v1 is actually stalled and > > the community is reluctant to accept new features for v1. However > > the workingset refault stats are really quite useful and exporting > > two new stats, which have been supported by v2, seems ok IMHO. So > > hopefully this patch could be considered. Thanks. > > > > Is just workingset refault good enough for your use-case? What about > the other workingset stats? I don't have a strong opinion against > adding these to v1 and I think these specific stats should be fine. > (There is subtlety in exposing objcg based stats (i.e. reparenting) in > v1 due to non-hierarchical stats in v1. I remember Yosry and Muchun > were looking into that.) I think only kernel memory stats and zswap stats are objcg-based at this point, right? The workingset refault stats seem to be memcg-based and should not face the reparenting problem.