From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A5DBC4829A for ; Tue, 13 Feb 2024 08:10:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1FB46B0075; Tue, 13 Feb 2024 03:10:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ACF676B007B; Tue, 13 Feb 2024 03:10:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BE266B007D; Tue, 13 Feb 2024 03:10:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8ABD66B0075 for ; Tue, 13 Feb 2024 03:10:06 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F0C48A0052 for ; Tue, 13 Feb 2024 08:10:05 +0000 (UTC) X-FDA: 81786057570.02.1F8D470 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf04.hostedemail.com (Postfix) with ESMTP id 163F94000F for ; Tue, 13 Feb 2024 08:10:03 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=xTKvEDXY; spf=pass (imf04.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707811804; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=egqhK25dF+GvbO3CcPt+NHWgpmthY9oC+i2hof4UYGg=; b=PwBR63mBofScOXvpN0iiYNYs4NSXjqJwybG1QyTc3bD+2WnoMTTbHQot+HDlgygDPYqQVu f8g2vuDZj/ms7QeWoDkEsIdWlQ7lONDhj+OT2ZiXyd2KGhowu/FMR9Ua6boldDQ2QOlktz 20pEucownThx+iNUv421QrP5vUHmsmE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707811804; a=rsa-sha256; cv=none; b=HuoqqKlJ2rHM+/TVja3xG/h5VnwVeuGuY0AKv2EPVnTh8HaSDeD3IzFBuAdH2CPDcFkiVc gUCykRDnQHMzm09bRb/St+hqjFq2JBQn/BrdDtCLyGTBRADe7AJ3xaY8ApKC7mxZYzOapp DD14+U4HpydySVcmy02Gh2IUGfGZues= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=xTKvEDXY; spf=pass (imf04.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-55fc7f63639so5101781a12.1 for ; Tue, 13 Feb 2024 00:10:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707811803; x=1708416603; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=egqhK25dF+GvbO3CcPt+NHWgpmthY9oC+i2hof4UYGg=; b=xTKvEDXYqeJ3OHyDScIqOIK9RwLVO3IFGCnWyKufnpENF/AWtx86SE+S/U/EV1x0/f Io93lhIk2TDckGy7uCRNxqKRvOsf9Q/v5hQeNfujcv9Fs6Hkb+jLXIs9aWcLqPj/h0wA 1NslyO84NtEnv50rHSxJOrOtEkLxBz0YfZ/M6i19XHdreeabvNQgRmam/b0otARGD2A0 k9aDAuUinclkeK0dk8bSFnvERurAYh3SMGxWdPtdPQdAZPN3063ktmon6ezwFx7xMuOR A2lUt/AzsllgkusiTBwnezY6Zpu82MCVI3y/4EOtUJdO+WDzPU1M5taOW/6lnOcl/jXT 59pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707811803; x=1708416603; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=egqhK25dF+GvbO3CcPt+NHWgpmthY9oC+i2hof4UYGg=; b=iGcru+PFZ9gaoB5cnF84PrUvF8xobkensVl0BGXYPEW4Nm26Tw3WfKd2X51XSld/dd QK8umY8c2eqBv//9LdCQFylwAcWqfDzftm1ZPvCo8581fMD0Vb32bLObR7TjEu/elwPM XxYFEsIgIMvWwal3UOJoF/LRZjdjieWfEwH90xe9okIfUXXKRhwvbjLE9Sf4Fdh8Wb/J az+cH2tjIgMIjgDjL6Qzl/Km3f8D0MyJipcUIApEX6o/FIFjllzWS5yjNX68miX1lNdz tnTvPuOqdGyE4EkJvFrIIm6VNev0wshOEsOIhh5dd1imwoh31uSXdDy6BBsOJzNMcIEl DjPQ== X-Forwarded-Encrypted: i=1; AJvYcCUYYyBoH/ugnOJapA3PtUj/8DXHQi1EvCKSyuzH56FAQmh91f6F1/jGcQskO/MbrdPVE4zuNOLZrwoFPI1uKEMdRn4= X-Gm-Message-State: AOJu0YzRHGWPQgjnhL94Z3omRgFe5tw9vRi2Xy0ePoPgaxwagzJwL8Zi cbiEp65aQBLjufuQPkYPEgqGENpNWbn2w8o4HRDicjxeEtcl3eQRY5s3Xfu5fLg8+lmq3h0w7SZ dCOiT47BAMz00NRHZN9PldrjIGeUvABkEIVRu X-Google-Smtp-Source: AGHT+IENH19pj5ViwJfKU1HL1VYtfhEe9SQGqrBU3moVmzP0ugffawEMxTzJgRblHo5SMYY/kWNCJ05Y2ZM8b0UJpy4= X-Received: by 2002:a17:906:5615:b0:a3c:2da5:93b2 with SMTP id f21-20020a170906561500b00a3c2da593b2mr5309045ejq.1.1707811802500; Tue, 13 Feb 2024 00:10:02 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Yosry Ahmed Date: Tue, 13 Feb 2024 00:09:26 -0800 Message-ID: Subject: Re: swapaccount= commandline option To: Michal Hocko Cc: Narcis Garcia , linux-mm@kvack.org, Johannes Weiner , Roman Gushchin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 97deyuy6t5tus4w5ior5fsbudtoybkg5 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 163F94000F X-Rspam-User: X-HE-Tag: 1707811803-696875 X-HE-Meta: U2FsdGVkX1/SOoVEVvctonpeNIjXBMK3YDtd2IUURpKcXyccvWviO/eVrqcn1gsBxZrkivLyJ+zfIkw5YgjW85VoS0j4b68QLdaC+970/u01EyD3ZbFP+oXvqahliUj3insQdOFhXns1UrRK0kvGVgvZqZ/Qlin8scRaRnHb5ogm30/XdUo4Z6T4AFTTrOJiLLLlbqFM3nO+inRoBMbE6nLbzT8oG1zeTdSpvyDO1N/yGySEeN2ETMPxC35C4GQdZKF6yi4px7Wg1Jdi9EqzgHO40BUl1UzK0FUI0tDqH3o9Sql3L/5QEJaWbWCagbI7rU7TP4OJ0u3uLqFXTL9NsWRKNknl1XyDQabXux7TIgfR0ORBxJk3GL5UNSg/aiA+fsQk6uKo5pYIYujrPURbjV9AxvAPn4E/LAFk66gle8EVe+FP1TR0zU//8uLw1mBWn0bqr8pPipWsc6SR6YE7nlP/IAf1LycU7JWD35zWo1VkQk6hFHGd+ObzrbyxxaV2eg0JZgfCxaWq1C8gkIejSimoo79X3r/xI7U1itoxwc0FJFTu4lOr383uVS6O8DBJi/uCfIS7qpkEQ1E/r2wwdwPg39DoPGj0zqDymZNTxzw5JA7v3NpNdik0FUEwfHyQVDZStQJrM9j1MuFPb9SffgSreo/lSTvUPZsX5XtZ62nRlrYiW4yVJSAgZ9Et+/MnK10MdsbWEENE0bKOjJageAO2b49l786t5Iga9f8vrOf8SDrAJhJCuhD0YyYEirpIXHblM9cDLQHfcZkhmtZv6scGSTrAYJOPulSBiLcsWrEvospb7dPXMVsxkounboHg/vpM3EyBFEPV1pVAwfkEkywsk/QKuwnUOxkUeIn7oHct/z9/wvn2Qp1BJjdNT0R08hMHpQsUQGHjtZ64Lj0WZJDNyxuAspSe1/SSqBf9M2ZSPeRI7cMGG8wXfPqYYj4KrTpOXs/9QCkh3glR92K Xhe1H4Wh p1k+D4e00zbPQ771s5OaxsCNH5hlcmDWqM5gWsRnnzgwErCjGFzk8u8aYBVRF3iBSKtByZ8OhGTQabnyOv4TRhWxVISnR+yQRRJKRJX2k0QK/rYk0PZFgI0FcXG5iYskPQG9DkY+lCIMCUjf62cYgSzrzXeEENBMrdWEEumfOcGMD3Bt0lsPXSbdREczU23774KUL5yTTZmp40OCMylSzRjak9Uw7CuMsMuL+y+Zz66En6daqLE0BjPigO8ZyHWHIChJTP7DozwGVyni6DhqVLbI+YUIiaompfF3MdkHGu7AaABrvLYQ/sxYftd/qqvc8k3u2RWHYDMOPSzr57ghpgke+vsf7r1kqR+AefT4wR5TxE99i/Crs+I7kMwJocDXfjbgrXB278NaK+QzpIDnLc+mZgf6E9khNTWk2UJaqN/Fdy7LGcN0bfGfhhDJ+lIKWkwvo+OgMoZSoNxmWA6TbcCXJ9g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 13, 2024 at 12:06=E2=80=AFAM Michal Hocko wro= te: > > On Tue 13-02-24 08:01:37, Narcis Garcia wrote: > > El 12/2/24 a les 23:37, Yosry Ahmed ha escrit: > > > On Sun, Feb 11, 2024 at 1:33=E2=80=AFAM Narcis Garcia wrote: > > > > > > > > Hello, > > > > > > > > I read this warning on Linux 6.1 boot: > > > > The swapaccount=3D commandline option is deprecated. Please report = your > > > > usecase to linux-mm@kvack.org if you depend on this functionality. > > > > > > > > And I want to know if this impacts on LinuX Containers (LXC) swap > > > > accounting. > > > > > > swapaccount=3D was deprecated in the sense that it is always on now > > > (i.e. you cannot do swapaccount=3D0 anymore). I believe you are using > > > swapaccount=3D1 and want to make sure that swap accounting will still > > > work with v6.1, right? > > > > > > This is the second question we have had about this message [1]. I > > > think we need to clarify the warning (and perhaps backport to stable > > > kernels). > > > > > > [1]https://lore.kernel.org/linux-mm/2593755.Xrv9ptJ69j@sinistra.local= / > > > > > > Thank you for answering this question, and sure this clarification is n= eeded > > both in documentation and warning message. > > I've found deprecation message was commited on 26 Sep 2022. > > From what Linux version release, this deprecation is included? > > > > I suggest this for setup_swap_account() code: > > pr_warn_once("The swapaccount=3D commandline option is deprecated. " > > "Swap accounting is always on. " > > "Please report your usecase to linux-mm@kvack.org if you " > > "depend on this functionality.\n"); > > Would it make more sense to warn only if somebody tries to disable the > swap accounting? > --- > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index e4c8735e7c85..dec75eedf634 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -7936,7 +7936,10 @@ bool mem_cgroup_swap_full(struct folio *folio) > > static int __init setup_swap_account(char *s) > { > - pr_warn_once("The swapaccount=3D commandline option is deprecated= . " > + bool res; > + > + if (kstrtobool(s, &res) || !res) > + pr_warn_once("The swapaccount=3D commandline option is de= precated. " > "Please report your usecase to linux-mm@kvack.org if= you " > "depend on this functionality.\n"); > return 1; > -- Yes, this makes sense to me, but I still think explicitly specifying that swap accounting is always on now would make things even clearer.