From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65D0AECE577 for ; Mon, 9 Sep 2024 17:21:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D752A8D0003; Mon, 9 Sep 2024 13:21:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D25B98D0001; Mon, 9 Sep 2024 13:21:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC6288D0003; Mon, 9 Sep 2024 13:21:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9C0B18D0001 for ; Mon, 9 Sep 2024 13:21:00 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5C00FA0D4B for ; Mon, 9 Sep 2024 17:21:00 +0000 (UTC) X-FDA: 82545865080.27.E5289B2 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf07.hostedemail.com (Postfix) with ESMTP id 8803640009 for ; Mon, 9 Sep 2024 17:20:58 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=lZUW1g9s; spf=pass (imf07.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725902357; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CFGndf6+Xj/OcozYle3EJLLaDe3XNlSVsUPxx6tiLjI=; b=SZDzo9q5FyrXglMPwj1HUc1Ht64UafOJs/ebt0rquTGelVy6oj5HQEoVsIJj99cPGnyf4P uOVuOTvj3WcIYbR+ByJWU/SOFY078Eg3Z85fTKV5hECgQ242ndrW7aEOnXC55HSBzXZNCg Jm6hX3Reja7reSSan1Ibzuv1NmrKzTk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725902357; a=rsa-sha256; cv=none; b=dMKDuZDytRfKo9/M5IKpzB+Vq3qb/X0M7MndiCkePKugZLG/sz+0dft6Any9cT3o443r/x A5ynRRZZL6xnm//jSUNzJrcYQsHj19F+AlxprWXC2iofDUwegP0v3wl0PJPcETOX/IzqpR nYXJKSd2RUYGOZBuM7sXk7D3jImhM/E= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=lZUW1g9s; spf=pass (imf07.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5c2561e8041so5149945a12.2 for ; Mon, 09 Sep 2024 10:20:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1725902457; x=1726507257; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=CFGndf6+Xj/OcozYle3EJLLaDe3XNlSVsUPxx6tiLjI=; b=lZUW1g9s6XqsbbWdTMSVmnTlsEvaHpFBRyGfHXcQjX68lQpguqlpsVaqNHQjXMI1+J iTzQVGT8kYRFAlacDyJb7FvuNNzKUv3qo5K9ECrIHGaAo9QXfGsKRnI6F3It9QYyv2BP MwCwUVxk1d9YVRzSD+uTJQB0JRxG0W9WROndzR5INULMoVndGsA98olHDuUIEtXztvcN w2pEIurASTopMccmK1bPOhF6y6SIB5oUx+dGlVg/Wn+71S0/6yfpxqesfPtZfRY42BN4 9TyXpqUk/LddZRfI4GDnvddVmd1ezQ1xgce8zcOSUGa2qHauAay2N0Tp2WHSSsNmxPJu W7+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725902457; x=1726507257; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CFGndf6+Xj/OcozYle3EJLLaDe3XNlSVsUPxx6tiLjI=; b=W0C5/WhA3ZwSXaetLVzjkSZ1kkm0AjPqXfEnnvvul5qW/Vnj6QxtMLPhkrPDUXejgH VfjGTT1TIBFzUkAN3stzpvwf3u0LT1q2/5viEojbggoZBOYquG+InsickGgBrlKaIKbq GlTmWh3/fYz/I4AhuUKRqRqQAObsuyVFhCSHT1G2HLAw1L4MXCJkbRD/a+LUCOb0Kc3P G12vKs8cOQeWEOLstBbRoGgYpcCoXLF1+mMhW/jZTsUMd6MvxfFNSs/eXHdt/9G6dBzI l3/C880DUzJ8F4RtyNo2WzRklwKAVawzrIupVzE6LtMMKXzqrmCiV95e/S3rkGFNaXtH OFsg== X-Forwarded-Encrypted: i=1; AJvYcCUzt3EoJRKyusOKTaT0Z56TPrSzXZHdMxd3t+LfHix/6KP8I9mVjjZs8gnJdPWZk+C+EQ7YsumTgA==@kvack.org X-Gm-Message-State: AOJu0Yy6k8SJvzFdKsnk4/R8RjNVbb7bkM1W/z9cUL37x2MzvpKjPJUo 70rXloS3SjNLfsn7NeFEFMJCDWi36cY9ORiurlPckmw3Gfn7YsvGHWJToZ0J4AsGeBheRl8xM65 qIvAd1P+0SlwdaLJbGkkfKkPzEf0udWClqkCd X-Google-Smtp-Source: AGHT+IHEMkXRi8Qojfd5ZuTkY9ul6MC80RogKg7lfulxwokHMBECv3XZL6XRA4yYXJEOQGWoOekFvGU/bnyKPClSXW4= X-Received: by 2002:a17:907:1c23:b0:a8d:2e3a:5303 with SMTP id a640c23a62f3a-a8d2e3a54c6mr540762566b.39.1725902456088; Mon, 09 Sep 2024 10:20:56 -0700 (PDT) MIME-Version: 1.0 References: <20240905173422.1565480-1-shakeel.butt@linux.dev> <572688a7-8719-4f94-a5cd-e726486c757d@suse.cz> In-Reply-To: From: Yosry Ahmed Date: Mon, 9 Sep 2024 10:20:18 -0700 Message-ID: Subject: Re: [PATCH v4] memcg: add charging of already allocated slab objects To: Vlastimil Babka Cc: Shakeel Butt , Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , David Rientjes , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Eric Dumazet , "David S . Miller" , Jakub Kicinski , Paolo Abeni , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Meta kernel team , cgroups@vger.kernel.org, netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 8803640009 X-Stat-Signature: qebabmu1roaosgi4bhdssaq8axonozm9 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725902458-609022 X-HE-Meta: U2FsdGVkX1923o3L5ni1M2ZHTOKQYrRxZeAygGUoNMetiPoPb0gtTFZ0bnXW8pudunFw/YmnJtc1rNPJFXC+7cfI4UR473KGPfbk+f749k4123DP6goeJFLGA1IYYo9YqJ7tY4tZYkgM7h0xHmJXZO8t/QdxQF8wDgV2CoYhN5iyFGmHVACQYoXbKfU/xv2ecYdiTkfIcT2RpEyQk5FgP32+QHrKRdBcdj11AgALPYUr5xDa+WWU34UTdM5UYC/Lpb3ioieRtnqUpdmwhr26Z1uyo+mkvIENqjuVNtmJP6eHRlY4yVvlBaK5DwEn79scriiDygeaH7JJQqDC/U1K3IFQdmg8PReqkSSMVzSYQkDfo+zljkRKsVKS4Iu9KPKu+w1tvrxibQR0ck8BERGL7ZwqWci8PpqgY9b13z/xOdpWLUvEb+1OkHYGBpzwFtrL0JeXzsU4selVGUadyvg7JptK2l8geXNLyZvBJGQJSoFK49Nv8yn7+loVy8RWTNRuIc2JlDWQuSO4riDgkHVifLkCR+zZ0E4jfEglU7+nfqyEj6FhD6BuAzav1RRXmTCkBOzxWwUT3PzXEwi8YtckXZLotp62izfIogSdFMHQnkCDI3Jkekj3fs9HbQtKnwR09kdVrWbA0FRBjkSg4u9PR6MNZzdUr929vvgIcB9UYB3/lKhmEQAkd3tHHIbQxLKt+ZAwwbncYC8qorlLdipK2tkOOtewkWWidkxFSRvUIiUT6g8VCgsw+dDXAQ+8JgeF8PDfZODHQ09QFDP1JcmTN96VDdvkC9fASCZN7Sp92XavsELOVMPBNFIhtETyH1G8FvLqggBf80NdbyN2zFF0D9s11JCeB5dqbmQVxDBmbWXHy8QzajvbQ5ccRe1yviZf80q063FwKe8PebfD/14cZuwJc2LY00pZhmNHGZNLq0kQh6gjzDGJfdo29AeWFWcsjSMyA6nw65e76tub2Jm 2hRYrQC4 Qjf3wEe9akAqJTItQL1TOtFrWanc15F+j4Eq630LL90UpFnsG+LFUZCXlAqzDkVG2J8Ikiv+rrT3zvJwRJYKo3rYiW8M+F5ZpKARvd29Us9Lzhpm9vBn2qqhNVTl5alsAV4GWvGY4JCOU4LD8T/khjgv/YWADXDVcsKfmwlhHzwQ0AFwAIExWGH2xfjObMkh4JzVGACKOS2bC7E6a6J+Gj/XXhEMH8d39iqPYglMLQddzQWSayT9gzrchFmuWSk4SFiozvaAIFKNIack= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 9, 2024 at 12:59=E2=80=AFAM Vlastimil Babka wr= ote: > > On 9/6/24 19:38, Yosry Ahmed wrote: > >> But in case of kmalloc() the allocation must have been still attempted= with > >> __GFP_ACCOUNT so a kmalloc-cg cache is used even if the charging fails= . > > > > It is still possible that the initial allocation did not have > > __GFP_ACCOUNT, but not from a KMALLOC_NORMAL cache (e.g. KMALLOC_DMA > > or KMALLOC_RECLAIM). In this case kmem_cache_charge() should still > > work, right? > > Yeah it would work, but that's rather a corner case implementation detail= so > it's better to just require __GFP_ACCOUNT for kmalloc() in the comment. Fair enough, thanks!