From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 616D9D5B861 for ; Tue, 29 Oct 2024 02:43:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 631796B00A6; Mon, 28 Oct 2024 22:43:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E03F6B00C1; Mon, 28 Oct 2024 22:43:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CE8B6B00C2; Mon, 28 Oct 2024 22:43:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2EF3D6B00C1 for ; Mon, 28 Oct 2024 22:43:44 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9657B1C62C3 for ; Tue, 29 Oct 2024 02:43:43 +0000 (UTC) X-FDA: 82725094116.14.35D73BF Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) by imf11.hostedemail.com (Postfix) with ESMTP id 69AE740010 for ; Tue, 29 Oct 2024 02:43:12 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="UP7A/f/o"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of yosryahmed@google.com designates 209.85.222.178 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730169767; a=rsa-sha256; cv=none; b=cy65oQAEAZinfVU8UJViMsGViFIX+babgo7BpNCdOX7j5ixlxPqmZaNJVhcYvKD3bKTUG0 2Dg78mxNoz4QZ320RYpK9kTqqSj6zs0ef2foWn0tB55pEExYozP5L16RIOFW5YIiywrHY5 zyOeOKkS92+SXsOTA8WRP+/1Tms8Bmo= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="UP7A/f/o"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of yosryahmed@google.com designates 209.85.222.178 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730169767; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0r0u/BybG7849PH2O8N2VQGNwjrvyp+wg7FV5E19Pv0=; b=j8MC3Lf0DbipMFpllGhepoPIPjI3tXoTArRKGe0rbXDbJch9SNQZVCx4TuNQj90OwGVQFW mJUcfNc9oL6E26U8eNTiBApg/DDmidwYfRr86GiD+31DDeysvbqD1FAFhVjCrQlQhOyLI4 shXJOBYkLMfnu+jO5AmS4Rbm6vrKE3s= Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-7b161fa1c7bso369482685a.0 for ; Mon, 28 Oct 2024 19:43:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1730169821; x=1730774621; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0r0u/BybG7849PH2O8N2VQGNwjrvyp+wg7FV5E19Pv0=; b=UP7A/f/ol7YLHK7Oh8PvCP5W0VwbXyIzi8yIgEVk1cPTVMyQnkpiLXSfx1ig8MUQyv Mvm9yeWqZUfn3sbOLkwsLOKKPNXRMyS2cSCHglFz/n9Vykc6y9BEYciBM4ehYitB5Req dNbQsRpk95YNctGmCDCsjM212SzGeAqyHQttEExSNMpQnbAWcgae7LNu7hZAoVU+QZht orUwVHdnLSdpAZrpPk9Xck0KhKryj7Qpf8CiFEw+OSnHiQ546ka9Q0dAigGlbALCnNNg 4b3UeZDIg61j+aBDp9R/NItQ//95q10IBxsl6j05mBAxo7D1JZP7N/Akj1uZOGOEEStO oRcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730169821; x=1730774621; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0r0u/BybG7849PH2O8N2VQGNwjrvyp+wg7FV5E19Pv0=; b=MTlUoKt2mNYx8bFT7OhQNPiTFNl/p539q6zU557TlDoYmyWLJeMhC+3AZ2k/rYEgKs tCLpTyN/LCMe5Zg9ITG2aY4HhRYVBj8T7j4li5x7Fj0wEzyE8YrCtkg3Q29E5RiXYGFz vIx755VV7lCagf4fpuqhZI7jNKL77WJDZGJ1eL0A0aE9rOYToMPG2zIiIV1f3cGGNS5s lnAjVlmPfbToPQI3ewxYrffF2pAsogQAMbHGqmV9a4EAfAH53J2HygABBVO0k/e08fCq vpHY2W5vJkwiA3wCewkgPrAmO/ABHghE+yWMHvPly1PXmgsvBC+Ksp9u6ra7FLbN1VF5 uAzw== X-Forwarded-Encrypted: i=1; AJvYcCXF3dVzXdes9BNXz57U1CF157iVaNxK+StFdvhVByszQORbAP357K72MAt26jUBso0Iff+1KjrD0w==@kvack.org X-Gm-Message-State: AOJu0Yzts/Y85uPmCGfJyUnWtkOazICDC3DsdifoxN9npPwY+SSIND7L /mklwHAb5OELgDwW+6FGp/KQqd/HhDNtOI3nSTxcHl3OqVTjk7Nfv98cOK1+HccE/dDfu2AD8e2 Kmupt+fkUMzS4k63CSvzSRcIWnNwHYpmNKgxV X-Google-Smtp-Source: AGHT+IGYQ9AudrdXVaFld8PnZP3WMiTL5Ndbl97BDIv4DLNb3oqHt0DqRhLWLRP5dANnBHtCRZb3R3esCAEjmN+Dcv0= X-Received: by 2002:a05:6214:5f03:b0:6cb:f7c7:803a with SMTP id 6a1803df08f44-6d18585e936mr179900696d6.46.1730169820716; Mon, 28 Oct 2024 19:43:40 -0700 (PDT) MIME-Version: 1.0 References: <20241029021106.25587-1-inwardvessel@gmail.com> <20241029021106.25587-2-inwardvessel@gmail.com> In-Reply-To: <20241029021106.25587-2-inwardvessel@gmail.com> From: Yosry Ahmed Date: Mon, 28 Oct 2024 19:43:04 -0700 Message-ID: Subject: Re: [PATCH 1/2 v3] memcg: rename do_flush_stats and add force flag To: JP Kobryn Cc: shakeel.butt@linux.dev, hannes@cmpxchg.org, akpm@linux-foundation.org, rostedt@goodmis.org, linux-mm@kvack.org, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 69AE740010 X-Rspamd-Server: rspam01 X-Stat-Signature: fy1afpde8x9bc8gsr71outdr3ckjxr98 X-HE-Tag: 1730169792-970405 X-HE-Meta: U2FsdGVkX1+aiA5e5TmzsIe5XYC8BKTkENOzf6aEJfwNbsKsXXjB36POXiSY9A9WCUlrFE6ZI+xaSD2GXKWHdnTZyQbmeNg/1mutgXF+LXk+oTgFZ+zStPtfG1jxOrIqZuqMbdRA1NC9ngiM0IveFS2oCHs9uQns/lDIYE/9bJ1GcnTEa5RRl3/xehbHVsLs/CF6bdd91PZBX3ShgWjBjUnQJPIF50A0JPuUfvbcyvHY4LoATXN2N0qGTgRuT7E6jV6lJAvi+y7Gliv5Y5wx6AToJGcjX1USwgBhB2zUjd/co5/MkPlyeAE0YGAgkLu10kk5UwcimjzkFMtCCiCNMoRvcOks0hbZxDF7R381lGQfc9vszyHI5xoT/S9KwrHTlcDkhytg27INKexk/ihOkkZKpXqil2zBHgM7jseQuRptrmEjNVw6TCb3tRosouCGwp57AwLAr4oXV8TfuXJ7IEPOQ13kzcjxvK5Ll5JF8vZn58Ltzcm3D35Rd6Idn14/CUWddI8+HJlffialGMyFcb/SSANILfuoAGydUswTpN7UuUQUpf/vn/1v+DsdS2Lme1AGLPBvYpH5vmAyOHUEPLNoGbTbSAQmF74/Usssrnyk7VWYnM72tNSkGPf7Udd0F8kbB9YcDWAa5Uq9rZepV5kyyuzu4K4Wta3XS50WmHOePrFHPTBp9jNboT7Bu92/Vd/5B6YN8brQMxb15+GlPlv6RKA/XpNC44MBptdmArpSXyC635xywnjOMrpBvjAB6GmVB4vu/4MSm33uIxzy977UTXPgFlFPQ1BoN99YEi+ph+95QlDT9BLn//fkG8wWVDqlBbL2Jcelowz/LwcG0K6e1BRe/IzRtGrff687CAlmIsdhcdH/w8lIaAC/myxlKgBwfdkHSsTXKxoMfqKZpa/ofBva3E0h/u65HYTbq1ziHGP5FV7H8I6CZShq9FDiVKpjjnrKV9XWcle2aLS oX2+9oEM DuKwj4anROSSEkC3GyMAEwKK+/fpul0KgLUvhmwh4b1QNrZgS3zMCb3N8rUz2L2PqE7Xanu3QXtbQHfODwKiMMr5V//uV/A0EYgQZDvXLOMEoTw+X4h+XlCZzKG1VUJ4ebpP094oqgdixpqiX0gz/KwFWrabSZ7yV4hPWkFO56EJq0M6tSVEcOh1J9WM23YQvyvU6245YjFFfM1RHIa2gSrBqMgamDciMgMhMtU3qx0+luh/FZt5Bz1nBKIs4DiKrfWxUVtwSII3v7SGvT423ikZECyxbGLdKDgIt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 28, 2024 at 7:11=E2=80=AFPM JP Kobryn = wrote: > > Change the name to something more consistent with others in the file and > use double unders to signify it is associated with the > mem_cgroup_flush_stats() API call. Additionally include a new flag that > call sites use to indicate a forced flush; skipping checks and flushing > unconditionally. There are no changes in functionality. > > Signed-off-by: JP Kobryn Reviewed-by: Yosry Ahmed > --- > mm/memcontrol.c | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 18c3f513d766..59f6f247fc13 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -588,8 +588,11 @@ static inline void memcg_rstat_updated(struct mem_cg= roup *memcg, int val) > } > } > > -static void do_flush_stats(struct mem_cgroup *memcg) > +static void __mem_cgroup_flush_stats(struct mem_cgroup *memcg, bool forc= e) > { > + if (!force && !memcg_vmstats_needs_flush(memcg->vmstats)) > + return; > + > if (mem_cgroup_is_root(memcg)) > WRITE_ONCE(flush_last_time, jiffies_64); > > @@ -613,8 +616,7 @@ void mem_cgroup_flush_stats(struct mem_cgroup *memcg) > if (!memcg) > memcg =3D root_mem_cgroup; > > - if (memcg_vmstats_needs_flush(memcg->vmstats)) > - do_flush_stats(memcg); > + __mem_cgroup_flush_stats(memcg, false); > } > > void mem_cgroup_flush_stats_ratelimited(struct mem_cgroup *memcg) > @@ -630,7 +632,7 @@ static void flush_memcg_stats_dwork(struct work_struc= t *w) > * Deliberately ignore memcg_vmstats_needs_flush() here so that f= lushing > * in latency-sensitive paths is as cheap as possible. > */ > - do_flush_stats(root_mem_cgroup); > + __mem_cgroup_flush_stats(root_mem_cgroup, true); > queue_delayed_work(system_unbound_wq, &stats_flush_dwork, FLUSH_T= IME); > } > > @@ -5281,11 +5283,8 @@ bool obj_cgroup_may_zswap(struct obj_cgroup *objcg= ) > break; > } > > - /* > - * mem_cgroup_flush_stats() ignores small changes. Use > - * do_flush_stats() directly to get accurate stats for ch= arging. > - */ > - do_flush_stats(memcg); > + /* Force flush to get accurate stats for charging */ > + __mem_cgroup_flush_stats(memcg, true); > pages =3D memcg_page_state(memcg, MEMCG_ZSWAP_B) / PAGE_S= IZE; > if (pages < max) > continue; > -- > 2.47.0 >