From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8908ECA0EC8 for ; Thu, 29 Aug 2024 23:39:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B9246B0088; Thu, 29 Aug 2024 19:39:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 142086B008A; Thu, 29 Aug 2024 19:39:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFE1C6B008C; Thu, 29 Aug 2024 19:39:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CE6916B0088 for ; Thu, 29 Aug 2024 19:39:17 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 84F22A5B82 for ; Thu, 29 Aug 2024 23:39:17 +0000 (UTC) X-FDA: 82506901554.19.8502B70 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf28.hostedemail.com (Postfix) with ESMTP id B3B8FC0015 for ; Thu, 29 Aug 2024 23:39:15 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=eeTmZvHm; spf=pass (imf28.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724974734; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xPKmii8VGDYcV+TyAEqaS8QPtU+HBD45jztCQktpPHI=; b=hhaqZG0BTxigEBNqd/GKd9NogMqn33eMXyBpM7jPOKSB0Fq+3/PDq6KpQ1spSPD4kdCGGB fTOTUFJAOaWC9dd5ekOxvfMMg5gBZQP7MRA69OBpPO0uipnmbC7OkdegTIhwoYZd6JYZ8w VbVc6l2f76P74YQeF/dLxR19b6RJ+LM= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=eeTmZvHm; spf=pass (imf28.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724974734; a=rsa-sha256; cv=none; b=7dMny3zIot6EER0QUXR7vEY1XikTzBT3dY3vkTi/7ULTeQuCqwUSpTGW1qopTc3pTlRsMk QosgXRu++1JZJa8ZQtm9PRp3PzzeLLsiCesJnYC1WgiFuI2K1DxOS733iJTPkFbRgKRXrq lQBlZPuxl4OQ5OEoXlztEuo9aI4MPFE= Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a7aa086b077so121691666b.0 for ; Thu, 29 Aug 2024 16:39:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1724974754; x=1725579554; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xPKmii8VGDYcV+TyAEqaS8QPtU+HBD45jztCQktpPHI=; b=eeTmZvHmZDP/8vNyvAo0giszXsHCC4s5RAoamYnsf2G1JepKcx3nxGEKJt5HD5cAzJ jDs+cZgtvbC/q45Yl+jL+2Y5SSaEOs87/Pxn78HSidxFpB9PqUcpipbhgUF8JnjoSV9U uBDV3yQ3wpBfbPB3KjU+5dk+ZAFZBAfG3hlEDSzAhQ1JOpeoYd98a5RCmSho9UB6+sqj lgcHXdObaF4fMswUMUFMAoc3y3/z/M9OJZe5z5tlYLkrtE/d/RSdW3+CIh9nS61pATki vvjyaCIEK+ci+g9zGY3Kq9lv0NcYhUf3MR2acMc5ywPP389o94IvmEYJNmhOak6YuQH4 KyUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724974754; x=1725579554; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xPKmii8VGDYcV+TyAEqaS8QPtU+HBD45jztCQktpPHI=; b=NjFtuD+B20DH0YdJunvcNGGlDgj4pcddUgrn/LCC5Znxk/fb660mYW4Puy9XB11YRI +KrBy1tqGzqtQWJI2OXqLJE7Fa2p+LQljdMj0CUPVArXg4tn5tjt249sZ2f4SnmaULIo 3fnhqS20Z5zvMGJaif6ZQ42qpwYewhfzLfzhbCqNcVoRvMy8n7t613kl3dbCoFFtR7B1 pxlGJ/z6JRU54SG+hgo2g+eaGl3juY6hk8Vn3K6twoeLLECZkEIbIZyQXWFmHMoCFkNy RHUQdCpYMDexmKhDSrnKWA73I3Rvoi1XTypALkcTYvyWSHgE1aFgNm4ezPr9TDksHbZW d5jQ== X-Forwarded-Encrypted: i=1; AJvYcCVEwH9jHRVOofQlxxavMLtekKFiHFYi2EaD4GS6iN1PZBzHXTd2UIxvsrDSZnri8wcWrGW9+ALocg==@kvack.org X-Gm-Message-State: AOJu0YwpzemHMKNFLBjN585ATYSiGMgIuWA6B6ICtw7P26nft44qXdEg bYJ63jGbTHAAvL++SeSbq7vBr27Cw9UIRBkNlNnDtXz1Vz1ZxIlFow0ZsAc4eFYk6wEc6wl4SR3 rexb6PegRx5tjinev+xc8B/aY02F3IcHT/rP/+l/3A72htDUmtVic X-Google-Smtp-Source: AGHT+IGzZfUfLb/wr+phXMbsB0+tDWS6drQ4HUFsKOGrUqGacGSCGe1p4nfsL+WVQ9XrDA2jPRt1p5sNpvv/DAfFdKI= X-Received: by 2002:a17:907:980a:b0:a7a:b070:92cc with SMTP id a640c23a62f3a-a897fa638famr365229366b.45.1724974753491; Thu, 29 Aug 2024 16:39:13 -0700 (PDT) MIME-Version: 1.0 References: <20240828093516.30228-1-kanchana.p.sridhar@intel.com> In-Reply-To: From: Yosry Ahmed Date: Thu, 29 Aug 2024 16:38:37 -0700 Message-ID: Subject: Re: [PATCH v5 0/3] mm: ZSWAP swap-out of mTHP folios To: Nhat Pham Cc: Kanchana P Sridhar , linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, akpm@linux-foundation.org, nanhai.zou@intel.com, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: 3fkme6tqjjcqxhta9i7g4gr57jnupiow X-Rspamd-Queue-Id: B3B8FC0015 X-Rspamd-Server: rspam11 X-HE-Tag: 1724974755-93474 X-HE-Meta: U2FsdGVkX19lntsZBqsmS82d3VvQdXdBbdIsdWoa32T+282UBv+2UrkpfAgpFBln5SrYDj6C92wEEFOPaOE3l/bxIxrMVgjzkNgfzhFJeCQr0MXOaiInm+uEtXI9aep1i74n5YKzQsrrJbg9/JbIvHIFlzW6xAYqcQLg0m00hDSTXzWjimwY0noaezAeoMR9bZeMZgL3JOB1UfodYsUrOtxkEdy3QHaBGmDQkYlkepn+MjEzx1OyohavqWFsR9qNO/gD5NqS0os7CXB/E2devOkVE5Lcrm1BXHIInZayCD68ngwYh9KTG3eSyhQhuSDimR+q+rh+08HrXrfTmKI5LVGJC6XrBOJISkCGXuR/E14yjswUYaZQh+5vPjkw69oQQVNcplnxEVzZLshmqe+5fMUcMpfBNoOUdqoS8i2BkQPGtRycTnigU0+07/8FvTNxyqur2Il4ygrylwr24iAs+MKizNqpAQAALHOJHtoYsFMMyCjh/9KCmpMP+25arZvbw7BfB7mNkNSyuvyZzksSwpNAgJ+9ROWkEJys8q8SFHnY06yCZYK2/TCx8WCZGMKPVauRjGMljsZLYAfo2S5agTXkQedd5uYkTBUAragY82//opOftGBctpJGsTvfHToDR6iuvCOme959mPBjSbnltvIHhyg8xX7H1PQsiiBCVUdZBkDbXqFUzZ4aWJUuIZ9YXW2JtyarJKPOaoo/isCV85bfuahomWyqHUtmFZ/jLx7WC7TXvGIPbK3cFfxvHNhtk1aCHREKY2xVun0fzJeFlc0PIHcKuiZb07gH1Ysgqy5bhvfRkvFBTKBjwwZYNcQCAK6uutrDY3Jy7AF09jiD+Dauik/6h97HDiYXsFpxmaJ325txgAU2fAbO8xv5ZZ9t14r2J5yIQaD7BVTsXIqHtsqtT6fbjt7JDctskqCIwwPUsB12yAyUR5RRWebkpQPxJqRoJo4DFnMvT7IPQaz PEw6eXIs HHJ6p/o0BSPfow270TfYDHO4L99td7QPw6rRlX6l+Pv07dWO2MHrueblEepvech8zaPAG0ARzOjmMCzesal2aZiwceb/hTwuHZ/n6IpJ/8ARmz9/d/XaTwF8F2okuQTxgQgTX7on59MRtI61Dg3WW6L0buPACAiC5oSZvxmV6KYwnvitMgC+UoRwIPvJs9OI2p+kdJ5DSOVPhAr41W0IctV5lKfBoy58DW7HGRGcKPWqxU0yYhnNcbzrKbg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.128928, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 29, 2024 at 4:33=E2=80=AFPM Nhat Pham wrote= : > > On Wed, Aug 28, 2024 at 3:38=E2=80=AFPM Yosry Ahmed wrote: > > > > On Wed, Aug 28, 2024 at 2:35=E2=80=AFAM Kanchana P Sridhar > > wrote: > > Are you saying that in the "Before" data we end up skipping zswap > > completely because of using mTHPs? > > > > Does it make more sense to turn CONFIG_THP_SWAP in the "Before" data > > to force the mTHPs to be split and for the data to be stored in zswap? > > This would be a more fair Before/After comparison where the memory > > goes to zswap in both cases, but "Before" has to be split because of > > zswap's lack of support for mTHP. I assume most setups relying on > > zswap will be turning CONFIG_THP_SWAP off today anyway, but maybe not. > > Nhat, is this something you can share? > > I think we're enabling it, but we're a zswap heavy shop + THP > allocation is not suuuper reliable until recently with Johannes' > latest (and upcoming) work, so I don't have much data to share :) Interesting. If CONFIG_THP_SWAP is enabled this basically means your zswap utilization keeps going down as your THP utilization goes up. So the swapin cost would go higher. How do you deal with that?