From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01A86C77B73 for ; Thu, 20 Apr 2023 20:20:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35D19900003; Thu, 20 Apr 2023 16:20:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E5F4900002; Thu, 20 Apr 2023 16:20:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 160B4900003; Thu, 20 Apr 2023 16:20:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0418F900002 for ; Thu, 20 Apr 2023 16:20:27 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C6D171C62D3 for ; Thu, 20 Apr 2023 20:20:26 +0000 (UTC) X-FDA: 80702886852.26.BA2D555 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf22.hostedemail.com (Postfix) with ESMTP id 01C30C001C for ; Thu, 20 Apr 2023 20:20:24 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=QAXp3ROb; spf=pass (imf22.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682022025; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gG2Ql85L6iDQ8KDJtvyVB1US8rf766mBBw7kP/giR5M=; b=QpyJCPk7ekAW0OHSJz4bVXm8Q4NIXIGKxCQgVDbSJiCvdu6JtF/5HN8Ge6cOHTy96zoasA /Vq9cc3FmpAeOc57cUGPBhyQfsat4JP49+MSUSlH8oIohJ4wxR6KiEoMvx8yPYMZYXsdDA SDyix0BHuHTK+mDzXNPcmU5R6BFW04E= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=QAXp3ROb; spf=pass (imf22.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682022025; a=rsa-sha256; cv=none; b=C7Hxq2jdtbL9WFhUZb9NWxHT68fabGH5b2DgeywZyAaoHnM1TENo6DlRXBWgWXlJjoh9bO 4L5PfbCxwWWmELR7pAQvJ8dhieUfneW7HedobPo3aYs3ReA8Bs8U2j/7VFhSnu6DjavToP cYvHtVNwEL/EemSdeDa/Yob+Re2ldV0= Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-506bdf29712so6018411a12.0 for ; Thu, 20 Apr 2023 13:20:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682022023; x=1684614023; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gG2Ql85L6iDQ8KDJtvyVB1US8rf766mBBw7kP/giR5M=; b=QAXp3RObgIJpNM6iA+LUaWs2XmoxP0ETyPn/Hb7hsyUsoITvm+q1rB3PzE6Mw/ofni ULxOJ87mYAgAGSCd3rekbSsk8DyQtNXFtFQKX4c/KlTgtFoi+yknLHSR2BFFuZOSunKq vBK7hVVH0rH87rWoaKvGR/8SG3U1jq4nukkkvYzR31hv46lsUWafURYe+lWJOzKqHdYR ZAcEjfCDqzAYgzB/a6n/luU94tpPH/nhhW4mPeWcH3Mz/nBvuqPerlcHlTs5HgcrAnuP vOri0/ZN87/rTD24tM0uo61TQtf23tLNmshMmIQgAi6qQbai3wi9w5y14dyzB74qxq9+ Oyog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682022023; x=1684614023; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gG2Ql85L6iDQ8KDJtvyVB1US8rf766mBBw7kP/giR5M=; b=Ek92sZAYYzvPoMNzvLzg9IEHJl9rBaxKOo8mLxxTtl/cpUdxgq2qDoa5btcS5JZ7SK dDhJzGHeyxUBkr+HdbiSfLxc097dnggaSZomtbUfpLbvLPwXGibAxFko1oMl2Aygy5nS 3yUocG1/awwxcmpMr9DHKDuZzqpwcBuktax5sUhIrqOC1ue+MXcEaaVKu9PSkm4JUjmh jmgIOOsqVKSj+AkeDTG5GFrF27i39hKp2AHam5D6Ax7F5DebJVOHBQhOCOeXpSLoSUSJ ddtI1IfXTJFTPa4bQpv35/BOSa26drqDA0Mi2DiJNBCHe5PwZ3T64OV7iyWcVUmBFi/d Kp8A== X-Gm-Message-State: AAQBX9eTrvqyHQ5lw3CZf1wXGgaPOzWV0x8PON1KAFnluDJJI1RiZ7el SRiHIzixYGQOQglkpJrWDZxf/Jymvv5YiqbMjLXV5Q== X-Google-Smtp-Source: AKy350Zqqjhf63hrvxZCBfDJ+G0AGIpxZ0fOO09uTH99ETeQpYhmD9A0SBuIcV8kXVY7fmQbcwTq+21dl2Cyg9I05mM= X-Received: by 2002:a05:6402:4413:b0:4af:7bdc:188e with SMTP id y19-20020a056402441300b004af7bdc188emr6254738eda.16.1682022023268; Thu, 20 Apr 2023 13:20:23 -0700 (PDT) MIME-Version: 1.0 References: <20230403220337.443510-1-yosryahmed@google.com> <20230403220337.443510-6-yosryahmed@google.com> In-Reply-To: From: Yosry Ahmed Date: Thu, 20 Apr 2023 13:19:46 -0700 Message-ID: Subject: Re: [PATCH mm-unstable RFC 5/5] cgroup: remove cgroup_rstat_flush_atomic() To: Tejun Heo Cc: Shakeel Butt , Alexander Viro , Christian Brauner , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 01C30C001C X-Stat-Signature: qbu1ytduqe93g78qfx8t1187cr4ndra6 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1682022024-704219 X-HE-Meta: U2FsdGVkX1/kXDgtyBIa9C1fB+DQ0qB1ruINL+pdtPX2/tGIe41W/xx8K+DSF9OHB1VmkBvqXQGciQT30GSubTEtHCKjUf8suvVaOI1h9vZX8iKUH3Idc4tbGN2mKCdoBND7/ejQwLlP11ycZShkV10HuY3ORJAQJaH6lEgX4aX39QE/cBFUEt1k1YAUx7JXJ1xMd3IuBIL0j6s0TzTS7JA9h2VWpVtEHWHjQ7EXW4YurqDGkrFsDi/N3yBWcnFJmuW6z4QksOFj4d54uBCn0V4GzS3b9ceILE/h2ZBXwEy7MExduL7yTgQbZKvzeFBzqG4yMqrrXRhjbWe3Q1st/BiEJKTVLgUib3PeVOivRfplLNLOrIpwBF0ZONrzFRGhZg+SP0I0orI2LFZMkJVhx6nG5YSwcHMJ7WA3smk/Rulq3hcjJlSt2ZJFNiqMy6CBUZvO54ZSRCVymgIKyff5Jdf81vFaa50jAtzzDSLsbFPuTlr0/EcPyMaeaGAoNKJ65wyuxfyYqj5+Di2KWboRuOLWLdLzXF12fE6/NuI/CTdeoughzXqKVyrN4twiGwq1dxtw0kVJIIcT0aymTncQRUUWXasWmthUUBqbSrmJwO/r1k/EjxWvBHiT8312V/BCihBFu1EGmjupTo7KQSpWXUqM9uyJBrM/Zedx19XS5IoQt7eqwyCsqY3N8O5ktRw9miBvazxcsJ/ChUovI9zgbulJqwp+uAKJqqnyAMYzaBRM1HuhVtTkNKZWMfAlBzgREdeKFeL+A126zaNzUnuPmzGXJNmiOVE2cDd/yiH8+JaUm64w9fnJOemJwV0Vi/PzOGGpP/DeB9HHpsM31G7UWLoYm82+wdoGBCXADRRcI3unpJdkqPL3T0dzeG7hZQkGhK+nHvBbGT053X5NxKIeuwEH1yrkBI4CvQLNhCDOULmx5U/V6FCjUj17hZFHNkY0XaB4pJnRV729Da/Qx0K ftbV6Gnb C83VFYQauBm3dEmeEWyY6ryHO+EdkQdNV5fz1OGJUaOylZkmBxtsK31ngJ29vHhTxQGQvpmYG8hGIPh3tvmZLV5fbO3hpwludCkd3igfEXXcvvJes0/Q6MjIfmJ5gimnptihWjfvWb1YLK3trTRnsw2Q1rVwd3ocwJ75eV+JnpD0UCwgxs8EtKOjqwrG4DE+yvU+dfbATmLRsV3A4J6jSNzg85iCLurZ03m08uFKIikl/K5qAiw3tzOFpGHniQIvYWzjoQdE6gEX+Xn0DtxAroMUEDDmXQ+SAsiNjgO+wuVJZnaCHWxAa8AbZvSpSJddHJHOoko+EJXSo/abSZfvfh+C4C2a/Wi8XAS814UaBMLIstX0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 20, 2023 at 12:48=E2=80=AFPM Tejun Heo wrote: > > On Thu, Apr 20, 2023 at 12:40:24PM -0700, Shakeel Butt wrote: > > +Tejun > > > > > > On Mon, Apr 3, 2023 at 3:03=E2=80=AFPM Yosry Ahmed wrote: > > > > > > Previous patches removed the only caller of cgroup_rstat_flush_atomic= (). > > > Remove the function and simplify the code. > > > > > > I would say let cgroup maintainers decide this and this patch can be > > decoupled from the series. > > Looks fine to me but yeah please cc me on the whole series from the next > round. Thanks for taking a look, I don't know how I missed CC'ing you on this RFC. If I have to guess, my initial draft did not have this patch, so I did not include you or linux-cgroups, then I added this patch. Sorry for that :) > > > Thanks. > > -- > tejun