From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E533BC27C55 for ; Fri, 7 Jun 2024 23:17:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 728BA6B0096; Fri, 7 Jun 2024 19:17:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D7296B0098; Fri, 7 Jun 2024 19:17:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59E786B009A; Fri, 7 Jun 2024 19:17:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 395256B0096 for ; Fri, 7 Jun 2024 19:17:52 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B3A3D1618D2 for ; Fri, 7 Jun 2024 23:17:51 +0000 (UTC) X-FDA: 82205657142.24.549D274 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf05.hostedemail.com (Postfix) with ESMTP id E2DF210000B for ; Fri, 7 Jun 2024 23:17:49 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=OpxCGigg; spf=pass (imf05.hostedemail.com: domain of yosryahmed@google.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717802270; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MAOu3r5TjNnaMsR0npAw2WjHsVUBpHA2CVLbSqT4c+8=; b=TLQggKifT50cFgWYd+p3BP05VMqidnwW5K3hoT/argpKZ9c3IwGDcLiBK5aZsAT7E7r9D1 QnVsOMsBVSgRJlzX6RQmGVOFSE4BQjXl8F04WReP+a+UkzPZkKRVICuMlz3XVyvcpiTgsc D2+/K8+uG0syFTWXw5S1oe7bfzFd0fM= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=OpxCGigg; spf=pass (imf05.hostedemail.com: domain of yosryahmed@google.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717802270; a=rsa-sha256; cv=none; b=u3O4pXb3FFxxQQsV79zQnTjnWylBvmNVGuTdQEr7R6qwtPtTz2k1ewISzVOCCejtZEeLjP YtqM/Mc9ybNjnhVTp5s6ukpdyQAuU1uILGMY/W47dSm8BRv3GFGfRSe6PrITHzb+0YuVrZ wEz0Oc4kbalvDVJPQnqozOn8hXVNRPc= Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-52b962c4bb6so3853104e87.3 for ; Fri, 07 Jun 2024 16:17:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1717802268; x=1718407068; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=MAOu3r5TjNnaMsR0npAw2WjHsVUBpHA2CVLbSqT4c+8=; b=OpxCGigg2Km01nqdAFadHNNNjZWmoetWowJxI5AqhXrKAiKhrvaZqvtWb+T6DY0/H4 rx2djBYVwp4lnkTuAEUyDHv5CAyjFBj65RSFqZViiS67hY0CeUofSDhCXTNmyEYJzlUT sgqQDe50QUzuye3qh0xKxen2JWzD7hMdu7IMRiqU1WYItPcHQN+kkv2b2ZzplzJpiK9A RRV4KE2tYfsaLqMKenadHQ3pNIJhWumDtoW7CAIIhnS5Y2heZ8TYk7fXCQrkc4wbhmKI //5g3XZPMwN777rFKRQ5t9wLF0vv03R/b+969Iwikh5cmR+LOWWpX3Ehxcux4GoMLHWM DSeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717802268; x=1718407068; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MAOu3r5TjNnaMsR0npAw2WjHsVUBpHA2CVLbSqT4c+8=; b=UOgew1biz8QJQNzNFRz1ORmdXUwmK3BQYW0g76HGuaSHj3H4QQGqmqqOqHAz7/Kg2K 9JGNvstV49Sh1Fnxq7/lj2Fmnuy1JDb7sa7Wl3YcZ12ES0WRsWP94Lg8UTuSB2uqMyih AfN8JQ+tTkANCuGXq9ZRqV9ZwjmcCOmWCG4v59hENOm9kbpGsJA38vYRVVrePlCCJP1k pikDbh1pPropeK375IkriUtyzoqWfzdP0bnRsds4O08+U++WBnnUap5I3HcTWnYYvbEf dC20HNbKYNNP9fleXnWYNPgcsXL3K67jQcY7TNUXhOaP1wV9gMOq00dhnrjg8lTGV3fv SFUg== X-Forwarded-Encrypted: i=1; AJvYcCVjRFnjknxyjI2qx1l/FC4inSB2uff4kcVQGchMu+UZTBPz32JFzUl51FX6XvBQPS1Pu97jMwa8Lk1WVZBM1bTCp0Y= X-Gm-Message-State: AOJu0Yx3RuO/gOZVfvtBEMku1IAMKQNaj62+oqQPTaKmyh0wr4YVo/12 aCnMFpp3rjB6ANLlGUmt2h4F7wdpweyuAAWFgzI0Uusj6Azu0zgiQluB2aM+i/ZW8XLLno4fJ21 txXi8tEye64TYt0yJqUH5QNaTP7lNngDHBB20K38M4sMhgokutIGM X-Google-Smtp-Source: AGHT+IE2hnTLk1weXhgvCaoD9PboDDewAunIdxaM21zkp3VonPAB2Ox/0fQtE9F/UFsPqRJcNElvIXq0CsHgR7+MzZs= X-Received: by 2002:a05:6512:201b:b0:52b:c88e:cec1 with SMTP id 2adb3069b0e04-52bc88ed2d5mr1115634e87.33.1717802268046; Fri, 07 Jun 2024 16:17:48 -0700 (PDT) MIME-Version: 1.0 References: <20240606184818.1566920-1-yosryahmed@google.com> <84d78362-e75c-40c8-b6c2-56d5d5292aa7@redhat.com> <7507d075-9f4d-4a9b-836c-1fbb2fbd2257@redhat.com> <9374758d-9f81-4e4f-8405-1f972234173e@redhat.com> In-Reply-To: From: Yosry Ahmed Date: Fri, 7 Jun 2024 16:17:11 -0700 Message-ID: Subject: Re: [PATCH] mm: zswap: add VM_BUG_ON() if large folio swapin is attempted To: Barry Song <21cnbao@gmail.com> Cc: David Hildenbrand , Andrew Morton , Johannes Weiner , Nhat Pham , Chengming Zhou , Baolin Wang , Chris Li , Ryan Roberts , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: s7wtukmti5xoj4sce1tc1jax16w68rx8 X-Rspamd-Queue-Id: E2DF210000B X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1717802269-869475 X-HE-Meta: U2FsdGVkX1+YiE8d/BFFsEo2TSbBInC383byejnuJtSgqkvg/GbW2m+7WZ1punR6czhRVqgoRHBrnhp5srl0+w0i1j457l2QXX4t/ke8Bl1Dvp4yqJl0MekEYvDmInL6Ta4QpSeLtpXAB5MLiU0PAbZgwVVp+kOIo8p4xZw878G1RMmojIEW/t6dNneJkV0kOFCqKwPb1cAE3VIIVPYsynistIk3buLfG21rGJDEbeexmIWXyUXK34tidPP9zJUai5WBnvVSkcw8je0m1jiBZ8axFIwB57aM5o1YVlSpaI9W7dN+2fxnkYf7TiyMwSSzhOGCuDJETrnmvjFFMSiWLmnsVaAI1Rp2lLZAAhxFdeMzdFhIfVjcUfzuESavY9Qrer2MrlpCyjz3QnLNB4SNSG5Zhhe1qXUsiuMVXGtIAKtsNv5uLwSOc6xPFvTOmaxS+Q1Uu9AuUDMtdwHrgMIyw+SBRqF5VNzzRa/Bn02ERhB6xiOrc8H3E2+QY77MtCJuisgnaq1Zp/MlCgJ0qX5WpmrDOrqsdeIdIImuYg8rOfGkEjXQAs36GPV1c/R8672ioCRhZITiEyM2VgX09Sp+5Wk5kiX6pYXOz7dgMAYBqMqT0jbDC+6eEnlciXlFQ8NL1bLCoQOiHmf5Mj30E41GbQaCRFCGgMljECCle7IeAU3oDyZOn8k0dUfUSt9W9vfDa1WsJQ2ThUC/Sjsy5CARKg0LA8cAVx4zSBsYFRzrFxkPyTToBO2HiNmzjn9dzsKWiLAryyuYcds/TueUqxdrWisbTVtrYvVoMAoUm9JuTmjSw7be04mRWPYObs4AwUmsMZLBXCVzihkmnJ3b5krqGWRVoI9n0//4DCVqaM1Ycid1pZ0/spZeAaW0uy6b4LH76PHiL1vThMpr5UR4VSHszvSz/b5oC8tBFMu/iu+w9mN2iSw9XWfPqv3TiqSuK+uRcLbKtc6zYoHhAC9TLNg XljTDHkx 4IFKDRZ4JmU/irJS1E9Uh2P7C3J9GXq5xmTrCfs+IfWt6kikea+pep7y0YRMgBOeyGpqZKQgJz7kEHccJudW40twbJOTj+2F3+YapqV1OvcjXxKXqKwGMTQ23LbENAV/fQCD8udGuKxK5q2B54l6MHL3cAOtIqrBcxZAckilebQuDRfBGg9MqrWWs87rtj/kuIAdAUuJw/XKfB9Hy+w0JZObQ67tVjiF0nVtSMMyADt/uLiWoYwMJrcrW5dZjaJWGFYLbMpBirU5SmUn5m9oYS5+VrQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: [..] > > One problem is that even if zswap was never enabled, the warning will > > be emitted just if CONFIG_ZSWAP is on. Perhaps we need a variable or > > static key if zswap was "ever" enabled. > > > > Barry, I suspect your is_zswap_enabled() check is deficient for > > similar reasons, zswap could have been enabled before then became > > disabled. > > I don't understand this. if zswap was enabled before but is disabled when > I am loading data, will I get corrupted data before zswap was once enabled? > If not, it seems nothing important. If zswap was enabled and then disabled, some pages may still be in zswap. We do not load the pages from zswap when it is disabled, we just stop storing new pages. So if you just rely in checking whether zswap is enabled at swapin time to decide whether to use large folios, you may end up with a situation where zswap is disabled, yet parts of the large folio you are trying to swapin (or all of it) is in zswap. This is why I think we'll need to track whether zswap was ever enabled instead (or if a page was ever stored). > > Thanks > Barry