From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFA36CEACEA for ; Tue, 1 Oct 2024 17:02:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1ABB32800C8; Tue, 1 Oct 2024 13:02:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13412280068; Tue, 1 Oct 2024 13:02:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F17682800C8; Tue, 1 Oct 2024 13:02:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D281D280068 for ; Tue, 1 Oct 2024 13:02:08 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9605C1C6958 for ; Tue, 1 Oct 2024 17:02:08 +0000 (UTC) X-FDA: 82625651136.23.A8E1117 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf26.hostedemail.com (Postfix) with ESMTP id A1754140019 for ; Tue, 1 Oct 2024 17:02:06 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ofb0pYIl; spf=pass (imf26.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727802087; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5bV3UhRWZD4cI+GXzuTGXGMA1zPWWKRAb8b1c9r2ox4=; b=sI+wbGl+T3Wn7fao08pwZPMn+X2+yf6AzMIzeMyfr/wjxi8j/Y9X7MdtU4e81vn0Z56wn+ GNWObJ6Ytk6ea1nnL1LFUhqlhSYNFF52QXp03noFIpV8c8Rhccs3M8kpkCoUqiCeAQB3CV nj4mTA7JRIC8t8KuKeXCRYT7kS5kqW4= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ofb0pYIl; spf=pass (imf26.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727802087; a=rsa-sha256; cv=none; b=Fo87TOZpvdupbUkD/JkRXFpcMpgaG8BLLSN6erlxCyS1F1GwO+zegaYtjV/LUkfKgKvkOF /HnGJyd3XUDz7S9ybuETOwB3mVwV+8TkOEzpGs6JHc9iQLuKI9Hi9o0Yq0OPMzKpuKJEfa Iuaq/Bt3Bt6uDVptnoqSNg6ymM8aS3I= Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a8a6d1766a7so51411666b.3 for ; Tue, 01 Oct 2024 10:02:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1727802125; x=1728406925; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5bV3UhRWZD4cI+GXzuTGXGMA1zPWWKRAb8b1c9r2ox4=; b=ofb0pYIlr8CjhlsdpgBYrn7TKcOj+GyCwaafCjIvB7Dp8z+aAAVxiFBQQwcf0VxAts OuKLg7HCxwanXpuHWRTcvM7KX4snZ98O+N+OyLBHjawqjYhzcT93XrundU/LzqxQ7YGi afkuKjEuivFRZK4+fUgOSsxTzSd8Yzdie+80oZeqLjYza1lsoeqW25od7C0M9XBYSSCr sCX+5CXJkT0SY90cafVulV+UXLt3FEAOZpTD3XCFyN9DID2GQ56oFXg7HwZbN+9ZWUmV 2LHjuefy//2lgscepcn75UD5RbsHqEKMIC73KUL1CiwJcUel4MgeKcv5uFWSqmJvjzJ9 VUkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727802125; x=1728406925; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5bV3UhRWZD4cI+GXzuTGXGMA1zPWWKRAb8b1c9r2ox4=; b=rhpnOQ51qZuXO2sxKouhAjZZYEYVnH9e2Pn48QCxJSqDgK2HpYcqxTgW25/UgYz6F0 bjbNk32OiIyTmKRiNQyhoTQ1vOHd78hbJna56Kn00AtopDCoJBIcJmjXg5kHI+3HDQrQ /O1maPCP0r0xHas6EGmaeytp28aE2YpRqhD1gyAKbGhEt1wufTppS5bVCvy3QFugqdj6 a/gVw9NV3Xz2jUpSyl30Bj2HmkajqCiBCv7l3p7+kOI1K5f53RL7025It4Lb/iRe+qeX 0+z+fAxhN1y/ejdaNdc3BR8WeKgECtRUoF4LAJ/6YKknUvtmuAfJnRV24tv4eSkHqm0r NLiQ== X-Forwarded-Encrypted: i=1; AJvYcCVFd+Cd3q0w5Clm/rj7jrT5wL2nHGLRJpvWN6xbtJhyX4XYweJEJvFraDTO7DvciQLoDWyCa2uTFg==@kvack.org X-Gm-Message-State: AOJu0Ywm6tRLeFqfRvJYFDVIBcJajjhcdr76Lgt0poz+86gZ2C2JFAEp Yb45P7Ar4e+kidGtjwc0Prfm6rSuuBRqrI6qo6Es/6RblO8ygl0ojAK8rwe0e6cI6Zpao0Y7Tp9 8kVkD1Y/O2lHrugi9AlcLFR0kcGtyG6RdIkcY X-Google-Smtp-Source: AGHT+IH8ThQ51HBLCX/kr6qw8fgHXecD6CswhF1p1ZtPySqavrPgiaXJQWg177FX8jIJod+dIFiSBY0G6QeGBiyidDU= X-Received: by 2002:a17:907:98c:b0:a93:d181:b7fc with SMTP id a640c23a62f3a-a98f836eeaamr21140766b.51.1727802124770; Tue, 01 Oct 2024 10:02:04 -0700 (PDT) MIME-Version: 1.0 References: <20240930221221.6981-1-kanchana.p.sridhar@intel.com> <20240930221221.6981-7-kanchana.p.sridhar@intel.com> In-Reply-To: From: Yosry Ahmed Date: Tue, 1 Oct 2024 10:01:26 -0700 Message-ID: Subject: Re: [PATCH v9 6/7] mm: zswap: Support large folios in zswap_store(). To: "Sridhar, Kanchana P" Cc: "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "hannes@cmpxchg.org" , "nphamcs@gmail.com" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "shakeel.butt@linux.dev" , "ryan.roberts@arm.com" , "Huang, Ying" , "21cnbao@gmail.com" <21cnbao@gmail.com>, "akpm@linux-foundation.org" , "willy@infradead.org" , "Zou, Nanhai" , "Feghali, Wajdi K" , "Gopal, Vinodh" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: d9ragx1p6y6wbwzhw141gnuk1toouwed X-Rspamd-Queue-Id: A1754140019 X-Rspamd-Server: rspam11 X-HE-Tag: 1727802126-381539 X-HE-Meta: U2FsdGVkX196iPDl2IBo46Wv3kkVg4tz2CMscWJjqbIsX0XeKSqaW219yceVXAML/RUKRv7hZw0Zn+Xb6Ck3G8dVS8gz1bvacZQLZNLnjreGeGb9DPftE4UyyYkgczfg6CC1A6eGbQn9/T2XBIDbnux70hN3BliSlq0NgJO/eyc4KxmUq6GSeFtWv7sPfGaKjjhXKHb+L03GXyvhZFyX2giWf4c08UAPsY41usgrMcYncMfwI4q0YwB9gk2aSy5NiN2qn3miCbd4+I+EyyYyGKR5V2T89L/VlvwIkqNqgblGLvaTm+pdFX9JcP5an7MEtFp7fBOrPgClIpF9694FhF+JskWs2AqZzpjqe0OEFsDwIohZoD6x0aSPQLXBFadCP0MByDtINfna9vOT8O/rVtqC5//+DPR0jysXOTyedwZifu8CuvWr3T5wcWHYJ+uhMAvi80LJyxjDhb6dCY571OicWXlrWuES5aCRTmo0o2Ko0l6h027xdzfuU0wkUuyj/cF/yvOFXLELja7y1li5YLSG7MdGvmTyjuik6GUODDEkZGeTRT1UWVmXLkzJtuaVfwRogBjXwulFLV7npmBmHPFg6QOQWwDShTnPK4zSVItwYYerhDISU4TGTYSPXb5i4k4H85XYSNBiZyoTPqNLtfoBTmn/l0MwPsAdX9aYh56i15qeu4jEAYCNVZieYe7CSfsEfv+ZMf4OfPu87jv+dbh+CJccatJ3L2ir4GAFV3jG3Nc4cQNg8ordP7b/7h5JuMEpSCxJZdwQ6/JJjWOo8SYEvbdGDD9S6WP7zJnAnKBzs3GookRmVYIhgi0uWPRBuJs/fmjwEpWDq0CGh9WnLHc0yuRYiSZiKE7VvbCWI+QQAOCY5JISwirLa+S19QlSxXmWu3Ed0h21CsF1qmGZ6C1b1icA5hWZIRG0lNYgMZtQzWSHLThuuAL95dyB2VOGADCZrLiiB3GtL/U/+HM Li/xGDIY mlLm5LYKYP+vqos0y2WA+L3K7bfJtmkEHD7Yv9Q3rAmJ4E8lh+QqmlkC3qrT9QhKzTWfPZ8Q4N8kjvydcW5jT1GDUxWqOTaE5VR+KDmfwjWPvLhBlKBApAsa0exb7GK2AEntOzL7Frxh0z/TY91yzAKMwyZpahlA6MkvgqfkR9eqhOFuWsuQIK38QUn2/glRTbLfVC5CKEmYUarIT9p/AkNDk7qZFOIUUk1+NBghTg6To2ulrExzpb9z9Yl3aNo1CKsabLyqgPHCPd8Rr1hNU/AGI7S0700UG/aKm1YqnHKFg81diJmqMA2rJFQgrJZpyS/fMdK9OgAiS7ALgdUSbTgvTXjrmQDFNRxQAuWGRnjzgwCiCQPYlI+TFirkYnuuBTaO9BpY4EOo2rpXNkKRMr6Fh06khVoMD/COAnkSx9fW/JDshJq2Apa44/ApnR+Vt9dFD33oFE8YES4CWIdoWqW+c7IhTLNIvtFcE8kPKvVb0r/LJs3VUTcc6mEM0BMMI/DCY7nOPXQmKvilFwLDxzNXy7pc4IuSqdx7c7YhbW7Ihr5pNMY4KuczR/va/UxrPQM9OumKsogwBucerNH/jxvbCbRNQEiFzktmZFUGBUOlOfHyvML825MkN1R1rtLovt0D8aFyuqmKX92A2tm7KY2oremgsD2u9DWi8Go0SMDlu4Kw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000348, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 1, 2024 at 9:58=E2=80=AFAM Sridhar, Kanchana P wrote: > > > -----Original Message----- > > From: Yosry Ahmed > > Sent: Monday, September 30, 2024 11:00 PM > > To: Sridhar, Kanchana P > > Cc: linux-kernel@vger.kernel.org; linux-mm@kvack.org; > > hannes@cmpxchg.org; nphamcs@gmail.com; chengming.zhou@linux.dev; > > usamaarif642@gmail.com; shakeel.butt@linux.dev; ryan.roberts@arm.com; > > Huang, Ying ; 21cnbao@gmail.com; akpm@linux- > > foundation.org; willy@infradead.org; Zou, Nanhai = ; > > Feghali, Wajdi K ; Gopal, Vinodh > > > > Subject: Re: [PATCH v9 6/7] mm: zswap: Support large folios in zswap_st= ore(). > > > > [..] > > > > > store_failed: > > > > > zpool_free(entry->pool->zpool, entry->handle); > > > > > -put_pool: > > > > > - zswap_pool_put(entry->pool); > > > > > -freepage: > > > > > +put_pool_objcg: > > > > > + zswap_pool_put(pool); > > > > > + obj_cgroup_put(objcg); > > > > > > > > I think if we reorder the function we can drop these calls, make th= e > > > > comments positioned a bit better, and centralize the entry > > > > initializations. I am also not a fan of passing a semi-initialized > > > > entry to zswap_compress() to get the pool pointer. > > > > > > > > Does the following diff improve things or did I miss something? > > > > > > We shouldn=E2=80=99t be adding the entry to the xarray before initial= izing its pool > > > and objcg, right? Please let me know if I am misunderstanding what yo= u're > > > proposing in the diff. > > > > It should be safe. We already initialize entry->lru after we insert > > the entry in the tree. See the comment above the call to > > zswap_lru_add(). Basically we are protected against concurrent > > stores/loads through the folio lock, and are protected against > > writeback because the entry is not on the LRU yet. > > Thanks for the clarification, Yosry. Since this is a change in the entry > initialization wrt the mainline, is it Ok if this is done in a follow-up = patch? Sure. We can discuss it separately. Do you want me to send a patch or do you intend to?