From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCF7ECD37AA for ; Tue, 3 Sep 2024 17:50:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C7198D01C1; Tue, 3 Sep 2024 13:50:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 550AB8D018A; Tue, 3 Sep 2024 13:50:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 306258D01C1; Tue, 3 Sep 2024 13:50:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 082E08D018A for ; Tue, 3 Sep 2024 13:50:02 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8F5CB140779 for ; Tue, 3 Sep 2024 17:50:01 +0000 (UTC) X-FDA: 82524165402.25.1E8933A Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf21.hostedemail.com (Postfix) with ESMTP id AA9D51C000C for ; Tue, 3 Sep 2024 17:49:59 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=qHwS1l19; spf=pass (imf21.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725385673; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s0G3wSQMAl6e0rRV+V/XUHth+hntN01i+HARZDZUoKo=; b=jA8xhMH03F09mIGrrIWKkNVA5hMpCb1/sM4QN3lb+NahGGk3swFj03h/2C5mXWcp20wzdt +PNVLuE+KdIL8ViI5cf3MytuxOIm7PZ0/CmNVxb8GNdLb5QKYInpK1ezu0f3wEVA0hh5yY elYOU8YHqQGogjzwu5U7FIrcK2oW5N4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=qHwS1l19; spf=pass (imf21.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725385673; a=rsa-sha256; cv=none; b=Djz3fGsWMYkMZV72ZLRVHTSQUMAQ+aeUKCaYqLyftFQpe8cYRL8St8N91ImhSQ6h8GhVqG sqKtu0pEdIUbOU323W59+pZgK9zH7MQb7WtDmSLIFnepX5qP0dZNNQlkyphfTGPwbZzVoE ielLGEPrNuYjnWGc00sneGpefOJH12c= Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a868831216cso661492166b.3 for ; Tue, 03 Sep 2024 10:49:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1725385798; x=1725990598; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=s0G3wSQMAl6e0rRV+V/XUHth+hntN01i+HARZDZUoKo=; b=qHwS1l19Stest3my5U5bC7nAAmjYxE0gvoUhwju1Jsn7YoHs9PrYOAveApP+ZNT0rg 0vTiroQE73UtT8dd7JzUfkdJQkJbiAoymnydThwiS7xghJXLpAQANYJjlinwZx0YGfzN U3CeEzh7QsAjtmQrk/tk1XLRgI+vml7vjbAmhAt7FYjZYKriLfdPM/pbQ3Ma1gBSOHa5 K11n0pFHRyCg3XsNzIiPJEKeq3/ln6hTtZnxTS/Xh/jRFTjsGHFEs6/dGCpA1ug+hdrc r/hiyQt61QSyAr2TFTDiCbvnHFtWbvKBmEqQs7JhKgaZwiuk8k9llblwWS3iwwcOnqlN ul/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725385798; x=1725990598; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s0G3wSQMAl6e0rRV+V/XUHth+hntN01i+HARZDZUoKo=; b=P65Flsmsfu6ONh1YJ6Ddc7+h3EOn14ZdezG3GSVShYnMlAu3j9VAyQfEDJP50aWIU2 q+izWohM2cIUWe6a2uKcgtzsbLjaRwql6NEWFeYO92vkgV+UwdlRDzWNWZlEn3IC8kdu LfAl04i1zXD1uXjNQoAyTpGivxZoxAm5QKnUble8RFfm8CHeBGTRSLHL1iTsMm2Olbu7 yx6A+vtHrI44Crz+mTn0pryuybr8qV4DIuiDcrq9iYdz0YvJ4EVAcd2DAWt+EM26QBLT 7Ysz0vTjCeVgeE5RmSCUz6+4NPQSpbMw79pglzB5E0W4UmGyqf9LFfR6LHyC9Zs4VzW6 xrNw== X-Forwarded-Encrypted: i=1; AJvYcCUQmw3fM0gwxo+HHjOiasjGIEYAVMz04PW72NzhIhD/OCpGdvkMhDo5ErTdqrUNB1iboA5IxGq4oA==@kvack.org X-Gm-Message-State: AOJu0YyB7NHJL+n05GMSF6VQzv4tBZ6mKTLaxHtJzQ3phoJ4ZxKM2N+k 45YNXGuqWI39MCG/Xjk1fedO5VsiK2IY9noQo+t7mjzWhINijEo8o1NpvbA2UfH0g/Dj6pQfQSC kiLBfFZYAKV3VXEpYvwJNPL7HRKW3G9IC3DSP X-Google-Smtp-Source: AGHT+IFofB3wIffAK9PeJljfYupTAr8ZvLUp9muEpmKLRv5Pk0pqIHrN1ItxyWws7Vw7+2fkN1xum+X0r6RRrMeLmUk= X-Received: by 2002:a17:906:fe44:b0:a86:96d1:d1b with SMTP id a640c23a62f3a-a89b94b40fcmr924680766b.16.1725385797168; Tue, 03 Sep 2024 10:49:57 -0700 (PDT) MIME-Version: 1.0 References: <6f65e3a6-5f1a-4fda-b406-17598f4a72d5@leemhuis.info> <02D2DA66-4A91-4033-8B98-ED25FC2E0CD6@gmail.com> <3D1B8F1F-2C41-4CCD-A5D7-41CF412F99DE@gmail.com> <277CDE7C-7ED8-4840-9C30-533C9327B028@gmail.com> In-Reply-To: From: Yosry Ahmed Date: Tue, 3 Sep 2024 10:49:19 -0700 Message-ID: Subject: Re: [regression] oops on heavy compilations ("kernel BUG at mm/zswap.c:1005!" and "Oops: invalid opcode: 0000") To: Piotr Oniszczuk Cc: Pedro Falcato , Nhat Pham , Matthew Wilcox , Linux regressions mailing list , LKML , Johannes Weiner , Linux-MM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: AA9D51C000C X-Stat-Signature: xocc8wrgh1tkgqgnwp3dhw4mzdowee6b X-Rspam-User: X-HE-Tag: 1725385799-631113 X-HE-Meta: U2FsdGVkX1/h0GwlSbLqFCWraIwq3EDbA/nt666DcAXiUDfITeGRwc4SV82WUZDaup8v3J+6lgeWJw8st7PT0yOm2iN0n4vC3mSPV/bqd28oOdmnhxjGfOYE8syTbZWDD1dlw1suJB1rMmbBQfPmkQ5Ou7NThgGl4+fd97v2Qs4dDuxdx3Jv/LjCzhJrfx3mXIrAy/SgcdZxoL9aQgbQAQ77ipOHw17cTm9D+z7ewiMI4/ckOiNxSQ01KMEUU4gEoMeDiC4JbbEIT6LS8k6dBnra2RtLbJWVv5GO9ZTx9oPZQPJ2wii87ZYMDg7nQSDVUDzEwCajWzepC1RhERK4/CYc4yA9huZAXIe1NUQrHQ4dCPvwmAliF93t8x3q1j0+Is1zDqH78L9UM88Aw/vEzFSNlNe1f4QfKfaoLWIetEgxdb4lPzFGxojsIKUW7otSooOpl7O+w0lYCXF7Il3ewhgBKmRHW+hbkmy3QM6NxYeLCZFqxt5+5KRkFryZsC4gVkdrGqEmuqqGEB0yn4AfkY+92zcbNASb8oSlFWIfEzr2YpTBvz5PWz72h7IiHxCkDSzJEvHld2dtPHECuAcPtL+OK6tyGQHv01ySbikRSxVpJPAz+DAXjuShpTuD0em+ZnzcvxQ8XzCMAbxDlqfMmavwp58ez28TEX71BgmeJntQTiq7CsO2TQG3D5La/esKFMelepsfr1TbDCS0WbTg+darVh90vL9KVfo6U20hqk7+iK+kk+BS/+BH4fmWrJhqh7BEIGo4DdMWNXpF3rhG0dn++XaDr5AX8T0NhSDH20n0vqBwuIFRP29LjLe2mWXc8l3IulzE+tG38ihAxa0/GDcgubmBeU1T2B2M/FMHbVlzq56/PnQXi1VTjMeEcGnzLQoA12bljtuVj9151u3bd4F9lHaOOj4HA3td3lrvQHheJlUJYtYPIzMLbPIK9H/lcLxs90Q3b3aH/D8k8g/ l0AQLY/l BbEfJ+YGtttJFG3whmy2IqDNDYopyXAzurcTPeLXC7p/mHgbIqQDnGiRu3Zx7JjPiNvRwQWmjYG6oRFjpU0soiHKt/tcOfC/c6Iu86QrueVXANWtT5LeCFD5KQvVhGR2+4MB4XC+JahHm9JTL2tIQbIT78YCYS2EvOUxPLE8VJDK6ek1vB1nKoVZ5Nn8NUvblHB+msOaw7daXakrHEiAfoPOZqK1Kt4fvYQPRool8+/66vBHX480SzgkwtrhvQ4fOsk8G+3fQAvHRdx5d0TSzvs2AKdtTa/mf52WmvLDwxtT44Fdc0WFdJhxbvLKU2RD1ufl3CdwVGej7S/nmfc7ycIiL8W0cwrqJ2L/WdW3HXZW4em3xAVE3DprkJlTEjV+qacD9X1aE+sQHX1I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.011300, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 2, 2024 at 1:58=E2=80=AFAM Piotr Oniszczuk wrote: > > > > > Wiadomo=C5=9B=C4=87 napisana przez Yosry Ahmed = w dniu 31.08.2024, o godz. 19:23: > > > > On Sat, Aug 31, 2024 at 2:41=E2=80=AFAM Piotr Oniszczuk > > wrote: > >> > >> > >> > >>> Wiadomo=C5=9B=C4=87 napisana przez Yosry Ahmed w dniu 29.08.2024, o godz. 23:54: > >>> > >>> I also noticed that you are using z3fold as the zpool. Is the problem > >>> reproducible with zsmalloc? I wouldn't be surprised if there's a > >>> z3fold bug somewhere. > >>> > >> > >> Hmm - yesterday i recompiled 6.9.12 with zsmalloc and =E2=80=A6. after= 16h of continuous tests I can=E2=80=99t reproduce issue. > >> With zsmalloc 6.9.12 looks to me like stable. > > > > Interesting, and a little bit what I hoped for tbh. > > :-) > > I tested mainline 6.10.7 with 26h test and also it is stable with zsmallo= c > > > > >> > >> With this - what will be your advice to move forward? > > > > Well, it's possible that some zswap change was not fully compatible > > with z3fold, or surfaced a dormant bug in z3fold. Either way, my > > recommendation is to use zsmalloc. > > I have been trying to deprecate > > IMHO - isn=E2=80=99t bug in this report + difficulties to reproduce->fix = enough to depreciate z3fold? I would say this bug report is yet another reason why we should deprecate i= t. > > > z3fold, and honestly you are the only person I have seen use z3fold in > > a while -- which is probably why no one else reported such a problem. > > Well - in fact this is ArchLinux - not me. > I=E2=80=99m using Arch and kernel in builder machine with ArchLinux confi= g + packaging According to [1], zsmalloc should be the default allocator for zswap on ArchLinux. Anyway, I initially thought that no one was using z3fold and it was bitrot, but apparently some people are using it and it's actively harming them. [1]https://wiki.archlinux.org/title/Zswap > > > > >> Is there any possibility/way to avoid bisecting? (due limited time fro= m my side) > > > > So unless you have a reason to specifically use z3fold or avoid > > zsmalloc, please use zsmalloc. It should be better for you anyway. I > > I see benefits already: on very memory demanding qtwebkit compile: > z3fold: swap frequently gets 6..8G from 16G available > zsmalloc: can=E2=80=99t see more than 1..2G > > > doubt that you (or anyone) wants to spend time debugging a z3fold > > problem :) > > lets depreciate it! I tried deprecating it before [2] and performed some analysis [3], but there was some.. resistance. Maybe I will try again and use this bug report as yet another argument for deprecating z3fold :) [2] https://lore.kernel.org/linux-mm/20240112193103.3798287-1-yosryahmed@go= ogle.com/ [3] https://lore.kernel.org/lkml/CAJD7tkbRF6od-2x_L8-A1QL3=3D2Ww13sCj4S3i4b= NndqF+3+_Vg@mail.gmail.com/