From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 251B9C761AF for ; Thu, 30 Mar 2023 07:55:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE76A6B0075; Thu, 30 Mar 2023 03:55:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B97FD6B007B; Thu, 30 Mar 2023 03:55:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A61106B007D; Thu, 30 Mar 2023 03:55:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 98A026B0075 for ; Thu, 30 Mar 2023 03:55:57 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6C86380F80 for ; Thu, 30 Mar 2023 07:55:57 +0000 (UTC) X-FDA: 80624805954.12.74D38F0 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf02.hostedemail.com (Postfix) with ESMTP id 8C1AD80020 for ; Thu, 30 Mar 2023 07:55:55 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ZD9aj6n0; spf=pass (imf02.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680162955; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=anbj3k8bVreIFvoy5ezWKZvlLhuV6pERZy1Bnx+kNns=; b=U5gU+RGXpG1Gq5Jtk3TQ7Wrn3FyvXOhld3SR554IHsMRzAJQt7WAPQwecXDvVKUEfw86TQ dsorz2E/kPoWBDVt2QgqI6gAKYDzT/3XL7DlNAfo2CPOtCPXLAtYapOSqzaeZHoWPWQakO lyECFS6AwU3DeRLPmCJc17H7tTyx9Jg= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ZD9aj6n0; spf=pass (imf02.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680162955; a=rsa-sha256; cv=none; b=1NA6RUHcuRpR5thJVU8cpH/o9hiweHxu8KJa9qX4omFMqPtTMFctpu5a+XLXZE9OOwGaKn ZodBa3odAKlmgCwfM9TcGNNHvYfa+Gwms2JBbeB59zFGqb8IFImyzHJTovWicAyhHcK9ch NsHZayK/1ZYSCFTeV0D/nx+Qy/KvqfY= Received: by mail-ed1-f54.google.com with SMTP id ew6so73022970edb.7 for ; Thu, 30 Mar 2023 00:55:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1680162954; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=anbj3k8bVreIFvoy5ezWKZvlLhuV6pERZy1Bnx+kNns=; b=ZD9aj6n0GX26RjIgVcV8XWHXeXxhiTySnXtfLlIh2Y4ULsYer620/o/Gxai5NDEyx0 U9cLhrKkIyrcXCb9H0C1LsSrI3aYqgf3GO6P4vMGibxu+NJs5rV7tQbNe7/BuzZ9ngD4 QlTJGq/55WJCvX0baHxwlbOU546xXFXX3rhwhxfTlPe1DtgL+SZFj+3v/M/zynT9IjDn ZyadAB66teMDMbs9xKwieRC4GEnlOFheMYpz1xGF7yvvoKjAofsoTZMoVDKAnSS6/+pv n2YA0BsqSmXP4EqjlRt/DgekBF6qWk4ejPD+mZWis8RRK9kN76WGkT00+z0dkPShQagp 7beQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680162954; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=anbj3k8bVreIFvoy5ezWKZvlLhuV6pERZy1Bnx+kNns=; b=MaIwSm0Rh/SA34s1Y46sL2+S/ZA5Y+3MzBZKPzEKXgyAdPDcgS27lkB1PUjWXvWyA9 5gv2szlMIgHy2vn/Lmb9ExyK0hQ6nZL9ld/kXe7tuufpxIOC8Nx4cWd9Vgp/NbBKt3NR eUJ1d7f3j0klABozuwcRQXTfilPnsyss11aM3FbpLVUAMvLtbl//Emp0nsfLb13j92/t AwvpVHU2s75PB/qviIN8PtQf+UppEm135P8/ku/i4BIGgnh5cZObPK7Pk1bT43vZxWfC dySNu7qzysxhvqE/KCIv3rNzHK7YWbXqNBUELvP/OZAJ4qbgKAwZNp6zBzrzNYzm3DPA ADvw== X-Gm-Message-State: AAQBX9c0UdFBJMx38kNcJdH0dv0xKj9Xa59pk+TFuUF03dO++2UG6/Rw GAMvg57qYG82ZXtbuB2CiXuWcRq6Nj1CPwy67ewcNg== X-Google-Smtp-Source: AKy350ZKBVchKo8yL5qnCRGOKj6HMXymGhCHv0sbs5xG5akH53sSrKAZcQmbeW6Sz+oAWJWB2Er2VE8WUpb+CRjLT3s= X-Received: by 2002:a17:906:eec7:b0:93e:186f:ea0d with SMTP id wu7-20020a170906eec700b0093e186fea0dmr10952473ejb.15.1680162953989; Thu, 30 Mar 2023 00:55:53 -0700 (PDT) MIME-Version: 1.0 References: <20230328221644.803272-1-yosryahmed@google.com> <20230328221644.803272-8-yosryahmed@google.com> In-Reply-To: From: Yosry Ahmed Date: Thu, 30 Mar 2023 00:55:17 -0700 Message-ID: Subject: Re: [PATCH v2 7/9] workingset: memcg: sleep when flushing stats in workingset_refault() To: Michal Hocko Cc: Tejun Heo , Josef Bacik , Jens Axboe , Zefan Li , Johannes Weiner , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Vasily Averin , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 8C1AD80020 X-Stat-Signature: a4d8yy534maayowaf4u6go3bhnx87e7d X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1680162955-946983 X-HE-Meta: U2FsdGVkX1+91hg54Tary2Blsgy5X5CkkH0zWTLrkXFGMLARtAPfazCqLjhklcet9OY4LiWlPijPd9/gLvebUc6wSTUITojsMxBJ17Vg7ObwJtlGA+e7eCW4mRWMOQH2qEKQeV/a3voOi53MQNlF3ADGJdUNom8g3yojoZGlnjWP1Q6qzUhoYo1fMZLl7vveqCZEviia0kmc1c8oYggJ36uaFjxU2GdfsoI16mw8sUD1Fh2pwJ97yqjvFZRdT5g24XT6vpCu0GSKmaCVc0KlJiNYhn/Cwa0uMBjAPn4DI/hn5LYYkLnveX+DUEKYYle18/tdHYX020OqX07RoulJBl2HDZOlyfPSNY9mJpIFxIRi93m872mJbhgqRPRhYHdMJ7pPCCJfmhVfUE7+uxD6nsJuj7eQGFfPgeKqBvuaeW+cqiL4LVzlFqYEThqjrtXPZvmAhYB0nRY4yNhLITDRgsEVnQF8P3FAzYcSFoCAwkUikUAUKE+0X1SzF+MkiVNjJgVIU1U3fmB1xDhGdjejlFmYnjgHSCMlSUlh2Cu8W6CC1suCxB+zby04+pbySFNmO7FkQrlv3aYa1l10md6b0NMbKIkIBkDNX4pbhv+B7BBnRQup9mcky3VvOjy/3JHKi44Mm81rxBSSyMjkM24tWKLnKxnxSn3XxUTo26XN4ZZC/RDXdusb7TeWSz3kmGLYCZfSq/dtdFiFEZrYGe0iPC/AE0VIqn3/Cdsgr9bAYYgiTN+LHWjQoqJAM20x6TivkZWX9tnLT1BBc5MrB30WKJnHgLYtRC97dG6ZuQjuiAsZkjerGqBhiRpkJp0I4tbO+i6rNeVQHc9B5f1HmJURngUHlaV7m3EwYd054ba8tkNw1ffF9XQ9jnS1cjfKUaBZUX7KSUaRAIAVjNgJCkdIeQ8t0SWRzHB4N1RQ0JHG/ddlzrjbgf3P2gKs1vtCrfOQkLrICxqdEDJAPemDd4R NUsVtB+g u9V/E/yY5MSqsOk7GOU/IY0oRkcpnXTgX92ETKDvFhvz5x/hi5vJ7yl7c8MqU2ggqFcmDFGY3rygS1Nk6Cd+QNsPXwlc2d3c9826hoWQVh+DgJnCcdyVTqT4XsL3XM4raEQu3NP+O9aSL0pAOXTpyHlBg380gK0BdFnDrwplFiTsUpEcxD2QCRItH+XZttxgIPcPCEGg31V7p4vQj2KS7R9/mtrnJm1DkEfktfbnlZdFyUtVl5VS2BbpSUwoMDVDXdWhuTaa+ECTQwswF/LL4O7uPj2L2m6U8gSSxEoEhsY/bzDXquK4DV6he/P/iHWZtEJnP+O/cl4h+dLQz1YQh1etGqcyw8kPbqOTC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 30, 2023 at 12:50=E2=80=AFAM Michal Hocko wro= te: > > On Thu 30-03-23 00:42:36, Yosry Ahmed wrote: > > On Thu, Mar 30, 2023 at 12:39=E2=80=AFAM Michal Hocko = wrote: > > > > > > On Tue 28-03-23 22:16:42, Yosry Ahmed wrote: > > > > In workingset_refault(), we call > > > > mem_cgroup_flush_stats_atomic_ratelimited() to flush stats within a= n > > > > RCU read section and with sleeping disallowed. Move the call above > > > > the RCU read section and allow sleeping to avoid unnecessarily > > > > performing a lot of work without sleeping. > > > > > > Could you say few words why the flushing is done before counters are > > > updated rather than after (the RCU section)? > > > > It's not about the counters that are updated, it's about the counters > > that we read. Stats readers do a flush first to read accurate stats. > > We flush before a read, not after an update. > > Right you are, my bad I have misread the intention here. > > Acked-by: Michal Hocko Thanks! > > -- > Michal Hocko > SUSE Labs