From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 371A0C4167B for ; Tue, 5 Dec 2023 18:22:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B80676B0081; Tue, 5 Dec 2023 13:22:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B30AD6B0083; Tue, 5 Dec 2023 13:22:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F9376B0085; Tue, 5 Dec 2023 13:22:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8EA3C6B0081 for ; Tue, 5 Dec 2023 13:22:32 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 647DB4021E for ; Tue, 5 Dec 2023 18:22:32 +0000 (UTC) X-FDA: 81533584944.10.7C3279D Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf29.hostedemail.com (Postfix) with ESMTP id 995AE120018 for ; Tue, 5 Dec 2023 18:22:30 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=0mgXd95J; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701800550; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zmg48ucaNtz1eYQ0lcHiyMSvr8VMzgFNPLFgYJsB9ug=; b=deeWDmhUO4mSCqFoX+tx7MVdQ0TiLPiQQCT0pjh2e/+Wi4PwkHSBXcaENQFwKUuzL0xVGj v3AbEWvqrOIRmVvGQBdJdYdH0egA3v98liD3L6pJnFnM6dDivX0FzqIjnClTYb3rE+GH99 CB7VKmrM4TSKuRlOuprh82/RE5/pJnM= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=0mgXd95J; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701800550; a=rsa-sha256; cv=none; b=ZX4gPU5i/f6N95qQZZROH390kv58G6xz4VdRJ7z1tgNz6trOEohB8AgsgS+A16K//R+TB7 bNiBO3w7EA8D2lpwDg8DldCPNamdnDBKE2N1bf8d1yucgDubMUTYfg9xRwJN1jKS2NP3zl fmLL0xTTm2R8EdtV8PBvT+jSKHWu0DQ= Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-54c7744a93fso4661698a12.2 for ; Tue, 05 Dec 2023 10:22:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701800549; x=1702405349; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zmg48ucaNtz1eYQ0lcHiyMSvr8VMzgFNPLFgYJsB9ug=; b=0mgXd95JpB6oRR7Luraqeg1NiT8xz7CLBqWsHpAsP+JEJmzFdcWL5pr0II8rWrLJxf 1KeoWTDKg4VbNWDyrK2NE35zOsJFDWIUmi80d8xYuSIY0/JAHtxUL8xayXELq0tbyjfM GcQqpViA3PmLz0ZcsLTxRlZPfRjfOJPh1UQ8Oqf4koYyBW3V8xbSi/c3UO/69WofH8Sq 56iVX5ZrWDv6thhXP14XgRJmoI/niDJUJgmoxCdYjwNAF83b+DT1a8iCUrka8ebgoIai GjTOn7yDWotCcwtW6jTeE10Lbbw8ftrG6Wq99Vu/+497vS0MAu0Eam4eNpjjqgMgJbHy KHAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701800549; x=1702405349; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zmg48ucaNtz1eYQ0lcHiyMSvr8VMzgFNPLFgYJsB9ug=; b=mpQBvPFjN3b3Qli3PtsxiEWDotwOF5gAfYIBBKYop1b+88L5V8lHVC08iU87W19AlH ky06H2I3BKnqlxQXU79sTrddcwx5mVcwNDM9IMecaqP9vWzexU/AsyGFaX1g5wfKFScu RnNbRbLRwoFs4R5MXiLvG42iUWoaD2OGTmCbMliCjS/ZE9mTnJ8gcAQDb+PI68ZNI1ML 74f5VERNSyQDpHEWXto55owgB84UjY0kvKPUqfu9J7PHkMvkz3tpGzdSeBZZ7UdMqMMT 6Rq64NvB8kIAR7vFEFSAE2/w/EMlY0l1PqR+/NoQMk4ngzJTw3alPOVVF9N/fAKIm7fe OmQg== X-Gm-Message-State: AOJu0Yy7D351BizUsMUxu1Soo3Bh0Wgqwa+3koc4DRr0OXTy7AZz+5Du AokT9TJUx/aYlXPi7E3j9Hs0+YXWPxPWLkIpZy/WTQ== X-Google-Smtp-Source: AGHT+IFxluMz9sMmuxSFOhQkmwPCAcZ5/u8Ab6p6UNrzKjlnMibiuPAGPqvvqV6rtEaQ2cNgW+y+zDH5NzMnbiRMc44= X-Received: by 2002:a17:906:7:b0:a1a:c8fc:2e2b with SMTP id 7-20020a170906000700b00a1ac8fc2e2bmr2763817eja.132.1701800548623; Tue, 05 Dec 2023 10:22:28 -0800 (PST) MIME-Version: 1.0 References: <20231130194023.4102148-1-nphamcs@gmail.com> <20231130194023.4102148-5-nphamcs@gmail.com> In-Reply-To: <20231130194023.4102148-5-nphamcs@gmail.com> From: Yosry Ahmed Date: Tue, 5 Dec 2023 10:21:52 -0800 Message-ID: Subject: Re: [PATCH v8 4/6] mm: memcg: add per-memcg zswap writeback stat To: Nhat Pham Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, cerasuolodomenico@gmail.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, chrisl@kernel.org, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, shuah@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 995AE120018 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: qdnpcgggem3hczeor1kjpjmc9ums4dg5 X-HE-Tag: 1701800550-105927 X-HE-Meta: U2FsdGVkX1/brccKf8Qy5Kd5EnlyP4YeFkJIzYlA7nT6uKhxudq+7jn//v1z74Rm8iqraFZx4WxqwAGh10vpTT2gq2ObQj/Xo/BhmasVgLIuZCYGadqz4oMqD9t69H9L2C1/aHlnJEViYp8tt/oC3dW5nmJrSsq0sqgErqyTv/7IY2xNBLbM6gHEm+L1Rs4tjIi8cSuvarEMrgNzpg2zn3DrE+15TWOTJ6XXji2eDJkp2m+GYO0wmLh0OmFXXsbCZP6KxFcF9OVCQvQzZRQCvXtUOCj3obg1TCL38IBsO53+DPS7rcyHB/iWUFvWJf5EpWfBVjddJ2IAWS6rA++LlvQ7YLBPCJspnwGK6net13SV1UFsWcnieGb2biABnNpaXmhUrokS8StEso+Tff+nKm0NkFv6ILvpGV6Qz2t5ZLGMDEOEAwesZ6fCosfpS7NWVRFKrU+wrrdIYstTzRgxIlsRqpGGW2+e8G3IwBCcc1yzBxbqbZ8oOvvOSYpnXBNXLI4YAeSWqBqMzMJCLz//guXBaReLXH6cN2/Qq3jGfrkKI+v/RGFdGy5wTqfoPQBnZm+/wMOuUdTmp4JmFCs+fA5M3WLHCdj4o6e7KoBcVMTrZMzZ2oV2djVTlovXR3C1uWfFaECSo+fxuTDKpw48L/RA8rQjZTx7TSnjR606bhw1xWvwl86bI1MhpGjl0yOUZvGTs66ZS77Ta2glpydMYqKRBAeYpgG3eSQYT2X0PjdfTIwpr32CV4OluVmsuvWP7zd22B4kDfRh6GHWKHxd/t0q5iH2CDCmADJNPgIUcZBVRFGlGg/c8oGTvowswf8az3E7apzQd2t4evV8fQGfF1YodY9f5tVPqkiNOv+ga/tWzEJmfEoJ36lbVczqZWLAbBPM+bDoRB56qOvSL0A7Cnx0pZ5ROoiaQ/WSg8COIiWphLT5+uX6WcVV1y/rTnLdyyBu9XxmBMMW5SYChAN DN5jJiMo Of3Wj467tEcSdpkc+WyWBjklCZNV4IdcF2SlNEOGceJmdxI8F9ObX89vIOgRzicnFZ2WpHNMBscJtRsohpch8kVX9K+BWmvsy+pkLJvnDEYgkdKRcUbZWedFLYuzeaTNlWeyC4C8KHgaWUR1FWv/g4XgAPtOoR29wt1OnHbxi4QdOP2GF0amxWz8a3UdB8BSe5zWn+GyHgmitc312hAKM/E0l1V7gpDCJTwjBaQs4Cjh4otCqWWmK7CP+wn62tbhViIwtT8D5ZLHhIuuayWzVIhc8NdpvL0FpaxlJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 30, 2023 at 11:40=E2=80=AFAM Nhat Pham wrot= e: > > From: Domenico Cerasuolo > > Since zswap now writes back pages from memcg-specific LRUs, we now need a > new stat to show writebacks count for each memcg. > > Suggested-by: Nhat Pham > Signed-off-by: Domenico Cerasuolo > Signed-off-by: Nhat Pham > --- > include/linux/vm_event_item.h | 1 + > mm/memcontrol.c | 1 + > mm/vmstat.c | 1 + > mm/zswap.c | 4 ++++ > 4 files changed, 7 insertions(+) > > diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.= h > index d1b847502f09..f4569ad98edf 100644 > --- a/include/linux/vm_event_item.h > +++ b/include/linux/vm_event_item.h > @@ -142,6 +142,7 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT= , > #ifdef CONFIG_ZSWAP > ZSWPIN, > ZSWPOUT, > + ZSWP_WB, I think you dismissed Johannes's comment from v7 about ZSWPWB and "zswpwb" being more consistent with the existing events. > #endif > #ifdef CONFIG_X86 > DIRECT_MAP_LEVEL2_SPLIT, > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 792ca21c5815..21d79249c8b4 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -703,6 +703,7 @@ static const unsigned int memcg_vm_event_stat[] =3D { > #if defined(CONFIG_MEMCG_KMEM) && defined(CONFIG_ZSWAP) > ZSWPIN, > ZSWPOUT, > + ZSWP_WB, > #endif > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > THP_FAULT_ALLOC, > diff --git a/mm/vmstat.c b/mm/vmstat.c > index afa5a38fcc9c..2249f85e4a87 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -1401,6 +1401,7 @@ const char * const vmstat_text[] =3D { > #ifdef CONFIG_ZSWAP > "zswpin", > "zswpout", > + "zswp_wb", > #endif > #ifdef CONFIG_X86 > "direct_map_level2_splits", > diff --git a/mm/zswap.c b/mm/zswap.c > index f323e45cbdc7..49b79393e472 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -760,6 +760,10 @@ static enum lru_status shrink_memcg_cb(struct list_h= ead *item, struct list_lru_o > } > zswap_written_back_pages++; > > + if (entry->objcg) > + count_objcg_event(entry->objcg, ZSWP_WB); > + > + count_vm_event(ZSWP_WB); > /* > * Writeback started successfully, the page now belongs to the > * swapcache. Drop the entry from zswap - unless invalidate alrea= dy > -- > 2.34.1