From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 037FAC4321E for ; Sat, 3 Dec 2022 00:57:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41B046B0071; Fri, 2 Dec 2022 19:57:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CB556B0072; Fri, 2 Dec 2022 19:57:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 293126B0074; Fri, 2 Dec 2022 19:57:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 181A66B0071 for ; Fri, 2 Dec 2022 19:57:14 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D54BD1C2470 for ; Sat, 3 Dec 2022 00:57:13 +0000 (UTC) X-FDA: 80199181146.08.53296B1 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) by imf03.hostedemail.com (Postfix) with ESMTP id 8509F2000A for ; Sat, 3 Dec 2022 00:57:13 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=TLQIPa6g; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf03.hostedemail.com: domain of yosryahmed@google.com designates 209.85.219.52 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670029033; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DPjZ7mvL7nYnQckkbN4QRAK9DHc9/tMCEO18HbgrivA=; b=o+O4Fcla8EXr2560b6z6OMGvdzGPWJKA+RfQWp3Xgp0nhtyB9ElXgkUrQlXRjGKebPtBTS 8K8vRfMP48eVxr6TnQCrOy7Ax5Mq753W/Y1jEcBNIxd/Y32boWjyn5kG9T0Vx1kRZ9IdmI dnj+vbt2uon6Pyv9zVfc5Vt/uK5JsJE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=TLQIPa6g; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf03.hostedemail.com: domain of yosryahmed@google.com designates 209.85.219.52 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670029033; a=rsa-sha256; cv=none; b=u6R968C8JLTOxVfLzxhYroAkdxW534xST6ET4PM5X3PfTXyl4SjCH1gzR/J2feb3S9q6Xf Figj1nXehRlj9MQwow3OY/ERrCtBqTRKKeLTqM7NX/q8MxQjYUK/5f4ZuTkfPkqaBHvlIn rmLLINhKT3HJ5fAdEF6UfBGopOWJn0s= Received: by mail-qv1-f52.google.com with SMTP id s14so4510102qvo.11 for ; Fri, 02 Dec 2022 16:57:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=DPjZ7mvL7nYnQckkbN4QRAK9DHc9/tMCEO18HbgrivA=; b=TLQIPa6gXHX7UTknaOw9/ETbs+uVF1fmEX74fdi9pMYVGiGbTNTYzeRZWh3UVan/A5 pgdygh7OpAFfNfU10yhfPrHmD1RPbAHkH571Ih/cObNYEwvWz4MfiIzl3RIhPhuVNRWn Akv7MU3BSaPnJoowJnA5vNdzOyYKKugnxnxmH++c0xFDIis6hURGi68K3zljnG2ylZS2 FpBG1mEk6kbCq1bqwDv1XZDHvseqr0RdUee1wWlmpFiSR0CfuZ1k9HkOB/9rHqQmY9Lc RKtzIiGlEPW68kLDLYfyiP0IcEdtwHWB7Ge9weEkCT2wr5yOO/MMZCSk+P+6nhIz7DzI vA+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DPjZ7mvL7nYnQckkbN4QRAK9DHc9/tMCEO18HbgrivA=; b=xL5xSQcFZcTHyq7lBQelkEbDmjXlHDWZcaf+K5KL3/B8hPo+1RIcZJV5V23Xln7vFe zR3/1Bvn5opkhynro74jIZIT6qp2EbUCr1R5M+SgbplAcueFZSHXmDxDP0o8hSIeSBB+ hsheGrRJlnnyobmJ4R8QBkVmG458bd5zKLqt5UFrAeqUsPPMGb9wkfw1ezCvONl3LLXo sFd3cpNGsFJdpdYJIWRUirWFgUNzKZTMZI3lNEQdLbXOe3JAQxY4XNmARpJEBxx8OuVE bHY0HUiRvbdKlZGw8wyqz3J2V2xVvwYrPjGW815+jbLEsA/mdCSpi+pRcBgs9MQouGo9 nfNA== X-Gm-Message-State: ANoB5pldK0zlTpH/NrQII4GL+aAyp9B685OB3Gqtypun6ZNzlffu019P TW+bXQyYEdwWY4PIecBB0TP7/mQ66xRc7fZ4FH9kEA== X-Google-Smtp-Source: AA0mqf6uJI6YE7HdaDtFCa10eglITVg/eCmiSOHcJInJThU2rKq0k3g6nuhC6zn7h9TQ+B2i+wMscC7SVNDwWkFOTU8= X-Received: by 2002:a05:6214:3506:b0:4c6:b483:dbae with SMTP id nk6-20020a056214350600b004c6b483dbaemr50825011qvb.79.1670029032734; Fri, 02 Dec 2022 16:57:12 -0800 (PST) MIME-Version: 1.0 References: <20221202031512.1365483-1-yosryahmed@google.com> <20221202031512.1365483-2-yosryahmed@google.com> <20221202163527.a72646c9d42f3678b20dac7b@linux-foundation.org> <20221202165027.8d0761724f30f6701a9a5da0@linux-foundation.org> In-Reply-To: <20221202165027.8d0761724f30f6701a9a5da0@linux-foundation.org> From: Yosry Ahmed Date: Fri, 2 Dec 2022 16:56:36 -0800 Message-ID: Subject: Re: [PATCH v3 1/3] mm: memcg: fix stale protection of reclaim target memcg To: Andrew Morton Cc: Shakeel Butt , Roman Gushchin , Johannes Weiner , Michal Hocko , Yu Zhao , Muchun Song , Tejun Heo , "Matthew Wilcox (Oracle)" , Vasily Averin , Vlastimil Babka , Chris Down , David Rientjes , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8509F2000A X-Stat-Signature: wqbhyny1h33cmerz7o3j8ri5hatzr5o5 X-Spamd-Result: default: False [3.10 / 9.00]; SORBS_IRL_BL(3.00)[209.85.219.52:from]; BAD_REP_POLICIES(0.10)[]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; BAYES_HAM(-0.00)[38.25%]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; DMARC_POLICY_ALLOW(0.00)[google.com,reject]; RCPT_COUNT_TWELVE(0.00)[16]; DKIM_TRACE(0.00)[google.com:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; R_DKIM_ALLOW(0.00)[google.com:s=20210112]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[] X-HE-Tag: 1670029033-408225 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 2, 2022 at 4:50 PM Andrew Morton wrote: > > On Fri, 2 Dec 2022 16:38:12 -0800 Yosry Ahmed wrote: > > > On Fri, Dec 2, 2022 at 4:35 PM Andrew Morton wrote: > > > > > > On Fri, 2 Dec 2022 16:26:05 -0800 Yosry Ahmed wrote: > > > > > > > Andrew, does this need to be picked up by stable branches? > > > > > > Does it? The changelog doesn't have a clear description of the > > > user-visible effects of the flaw, which is the guiding light for a > > > backport? > > > > > > > > > > There are 2 example scenarios in the changelog that misbehave without > > this fix, cases where the protection of a memcg that is the target of > > reclaim is not ignored as it should be. > > Yes. I found them quite unclear. How would someone who is > experiencing a particualr runtime issue be able to recognize whether > this patch might address that issue? > When we are doing memcg reclaim, the intended behavior is that we ignore any protection (memory.min, memory.low) of the target memcg (but not its children). Ever since the patch pointed to by the "Fixes" tag, we actually read a stale value for the target memcg protection when deciding whether to skip the memcg or not because it is protected. If the stale value happens to be high enough, we don't reclaim from the target memcg. Essentially, in some cases we may falsely skip reclaiming from the target memcg of reclaim because we read a stale protection value from last time we reclaimed from it.