From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1EA5C4167B for ; Wed, 6 Dec 2023 21:14:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4276F6B009C; Wed, 6 Dec 2023 16:14:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D8126B009D; Wed, 6 Dec 2023 16:14:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29F146B009E; Wed, 6 Dec 2023 16:14:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 176646B009C for ; Wed, 6 Dec 2023 16:14:15 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E17A940298 for ; Wed, 6 Dec 2023 21:14:14 +0000 (UTC) X-FDA: 81537646428.17.04B1173 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by imf26.hostedemail.com (Postfix) with ESMTP id 0E98114001E for ; Wed, 6 Dec 2023 21:14:12 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=LHko3B7j; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701897253; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PmJEDBzKxyQU9MCwcJin0j3ArzElELYr7Bhn9rZHDMc=; b=jE2kgqTG25v+9/5S/ZHE52wgNN85TfEo2Kqv3l30TTnjtzr8T9MaNvtA9tXmXGaewJcjBY l1znVrrQ6kNie/pkJSHJgdsKX6pYK70/86+NM6QjsIUQFmJyqCMM8Dd+KMTgz9P5M0sKB2 4y7IWoNzj742hNejzxuphJeH8O8UD7U= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=LHko3B7j; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701897253; a=rsa-sha256; cv=none; b=Vzk0q0gEShHgZG/KBqv+Sd92jNrqoUxmQlH7yfpocTO14YASImwb0FHOigKec5KQCBgPQe 2rpUahFTPR/vJMn4lSNgn0vDDuqgIhQevXJvVz3lwUQxqbVfg3eZuDITG7+YF/2IPU4aYa CU4pv2ru3uIMAJeprmQy5SYU8I3vcMM= Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a1e2ded3d9fso25944266b.0 for ; Wed, 06 Dec 2023 13:14:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701897251; x=1702502051; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PmJEDBzKxyQU9MCwcJin0j3ArzElELYr7Bhn9rZHDMc=; b=LHko3B7j/gi0Gxh7bb6i3GcgXx7kGc09fEwDMpDUwcxKDmtFdWhcCbOcI21Tx4e/vg QzxeujpZ+u8auntzKWc3gVJYCIlgxSRpQUdZ/Nb0vySLQu6RopuiMDVs3/EGBj0+iwCt JVXkUwGM0pKSbk6LnuprPPEPZWSYE0mU2GLfvsmTRFcaP8809xBkCJGzE2K0CeKtsCHh uGX8nFQJKWqmuJtf3x6Yoq8y+Va7+2IIzOMz8SAF8cHaGdhgBMskTeWD3AqQfS3dTWgH 5qZ+YtATyWKRTjnDDxuByah7m8/9taRPE8VpRSwhciQ3dbKPe3ytdj76+1m3FQketuuB PDNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701897251; x=1702502051; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PmJEDBzKxyQU9MCwcJin0j3ArzElELYr7Bhn9rZHDMc=; b=pqcxIa+8cZYBIqdrRyRmrtTkTvhqKvoibe+qSSCqdh05WEy0aGpnyPy9HwkrMUdsev hqzrnX1yUph1yMloawzh9OZdnoLz3+hW7mHfWLHcXchQOjzLvUamTzD0WhpBksjGw+r8 ldUMUhXJGtqli936RJTu8kn9wjfYmtryv+VcUBRHICeUUJAz3mwqIw5GvVx9g8LQ+Ijb tU9ZqvK9DhIhcm9hAWGUxSbtwPY8B1K5sL1qf6A9oVwf2md0OXLHke25r1zxQW5Hctf9 IEVtjOSPuZ62rGex8s/iURruxCpwGSP4YVGf4O8btYRjAar0ogNtIdSVH+EPXj18VJFW 7HoA== X-Gm-Message-State: AOJu0YxchS5XXD2IUNCN44PgOdILNOTTwkfNYp1d6V/P//EA3zzk1pRg p4L6XlkYvTAC1SlULOZyeCW1hRBJYYOhYYJOVfc76g== X-Google-Smtp-Source: AGHT+IGdUJ0U7LGEKJjGqt5itynfcSrlXa/hzW69+tBQz3ZKJeFsQ9wcSARFzKG7Hzt4JesxN71jS11/3dhzFfPH9sA= X-Received: by 2002:a17:906:3518:b0:a19:a19b:78b1 with SMTP id r24-20020a170906351800b00a19a19b78b1mr730768eja.116.1701897251403; Wed, 06 Dec 2023 13:14:11 -0800 (PST) MIME-Version: 1.0 References: <20231130194023.4102148-1-nphamcs@gmail.com> <20231130194023.4102148-7-nphamcs@gmail.com> In-Reply-To: From: Yosry Ahmed Date: Wed, 6 Dec 2023 13:13:35 -0800 Message-ID: Subject: Re: [PATCH v8 6/6] zswap: shrinks zswap pool based on memory pressure To: Nhat Pham Cc: Chengming Zhou , akpm@linux-foundation.org, hannes@cmpxchg.org, cerasuolodomenico@gmail.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, chrisl@kernel.org, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, shuah@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 0E98114001E X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: e16m7hii8ctt1z8e6r1759mcxs559u9w X-HE-Tag: 1701897252-739992 X-HE-Meta: U2FsdGVkX18ZIaEJh1mJLl+z5RNzhM7sjjT2QOPyKzk788HqaQ0gpsiu0UZs5uT5v2vcklSulsOJ5mNsKcDLmphrj2B39lrIrSkQZuTo97Qh138IMB4GapaHFAZTc6idCwyoUNLnsLPZa1YOoREDD3VfMYDnJEz3eLsUT5oy1oW4fP6Brzh6nos2kEeSBAys+LGcZZrG2KUyd4/RniTz9F8QOSLkRlw/jWSKAgqd4MkFhO8p20AtgdCOIvwe+hvKGQ7Xb3b+LnGFRPxdwZwcbYR6UGM18qAYPwlWdnsrHaD/07U0LkvRKYBHFwfBZvNZ6uMham37zJMXj3BNhex2mPxrQqltXQXesOY6RLTTvJlp+g7HHzoLV9TXDU1EoQdxc5SNNgoeN3qxjaw/CsjhyLtQZA96IrfMAbSjG1+RaWbO3ZbL0wcju8KEOu8gm9szlYYh+OxOGEgMdu0ul2vvXuSdkmTdARvtwIxFkPnGJ0HQx3PyORk2yK1ewDw+XEggMBtYxQM6Ejr1SdGuuEFlq1BStdsYVPrNwNYCNV1FnlKM0mOd7MoWBUz/bwC0Ajh2vqSQ325M/n4m7OxGMcQxnpOE26mB0xpAaJDqy2B3AV6OiVBTxPb57Tok/eavuguOSUHCDNBGpgB26WuPbtYzq9s7yojtouGyu8siTdVjx2wLQSnHMOA4m2zr6yeJIDW8OYwCXFHDVVo8dlHgnT4GNulz3SydSGVpTRLUPH9OETvvigbnRsGCI2T85e9w9CON18bDO7g8Uwa6cGMyJz45UWeRpJbSWFVRtGc6VZpHfBJMGU/Vvw0aOFqpOGMyzvHY+qsLz/6qtX2yhP/zB9Y51wgMqv2IjZzHFEgONnpOTa+4sFSDyPJMsiIh/1/HqqW4dj+cNOWuTqIU63B35ErQ3Jm+H2Si5pB3mwpUb7Oib1r0XKF8c1ltJzcdtY2dqPixM/CxJDftRv4cEEBbDUZ YekP3uvB JhVeauAP9zcjA3kXryFOcilQIvoQWvqAfs24pfFqi5GHTDDa/H3FFl7lfugyHQBTNJtcYykhGur7rO1IfZf764I59mxr1b8S1EvKySFic2Y6Urk2dp7rP7dvMCMEEbeH6bYgvlSrhVlXN6Axshtk8ZzAg35xt1dl/p1syKIQpVFh1YwGla+LcoylIP8bN4RDAwDQx2McBweCEo6uRzJ4P1evwSWLhftY4MroRhjaCka/bJ0W0o9Mx57Opxw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.005164, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 6, 2023 at 11:47=E2=80=AFAM Nhat Pham wrote= : > > [...] > > > > Hmm so how should we proceed from here? How about this: > > > > a) I can send a fixlet to move the enablement check above the stats > > flushing + use mem_cgroup_flush_stats > > b) Then maybe, you can send a fixlet to update this new callsite? > > > > Does that sound reasonable? > > I just sent out the fixlet. Yosry and Chengming, let me know if that > looks good. Thank you both for detecting this issue and proposing the > fix! The fixlet looks good, and Andrew already took care of (b) before I could send a followup fixlet out :)