From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA006E7C4E2 for ; Wed, 4 Oct 2023 16:59:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 791A56B0296; Wed, 4 Oct 2023 12:59:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 741008D0002; Wed, 4 Oct 2023 12:59:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BB6C6B0299; Wed, 4 Oct 2023 12:59:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4745E6B0296 for ; Wed, 4 Oct 2023 12:59:29 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1652714038F for ; Wed, 4 Oct 2023 16:59:29 +0000 (UTC) X-FDA: 81308390058.05.9EA7F31 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf05.hostedemail.com (Postfix) with ESMTP id 46AB9100013 for ; Wed, 4 Oct 2023 16:59:27 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=YrOe+b6L; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696438767; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eSLEpMzuN33kxQzm5qH/gkILKAwB7b5zDmsWnwSQOLs=; b=05KQGaPQVblMgPO7viFtRYTfrWre/A2kfAUZiABNdm8eQt4QYeOuI+G62NLuGe10Ko0VV2 ZFX9Zst/wr5q85hkoKHC8rPh6y3xb8lLvSJU5832AcIRvSgMCSUAsV+F7JvnxTttSnY4F/ OLLmWNyON+Ce5IAZbUuRekLMPbc84co= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=YrOe+b6L; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696438767; a=rsa-sha256; cv=none; b=0nSJJQs4xalzLcZmh8VBz/QzgfBiLc9hRregkLepL2brEPg4a1T7qBJR5ZYcIDbKcaMRaj Z25uZ9ej5BncP6lqvxyX1UvvtH4F4iLSRE1qVjfFNeEjmtPIFEAfH0q9KZenaIUaWpU73B 4QbCHfXwous0U6kYmOuHmUW71IKw2CE= Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-533df112914so4084388a12.0 for ; Wed, 04 Oct 2023 09:59:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696438766; x=1697043566; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eSLEpMzuN33kxQzm5qH/gkILKAwB7b5zDmsWnwSQOLs=; b=YrOe+b6LQd9bACpK0ie/i2ON7IIXvwJ0EYkbeAyIS0EoTvzRxKfMx26eILoOpdIbLo 1gshu3UjDl7tf1LBjGkFTEHajhq8Ncy+pgdnjAtcgKomBiEAXYsimawbmCcRSgyBQOr6 MjPzrC9Pqo6W3sIQRrXSBrfezI7WVuazuy2ldLiCB3Foh2+v+1kEoA5cNso8Ftpj9qKG nbXIKq+YLpRto3obirE20WEkGDhkKqt3aKL0VVM7nDTN8OpPQglwcSFBaVHqLSTU4+rf v+lFPaPiqW/+e/IG9T1FOXSYRE12yZks6dt4rhi3LXE5UV0BfOH3n30sixw4JfBexKYg m2TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696438766; x=1697043566; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eSLEpMzuN33kxQzm5qH/gkILKAwB7b5zDmsWnwSQOLs=; b=b+AM/JxdNHnjY2bCinIHLJlC7EgX9/k5LiyNmR8ekmmYem2SKs/rjZoCjECGRlf46d JGsuwhzh2b4UrrkBpPE0l5Wj67UBW3CsIovpaeUv2q+IyLLKlDTDbaIH2DZjhSb5iXIp HkjdP4CgcTLWA9P642ziYs0WvdvG2kqYgGb0+ERwfY/jjIDclvmeRB+1bfBR1IPVyu5L XsdmbYitc5fYd3heomEDyiFafKweCxAsxb7tHvbkAks5GxMRwuyruM8NF5sX8MbD+n+R z9ZBXKUPaYZhOmjzf7ywKgSPHuFOZ9NBLk9RS606r8xEbf4N4jw4eJoOqo8j4ZeRkIHd gCWA== X-Gm-Message-State: AOJu0YxrxUp+DZfodu3WaGtP+bf5MMJ2CKsbaOgwVGkKEp3q4fpyknN4 65i82dE+n532fQZPZC+3P+nxBZhaE6hLAXbhtio/Sg== X-Google-Smtp-Source: AGHT+IHvMn3cUi8cdEInkKSKT7oTyPnMvCooRlL/sjr6CtL9EsK9lo8KLtXDrbVnbMCsRglelu7I0bk+fUDog761gMw= X-Received: by 2002:a17:906:7485:b0:9ae:5fe1:ef03 with SMTP id e5-20020a170906748500b009ae5fe1ef03mr2430403ejl.67.1696438765556; Wed, 04 Oct 2023 09:59:25 -0700 (PDT) MIME-Version: 1.0 References: <20230922175741.635002-1-yosryahmed@google.com> <20230922175741.635002-2-yosryahmed@google.com> In-Reply-To: From: Yosry Ahmed Date: Wed, 4 Oct 2023 09:58:46 -0700 Message-ID: Subject: Re: [PATCH v2 1/2] mm: memcg: refactor page state unit helpers To: =?UTF-8?Q?Michal_Koutn=C3=BD?= Cc: Andrew Morton , Shakeel Butt , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 46AB9100013 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: r1x695rsyhyozu9gjaxrf3wiewya4efy X-HE-Tag: 1696438767-23623 X-HE-Meta: U2FsdGVkX1/PjQq8tPNMIzC3j4AIpYYpXZqIJV09Rb7Q4L4FBO0t73gZkeD/GVXGFSNl0Z3rxK6MQ48GWJcW43GriiCkqDhO4BOh1DmoGv679BRrJQcXB/2fXGesGWpBeS/I7zCI6fNhzx6nEU/81Xt6jbxcEB3mtRHkOVt6EkvCPp5X/h/iaTKiDWNNv9psm3h4jsNg+AmMkQw0QbhYa71efg8ZGJN3Aw6LUfq65BoiXmrPqLjarWq/TH9ZM0AxIlEvDHdsBq/bYJ7f/EL5EwQDuM/ksVDmcvnUMZmCYVXblcVkh8muJW78pd+AGbrG4hU/RDoXD0xJiQKC6G40FRiisFICNFoAjVFm+etXDvjtLIBU6KTFiM3Tvi/hbmDICOn4OFjoRVNv0r70RQMxnfotpugwwU189GeYNg6+TM+hudFJC0R/nIKNWOZnu6QOq5hwIht0uSYsosmPQDl0gjZCd6AGhEyfuhzKQYCQmx93JWFdfm10QoBL5zGUKLch7eppptxyBZqHHRplY0Pd9lXGbVIpPcDjTGY8m7cq7Q+cIQqmBRcTXPSLC3uxjwfEJBrgCaBo4USdvcoLwTCyOlgo07GDRuKANaQGM+pCqKidvSFW7szv2JXjFQ9lw7OqRiTf+Xtp679v510FgU+iIvXrtLDxxLkh7xRwGsVofRTz2w9GWwreOXbwsheKQ/XEPHP3sA2bETxxJMYWW0MazVc7xTLW+L1CaEoyNX6SR6Rl8JNDv+WEWOhh8Fanz103XubN88I+ZthchFcOxgsPhWQnPkekPtNRk+f0h0HvSPm+TnvAISEjjuhie9w+SC1Q9YvPdk5oaWDxYHzYh2AwB2E8Vt7LZ2IfKD5jwp13JpWqklKHUk3iPWxcUfv+AQfB06oxAUX9P2yIK1H7HMrz7OBCdZGgix5kZZYX9d5Vk5dwVg30MSS+eH0M5yOorzesxghXMoDfv/+gugj8I7/ 1Sy1yL7E 44JbM/PO5NJzOW1DrReuQlgIduCSCNfjabkCXatBYh/PjEeuVyDp+fJSCKYtC+DPTDln6r8jC9LRts82uBuQ5bGgdRe5Z1kBpNM3hfPL9rutS+IhH1SLDk0jM2LAweasoQTssbCapIGgt9TZOD/sLKbM0mA22rbUStMRbR0+E4SvWnMIrTL/TogKGn5vOLX4TcWw3mb8duKPef+WOdlCOFt5HpPR6W8vIZzmBhrbL/bFI3Juf51hDOCx4sT9j+N5A60WeLXtViOPdKLQJosS5F3ExPJMpJWItdd6KcBpvdIgkMk5vOpA3Pxs4Ow== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 4, 2023 at 2:02=E2=80=AFAM Michal Koutn=C3=BD wrote: > > On Tue, Oct 03, 2023 at 12:47:25PM -0700, Yosry Ahmed wrote: > > Those constants are shared with code outside of memcg, namely enum > > node_stat_item and enum vm_event_item, and IIUC they are used > > differently outside of memcg. Did I miss something? > > The difference is not big, e.g. > mod_lruvec_state(lruvec, WORKINGSET_ACTIVATE_BASE + type, delta); > could be > __count_memcg_events( > container_of(lruvec, struct mem_cgroup_per_node, lruvec)->memcg, > WORKINGSET_ACTIVATE_BASE + type, delta > ); > > Yes, it would mean transferring WORKINGSET_* items from enum > node_stat_item to enum vm_event_item. > IOW, I don't know what is the effective difference between > mod_memcg_lruvec_state() and count_memcg_events(). > Is it per-memcg vs per-memcg-per-node resolution? > (Is _that_ read by workingset mechanism?) Even if it is not read, I think it is exposed in memory.numa_stat, right? Outside of memcg code, if you look at vmstat_start(), you will see that the items in enum vm_event_item are handled differently (see all_vm_events()) when reading vmstat. I don't think we can just move it, unfortunately. > > Thanks, > Michal