From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A69E2C4167B for ; Wed, 29 Nov 2023 22:31:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3574A8D001E; Wed, 29 Nov 2023 17:31:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E0708D0001; Wed, 29 Nov 2023 17:31:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 180FD8D001E; Wed, 29 Nov 2023 17:31:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 048548D0001 for ; Wed, 29 Nov 2023 17:31:52 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D72E81605EA for ; Wed, 29 Nov 2023 22:31:51 +0000 (UTC) X-FDA: 81512440422.05.DF6FCA6 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf11.hostedemail.com (Postfix) with ESMTP id 0EAFA40018 for ; Wed, 29 Nov 2023 22:31:49 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=IKsGBDKk; spf=pass (imf11.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701297110; a=rsa-sha256; cv=none; b=ZloYVFzdtb+oMXmzrMmQi1l5qtXmCHPbzSnzdzKLvlT73YY33BSjMKsgCz8CS1KOhEzTh3 r7mdFfn6nxUU5iPs9c0+KYDUi7/WXEGVs8C8fBLswsE2p1HQoXrxjq6UG5TAaeYOgwf9QX 7I1DyAJMlLNR2MpW2jcrsJmGut5oymQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=IKsGBDKk; spf=pass (imf11.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701297110; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6JhsGGqS71bK1UUounxYTwpbhCJBb/sdoMDafmdlVMQ=; b=Gp2DcfdEtNpRXuDjCmPtbY1FJ9wjshCBGw+3joMsvNhqUaCPJphERkMtFi/zb45799e0bN zwxNR1a4nnAzL2PDjkOr4rTeqSONPNNTHsX4GH8eCT56g/X3oqbW/hRQ7L+68ueSNtMscH dgbnFbLj+ohlZvc/LVWohBDQxZysl+Q= Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-9fa45e75ed9so37652966b.1 for ; Wed, 29 Nov 2023 14:31:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701297108; x=1701901908; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6JhsGGqS71bK1UUounxYTwpbhCJBb/sdoMDafmdlVMQ=; b=IKsGBDKk5Hr7215taLjpmObkKsg0NTvuFLxeUCRjG8e986vOivdWI4EG1eOY/iyBhY KtGystcvjf3ukymAfxg0BnG1+Vyh2Nd4kdyluw+8LTzM8ETovRXHL0/C2hdiw3+mvrXz BQztj67WjxFNoW7tb6n/+bDfFuexAX1cVzt5SpmXVMDTARCO5UAVkwWRZYPNZSMSFg5O YDJ3MGHY2NPCzc58FXWWdz9/e3DaLq8PlqwmuDsgmaSiq5Qq1z46YOu6xhQBwZwJuPwm wESiq7RyDvIhPYIa7/UflDoz3UXmgMNTi0yuobIlvR+CDlNDS88yiHIxIB6xvmCB0D82 QK+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701297108; x=1701901908; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6JhsGGqS71bK1UUounxYTwpbhCJBb/sdoMDafmdlVMQ=; b=e257NHQ86FP7aNrHrKdsKhFKiiNfNIXR6uVLU+jH9+YwtvxzYtu44BCQnwdDiSDXk9 umNQNm3QwPf1NacQssBXJ+jvVRSzhj95EuetqMtHds28x1QkWWHE5szDa61Y22AWYkbM IEpPQEUHaQMqQKGUvtr/I0K2/uThAVabkELOfSvv/TRnzbM5YA/cKf6S5NkEmV/BQxM9 UTBYwmnXRyUOK1nEs+kPQAYk9/gs1O3HqJcyHFDO4mtACb4Hw8/cMeeQvU7pG+N+SPDE qvIkz/EGwAB+VbVDaKq1qG9KXpVXwNYd7ppanA+ZgKTeBZbEebV/IPUf92CwUHcHhRwr 5VUw== X-Gm-Message-State: AOJu0YyWadg50fcgq49ktXGwjObA9nsuFhkMbt4eY5L9kpsnF/gemCCz mPP3K+55yP6a2fP27ukUt37bofWBbVo97klV/31nlw== X-Google-Smtp-Source: AGHT+IEdOHepzllFyUV9+Dg16tA5jdOXWM9dRvwFf15zZI9af1Md173X8xnGqOdIUfmMalNEd1jGJPCuIm7oUABOJ7A= X-Received: by 2002:a17:906:39c9:b0:9fe:5d39:41c6 with SMTP id i9-20020a17090639c900b009fe5d3941c6mr14272551eje.51.1701297108476; Wed, 29 Nov 2023 14:31:48 -0800 (PST) MIME-Version: 1.0 References: <202311292250.RUfWGNgx-lkp@intel.com> <20231129134313.656e76c2e3fec1361007633b@linux-foundation.org> <20231129135342.5697165df1adfff04c749082@linux-foundation.org> <20231129142935.d9c76a2fe35efd9a4c7b4087@linux-foundation.org> In-Reply-To: <20231129142935.d9c76a2fe35efd9a4c7b4087@linux-foundation.org> From: Yosry Ahmed Date: Wed, 29 Nov 2023 14:31:12 -0800 Message-ID: Subject: Re: [akpm-mm:mm-unstable 179/192] mm/zswap.c:825:17: error: dereferencing pointer to incomplete type 'struct mem_cgroup' To: Andrew Morton Cc: kernel test robot , Domenico Cerasuolo , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Nhat Pham Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 0EAFA40018 X-Stat-Signature: hznktgibwuq83q45zyht8n6dk16zkjzy X-Rspam-User: X-HE-Tag: 1701297109-880657 X-HE-Meta: U2FsdGVkX1/wM2O6nZEgSU5LFkG/Te/ThhXlh6wx6+NmFM14+Hjb6NOtVPlekctvZWjPyUICRlepvPIX7yjwnBYJZvXlQc5MCe4SnM/6fDUQiuvrJMb0bTpcYauNEHIhfILAO8HH2tbNds8B46UqFseVxqkXnFSvLij/5TZ/KbvJID2U6EoBZ+ogguWIsLI9oCV87+V3Xh8M/umrjJJ7JZQr68rYdHoQsEGRvcTXbq0l1eDRhA2hGFTeFeYczKiQNF3Wj+OfQpC8MXZMEslXuy+dnvAZfJ/kzLqjd79r7dKHQXIJPfo2EDUhS5PkUA+m2/N1cN6/ybhNJn4aCpEwFNwW/gD2Jd6OqubEQkE+kQbCB9NjKx1mXIjzDl6mKTuhMfjZS0dPB6Cm/gy57vh7ROsAeuEjy5scTthjRtNIKFK9RoYB4cbhd1//E/5YD8xtyXNeVhdnWA2KewnpIcCiUYuhZ+zf6eqVYR97n/wqqqMz6snbXebscMSZZM+ZhmLDDR0BDwjCpKaGobYCvgWcCiitQYyW/YNUQXRU/ehcbCa6p5EJGl+MmKA1cAt91PyRVihTWfg06LT+Imls3KMI1mKO51jvBNxeDzmj9T3axxGShqJaKgKPlBT1rC5g/D4RDAlBNx6d/PE5xeyFxI4SFOGcCa++IbHMChqWl5bzrpDLPfDCuqlQWglYma+vNA7JvcpTpzIKSaYoVcCIevFTyexONS1tOtXxXuU0VhORf7N2ElztnNp4uHmH22mKGagZlrtbU4QzwVVEGG7TlPgh+vnPNaCUkbn49ADi8036UEGY8oPTO75bkaf1SDqGJQJH+6/XdSivJAR+Aye/qSvHnRyWIEhB6gFqRDqOds+CC5Q4QreLqgr+knkLUMkWtMBzspH3upub+xApxdTOuacGAdcBklqpRjsX6QbbQtAR8ljswA1sNcerO/6IvVRw1nrwF07AN/yWBVZghHMLgzU HsqQWqBt kN+mPY4kvr9dOKyppEXZ/hFbI0NojlIEEUOXyvedQ9KpHgmFOeh8w5J2yvBogaQNrmzN7vP3YYrbKdXQQ/PJNzf4dsXMQRJBlK24XJdPA5Z646haltN2dSzyFxwbWa7ftvaGbMXrNZChjbl/b1SnHCoZBwmOmMumzpj6tU5dKoTyPBTXcS69W0Ck08OoDd+1l5ZbmdXKjDQcefnyzIz2N+HYFQTjDrzkFrrmWEs5RRjiTquPbspyRcz+IOVwFEfK6iPLyNVv/BwMIMu5b6RObkZI4P1APWh0a2DQBbLfWJp889MzMsD7BJIGA6I/6xUOL2nAL+iwLEhr0IB8I4hmoy8WNDDO3QVO7N+rGeZDlKKtpwfeasu+BDtKHtjX9UR8umEIENVjjPypJuYsw81j+zhshRWGW0TYZc4Y+eSvv3PtCFmI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 29, 2023 at 2:29=E2=80=AFPM Andrew Morton wrote: > > On Wed, 29 Nov 2023 14:18:15 -0800 Yosry Ahmed wr= ote: > > > On Wed, Nov 29, 2023 at 1:53=E2=80=AFPM Andrew Morton wrote: > > > > > > On Wed, 29 Nov 2023 13:43:13 -0800 Andrew Morton wrote: > > > > > > > On Wed, 29 Nov 2023 23:42:11 +0800 kernel test robot wrote: > > > > > > > > > >> mm/zswap.c:825:17: error: dereferencing pointer to incomplete = type 'struct mem_cgroup' > > > > > css_get(&memcg->css); > > > > > ^~ > > > > > > > > OK, thanks, patchset needs work for CONFIG_MEMCG=3Dn. I'll drop th= is version. > > > > > > Well that's annoying - the "mm: memcg: subtree stats flushing and > > > thresholds" series had lots of dependencies on this series. > > > > FWIW, the "mm: memcg: subtree stats flushing and thresholds" series > > has no actual dependency on the zswap series. The conflicts come from > > patch 2, which moves some code in mm/memcontrol.c, which happens to be > > touched by the zswap series. The first 2 patches of the stats series > > are just refactoring with no functional changes, so if those two can > > remain in mm-unstable, independent of the remaining of the series or > > the zswap series, then either Nhat or I could easily rebased our > > patches on top of them, and you can easily move the series in & out of > > mm-unstable without conflicts. > > > > Another thing is, the only difference between v3 & v4 of the "mm: > > memcg: subtree stats flushing and thresholds" series is the rebase on > > top of the zswap series. So if you want, you can take both series out, > > and add in v3 of the stats series instead of v4. If you need to remove > > the stast series again in the future, you can leave the first two > > patches to avoid conflicts with the zswap series. > > > > Ok, thanks. I prefer not to make what is in mm.git too different from > what was sent. > > I've left everything in place: > > list_lru-allows-explicit-memcg-and-numa-node-selection.patch > memcontrol-add-a-new-function-to-traverse-online-only-memcg-hierarchy.pat= ch > zswap-make-shrinking-memcg-aware.patch > zswap-make-shrinking-memcg-aware-fix.patch > mm-memcg-add-per-memcg-zswap-writeback-stat.patch > selftests-cgroup-update-per-memcg-zswap-writeback-selftest.patch > zswap-shrinks-zswap-pool-based-on-memory-pressure.patch > # > ... > # > mm-memcg-change-flush_next_time-to-flush_last_time.patch > mm-memcg-move-vmstats-structs-definition-above-flushing-code.patch > mm-memcg-make-stats-flushing-threshold-per-memcg.patch > mm-workingset-move-the-stats-flush-into-workingset_test_recent.patch > mm-memcg-restore-subtree-stats-flushing.patch > > in the hope that a new version of the first series ("workload-specific > and memory pressure-driven zswap writeback") can be dropped in place of > the old version. > I see. So Nhat needs to *not* rebase his patches on top of the current mm-unstable, right?