From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 446D5C54E58 for ; Tue, 12 Mar 2024 10:22:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 855DC8D0038; Tue, 12 Mar 2024 06:22:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DE828D0017; Tue, 12 Mar 2024 06:22:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 657C18D0038; Tue, 12 Mar 2024 06:22:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4793B8D0017 for ; Tue, 12 Mar 2024 06:22:48 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A8BE6A04DC for ; Tue, 12 Mar 2024 10:22:47 +0000 (UTC) X-FDA: 81887998374.17.C58F0BC Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf20.hostedemail.com (Postfix) with ESMTP id E097A1C0009 for ; Tue, 12 Mar 2024 10:22:45 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=F9Fzl+QQ; spf=pass (imf20.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710238966; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qwlSqCcmIQTp4qWBUcG0QiZl7XK3uVt9HTvZMCmPyho=; b=DhcUzwrmxNDcP0M4OiQDuGczZTEoyCaKA5oCQmZ4FfWB2OcaQNqAxjUl/fhfOluHU/KmKA K79fTb/AC1L2eHr+DPqL5pQdA7J7+joNUSegoHefBwHSLv9Fm0PQ7akdI7qakIiQS5K5J+ XZWMH4ZSq+QPc0pEk7o9uegzqIkX670= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=F9Fzl+QQ; spf=pass (imf20.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710238966; a=rsa-sha256; cv=none; b=GwLtuPyIb9hyWbeS3Q9PYuwtcIQNH9zSvs/H8n8xZ+Vd3sdwfH2GZaY3vbuKbRxpMrDKvS slu4m1SlaGaFuwHorWiwMfy00QK9VchFOBBaqDTzxMZTM937rs11CvORTfu9XJRgEYgSuG ILRj+wahYBSTBhkGRdT4XbWLilY7Ufs= Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a2f22bfb4e6so785665066b.0 for ; Tue, 12 Mar 2024 03:22:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1710238964; x=1710843764; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qwlSqCcmIQTp4qWBUcG0QiZl7XK3uVt9HTvZMCmPyho=; b=F9Fzl+QQZZkjdEqkeQ5JvEHlV/J9fAxtBjD5LBRr/CvDw9utEGZEMvxBWk1dG7cNoi /jql5ETTAPX28ySqAQV0eNgGQ6yn4lcHGwhXVqbv6q9maOWaxyFXlyKvUzDRJXrqbAbS xtW6HLQzcJGD8IXOomr9Qy7hQTGQZ3Z3jBxdMBf9+bUE70ZfL8kLS5kdOEcldNSRqJa/ yl7zpzcXR3R86V4GfTmbQgDo1zs1WSNjjs9Z00BxHD6DzKY4AHfJfrL9Fv0PJmfZvdMj qYboCThGnu6XsNS8YG6SJ1W31VNkuK3wzk+5lggZa5t+TtmkUg3l15opK67y7quqS6mq iisw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710238964; x=1710843764; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qwlSqCcmIQTp4qWBUcG0QiZl7XK3uVt9HTvZMCmPyho=; b=PNj3OzmkjiMfXbscifr920axeECmQ/iBeWIBvAgJNHMkU8aUNI+Y73rWU4w0tK4nYc Kpmo1XIebdZI4lpu9Uklsky1rWdFVUpXlCBGUHCszq4jDA6SA94l6IG5UMcTsoNq6jhc lf8h3WnTudESRAbWvm41rWlF5zdKlv3NF7Ts73+wJnGcBBJTI5pQuGhF6Ma6F7SbbUt2 gbsNu/PECMeI1oBqg5ch8IxA6kTOpj+zWCm6W+4qaqwv1A1LbRmOgbdbZHk3a9NZRrJy u9yaupHDPU7mXykcmxLTiYapBX0G/99UL4PyEtH9LhKyTpQt0N6I3gizGyFD9kMQvtcW Vz0A== X-Forwarded-Encrypted: i=1; AJvYcCVer5Knx864pJRyy2rFULQYVA68hqKncpO8wd9i1fCDPlIGvuq5xdeMklkP9/80aj1JUY12Y6ZOiRN171oT90LdR48= X-Gm-Message-State: AOJu0YwCu6f8VRsu0dKI8w6jJCd59PHPUL5AJ0jMa4v4kWrggQBlzO6I 6mWKM6EFF5dCVld9oG8b2SbNjo3yfVmqDmsC+uMDBxZWOeCxCOCNrQ1nM4tDbKTCFVNB+3VjHaK gseoxXlBmbeA72XX366PJR29Aefudq1JCU39fGxHqicaJwLtmNO00 X-Google-Smtp-Source: AGHT+IG4zIJ6KPcEpowwL2eYULkssu/nf4WiRLsFrH81EeV4R1r9+XavkF2NcCG2sOIumI3K7s5YgsP2tGeXGk2Atts= X-Received: by 2002:a17:906:13d5:b0:a44:2563:c5dd with SMTP id g21-20020a17090613d500b00a442563c5ddmr900504ejc.45.1710238964252; Tue, 12 Mar 2024 03:22:44 -0700 (PDT) MIME-Version: 1.0 References: <20240311235210.2937484-1-yosryahmed@google.com> In-Reply-To: From: Yosry Ahmed Date: Tue, 12 Mar 2024 03:22:06 -0700 Message-ID: Subject: Re: [PATCH] mm: zswap: remove unnecessary check in zswap_find_zpool() To: Nhat Pham Cc: Andrew Morton , Johannes Weiner , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: E097A1C0009 X-Rspam-User: X-Stat-Signature: jf7jnrxnytijujxjq4j76p7mt4gfw8ih X-Rspamd-Server: rspam01 X-HE-Tag: 1710238965-827209 X-HE-Meta: U2FsdGVkX18DjKHQF66yBtEC1MzyMtGanALMo5v9ZX5RHhHgLBFla1akY5blL64ZLNJnr2t9gt1WD35VoKDbGmhMKaJE+bLYwYCPgax9/b8p3VCVAUH4y6qzRgQ3uCZFHx/GiGnCV5SJ0iCHu3nNRekiOAborSLcFTU4BxEDrsLFLQXykDAYbwbRzHDbWjSJyhPvZhuINjk1JXMG6hs1UVQAaHCnVN+QAUViIESH0JqkjgpzUd218AUiwM+d/qiYC2TkBnzR0wmMieOIcRbqogMnICb1ZKJcVNNfJEGnkU+dKTbvYL1ZcPogxLrsK0qIJUoRbxqHtWnZ1NVN0Pdr4EPYgCHQRlHM0PHAeaFQgw/LeygmJ6E4KXtpnDOexpmmJytuPOhysuAkxjbCPjSt27qV78hgoYGEK/2p28OvYGRUtC9J5gdT7C117p+w6juVXrmrwWcpGxYQWieR6RSGIRQSHAwVVfMNmhwxenL8+UtfZUbHtyIaXU3Y6CJYGGIaIMUWptYRvGsi6qwjtEDTYHZEjfvs/dEXJr7OrMtdN28K3IkhoetawA1slMWg9WD7fIgqMZEPqrQpE5ENyGZ23rHxRinGsfwAt9ziTIPebQEGuGhKoTWhDMxo6hoAbTSmMKaJSML8Q92qas0MQmfPNTu2rT4wn0r7VImL03KzQbrbLemPcVe1X1Ayfl9vHfyZ0hjA30G8zQXJSLjR8tQCV1R3aIUWV2aNWX3gP1xYo1ZpgIpD3mn0jc3/6xd83A0kb/SS2WsRd9jFzNPPki2QmgyAdbkPSHAKYvnAGYOIgSsDIHXoMqpdE/v8vfG+ZvxHU3StlKpy/LOIBAh98FHcnjs//tgZnd/v7hdWqWvQBL3B/CKuSb2tL3WNtqkb7ZxsaDtbGTdrdhXsTOMzKWehL98pxCrEp/PGYtAVq8/oC3XxgEvUhQsOywlpd5rdu9BRknSQpeR2BB2UT4uWyvG ACLqpfkc KDL0EcapTuxyXFRZ4jdRkeiRm6elp13HtFmgG X-Bogosity: Ham, tests=bogofilter, spamicity=0.003843, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 12, 2024 at 2:35=E2=80=AFAM Nhat Pham wrote= : > > On Tue, Mar 12, 2024 at 6:52=E2=80=AFAM Yosry Ahmed wrote: > > > > zswap_find_zpool() checks if ZSWAP_NR_ZPOOLS > 1, which is always true. > > This is a remnant from a patch version that had ZSWAP_NR_ZPOOLS as a > > config option and never made it upstream. Remove the unnecessary check. > > Do we need a Fixes: tag for this? I guess it's not a bug hmmm. The compiler should be producing the exact same code either way, so I would say no. It's just a cleanup. > > > > > Signed-off-by: Yosry Ahmed > > Reviewed-by: Nhat Pham Thanks!