From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC18ECF9C6B for ; Tue, 24 Sep 2024 22:29:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6AB176B00A7; Tue, 24 Sep 2024 18:29:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 659B56B00AA; Tue, 24 Sep 2024 18:29:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D3C96B00AB; Tue, 24 Sep 2024 18:29:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CE2E06B00A7 for ; Tue, 24 Sep 2024 18:29:12 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 75D0C14053C for ; Tue, 24 Sep 2024 22:29:12 +0000 (UTC) X-FDA: 82601073744.09.865A28A Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by imf19.hostedemail.com (Postfix) with ESMTP id A78471A0013 for ; Tue, 24 Sep 2024 22:29:10 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tpNlnA3q; spf=pass (imf19.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727216831; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n39eMlOm+SyrgwEiQBgcVOHL+GxwOs4MvJmrNHifhyo=; b=SuIcp5z5IOPadcgFtHiYOxohv6BBjTx7sk+J0tpxNR/3jcSSejW9PksVherjk7s6Sa6dJA 9td8jC+Z6vRcHReaKhNQowWPmxNSMt8Beq7yJFUDD+TQ1aN2pxyicQFIPiN5JRaGPFGlp8 0rfYmytV40LV93GTyEakLDAPeOH3iUQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727216831; a=rsa-sha256; cv=none; b=tYJSOFY0G6aPx+mfw4MTDuED7Dbg3dw7O6IvtLTOD0Ra/b/U1wNX9O2XNxwrkNZzq8cbzM ii4J8CnMnCGoqMHvExii6Ag5ZB/MxhGxxtfzHX7tuSr3US409khAdvJiAe6OyXcif47bR3 WS3f2hfxOzxzNXFq4v6boG/JDadC/jw= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tpNlnA3q; spf=pass (imf19.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5c5bca6603aso3481398a12.1 for ; Tue, 24 Sep 2024 15:29:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1727216949; x=1727821749; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=n39eMlOm+SyrgwEiQBgcVOHL+GxwOs4MvJmrNHifhyo=; b=tpNlnA3qzj0b7GxQhd1UIGkEkuHvY5DGV4HsXdszO/5ym7k/czh9EG6x6dTjf2haYu YADpGl5LrWl+kTMpKeuz/FEsBm8qH7gCV8xgtO+DpWkwLxmRgcPCCnX6tlJcK4iV48BY h5jJ4gEL1yinauUGKp/xZbdsb7UaHNwfVKR8HT1QW0erom+TJo8+ySrPbv5TNQg9W4ta lW9HSuvYbXVWd06iBGvSXLupRh1+ohsizp+gWMYg6f6v1Bg3Fjg26gntEuPvcau8FoKi VoRyk3FlpCxfNaf4QBZTQXrV4oUY+05WqyMrkUT9QA8aw8oF4Kbqd+VteCVWZlEp4UWg 4XeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727216949; x=1727821749; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n39eMlOm+SyrgwEiQBgcVOHL+GxwOs4MvJmrNHifhyo=; b=S0glX8bRuuLYEeQ/2vt1aNkYeUnO3vbFjxqhBNTVsVgvEJV46H/81InyuhXgS4yjyy OKDjQOBr/0II4bMYApk5AL7d8bErAUkK7dQIQeYD3AfWgDeMjDb3SxcFkJFR3MCvvg/i 3THuQ2oDwfJrTqGkdqGEXZwX3nn2Kh8IAkoaNkEdgS21+ke7iZxTTINdKlTe9dJ1Dbwg cc+PO+BOlByoyNMQ60faTELLchnZP0CfFB5qgK9orF4kPmxwQe8KX/8t1m6iTrFoqxIb 3J+0AMpFtpLskto8mD1oVbOckyf7t9kli8pYaEkXzkX7tUnE7L97GZwKlWVVraEcyoom NKtg== X-Forwarded-Encrypted: i=1; AJvYcCURswQH7gaFiy09SQlUdIaOa7HsvXRQbTTAF9MKukrFyq5EuImR6+9UU5U8sHNN+AuJ+SOFephESg==@kvack.org X-Gm-Message-State: AOJu0YyxKp5szmoH8wZrIIzpyTwAmNsFNwVXif/nNWeP1tqkhBDFmT0u M5DxzAe8qoD7tAsvjnNqAs1EPn2eE7TwQjr2v9OJT6LOfrHoUPTI2H7svKJtMeh85lXCabSAkhL 77s6gvC1KE0mzE1yxb6jkan+vdhDkp7dwP5Go X-Google-Smtp-Source: AGHT+IHZXtbf1m4/Vq1sqBrHk/G+Rz3IDVUgzWzPwCiWjokGu/B1SPj9zXhfB/fRMBaTX/BPBcYLLvgIwCxbb8dviQc= X-Received: by 2002:a17:907:2d92:b0:a8d:6261:23ff with SMTP id a640c23a62f3a-a93a035da14mr58181166b.17.1727216948815; Tue, 24 Sep 2024 15:29:08 -0700 (PDT) MIME-Version: 1.0 References: <20240924011709.7037-1-kanchana.p.sridhar@intel.com> <20240924011709.7037-7-kanchana.p.sridhar@intel.com> In-Reply-To: From: Yosry Ahmed Date: Tue, 24 Sep 2024 15:28:31 -0700 Message-ID: Subject: Re: [PATCH v7 6/8] mm: zswap: Support mTHP swapout in zswap_store(). To: Nhat Pham Cc: "Sridhar, Kanchana P" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "hannes@cmpxchg.org" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "shakeel.butt@linux.dev" , "ryan.roberts@arm.com" , "Huang, Ying" , "21cnbao@gmail.com" <21cnbao@gmail.com>, "akpm@linux-foundation.org" , "Zou, Nanhai" , "Feghali, Wajdi K" , "Gopal, Vinodh" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A78471A0013 X-Stat-Signature: 18jkwxutwyao8xw14h4on11ps36kon6e X-HE-Tag: 1727216950-228493 X-HE-Meta: U2FsdGVkX19VF67oqvAcAI0Ge7mmx3pGm4AnllnbxQrl9IgnRZILVyE6xvc8Ne7qgtUHUVAX+kdbqHl4B6BADRBjju2niAtK0oL2BA4LLO66RKfRwS26muXSrPIe7hEhv5a8w8oJzTKXFjMZT5zfI2c6zEsgK5fQzNJNKGP+Rd0w37INyrZnG8qegalTD2llC3EcqmsS68q/1S/YVKFZ3vLI3rsQjjApD2nX81Ksbcu7VZAk91zvlJHxPDDObeR2aVolM07GPnheEDhPeP29kj/cRU/afITpvUNEYo+U9s55rGz8zV88tPnyLD8xeUHwjwMUtchHR6vwrmXqOCBAwq8fbdG0X4kALrOinRkeneAha2/ZwdHPfFGvZMGAREm7RK0NsSLgWk3T3WeMe7rJ4J2ghExyRfCRYblIyLC7X+Okele+qrS3C8fG2JXSsDcPjt+UPtecyydJ0rnat6Y/maeAexXxWyPcYc5MJcC09vw36lMxFRXTkoSVt26ZsOkhWzKNiB9Pd/SRQXginfeDFsIHb33kM+OoBflYmF9tKcWf6QMHRbAQykmPUHOaThJnV9dOWBHjNBkvxxtGkhaD/r6Hs/Ze1UVAO4oCSDqc5pxugQfo4/skCkNnOPt3W/XU7db7rKtguTsa2/2KHDP54wJyEBFkF+wGhU44M5lMY25+83bUanlAXqZwAPg/cJoueWGpcg8nFtQxArwKijCtEJqqQ8uusqtHx1n8dBZ3TIf9bOhuaXJQ0kR9TVnzrS61Etc852Dsw32kwz9YgRiswxv4HVcmXnyTsQG0J0l1xi/GtRja3tHt9gb4HieThpfsnq+XIlEWZGAM/3l0+WN0C/JmpDbRSDydK9g7FfYF/rlq9fWasW3ihPGiUflsVWVoYznih4/Grtb7jRc8xZ7/a6S7La6FVQ8p05riR88G5HnU5tmiXoM6gMchAL0QFW6Ki2aaHKvbJrpn9daubkw M5kJH1Sg U2fX0DcwA7fQuvPMztaQxz86Oysa4iDoEWItZKqPoiVFmMd82jYxsabAWbfLB7nCAoKcatteusP7BrBSBnvzJjAEuCwS9AUwFVJDQji7uXn8zn3HOMnCPbis+F7Vq5+T0XEKrAbNwA5TnkDeJVpL5K71g+HgMTq8DOhtAtH21LSmx6TNCOw85NePXwzU2jFibvkCvEvDIzY5IWmooEMzZup1CaVp3GZrtWuOGlybslD7UagYu77QwH+CQ8PINHg0/fz+UDtBp3BZlsutKyjic7kLZK0GKuXJnWvsiejvni5d2wIuB3hXhniEECGEUdJvRZJuPWymeDThooyI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.199876, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 24, 2024 at 3:16=E2=80=AFPM Nhat Pham wrote= : > > On Tue, Sep 24, 2024 at 2:34=E2=80=AFPM Yosry Ahmed wrote: > > > > > > Why can't we just handle it the same way as we handle zswap > > disablement? If it is disabled, we invalidate any old entries for the > > offsets and return false to swapout to disk. > > I think that was the suggestion. Hmm I may be reading this wrong, but my understanding was that the suggestion is to synchronously remove all entries of large folios from zswap when zswap_mthp is disabled. What I am suggesting is to do the same thing we do in zswap_store() when zswap is disabled. Anyway, if we are removing the knob this is not relevant anymore.