From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89106C47DB3 for ; Thu, 18 Jan 2024 17:03:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8F356B007B; Thu, 18 Jan 2024 12:03:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E3F736B007D; Thu, 18 Jan 2024 12:03:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D07AE6B0080; Thu, 18 Jan 2024 12:03:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BF1636B007B for ; Thu, 18 Jan 2024 12:03:44 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 81653160D3D for ; Thu, 18 Jan 2024 17:03:44 +0000 (UTC) X-FDA: 81693053568.12.D885A7C Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by imf16.hostedemail.com (Postfix) with ESMTP id 09DED18003E for ; Thu, 18 Jan 2024 17:03:40 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=TPjONd6q; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705597421; a=rsa-sha256; cv=none; b=HqRIl0Lx1+OPkRRui+0H04u7grLtPgXt+DUYb6671v3SDsOjoXf9e672HSEGij/emF6Yxr JjwYKyNdwGBHRikhLm9R89phiwbcBfnEvlmJGEeXpas7jLewfvziBu2ySmuNeQBOYVrMuG 6ML/jcJab1gOctC4a1wBRTOCxSpRYl8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=TPjONd6q; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705597421; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I307JXW0PD3nSS/XpS3TGtlMDXTLZF0yfATueCQN9yk=; b=zlJ1L9mN/3nPDEfcli+UAEhE7lV4rgRMgOwvUsnujvQfBL+s9f7qryJbNkWHzOUTwAuP1N mIzT2stwrZBT7Q6THg3hlKJ6XrDX1qVYOk1N4dFaMA1Ms8jmys8OS4N5PhE1BkJ4CRJW25 ofJIUvxXWCM2HVWHWfz9FnGATEqUj/g= Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-55a356f8440so812092a12.2 for ; Thu, 18 Jan 2024 09:03:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1705597419; x=1706202219; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=I307JXW0PD3nSS/XpS3TGtlMDXTLZF0yfATueCQN9yk=; b=TPjONd6qZXF6LE8U1RT/RdN+3rPKWMzUT6xfuukbe6WJBP83bWwO7I3Bv/OPevwgTO eGDL8W1U3n+a/4STWSSwnGvqSmEGK8OyjBAo2OgqSNT977941oF7qGrhn/cteQl+KxG5 G6bY+UOg+Te0TcEzjnbuEDoI65Cu/mzQY3GfGW9oHxD6f4NZ1UVFAotBqydjBzpvtGBE e9EUAKtfc/hUqyG61FmyIKLoyT2h4r/GINwSsyoN9taZsZ0L4tqUy0lF6hS5S8dez8OL eA0uesZ+5R4G7/O+0NUYOPmgrwzIe3yO1mBC1LxcUZqVH0shLamaPMnj/u2N8slpzxKF lQcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705597419; x=1706202219; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I307JXW0PD3nSS/XpS3TGtlMDXTLZF0yfATueCQN9yk=; b=GBinefm7bvNlklfu7CanyAxG+3BHId4ci3v8g2Fd4KvyHaDbnzPlqvyF0eEp20DEaL jGN8G5KbbBFh6jCECKYLmb419Rs+UovCMG6ouiIraoTbWpfp4/7dA2CNhh7wqclk2AJ3 nT3yofMfEz6/oiilmLIoGJm5xVCJsXbjzQhAhIoqBRWfLYfdeuUzln0CvYWtW7FapaBf JQxJCOUBHaSsJhoOmtQqKfYn7ieiusHxOIQcpXZnIiSGLFZAfUor8C3+kNvOkVONWymv mtOFaepPyEVSGTt8KE5YYmQH3ArD4+T5RtanvJNU9i2tJnKQZuIL8ypKqbg1TL9e+HGS XqyQ== X-Gm-Message-State: AOJu0YzVmZizPrGBDFAI8kFL36dK3n+EeoHMzmR8NBA4xGxSKppf7IYf o4BogpIR58xv0qZArea0a7XoqT0pkLPwVUvFOWw8k+fDwS8v9RXWPtTlMEsLr+UXiX599jMGIQF VnqDu4TmWr8V5Zcx+uIe+9hJh3AQ94fZvfPgz X-Google-Smtp-Source: AGHT+IHuKD7maC0nGcnATuuHa2w9rlSgs1J23fq1aMgrTRCopXT2ixM6PjBqomxuPr8I6ScWM/QfYuNvRMXHzYokJDI= X-Received: by 2002:a17:906:ca41:b0:a2e:d88b:53ae with SMTP id jx1-20020a170906ca4100b00a2ed88b53aemr674261ejb.129.1705597419020; Thu, 18 Jan 2024 09:03:39 -0800 (PST) MIME-Version: 1.0 References: <20240116133145.12454-1-debug.penguin32@gmail.com> <20240118161601.GJ939255@cmpxchg.org> <20240118164839.GK939255@cmpxchg.org> In-Reply-To: <20240118164839.GK939255@cmpxchg.org> From: Yosry Ahmed Date: Thu, 18 Jan 2024 09:03:03 -0800 Message-ID: Subject: Re: [PATCH] mm/zswap: Improve with alloc_workqueue() call To: Johannes Weiner Cc: Nhat Pham , Ronald Monthero , sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, akpm@linux-foundation.org, chrisl@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 09DED18003E X-Stat-Signature: t4gwtyorupxs7fdohrqk4x886gznpxwc X-HE-Tag: 1705597420-574375 X-HE-Meta: U2FsdGVkX1/XcyTWLZya5c742cE3BYC+ISDSKLExS0F711xdps0mo6soihezL9WzPFD++jVvncSTnzIB1oU+s0o73/vNkyjXSlRb4Z0Kz8L6lJKw9KG8kjJ2XPj9qnmMXXXw0d+AzQ3QO566q3BAP3lOO6axAYItcl7ZO0riJtEeFa/twCL5BhNAWvDV4/mwacYvwVEDQDe46hklQt85u2NPPy6ClckA7Kav2IlIAVkGM0JmeXvNQYI5Dy5C3hE8CTQ9ycG5CmVqRo9qrfU/PebJuJG1Y8IMEw53621CsuW2bcgKvs82Ilhc4+ixJ3vLRYPbDQaXdV2JZPFxvDEKZ8xCS8OjkBEgStwYCzh64vMo3pQRWuisxTX/KgSyNTQl+rJR9xdFcYWCxUFKcDwT3u+IQwBKUs+j7iOBBwkROj+j2X8tu1dy/LVntohgKfT9uhwQ166rjUJ3OQWmMNE+ZU5h0E5Jm2TZBdvO7i+CiEeWjbUQuErqWGDFgM+kVVi+n3vj4kSgDw8t0/196yb9gkUjRtkreczjkbRpVAHPI6CrJGDj+c3UMbAvGc8zP0M3fzq76iBa67gNMrkGtJLRnqynGECRX0ZA+qxYyG+WFOiYCe4+SbdX+5rsiHyOwD02GDdZpYTXLG0zPZQAP7q5yoN3Dly/IfSDSeHL1dvfSJKxnFFvQHNC6lOhXs90XM9GTZmeFQ8BX2o572okGbiu0ziVVy7N8gJPJ3GwXFf1CcPSXruZWkSW5YH6w1LMQSs+HYdu1zlai3JAmmAL46j9GHkAOE/Lpam1MyG3udqjNAhS9ajc7DTtXgGz61kJTk5OlxJliIsjcDDUt2G6WFv97wBIm9D0KAAIWexV4XHMHw12ZtQljwh27L6MU8KC+ytFOHIRBmcKzK1wEEf1N13xnC9unkaKCW6IWav60SxlSYByjuTwXUFYYXOpKRwiNe9XG0iCjyl5iTE23KITZPu MFbudth2 zYdUaaL6QsdFBe6vxkftozOgs8MuHR23cPu2OaTW1t7d/lgy+VNcYjYc9nX3plZd2i025103M0njiWat4c99V0u+kE457SOfaupOusjOrl01NzEVWgAigeQRNT1+jNGJWhkO0Hm/aTuRGU0KsLzGdv5izrGaCjFMGBbVGIvOH7mPVe9ajEQAfyCbhwOJI5p6MN77DvNme6bA8GfZvi9s2YFgbbGNy9gYQKWNiEgBv4TNRmRdu7s90jGYbOX3ZlO3wF65W4DlPpek2VY64Bmu/cmGzh1sEiyhHIEiCYnMWnwiX4Dv1frvb+0Gn9pcAAOTdybfuXqyQPV6+LasTgt5hJFB0rqca/P98NDoyon1Y1MfzpAX88QhNFOY2Nq3/2kLQGqvgTdODnXJBQfPp1m7I1aidDw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 18, 2024 at 8:48=E2=80=AFAM Johannes Weiner wrote: > > On Thu, Jan 18, 2024 at 11:16:08AM -0500, Johannes Weiner wrote: > > > > On Tue, Jan 16, 2024 at 5:32=E2=80=AFAM Ronald Monthero > > > > > @@ -1620,7 +1620,8 @@ static int zswap_setup(void) > > > > > zswap_enabled =3D false; > > > > > } > > > > > > > > > > - shrink_wq =3D create_workqueue("zswap-shrink"); > > > > > + shrink_wq =3D alloc_workqueue("zswap-shrink", > > > > > + WQ_UNBOUND|WQ_MEM_RECLAIM, 1); > > > What could make a difference though is the increased concurrency by > > switching max_active from 1 to 0. This could cause a higher rate of > > shrinker runs, which might increase lock contention and reclaim > > volume. That part would be good to double check with the shrinker > > benchmarks. > > Nevermind, I clearly can't read. Regardless of max_active, we only have one shrink_work per zswap pool, and we can only have one instance of the work running at any time, right? > > Could still be worthwhile testing with the default 0, but it's not a > concern in the patch as-is. > > Acked-by: Johannes Weiner >