From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 486B7C77B71 for ; Fri, 14 Apr 2023 23:12:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 896E16B0072; Fri, 14 Apr 2023 19:12:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 820466B0075; Fri, 14 Apr 2023 19:12:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C14A900002; Fri, 14 Apr 2023 19:12:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5AFEC6B0072 for ; Fri, 14 Apr 2023 19:12:22 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 21959A0452 for ; Fri, 14 Apr 2023 23:12:22 +0000 (UTC) X-FDA: 80681547324.16.B057888 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf05.hostedemail.com (Postfix) with ESMTP id 49AB610000C for ; Fri, 14 Apr 2023 23:12:20 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=rqz6hoGl; spf=pass (imf05.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681513940; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rQD1oso+8ADTrmZywcy5/ZWb5KiX0kq22/9gdYr2fT0=; b=DFAkFy1n7RGtApL4c8L0L+n/8twtZlLzTFjRVNUl25FZwePgCFeX71ITjFMU4IA1J+iPGe 7UxesjBAqewyKu/Xhkg0/UkWtq2erCUu/hfolhih+TAUEtVMVI4OS3NUWQxenheMknCjfi M24kokj/lBHo8J+Tjj8MC1tIwSEOCR4= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=rqz6hoGl; spf=pass (imf05.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681513940; a=rsa-sha256; cv=none; b=48uglJM7769jUjHFtTb2ruVY5J2JV3kgfSk3XorGfK4bcJyYC75fEG1mYBqI138OE3wv/+ BJBOB9byDB6WTSFARRDGThszJwIh3eyGmc///B3mecYiyGZoy+Onr/PJtjZ35pBNxPpSrh 98ftWAB5G1MT5gd0AL9wRDni/ddhBdg= Received: by mail-ej1-f41.google.com with SMTP id dx24so5396320ejb.11 for ; Fri, 14 Apr 2023 16:12:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1681513939; x=1684105939; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rQD1oso+8ADTrmZywcy5/ZWb5KiX0kq22/9gdYr2fT0=; b=rqz6hoGlruHKPc5t2bxSsCjJ0q8fLUfCjDlhl4Z5UjfIBNLVoqdHRwpUspz3jYAZNl f2vofoEu2tP1aZLwxjiF8wqjCmLPyk2fhSgT6bIqpEi5T7lKgWxLmMIvDyPKYYPdytt4 0nzGQ667jAg9GOBlcF6dDnqE+apDZpaXthStELBKtqOKxcyoTD2j9OXN3rWM9uHm2XUe N1V7S4e4JntnuWAJxmosdJjiIoC0YQPvFtLV84JtHYBi/kBrs4jYzueDnngMYASwCDZy WtYQLvayq7pTuprvd4phPV8N3kXKSN0VwNR/SuNsTRnEjL4i8iN6/xkGqGgGY6QAAvn2 cSJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681513939; x=1684105939; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rQD1oso+8ADTrmZywcy5/ZWb5KiX0kq22/9gdYr2fT0=; b=AEMajUMgYdLZQRozUklWSdIxnh4kSqGKtIKenfAdRBsDKJ2y6phGmLDhnoFoam1dO5 CLI2nS0JRqn8wPx7Ib48uam699D433FppN37Wl16tVgJfymnV7HxcIzWLSj9ERUB7B+4 N63nmhfppcMaRWPOJwmsox7syxxevbJ2nMWVoygAtpfahbQLzXa38duAOaW6O3IRyO7X 6d9/RqmQF3phPzppwmiC7giDokqYQ2RqD14spIzBSgeCkVPUOBVe2hZxeqJ/ElJKRqJj iRLALcIW+lzARVmPTcJa+XjDPDumNTy9w4x7+cDLTSZYzkmtEx5iRoTpxmIChJekQ3qT c9Mw== X-Gm-Message-State: AAQBX9dlZMbWCVXQP/py9eU2IdQd2Of+YLnOP4PLSQo7iPk4NUPD+RMD fqRHrH/fT+Eb18ct+xZ/tUszNvgw1r0vtjii/rv2HQ== X-Google-Smtp-Source: AKy350ZVW/SeKKN7bQaip/vQ/ZivEBvqqS/RV2NR13bc/DeeXMLJdi7ZYfPWAWzE33zqe1KsI8fspxB3C5u2WkZCZxI= X-Received: by 2002:a17:906:4c49:b0:94b:d619:e773 with SMTP id d9-20020a1709064c4900b0094bd619e773mr320456ejw.15.1681513938572; Fri, 14 Apr 2023 16:12:18 -0700 (PDT) MIME-Version: 1.0 References: <20230413104034.1086717-1-yosryahmed@google.com> <20230413104034.1086717-4-yosryahmed@google.com> <20230413210051.GO3223426@dread.disaster.area> <20230414144704.2e411d40887c8e9e25ab2864@linux-foundation.org> In-Reply-To: <20230414144704.2e411d40887c8e9e25ab2864@linux-foundation.org> From: Yosry Ahmed Date: Fri, 14 Apr 2023 16:11:42 -0700 Message-ID: Subject: Re: [PATCH v6 3/3] mm: vmscan: refactor updating current->reclaim_state To: Andrew Morton Cc: Dave Chinner , David Hildenbrand , Alexander Viro , "Darrick J. Wong" , Christoph Lameter , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Matthew Wilcox (Oracle)" , Miaohe Lin , Johannes Weiner , Peter Xu , NeilBrown , Shakeel Butt , Michal Hocko , Yu Zhao , Tim Chen , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 49AB610000C X-Stat-Signature: jo4jbykea6guz5kt6qoxf1iy96qbkztr X-Rspam-User: X-HE-Tag: 1681513940-695626 X-HE-Meta: U2FsdGVkX1+N2F9++k0S8goWTBnQBXJIFIFiw1NNAbIdNo1qg1td3txkX8k61zAmvHYsOabgZoRLAvtCB3AkBpd9Acs3w6KD9jF4wFgeiHye7LgbgvxU8KOe4tX/LP4uEyAemjbr3XbAstlbj/sNcHtwW/6Wr6kbDkAcm6nwoe14tBm7UR5UOifUkNa1wVRZ9s/MJOGclZ+3VW9e4BLsGajBLsMgG+nCgUVym58OF4LBkfW0nSlnE++g3uaZlgIbnaPI8uLMczXI+LmO1EDGF7kudEBPr5Bg3z1bK6m4Kmp/HRzWpIJ/Tihoe/trBI7JizPlcl7/Lh+Jrdu+nA44Ww3QtL877jkvjjA7cYoMvaUpn5pyccV25i0bVgyAHs80nasYbfjSGL7iT1TkgeWaPpTnLScpZyMRUr7pIFeFX7w8VbyGqTUsIoTCQsjmt317FCISXf+eC6Fr2MThUaUG5GbBVDnt6S0AEa0L3cfLkc9noYE/getpFk6LStc2ftfbIj2U4bL1Zr/Rc1JA0nbc4E8O4rdTzXGPAxOEs03kmUjKnj7gKMbmDaYIsrGOxPsWAe6VWywjJv9mNlqA0jchTsf+xH5zCoFZ3ynLu5x27VSpBJ1g3q6Jy1CL1UJpGMTpntpZhDr2agATlr7eKfNf99ActuaLbd4Nu+xQVaBWKhJO4oqtdF6Gvl/IlKVntKWx9tqIIhgwpT8S4Ma3LH2UT8Ms9fAsl0w6fGvqE8KygfIc062fn6fFGQW2SpTeZ1t0oYplTxj/eFtJoxmbLusPWmcokjlFb3Fi9LG7x9dzOxdfbMk3mKe0fVN5cYc971fOQ0jyiJilfOGt4vP8HxP29vy6BBvUoNAdiv5JMFI7Go2fQz+3FywCQ8E1FHgayd0X4T4LMObxpl+o4trF5TvhgPGk0UNAR3QRu/qbHdcde3AaWnsgpVCVkXn9/K7+cUCkIh8XaFhT3oMmJxszfK8 PIL8tgKy beF+PQ+Vt+GNJisESd4jlHsDYuPoGjWhNDYxsfkta7Vc2tOYZKFWrJnx62ZN++bvFDMTwRpEZl5jsc6ElfvIV+/jZNyYp8oWPPy90D+jjSWbQEQe7iSabCgeSHtLH+xGbtB0ed+tpucUpdL6ltAu0JkWS1fyCqKCsTiNCDSmKAWuncNayBz/T55gRy/yvvEGnWYcC3Kt60nRyuYlb5oICTo7vnsWzkWJHWXD7Cf95gGF+2+2gmGZgBynIiP5XWtPtGffi6pD89wdrYi8nElbT6UjC6chj3qnN1LiH6ML8x/OP6G+fNK35MD8JjFE3zgy7eEDVscE/7XiHRSl7QD/r/PDar5a+eFAdsOxu4mzaGvn/3hxDK0nCpRbQ4g2KahXKpxVcFvMZAmo2KtbH2pETofH6cELXvxLY0RIopF9uWvdSYoeHEVpHXo09Pfohg36UINsr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 14, 2023 at 2:47=E2=80=AFPM Andrew Morton wrote: > > On Thu, 13 Apr 2023 14:38:03 -0700 Yosry Ahmed wr= ote: > > > > > I suck at naming things. If you think "reclaimed_non_lru" is better= , > > > > then we can do that. FWIW mm_account_reclaimed_pages() was taken fr= om > > > > a suggestion from Dave Chinner. My initial version had a terrible > > > > name: report_freed_pages(), so I am happy with whatever you see fit= . > > > > > > > > Should I re-spin for this or can we change it in place? > > > > > > I don't care for the noise all the bikeshed painting has generated > > > for a simple change like this. If it's a fix for a bug, and the > > > naming is good enough, just merge it already, ok? > > > > Sorry for all the noise. I think this version is in good enough shape. > > > > Andrew, could you please replace v4 with this v6 without patch 2 as > > multiple people pointed out that it is unneeded? Sorry for the hassle. > > I like patch 2! > > mm.git presently has the v6 series. All of it ;) Thanks Andrew :)