From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CCF6CF6494 for ; Sat, 28 Sep 2024 02:29:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9210F6B0174; Fri, 27 Sep 2024 22:29:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D0976B0175; Fri, 27 Sep 2024 22:29:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 799196B0176; Fri, 27 Sep 2024 22:29:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5A11C6B0174 for ; Fri, 27 Sep 2024 22:29:48 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0497C160F4E for ; Sat, 28 Sep 2024 02:29:47 +0000 (UTC) X-FDA: 82612566456.29.DD7D344 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf28.hostedemail.com (Postfix) with ESMTP id 3505AC0007 for ; Sat, 28 Sep 2024 02:29:46 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=JiQb7c1Y; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727490495; a=rsa-sha256; cv=none; b=B7PAsPxELswCukYUOhyitF/z8dKrsAO2Ke0UPQFavaWf9/OjhC/EhqMie4oyfI8oMritAJ wlnmjqC7xDpijKeGQeg0l+NPFXyMQE5j9iFeOzAPSxOU2eppezVNwZy+E5WesQkTwMNWyw AnFFaVbQvHSvG5wHOrqrCC/dCoDFc2o= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=JiQb7c1Y; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727490495; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hLvTzJd1/fYfqRazDuQvbjfT4R459nXI36EJOkl5TP8=; b=u2QAddEzKbEdNM3UVJ/2ZJNAa+0YenDb/BP8/fAXUHDj+ulwJC6e6fO3+vQS8b4IwaAIGu 9l0C/cD1KChn6U7J14OdNEgYD/MeoQUl5uWiywVNJKFvP89DArBlmcgAfjwV2RXrFB7iY2 nHZSMEwK4pNJ2DI209uOp5T0XJ4r1No= Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a8ce5db8668so433213066b.1 for ; Fri, 27 Sep 2024 19:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1727490585; x=1728095385; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hLvTzJd1/fYfqRazDuQvbjfT4R459nXI36EJOkl5TP8=; b=JiQb7c1Yp3C3nUV1lLgqiHcuTPSBFitIZhQghCu1SCJanCErot0LwQxjVmrGoQArbY fcmQ3YsTNgbJjlPR2y5cHjPdCJrsiHOiEhjiiLj6FgrQ3Wz5EBkIV3LcKa1CezZhiwUs 3HYrU5NLEUoVoE27sl7BPv0CVgRv/r+4LJp0IfzelQGLi+iOz30Yp2ZkYZ23J2He6Rx+ R6Qc5gPC43NnRkQfnxgf/B9ZEspfmQUBjKHQs8uJA1OVKF6g5ZMKDBPhu1WhRD2794ax kq5LpiO5BEb0mSXQ36tADMHGIkGFSeF3VqHDhJc84cHjqEgUiHstuOTPNhErzUpHGB77 2FfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727490585; x=1728095385; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hLvTzJd1/fYfqRazDuQvbjfT4R459nXI36EJOkl5TP8=; b=fA1+NIo4GDwrl7kS9TGq0iQWTAxW31MryM5eh/ZKV5mAq2h1ofUt478Gg4P2k8Rhh8 dcuKXwitYySUrOPBQ79faY2gHisEPmQaMayqMk28677bucYEdQp68ZvO1ukvdzqskhl5 4ONqCxsJ5xB4hpEoBRKe2+nQYr5S6lVUgiBDI/C3rh6oPWJFunbzKlANwlUqIJ5ZadWN D+vA/jfpM5DZs56iwevUmCqvTLIRz8dPAkth0c5kqmTQr7TUtE0m+NrIqOWFZ7i/XtQ6 IPAOXInyGC8wwELuaiEN/w+rntNyL429PC3ttgWuatsyf2Rf15iu+jm4RmszY9iCjnUE QruA== X-Forwarded-Encrypted: i=1; AJvYcCWnBL6Cbc5fflXYFGy/20lSK+0K20x5QooU1doo9+z5L5xDSFVvdFP9stXo5+ts8roVTjYK3k3X3A==@kvack.org X-Gm-Message-State: AOJu0Yym+INcQBgZEo4Q3Ti/tgxVzH/jDzEWFilOXYGO2LnSXODEczXB gGm0lDVGMyzEpbW1ncIHlzgR1RROgTgGy83POyuGv2PGjWSOLvHO4qYI/TAuk/DZMwn/zFQx1fi Ej3TRrLhKnUijdHe4K7CyLxJcqjidZkIPKWae X-Google-Smtp-Source: AGHT+IE7qLTp1kd4j7cINYu1fPxZ1tWTYsqwTgD5igF/GycFheEqf1NsDQfaIRIVmD7nq1gIklzAX2R8DBEnLV0O1yo= X-Received: by 2002:a17:907:6d1a:b0:a86:a41c:29b with SMTP id a640c23a62f3a-a93c48e80bdmr503811166b.8.1727490584553; Fri, 27 Sep 2024 19:29:44 -0700 (PDT) MIME-Version: 1.0 References: <20240928021620.8369-1-kanchana.p.sridhar@intel.com> <20240928021620.8369-4-kanchana.p.sridhar@intel.com> In-Reply-To: <20240928021620.8369-4-kanchana.p.sridhar@intel.com> From: Yosry Ahmed Date: Fri, 27 Sep 2024 19:29:07 -0700 Message-ID: Subject: Re: [PATCH v8 3/8] mm: zswap: Rename zswap_pool_get() to zswap_pool_tryget(). To: Kanchana P Sridhar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, shakeel.butt@linux.dev, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, akpm@linux-foundation.org, nanhai.zou@intel.com, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 3505AC0007 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 4rre59z8b9uju91ga68ns6stjky59hsa X-HE-Tag: 1727490586-803239 X-HE-Meta: U2FsdGVkX195XPvvIfsNftukhSVge3AGUgwXoFSeDq8QJaFPAvKK9ncw3w6YIUP5C4U20MUN8lyGG2w0rIsr6+t1Z6vDtTLfHcUOCdkMqahuUc9MvgfL3XL69d2h0NxAiwi6oJEIS2aD8iQwzwXA9om8RlWxcvKc+VOnULgPTrwpl23/edUSwpyPshoBvh0qYdwvNEvzUjmKtn4tIdsh1KqHGsUyYBWt0fiGRjz3Nb8BwCeOVlbqbMkidGwq70GEaiNl7aJEvu9aXMKjnsW6liVeHt+VboyiQ1Ei+lx1VyuyyJEPIpYUuG8JQmpmoKLUvjhIFw2ASnbPNuD+34GYf1i/vRo2y57fiNgoVt4JYkZNg02XzFHPCAYGi+h4IoQeAmlaL8YHxA9JRp7WEgnrsv96RuYgYOrSfSsL/uxWW0OO+XTC4bWhGYFkVTgzDQObeuMe3CpbDCtLmLR0AtkCLOeEoLItwg19acutWr33ySMdHo3Mwj+vcpijdmiGHtsuCafU/S1yhxUs5CFHM7wthnMcLvrEBZhnPntsB1ySGmqZaxughUG68e86jmNeQarWlFb+urA06mGDlXPonqiDjLoLoKDP4+6PGcTBcZaICL8T6Lh2ge2eSgKQy/j+2Lq4DIBKLPvs3Er7o2r0wjADko1zjK6b+63ycx98IaRRK7UoaEG/QAZAdPVVDN0CW/t18qjnwUOjFMA9hpM2+IssrZXaVIjr3HiOPCywu/HoBXoFeEPXdsgLiIBzU3Qc+IMmRkl7fSVt7jD3uIVLR1I7T506a10cbZcRHMnCxRlbGQ7aoynTRUghpYv0SGj5LfieO++KhHfjUb4wJ7nGE8iNcAHidoeOpDaTjTj8jdB/jeTqHuryaOb6nIUjTwDTD/g1ZHLUIBpz9pH7QWiwm2LmbHEFmdOjqsqwS38jvvIs1Oru5vDonqa/EjOnxJcetE5jeX9EGYOsMIClEcmenET 8W8ewUTt D7ERgPQClBToLkJ1Ko0x50ZimHvwS0n805fzrGh5dKRPhOkFOuSGTQ5uBIRyD3YLKf/P3/yCtJgTqexFpojyi9BgS03lS0hV9djtquyW0t597P7Ozy9XqePtpJ4DQ+jeY56fFts9xSqc8vIwd5tVdSHzvVROcPolglpaFvPmtkhAXDdscoumAJHTc7wuEiKCR6NY4REaG4pYBNS6mNik3yeScrwIoejmr0SYxWrY82p/R6puAIeS2P5ulpuMqqf4Unti+jQiQFKDznoCy91V8Elbr8uVH3yvv5528 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Sep 27, 2024 at 7:16=E2=80=AFPM Kanchana P Sridhar wrote: > > Modify the name of the existing zswap_pool_get() to zswap_pool_tryget() > to be representative of the call it makes to percpu_ref_tryget(). > A subsequent patch will introduce a new zswap_pool_get() that calls > percpu_ref_get(). > > The intent behind this change is for higher level zswap API such as > zswap_store() to call zswap_pool_tryget() to check upfront if the pool's > refcount is "0" (which means it could be getting destroyed) and to handle > this as an error condition. zswap_store() would proceed only if > zswap_pool_tryget() returns success, and any additional pool refcounts th= at > need to be obtained for compressing sub-pages in a large folio could simp= ly > call zswap_pool_get(). > > Signed-off-by: Kanchana P Sridhar Acked-by: Yosry Ahmed > --- > mm/zswap.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index fd7a8c14457a..0f281e50a034 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -403,7 +403,7 @@ static void __zswap_pool_empty(struct percpu_ref *ref= ) > spin_unlock_bh(&zswap_pools_lock); > } > > -static int __must_check zswap_pool_get(struct zswap_pool *pool) > +static int __must_check zswap_pool_tryget(struct zswap_pool *pool) > { > if (!pool) > return 0; > @@ -441,7 +441,7 @@ static struct zswap_pool *zswap_pool_current_get(void= ) > rcu_read_lock(); > > pool =3D __zswap_pool_current(); > - if (!zswap_pool_get(pool)) > + if (!zswap_pool_tryget(pool)) > pool =3D NULL; > > rcu_read_unlock(); > @@ -462,7 +462,7 @@ static struct zswap_pool *zswap_pool_find_get(char *t= ype, char *compressor) > if (strcmp(zpool_get_type(pool->zpool), type)) > continue; > /* if we can't get it, it's about to be destroyed */ > - if (!zswap_pool_get(pool)) > + if (!zswap_pool_tryget(pool)) > continue; > return pool; > } > -- > 2.27.0 >