From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC626C77B60 for ; Fri, 28 Apr 2023 13:05:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0187E6B0071; Fri, 28 Apr 2023 09:05:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE21D6B0072; Fri, 28 Apr 2023 09:05:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D83906B0078; Fri, 28 Apr 2023 09:05:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C16B06B0071 for ; Fri, 28 Apr 2023 09:05:56 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 79B6C40193 for ; Fri, 28 Apr 2023 13:05:56 +0000 (UTC) X-FDA: 80730822312.24.269207A Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf04.hostedemail.com (Postfix) with ESMTP id D544540021 for ; Fri, 28 Apr 2023 13:05:52 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=EBoAejzw; spf=pass (imf04.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682687153; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oQwjJ+xoYNglHrNfrRoLJyEfjXE+BHOsMRCb4QaEt/g=; b=bVh6PCryCgRs+3gKUhZjZK5mT+luEDQ6eDmNQ4XGR0dtbJjMEeWk2JPMAlXXjJ2Wyloz7c tIwZPYGl9OSxLr8ghtCVxyIrmwLlFzgC5TXJArPjbulIOZnOumFOLdjg9TJd0MrgLP3gRb NRaTsIPtziAxiaYLgPb3PkucLMLeDqE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=EBoAejzw; spf=pass (imf04.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682687153; a=rsa-sha256; cv=none; b=WZiO8Kj5lwDKMzXQKNUF4H7rl38AxtMNVSjESyFkIcYqLURg1d5gzwvHQRp1RCcJ6U99e2 z168gHPwNFpVph9+rWumJy9syq3UeVv0jCb6I+yqIiE34lRYHf7CX5XwjtBwlMOgGl+ypt 9QtNTZv5GSehpfty7Vz74uYiIe4DMVk= Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-95f4c5cb755so624273466b.0 for ; Fri, 28 Apr 2023 06:05:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682687151; x=1685279151; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oQwjJ+xoYNglHrNfrRoLJyEfjXE+BHOsMRCb4QaEt/g=; b=EBoAejzwbTBADNp4pMEUIYW1v6E60NZGOyGiIHIIH7vNiwcU0E7lyoZfCG6RImKtmC j6fL6h5wjwiZ9e0OL2cB8QRZ6rXObXCtLg44xFci+vz4TpqyvvTeApbKgE+spgGCeXXe PGYqgRzsQ2B4DN+Xfr9MAvKm4PaTJk6FWKLJDSHBRjJmvoaOSm7BijKvp56/DpJHhAm/ LhGWTCmWWzMDMRSkoZhB0AMKWOqvDgQkNSdttAvx+QEanXzXoFcWZ/8iylKiNS/LuI9G mdoG+F329veZDK2/AHXVUEqTjRyr2moo9MvG2Rn3oOe2sh6y38Vx+SHqHCLkkE4Eutuu 7ieA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682687151; x=1685279151; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oQwjJ+xoYNglHrNfrRoLJyEfjXE+BHOsMRCb4QaEt/g=; b=hMpgxv/DIF6AbxAPCTmMQnmSN9lhIqTzECHcVXik7tVT3u1EyuzQ+q1OGE7/Py8FfJ ooLI9kamsxDLLs8XiZRFX71gvNnW9Wy5cxdkE2E3s0SzxWmyywf16giEWb4l+UmkVMjB 9d81IKydg3e+O+DzNS80+aFUlKTR77F/Vr7gmCtADLxkMvOVQv0OhThYm/0QiOl8dFul ramLfT/PI0+fj9IpF06phrv6qxW24PXhLzbjY6Dz0nw8T+hiiLt0T5hQe8tmB9Ba51mn YHktstbDhUxMyU+7nDD7jjfQGpkbS/EzryCX0Sl687FbalLFmKmFcFZaObMDiajVAGcW jO2g== X-Gm-Message-State: AC+VfDyCwGY0iRkmPtjQ2Ilzw/e4SVgeSwqI8ab9PGk5EJ3rUMXsVlv5 LWr1ksZJJHVSBfEd7ElbiXdOiSZriwYUwf2uaFjDHQ== X-Google-Smtp-Source: ACHHUZ4r5TWSqC3HWv9cq3pAKjRH8mGLSn4q32vcFG75oMkzb37AVhcCttrizjvzVWMZc8n8LhWpr9DTBmrz7YuxSvU= X-Received: by 2002:a17:907:629b:b0:95e:e0fa:f724 with SMTP id nd27-20020a170907629b00b0095ee0faf724mr5579644ejc.39.1682687151086; Fri, 28 Apr 2023 06:05:51 -0700 (PDT) MIME-Version: 1.0 References: <20230426133919.1342942-1-yosryahmed@google.com> <20230426133919.1342942-3-yosryahmed@google.com> In-Reply-To: From: Yosry Ahmed Date: Fri, 28 Apr 2023 06:05:12 -0700 Message-ID: Subject: Re: [PATCH 2/2] memcg: dump memory.stat during cgroup OOM for v1 To: Michal Hocko Cc: Johannes Weiner , Roman Gushchin , Shakeel Butt , Andrew Morton , Muchun Song , Sergey Senozhatsky , Steven Rostedt , Petr Mladek , Chris Li , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 47ijr74bo811ca47tzzaixpfn84spqff X-Rspam-User: X-Rspamd-Queue-Id: D544540021 X-Rspamd-Server: rspam06 X-HE-Tag: 1682687152-995925 X-HE-Meta: U2FsdGVkX1+HWRHo7AiB156WkzV0Km++p80kPcihPy9qAeq79o0rBBWzo8ED5N/NhPSuOF7HLJNnogNSpTWyc9kJ/L/N00R4QQFDbR13q6Jib6R3sgOJbwnOt10qdjukl5B9tOLSS/C33RhoNzA/52vJECEqbUTE2hHA6QcmO2Y/i/L893oJeLqyScRksHMfrnFip61LJrBvGqxeF/WNzso2EZ83DEyMoTkUl0hXPjl6/31htczEnigUSBrY28gi/viPZ7XIam2lva93SnSOe9VSOdM98o/bGMk88+9iZ298qPiGU67qz7NLABJ/M5ZyVI/5B9IJagbJ0NkDG7B19ZfLk5YMYcAOTvtOEZ0l7DBSjqFMHbKS3AV1koy1VHY1bxx3iTJ/9iBhREi0Cfz0V5xZ2+xRbFlwJwp7UjUTMPyp18eQSnB8obqfcNiMLZ3tzttinTru/hn9CeJVpyq4VFaB9PGVR0+H+zo26UjoTtxpYKLHDAfu0y///3FRoLtxTk+C/DDUzJjF4agBHVfBtM9avXPOxK665XyaNDG7JEBRFyvxYWfuinbEThh/5uxL+oNzaubPIPZhAmlg+UOckvjd5ucgDMWIqo+9m8pJKuuJv1tBgMGolI65kW3/c8vMEFtGVOILY5c+QPjqONXqMpsGSajxDSyh3AJ0qGud0WEYy4fvxJG64zcBIz97ggK8Uxma321gCuVUpUvQi5QSSHzu9HlU0fjbfzgC2tvZCUS5VBno/+yQsEkWjlzwrpon29cHuoEwwsbuVA8b1/x2hx7PjaHIilxtgO/N8SMqQ257kp6dUHn7QDUVeqHoSCjvX3KZdSDZMf+NKBPilwDJQiLAVHyaTEof11CipLAld1uf2xW26w8v7vQ/0ymoP+N8tLRUZT5zhQwNjwnfWdexrYaHCudHF/x/nafce2utK/k1E2M3VDl/xvVH8TuZlfy7mL0ePPTZUOOwVKOyoSu gwbpGeL7 wh4h/vxqfn1fI5knRRFjqOjlSNsLTt0ziPx5y/dv4CnjTgxNtepE7nxBGpe/MBNt7C4u5QQC43AtuDRQBWVt/+a+j9H1nhfF5Cbk0oRnZqxNIF08Oge8HwEIP67EIvYL0vYjKzPUoJFuLH45apndpZuCbXABsCLiUp/D/hlBgEnyC2MjJbWYoIlQMJHJhH8NOlpqqY8voxUJ8H20NzFHbU48rX4+AZCGrVc/jUaRt5Tojhg+C9vkiq6buM8RI9HD1Duh/8FXq22lDHUaDyRW0gYWGSrRmv25AoMoL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 28, 2023 at 2:44=E2=80=AFAM Michal Hocko wrot= e: > > On Thu 27-04-23 15:12:46, Yosry Ahmed wrote: > [...] > > However, I still think this change is valuable. Like you mentioned, > > the OOM log is not set in stone, but we shouldn't just change it for > > no reason. In this case, for cgroup v1 users, the OOM log changed for > > no reason beyond a side effect of another patch. Upon upgrading our > > kernel we noticed the behavior change. This patch restores the old > > behavior without any cost really, and it makes the code a tiny bit > > more consistent. > > Fair enough. Just make sure you go into more details about why this is > causing problems/inconveniences. I am slightly worried this might cause > problems to other people who would like to have the same report for both > v1 and v2 so we should at least have some solid argumetns to revert > rather than "it used has changed and we liked it more that way". > > I personally do not care all that much. It kinda sucks to dump counters > that are not tracked or fully tracked in v1 because that can mislead > people and that would be a bigger problem from my POV. Great point, let me send a v2 rephrasing the commit log of this patch and adding the Ack's on the first one. Thanks Michal! > -- > Michal Hocko > SUSE Labs