From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FAD8EE57DF for ; Mon, 11 Sep 2023 18:19:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A65F76B02D2; Mon, 11 Sep 2023 14:19:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A164E6B02D3; Mon, 11 Sep 2023 14:19:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 905B16B02D4; Mon, 11 Sep 2023 14:19:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 82B0E6B02D2 for ; Mon, 11 Sep 2023 14:19:54 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4E46CA0AEF for ; Mon, 11 Sep 2023 18:19:54 +0000 (UTC) X-FDA: 81225130308.02.15490F4 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf13.hostedemail.com (Postfix) with ESMTP id 7A53220022 for ; Mon, 11 Sep 2023 18:19:52 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=wZN7rbmO; spf=pass (imf13.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694456392; a=rsa-sha256; cv=none; b=FR8VgsW7rteZCbdumokkW2ZgzQdeV0i8/iB9QF2rMSbfFGDhmmMvSGPREGKJd3ejmL6dPf WKS6qatFKXWAPLPx2aizCiRCyF7ft2mU01PYhetxZwOd2lna7meoSvtrVBmu6hV8AMbw3h o473WBIaeMY2Ly6V0bxAKEVzmAe9IGA= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=wZN7rbmO; spf=pass (imf13.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694456392; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d70ufF0cZdjzu8+wQySqcBMfKEaUVdfwSOMtM36noXw=; b=E0VVmYQa4l5eePkUDjgjMuGPjwMGLvXPz0ODq0YRRFrfdzr6GwvJyUkcC9LlUUO0Zr9d7C +Ei6YkrOYwYptCHkLQp137KlhCnsEtWaXB/pyQkRxvLbFMOavuFvgcQ36GJtxJ45NzZ6PQ fUTx0raLPZPyp/ERYRTl+vzLEL5FH80= Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-9ad749473baso79316666b.1 for ; Mon, 11 Sep 2023 11:19:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1694456390; x=1695061190; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=d70ufF0cZdjzu8+wQySqcBMfKEaUVdfwSOMtM36noXw=; b=wZN7rbmOZSO604C3VZMnao12CQ9egcYWJjjr2tB1gT79dYrs+dJElbq9leaU3GpwiE zvtnIzXHzE5hMU+GhydR96TED/mhbzey7gB5mF2e1GWEDW7Hh6d8ifzHh9WcbZdrlM/V 8f1yn+8kUPlTPMggyrAn3FKP1R75Z4TnkNbVOxwmi8/5Vh5r+/XuKNobGv6MxmmixW3x 31Il9iRFMAFgUHrcRigteiGdYKf8A8EFzLPsmAL8uzKt77Q55YUJx/1eeHGUCH+L+Twk fg4DJFZljwKTIChmUg70yU08Iy5k93z7f0TtJBSCbr/53piC52m6lFeyg3gZdt51WWLK jbiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694456390; x=1695061190; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d70ufF0cZdjzu8+wQySqcBMfKEaUVdfwSOMtM36noXw=; b=L6m+yxWRoP/42esbglz55cYWk4qYVWZ/FawzvWRoflZGIYmfr1w6pIK6JJtdi5skkC qe7Vi0GyEIEc+lwRpHIEj+S9cTkq0zljIUMEhxIy2k3F2XZEhoXJ4stC42TAPYqn8Fr4 a9VyAa5KLqQfZicmNZugF9ytW/z74CzQm/GzwPpa0pikTX+5YbfwDTRxKLEDa0Oc7SLL GkrVzQaF/3GMMvMIJMv2e6svXRkzaCRH13RtPZNGeebAO8z9JB47pyrNf/dGs4d5wWI1 e8W6ekXbSqlWWLwYqjkcd/tKT4/2bhS/q/4RNnv3nY7j5sQAMueo4DeWldxRn4ACVDl9 wJRA== X-Gm-Message-State: AOJu0YxI6gGKaBde4hN8z23O+Ib2NjvZHdcZDBxwHqMzc5Xizv3iRhgn WFfh7MXdHRxBuwRS80sdeEivp2msScpitcBq4sNiSg== X-Google-Smtp-Source: AGHT+IG9J7xsG+FP6sYoj3DUy1G4iIcaIxhgbwoUJzMHGmrALj/RSDSp43fnEtymYsvsyde7thnW9d5Z6FTm5Er9e7s= X-Received: by 2002:a17:906:21b:b0:99b:e5c3:2e45 with SMTP id 27-20020a170906021b00b0099be5c32e45mr9843704ejd.28.1694456390494; Mon, 11 Sep 2023 11:19:50 -0700 (PDT) MIME-Version: 1.0 References: <20230908235115.2943486-1-nphamcs@gmail.com> In-Reply-To: <20230908235115.2943486-1-nphamcs@gmail.com> From: Yosry Ahmed Date: Mon, 11 Sep 2023 11:19:11 -0700 Message-ID: Subject: Re: [PATCH] zswap: change zswap's default allocator to zsmalloc To: Nhat Pham Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, cerasuolodomenico@gmail.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7A53220022 X-Stat-Signature: oy9c9nk589jm11ots6dmju7c54kwaq7i X-Rspam-User: X-HE-Tag: 1694456392-243892 X-HE-Meta: U2FsdGVkX196dwhj9wJglwTU5ybmtGCwmakcdeRjjfwBdbeYv0m8JbAovLUxdq2E2K8VV6oyS/XD/mvo2+vHE78o1ue5VMxZlhVz8EayAcPHGayqMs/7VdSggiIClvg54ERoHQgIYbZ52SJ0GiDF2fzuL20wEkPt4mpJRMqQLFTcv80+NAZa7vKRwUtws+a8hNGtj8ZP5y+8Jxq9hs1BS0JHQkZZCjJdW6kv7CLTC/lzm5TiC8CPr9tOrwij6twwpKik7/0bWHUWqnUYGa22Kc/2ECkH9eTRb08ZBuzDGL4ErxduCiRVMzoFODHfQF9cQzsje7pUrxgeaaE2ov4L6mWr4eryRk5NWazxor4djZxpSIlcW2S56B4v420RczNa4SiwcOG6ftdqUwyFxQrJ15t1MIQYI5IcT0uYJvnziJ80rPu4AJ2XKwsshrW0CD2XwVZ277EkxaCXI2K46xnpcSVddYlihdULPOtgEHnSSoUhaEKh162+OIqph/PxV79Y57Jmb4kpq3OvwE+Kfc+3MgRo/zUfWsUHFHP6DMsS//g/LenxF938ZkXo7Pxk9CYrt5I6rkubOlTETRXxmjLgXr7LIxWvbPscp8rrlzYIRrmKVRNfndBgc41Ud1K1S21kAeeXcuiMCV83v1hfRoFtdz9fcdGYneiW0ez9OCL+2gReHvN8yg5Uxcv0jOecXO5/aKPkix0CF5G0wApJDgbdisEfsavHXgrc8Cj38CJ5ckgaTsnl/IlLZ2pyhMnoaYNI/r7hF6+XpE5shOTfFww8awnKEHO0K6tfD0OvveAX8+8/eKOGsCXNlYkBL18muFp5qbd8nst0vE70puoeGJbjGAzvyou1ACiJYgWK6QpHxnjBSYQxkRTbATrnBlk8wwfmL+ygP2//S1hMLUtzZvGlifkccMIt+KusAp9kmceTs2H2CmuvyYJADZVb7xVzx2udCCAMDWWjLFvRjERpDnD bLzLdcl0 qrHdEE3hKWZfuquI33li/hrcCmf/k8dD0J4BAZu4BKpcoCDxVLPetTS28fOfEbMv/N78NBmyPTq60ovPpG1v4DzsAY7tcYdlGy3xGdXmi3F3MjJk/HHY9DlGkE3Z5RnAD9MvTJ533eomf+LswIQkX7f4jVKJ8KD4blbHJ9HRU3+JpnIhvzLjmYf6bZIs9xSpI+JHXt3168WL/wMolDAT/tBu6XwkRINWPBSDkvll28wfZI6eWBy2Br5hJ+QPo9BaAE9/XQRjgCPss8GwAiQrrTGqo+x4LSk+MpMwaLRbkzWhBet3dTP/Dl0/virBWwNffbZJP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 8, 2023 at 4:51=E2=80=AFPM Nhat Pham wrote: > > Out of zswap's 3 allocators, zsmalloc is the clear superior in terms of > memory utilization, both in theory and as observed in practice, with its > high storage density and low internal fragmentation. zsmalloc is also > more actively developed and maintained, since it is the allocator of > choice for zswap for many users, as well as the only allocator for zram. > > A historical objection to the selection of zsmalloc as the default > allocator for zswap is its lack of writeback capability. However, this > has changed, with the zsmalloc writeback patchset, and the subsequent > zswap LRU refactor. With this, there is not a lot of good reasons to > keep zbud, an otherwise inferior allocator, as the default instead of > zswap. > > This patch changes the default allocator to zsmalloc. The only exception > is on settings without MMU, in which case zbud will remain as the > default. > > Signed-off-by: Nhat Pham Acked-by: Yosry Ahmed > --- > mm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/Kconfig b/mm/Kconfig > index 721dc88423c7..e0217deca084 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -130,6 +130,7 @@ config ZSWAP_COMPRESSOR_DEFAULT > choice > prompt "Default allocator" > depends on ZSWAP > + default ZSWAP_ZPOOL_DEFAULT_ZSMALLOC if MMU > default ZSWAP_ZPOOL_DEFAULT_ZBUD > help > Selects the default allocator for the compressed cache for > -- > 2.34.1 >