From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 219BEC64ED6 for ; Tue, 28 Feb 2023 17:25:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A73546B0074; Tue, 28 Feb 2023 12:25:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A22F66B0075; Tue, 28 Feb 2023 12:25:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8EA3B6B0078; Tue, 28 Feb 2023 12:25:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 804466B0074 for ; Tue, 28 Feb 2023 12:25:29 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DF8DF1C6235 for ; Tue, 28 Feb 2023 17:25:28 +0000 (UTC) X-FDA: 80517377136.18.FE0C78F Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf17.hostedemail.com (Postfix) with ESMTP id 1BEDC40017 for ; Tue, 28 Feb 2023 17:25:26 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="Xuo/b4eF"; spf=pass (imf17.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677605127; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Js8P2faLxkFZtl684W9+Zk/L7hGMmiDb7uE5Xjb5HZY=; b=EzeGqRtVQoTPGpbmzWliopXhRsQPcYv20j8gQJjM4hv8k8c9DL89nwonJgtzEJOlwvAy2S NTgvsEewek4/GEw0lEalTRo2zWnvSyqn4QkS4mV4UsECU2iJvURq7TQWOrK0fi1ZeG79eq hBXGN0vLkrFYoNvodNl9uQXxZpjAMi8= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="Xuo/b4eF"; spf=pass (imf17.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677605127; a=rsa-sha256; cv=none; b=ME5VW3CYNdWPKdrhnFaniDRSRp1t2QqQqY1DPhWxGjKTJGvi41k9Of2X/CBvBqzsCayczq Clx60obYkwMpt2Dl2WGEYiEYz6hjWSV16wZtu4p7VgJTHoGMp1LPoQIGLNgoU+BB27VSrp u08bL5ceRZ15nNg+739TLsUiQbC2h60= Received: by mail-ed1-f50.google.com with SMTP id o12so43064353edb.9 for ; Tue, 28 Feb 2023 09:25:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1677605125; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Js8P2faLxkFZtl684W9+Zk/L7hGMmiDb7uE5Xjb5HZY=; b=Xuo/b4eFLa7291if5RahoTmOJm57ffiz2Q3EHeFQHrLaAahb4ojKQhlUzrUugcXRHu c/85qk4NaAU5OAa4A/IBNZy+kAWmp6eo4mEDvwn4thCf4XWWZ0KMP9R2kPxIJPK/uWCw K3fdIRBMeRA/QRgjro1B6JDyvgwwZGwU33tFH3pR7MYf0vAY33NDr8L3w//fTCiajhJ1 ijy2zwJ3qtBE2IaabSdZdzuao8YfsqK7JTOkmsmd6yLXmrjv7AN7PQpvdIvGUQjRWMGt mw/T7bDvD9hW8pa2argxIPZqUv+ypCRHYTWCZXNsEY+AWYdmOVOuNWKElh+ZnwXNuOwf IjRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677605125; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Js8P2faLxkFZtl684W9+Zk/L7hGMmiDb7uE5Xjb5HZY=; b=LBVNjA+IohgBJU0TQCBf/5Fsuvue2ZzdCuuMeC+S7ORNPNywsGk86f+FOP6Wc2sbZ/ k9qPC/mbDLzehKgVsi2W+hjsAlBvozZJYWMLNz3PKguRRdqy9wQCkba3ECPYi/UAyoBd Z+Y+lG6Q40eQ4rQ9T9fvFhnz6JXA/tdKl639pnQQFR6Rk3TQxMRTlu1FVJldSUW6oNiK GQ2A1HcUa8bOKiRUp0WnaWEuw/bM45Ppl9q46IyS+AxR1NRKarbalGH2YYTL06z78a9X kXyAiK/ZappF1Rp5RByjzS7wWITEGcX/5lymTtlaN95qc8ThaaZutSFJV0jmo/MimFDJ w51Q== X-Gm-Message-State: AO0yUKWfD+k15fpK9Gme+IRxlAptnyuwYD3gM5e93yDEfucLcbNIKP1G 5K9Sv0xSfoEawAGrfMo4NBFUt/5+hkM9s+Su33RfPA== X-Google-Smtp-Source: AK7set+ALE9w3m9k0Xwps06/TqXDJjpaj7VbkFBHyWsJrsnH/clUz5tJf15W4k7SYWbxIxuzR6ck6POh0rYNZ90PJAY= X-Received: by 2002:a17:907:c004:b0:8af:2ad8:3453 with SMTP id ss4-20020a170907c00400b008af2ad83453mr8800069ejc.6.1677605125419; Tue, 28 Feb 2023 09:25:25 -0800 (PST) MIME-Version: 1.0 References: <20230228085002.2592473-3-yosryahmed@google.com> <202302281933.vU1PHuZr-lkp@intel.com> In-Reply-To: From: Yosry Ahmed Date: Tue, 28 Feb 2023 09:24:48 -0800 Message-ID: Subject: Re: [PATCH v1 2/2] mm: vmscan: ignore non-LRU-based reclaim in memcg reclaim To: kernel test robot Cc: Alexander Viro , "Darrick J. Wong" , Christoph Lameter , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Matthew Wilcox (Oracle)" , Miaohe Lin , David Hildenbrand , Johannes Weiner , Peter Xu , NeilBrown , Shakeel Butt , Michal Hocko , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 1BEDC40017 X-Stat-Signature: ndn4fkkm5om73i5xosnpp7jwsc7rf68z X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1677605126-881686 X-HE-Meta: U2FsdGVkX19ZGgyqhNw8ezEhYL0+E6L1WCLBtuqvUlDCYCnh99RGPGDUCKKbbmKjtHr5Ij0mzoSx26U+Cj7XX5OuMEJq5HBdiK8Xjzoi9RQRntd8LyCc0i6X8b9z+AwuVevd6D/IrtUBcKH00jLec/WOGGI8UNONvgL2PPHpOC19v61GWobwtgFaa08Wwo1Dd+xrgWnH7ZTd8Nk7mTx931AI0CdsO5ojK1gVf0ayTirGOV7ngpnJjhxwAgvkU1cPHiWAzzcoxCqvOFCAMAshFDP5TCHXjFT6LLVoiHgSm27NQ8UI3744Tatt8C/LHriCphRO+izjBa1qJLMGhbutd3CVeZl06zB3Kf98rFNiGnvWKW8ERD82skD0MBuX/gMwJJ74MSSr6acizufMhTB1ahvWMAT16N13UNE9CYoyAllQL1iJvITzLXzJeaQc2hPgE0ptYh2IvxiqSEVMAY/pQB0X/UYmkBeuxnWuYa9+pM64aQX1lYdEvPiUcWI78iiQATMNEDZo8dLuthp75MgH3cowFWAdgDf0KuYxkkms2mUnMOMnat/9+tcQdeNFcFebllr1W7qR75wTEeHlskGNNeifOYEBWf7czyQCEttW08GZODMxgZ52umGu1XehX4LlVFl0IRXXOF6tfl/OfbVLq9bACmzWlDmoESRhEWAeyFjqmtuyFEvDBBRNPo1cO/R2axR0DMwrc09g036U2eTn1x+fUswIVaalezs2kc19UGwmXBuYsa/7UwLP/uc8JjTJ8/OUxR/tXOk0YKhH/JD9VUrlI6WGRNEGx1aupcHs/a/D/dvVUfONI+FP8UX6zCzHcPaEM0dR7tAcS2F0c7u3u/saHTEGramZLaDNusI/PnJoQrz6i2Xb8Ufxxc2PU8nN60cmF8JtfZB3xblFL7WXk/RT6eXq9pZB0ajATovg9k7e8I7ZCoqilUhtKuCzkZSepzzt25J752gkA05R2Mo WloJ8rAC RnrzgJAL1jzjtw1N6iTfhgdG7ZgOxXBwGgMTss3KGnkfg0ezQ/ZVr37w+C3k2gHtCHZHfm7oUHA6+HYAP4Vh+33MLO7N1HdgwUPV3Ppx9USpvY6nKeh+vp0T+QBlJL3OefHTSEmSbhdgaAivaTFTIFZqXWhJrO/twpiwlqKWSReOJz1Ww7+vlkzna29Xrf8FHY0Ry1ASjUaCXhx6I8o6LNGEVHHQR5gUNRkfDf+ki3jdrALuXMxEmaCiNF0JXSvUo4m8pCbq5PHCffQKcOpETubtwnJ24vkgXq4viYegPBji5J/aBOghACYRGrHH027UjIZrh5hFECx0zLA63lt7Qtm3WtNiy4i9SNyeRFn2415tQXm+X2CmwuXkEXOl5WD201xotUZQx/Qd5anCLHmt7mvKBSzIdv0QURsIgmJwHeMaGQwy99U6d0CXMBnZN3BlMzVdFh0gdWEnsjYdppP1fzCJTjmQh+e78IOpXzrqevm9BavUh4cz9WlAOsZxHUXomX2cj9DHIW5gpYWuSlc/zmbRnEnWhZvZ9L1yGN4I4llq1raeWrjbUa02l3RFvgpWm5JD9wCgUghgZHpMR+U58y27Rw6svd5d0Q3wWvYKCkn+Mki/P/k/mT99Nww== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 28, 2023 at 9:18 AM Yosry Ahmed wrote: > > On Tue, Feb 28, 2023 at 3:56 AM kernel test robot wrote: > > > > Hi Yosry, > > > > Thank you for the patch! Yet something to improve: > > > > [auto build test ERROR on akpm-mm/mm-everything] > > [also build test ERROR on linus/master next-20230228] > > [cannot apply to vbabka-slab/for-next xfs-linux/for-next v6.2] > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use '--base' as documented in > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > url: https://github.com/intel-lab-lkp/linux/commits/Yosry-Ahmed/mm-vmscan-refactor-updating-reclaimed-pages-in-reclaim_state/20230228-165214 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > > patch link: https://lore.kernel.org/r/20230228085002.2592473-3-yosryahmed%40google.com > > patch subject: [PATCH v1 2/2] mm: vmscan: ignore non-LRU-based reclaim in memcg reclaim > > config: i386-randconfig-a002-20230227 (https://download.01.org/0day-ci/archive/20230228/202302281933.vU1PHuZr-lkp@intel.com/config) > > compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) > > reproduce (this is a W=1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # https://github.com/intel-lab-lkp/linux/commit/f6d2b849f186a927925a29e289d60895048550f5 > > git remote add linux-review https://github.com/intel-lab-lkp/linux > > git fetch --no-tags linux-review Yosry-Ahmed/mm-vmscan-refactor-updating-reclaimed-pages-in-reclaim_state/20230228-165214 > > git checkout f6d2b849f186a927925a29e289d60895048550f5 > > # save the config file > > mkdir build_dir && cp config build_dir/.config > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash > > > > If you fix the issue, kindly add following tag where applicable > > | Reported-by: kernel test robot > > | Link: https://lore.kernel.org/oe-kbuild-all/202302281933.vU1PHuZr-lkp@intel.com/ > > > > All errors (new ones prefixed by >>): > > > > >> mm/vmscan.c:549:13: error: redefinition of 'cgroup_reclaim' > > static bool cgroup_reclaim(struct scan_control *sc) > > ^ > > mm/vmscan.c:191:13: note: previous definition is here > > static bool cgroup_reclaim(struct scan_control *sc) > > ^ > > >> mm/vmscan.c:554:13: error: redefinition of 'global_reclaim' > > static bool global_reclaim(struct scan_control *sc) > > ^ > > mm/vmscan.c:196:13: note: previous definition is here > > static bool global_reclaim(struct scan_control *sc) > > ^ > > 2 errors generated. > > Ugh yeah I didn't realize I am moving the definitions from within an > #ifdef CONFIG_MEMCG. I will just leave the definitions as-is and add a > forward declaration before the definition of > add_non_vmscan_reclaimed(), should also reduce the churn in the diff. > Will wait for a bit before re-spinning to gather some feedback on the > current version first. I can also just move all the reclaim state functions (set_task_reclaim_state(), report_freed_pages(), add_non_vmscan_reclaimed()) below that #ifdef CONFIG_MEMCG. Might also name them more consistently. > > > > > > > vim +/cgroup_reclaim +549 mm/vmscan.c > > > > 86750830468506 Yang Shi 2021-05-04 548 > > b5ead35e7e1d34 Johannes Weiner 2019-11-30 @549 static bool cgroup_reclaim(struct scan_control *sc) > > 89b5fae5368f6a Johannes Weiner 2012-01-12 550 { > > b5ead35e7e1d34 Johannes Weiner 2019-11-30 551 return false; > > 89b5fae5368f6a Johannes Weiner 2012-01-12 552 } > > 97c9341f727105 Tejun Heo 2015-05-22 553 > > a579086c99ed70 Yu Zhao 2022-12-21 @554 static bool global_reclaim(struct scan_control *sc) > > a579086c99ed70 Yu Zhao 2022-12-21 555 { > > a579086c99ed70 Yu Zhao 2022-12-21 556 return true; > > a579086c99ed70 Yu Zhao 2022-12-21 557 } > > a579086c99ed70 Yu Zhao 2022-12-21 558 > > > > -- > > 0-DAY CI Kernel Test Service > > https://github.com/intel/lkp-tests