From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4820D64085 for ; Fri, 8 Nov 2024 20:24:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 433C26B00A5; Fri, 8 Nov 2024 15:24:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E2C36B00C6; Fri, 8 Nov 2024 15:24:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 287356B00C5; Fri, 8 Nov 2024 15:24:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 04CD98D0001 for ; Fri, 8 Nov 2024 15:24:34 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B9559140F8A for ; Fri, 8 Nov 2024 20:24:34 +0000 (UTC) X-FDA: 82764054492.21.2F119D7 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) by imf20.hostedemail.com (Postfix) with ESMTP id B559D1C000E for ; Fri, 8 Nov 2024 20:23:46 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=c1yTWCtz; spf=pass (imf20.hostedemail.com: domain of yosryahmed@google.com designates 209.85.222.171 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731097285; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NjWcx0U69TXGpkAnm8bJv29GUAXhA0iQfJ5knHqcOQU=; b=GXEDlXlosr+Ja9XU/TIAOT29qsVK9kdeTJf/4KglrXdWt4c6i0DXS9D+y/40QA+3gD16g2 2GrNM9oTH/poDBOzSt1Y+Kpx3qNpDa8gssUO8AJWhtD7I10fDK4QP6JGIameKTLFFwvL+l 7jfe7Npdkca8Nv4OEnMgjh1L5dp63S8= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=c1yTWCtz; spf=pass (imf20.hostedemail.com: domain of yosryahmed@google.com designates 209.85.222.171 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731097285; a=rsa-sha256; cv=none; b=oCRB+Musc7wtwHn9QEg/r7djnM12s+qIiWg3oEVS3/8Vt6Tx6+Zxv5SoahccBIMRybOi2F qSMAZL1/TzRdKUxQ3Ezl0xg172fyNNAmVx/XKzDC0imiCeUoo43ay0VLqpbNTGxIxRXk2M 5Fexa5sokzD2NAKrClg4Vt3PzBWCr7A= Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-7b1474b1377so169340685a.2 for ; Fri, 08 Nov 2024 12:24:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1731097472; x=1731702272; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NjWcx0U69TXGpkAnm8bJv29GUAXhA0iQfJ5knHqcOQU=; b=c1yTWCtz9VhuFdAhXTwCR3WfWd3y4zDxteE+srrwr/4bQRa2I29bVBH3uHUlE6X604 cDXMMuKeutPwR20cpljAK9nzmlrlKKQIkx3xUW65tXoPFQAMUKFQ8OsjtN/7123tnfse Gjk+1+wLpLy2c4HNmaytSdWBWlgnX2KBCPLGRj1dlNVPG+pturvSV+PRkZOKg1OusiSi VSnYoaQoFpn32QsSdp1G1CI8RzwrimXmN4QBkfLY3l4mu2qkw0vveLAmo7+qBnNz/NKN lhMzRRuAQCrCpKNEtyMg8ugsblwycXY7861xBg3fSocn/+80f4ZgMPd/xTZajgDfWIQR veOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731097472; x=1731702272; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NjWcx0U69TXGpkAnm8bJv29GUAXhA0iQfJ5knHqcOQU=; b=qGggGpi1tsIrTZ6MsUJLdfI6Xf9NAHK5bg0FDr5tkNVU9jMstPh+CCe/kvFf2bwva5 UnG2I+HDvI+oURSzfLq3z4ADwC3wRxak9MpPmmAh2mJCXoBsdMN76GX0xPDMWoBm4jht eth7/a156julDnozCNZIZgcPG9SXn4lIbMxbIQyq8/YPtzkGW9PIXGkWXRHgm5dPiMg7 7ZICu+Bwd5jG/O6TPdOV3zFLiQ3wKDR1K00KR6XAUIUiqyr98yhBDHZPCuLDm6WrzvkJ bn9SH4K4xdfNp6ykM1RGxkYksB3CgXNjEhyybhINq5z42ATWC14y65Ghhm4oeZ2YWlXb jpWQ== X-Forwarded-Encrypted: i=1; AJvYcCVRVCcXCUQ6SYgayrh74PBWgMVZN/EC3DOO8m1s+6in6xE+q9zUWKQfhpFJI9fHRVVzo3FIVugg0g==@kvack.org X-Gm-Message-State: AOJu0YxtQHNbBTTA+vgBTCr4LKdcIEy79kQkA4NMi48Kz2RjIShdHT37 NVdyCJVlV43uZsAkbkBdE7D6h3QF0+DNrgkbWjRIjOGTzQQZRfhs23A4luQXFfHInIQnXhJBKOl SAgEFS1jxo59VjjG+hjcT3hjoYxrvPujw0Hu1 X-Google-Smtp-Source: AGHT+IFTCXzZqbORIu77S8vltjpbqT2jiD2zFDJVpYKUMIQpdWZiXDw65WdrevpcMDyrDtwDYFhTKELCt2B1xRFsSBo= X-Received: by 2002:a05:6214:430a:b0:6cd:ac54:7995 with SMTP id 6a1803df08f44-6d39e1ee6a1mr58087386d6.36.1731097471563; Fri, 08 Nov 2024 12:24:31 -0800 (PST) MIME-Version: 1.0 References: <20241106192105.6731-1-kanchana.p.sridhar@intel.com> <20241106192105.6731-13-kanchana.p.sridhar@intel.com> <20241107173412.GE1172372@cmpxchg.org> In-Reply-To: <20241107173412.GE1172372@cmpxchg.org> From: Yosry Ahmed Date: Fri, 8 Nov 2024 12:23:55 -0800 Message-ID: Subject: Re: [PATCH v3 12/13] mm: Add sysctl vm.compress-batching switch for compress batching during swapout. To: Johannes Weiner Cc: Kanchana P Sridhar , linux-kernel@vger.kernel.org, linux-mm@kvack.org, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, akpm@linux-foundation.org, linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, clabbe@baylibre.com, ardb@kernel.org, ebiggers@google.com, surenb@google.com, kristen.c.accardi@intel.com, zanussi@kernel.org, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B559D1C000E X-Stat-Signature: r3fqn8rr8syt1ayj9uoxto37cu7zt9o1 X-Rspam-User: X-HE-Tag: 1731097426-549490 X-HE-Meta: U2FsdGVkX1+HoPcGHhevjUMwnAKSKdQNcx5bZEziZwoI9IOZThHlUtAdcSr55HU4Y0J2PvwssHItGyM4dN9bRPz/84YC341cAFzy4xUfk+N6DLwVAuX0yOlBhG525SAlf2WcxrIi/gH5cZMd83/UiWtIWnplYunt/WnENhNTx6/qy25P6MyzPXDKeKS52mXCjA+Vn4Y53oENyPQdTg5WddEPM2Nl/p85sGSKMrFLmn5QL8jnOVsuWTXEVVBgzz+YPydt3xJ6gIY9ImC6sRWC1CK27XZMNR9zatkhq2vMT7EXfHKkwfynJkY3+PiHrsT2OPGkpVQDx61HpHun2nKRSMg32Ikk9d408g1YLgGz+5tuhZotPnjPystIRNDvNvpT9ZhGu02dvr2HPWrw3Rgtztr8AYWvpCeB/RpDYfM3lcDLSmgOLVDQrdt8OXeWCV3hHIP1xXaed0jf2wdFj3lusYx7MOtMcJXlSAaerRi7KtJsmd4f5unmyY7TPC4J/rEPnoYv02jJh1O/6qJ4X5oq/sGGWKewn753rSygp6HuAqpVmqhoPakSaQ7wS8UVELxNxs+sjmLnGE7cN/Gzh6HbTbySgyNjCcbME55vh6oGd9FjEJvgehtNvk9X5FvJM6vcTrh2kYgBlDIverZDpWKYQ9WvrCXaJioOkHAGHp3B7jnKWDNS/T5JcFSNUfCkcPUl4decaFwwbORYl2cVB63X5cETpTaQg2+CfAyd0TBgcaNNX4Sl6UEqwNR8pg44i5WnKyC3hL0Qh5JlS3pwVFYcycI0O9FL80Alndyp/jPKdT9/JO4BNaEfqRBV1a3Qu7I6aWe+xHBbGYScdoad2Qqjf4AuGIQTQe/OV4wnziiRfttPX0tVvSrS0Hs0ulBRfF1GNrV/5b5NcHEamOxA1EDGLPtybj88sp/R42DP5UrQisx8mz8iHhpxDyTe2A8L0jY5mCBBVLgZDPrWrDbnTJ6 ojtX33qu WOP7G7QiSI7qZzSKHzQ21KTejWrGPa4d6b8392IEHiYDSjskhkfUo4BFUMWE4x+dbGL+5WD7j7bzkRJQBnJhhp4DT0SI/6/XrqRVroMJjThTAv5uwtak6t7KTM7owNQjeLXDk2lGGchDQSAv/Wc3WE2YyJ1uo3xCHOWzAJGUaG2Jv33O0z4vMfXvxLo7dMbsC+95vinwLqiF9zfO3qMhXP9mwLxhVOgIftzov5UavCb1IWlCZkkAyPPi0jhh+g4z2EPOI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000234, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 7, 2024 at 9:34=E2=80=AFAM Johannes Weiner = wrote: > > On Wed, Nov 06, 2024 at 11:21:04AM -0800, Kanchana P Sridhar wrote: > > The sysctl vm.compress-batching parameter is 0 by default. If the platf= orm > > has Intel IAA, the user can run experiments with IAA compress batching = of > > large folios in zswap_store() as follows: > > > > sysctl vm.compress-batching=3D1 > > echo deflate-iaa > /sys/module/zswap/parameters/compressor > > A sysctl seems uncalled for. Can't the batching code be gated on > deflate-iaa being the compressor? It can still be generalized later if > another compressor is shown to benefit from batching. +1