From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4A01C77B61 for ; Thu, 13 Apr 2023 11:27:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 492326B0072; Thu, 13 Apr 2023 07:27:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 44271900002; Thu, 13 Apr 2023 07:27:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3594F6B0075; Thu, 13 Apr 2023 07:27:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 24E646B0072 for ; Thu, 13 Apr 2023 07:27:26 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BCBDDAB459 for ; Thu, 13 Apr 2023 11:27:25 +0000 (UTC) X-FDA: 80676142050.10.510E764 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf20.hostedemail.com (Postfix) with ESMTP id 0040E1C0020 for ; Thu, 13 Apr 2023 11:27:23 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=JNfNJP3p; spf=pass (imf20.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681385244; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hzqQs+ynPLskxl47UZfCKlnD8vWrn86NbxoteoLGhFU=; b=aB7XuqPEyOCykcZv1u/FHYCRNCZ6ta/RL9dZqVlLjB/YWU6/Sq1Mn/zAgI3Puu6gueRLk5 Tpht7il8hkJzsihwZUylI4SBL2dq2k1pvO9QBOHF7JJ4RpfjwD6JT1ZyCB7pjizCbJdiug sqY+aJwBLQaE5cMKsxbh9m0uSaPk7qk= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=JNfNJP3p; spf=pass (imf20.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681385244; a=rsa-sha256; cv=none; b=JJbj1h0NGh3zlgoNpDR0OIajQ2dgsw12dBJ0o0FvVhIpwiEpHmys9UpLh9mOHrAdTkBEYb uNRWHYT/GJn3Lw7uti/zThL+QmMcNA37SrpDAz2DQeQwC9JWWdj7qBrCGKPO2p7i+bBliI jN1AbI5v20TEAsIT8C9vLVe3DPtgIzU= Received: by mail-ej1-f44.google.com with SMTP id dm2so36667171ejc.8 for ; Thu, 13 Apr 2023 04:27:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1681385242; x=1683977242; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hzqQs+ynPLskxl47UZfCKlnD8vWrn86NbxoteoLGhFU=; b=JNfNJP3pF77l40f1jjSgvbWjp2I2/WFvuBnxlqMR81t79Dtpme0p9vMqE0EfTQlY+5 UQ5/1l+482xix6SvemcrraWKa8GP6Eq9DLY2ze//BXzN6zXQ+yYtsnOSweo+AFG1OQtc C7hG7cdh1vUGhwwE+G1jeoRmTSjeavJatbUnKd2hrAI9Akn0/QYTYoYXhVnfkoGtMaIY Ox9YUu+JbLCOCTEirveoq4t/mSoxeo0MvMzFgs+MRLUBCZOCaTLKaqSpNbmiPSp3ITGu +7bV2a8y9RqGqHKl4mmEmAGXcma6tXW7Uf8YVPJ2TqTph4k1//8eeXUKBSKqd68ShkvY 42BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681385242; x=1683977242; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hzqQs+ynPLskxl47UZfCKlnD8vWrn86NbxoteoLGhFU=; b=K5wGG0KEH4Gn26PbGuv6j//xjeCUhiagB5+iTj48HUPldulGliTK+DtJtv4P1Qc9vL H3dwiC1B7OFIGHLPn9fjoVwwpbxDwrsmK7uyxa/tdWx3EXAo/ZP+tLaj/Qw2P0rk2n8b lHBJBSRoG1Dwjc889qnNE7WmAZjIw1ER1w69XNEEoCHISRl8xb8HU6xBcoNZ7iXgLhDM foSRs+g2Od1qhjDvkSx5OsiN4ND2bcXHveTbxntlRC2FSJS48Pz+EJCb8OEbavJ0i4cv MDIlpSZwcV+LniAnjzRQQhkuXKBR/Lb3/sf85hyMdM1Xc9+IEjMa8WZfgvvqI98PLEVD 0dKw== X-Gm-Message-State: AAQBX9fMi+C1TJAm1ub3yQqJAyB+9UwyrjsN1vIN54JB1FGF6xw5ftbt bpFXx61hJT+lucTcP60N0F+OrQ4Vyz8iEYG4iWiDqA== X-Google-Smtp-Source: AKy350ZRfFmJqhIM+zLx5wasnjk9Kpxdo4Y1Z7QE9rOwvq/eCO+8LfihDacwwj/WEG28XM3uy6urY66KF6eKt2jUGgg= X-Received: by 2002:a17:906:2c1a:b0:94e:8e6f:4f1c with SMTP id e26-20020a1709062c1a00b0094e8e6f4f1cmr1088308ejh.15.1681385242447; Thu, 13 Apr 2023 04:27:22 -0700 (PDT) MIME-Version: 1.0 References: <20230413104034.1086717-1-yosryahmed@google.com> <20230413104034.1086717-3-yosryahmed@google.com> In-Reply-To: From: Yosry Ahmed Date: Thu, 13 Apr 2023 04:26:45 -0700 Message-ID: Subject: Re: [PATCH v6 2/3] mm: vmscan: move set_task_reclaim_state() near flush_reclaim_state() To: David Hildenbrand Cc: Andrew Morton , Alexander Viro , "Darrick J. Wong" , Christoph Lameter , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Matthew Wilcox (Oracle)" , Miaohe Lin , Johannes Weiner , Peter Xu , NeilBrown , Shakeel Butt , Michal Hocko , Yu Zhao , Dave Chinner , Tim Chen , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0040E1C0020 X-Rspam-User: X-Stat-Signature: jtja68fxjowmuaxmsj1jboextjyi5teb X-HE-Tag: 1681385243-186200 X-HE-Meta: U2FsdGVkX19IlcqbhDCFOSXaahPLTgRXli+KiEEnAS1cR/lG5uYt9urso+dlQRvg0wGxM5t0uX01K0dri0UAu0VbYZe7pbPo/KaAJ0BECWO/k2Yp2d/+8+8+LyTO9abrSsYYK0ej3lV8j7I5kjCeJ3DeGxCotYtPiFiizyLcA541vQBmOilJr57FD9SwPRRBYw8BYi4JjdpYF673PJkLYevl6U8vu+TSgKcuggtfl7KvTpQjWPB5fJhzMGlIUkpCWwsZVx0xQVCOBm0KeS5lKhbx2xC9e0vk2Gg5NbnW6NEGZJuCumq6plez7DydnORRhG7U/hZzPzpjsyMR0dLw/AZRR6LvHetthNhzO7y4miHDwl695qFcX7dc/SR1k7bbFf8bRVbdNAKxeWvZMoznt7FAp35PfWe01POEc5s9a+FuB3QhYNlo/uwE5RyWgBs7OhCC//YxQ2K02t6g8yn7g5ADpkAzP3Q65rdyfrLmzfu7UhoYZ2Muhsw0MnjuYTErMW2luzyTsKbhXy2BO/0NJyC4kaTEnoPebD5XuZazj2NUivTzpt40GnIVsTQzWGgZEU1DzVNUwz9PghBQMWIFn78XdT+mY6r+znZ5Xposljquxol0aJfl/hftnHue6xMe7PSKpMSB+WdtUkcLD8VZuyw4lYn5ZXQ9ofVl9VfXUFj7khe557yOncL+8ep2pfx6oLOt1M+PwxuvO3+vwn/caX+49gR5VbRyhNLorhBpKdrA91I0MPP4WQNpvrGAQx99/vLOTVx4rtFAq9yg0z/IjYML3L5OWGFDnxPAJlR0mbt2j0Hp8zlh3J/Y3UojTLCVRq4K9wv31gqaFuqcZB0IF6AsZDtfsXMvbR6UTPDLvd4Nmu4NOVaEBXzEv0HfkwOvrBIw70YKpTuz5ujGXvifyXsR+FR9wkkeri4ZUpl0lr/F8lAYiT210pUqygm0WxkHjT8DVABfw4uFemog3Ss gS/kYmUh w7ucC3cx3fqGfaS706vqpcnPRUHGbMHA8BhyTF6G7so9ZbE+hIIVvQCbSJP2Oi0QfPk/blYasGG6XTF4hdzJQKAQAWapzp1mDJXp/DXImRmbG7oRDc0HKn2CcNXHV2EOEhB7kKpM8JDW6ASWo9R7x1GA3K9fJiHVFHtuHQOn/MUy1oVuHN1BgZEviThnlin//APP0Wxr+n/atNi5vZfAClSR30fWYgerGtiZdxC+QNWcumbNv/KBeR6Fg/eA6Mfc6stYfz+77oLoS7PujRuwlxvZg1tg0LM9TIiLUONHEPMxXW2razxVpUvEzxwjzR4bDPlp4Zm0eUyWbXWLzcArllQE+gfWmkZVHMxPH5J8iqL8UXDAyWSMVazecBnPostP/KifhvZGwDR/4rVsqpi7s+YNS5dbW4O9WQqBs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 13, 2023 at 4:19=E2=80=AFAM David Hildenbrand wrote: > > On 13.04.23 12:40, Yosry Ahmed wrote: > > Move set_task_reclaim_state() near flush_reclaim_state() so that all > > helpers manipulating reclaim_state are in close proximity. > > > > Signed-off-by: Yosry Ahmed > > --- > > Hm, it's rather a simple helper to set the reclaim_state for a task, not > to modify it. > > No strong opinion, but I'd just leave it as it. It's just personal taste to have helpers acting on the same data structure next to one another. I don't feel strongly about it either, I left it as a separate patch so that we can simply drop it. Peter also thought the same, so maybe I should just drop it. > > -- > Thanks, > > David / dhildenb >