From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8C55CDB474 for ; Tue, 17 Oct 2023 23:52:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 50D8E8D0126; Tue, 17 Oct 2023 19:52:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4969D8D011E; Tue, 17 Oct 2023 19:52:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 337118D0126; Tue, 17 Oct 2023 19:52:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2063C8D011E for ; Tue, 17 Oct 2023 19:52:50 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DE38280F50 for ; Tue, 17 Oct 2023 23:52:49 +0000 (UTC) X-FDA: 81356606058.23.807C443 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf15.hostedemail.com (Postfix) with ESMTP id 1EA4BA0007 for ; Tue, 17 Oct 2023 23:52:47 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=V2BoNsu7; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697586768; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8ijNKUZrGV/QasB3HbEVN0PUNmDp0ZQ9fTyJ7U2oDSY=; b=UzA1sU9UvQ5smBisx6H7DOrQHBLh+ZJb7oy4eC4lZPmC3OnAyQ+fMVw3TgrXNOE7Q7RP8f L5JjVsUvtv6RildQ6thV9khZjPjyl2A2XTQEZmPcFiU4Qdukj4mZG0QwLleXflG/bTE34O 27b8aet5j9/Ld1n6L9JInAZVDS48ZBU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=V2BoNsu7; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697586768; a=rsa-sha256; cv=none; b=LQXh860Qhhhuk2Fmm3flKiKjxzLBPwIWKFirG0df6e4C1sIbHFTq6NyHns3RGRCdtAa4ww KB9taK3FjiCNfq4fKclpGs7xo65pLJVbYk9xZ31ipsyhRuLLcdIZzgNknBJH8qAe7AtT3f IO998M4kudSVUxj89/RLwKBzHT4ezbo= Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-9c603e235d1so198267566b.3 for ; Tue, 17 Oct 2023 16:52:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697586766; x=1698191566; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8ijNKUZrGV/QasB3HbEVN0PUNmDp0ZQ9fTyJ7U2oDSY=; b=V2BoNsu7xD3RGstzN8NzflasGdkQCQ9q3a/YocJtoZMOBPox/rv2RxrnyQ1xMpqgE/ HnQcKCbj7AQa2U6+u9HYoTrCqCe48j0jALSLpuHFAjWAuyMgAUMruXyEkEbIpGiefAxn FKlubzhOhtIAM70BkZJMr7waxIjUQmD1PYX4/extV6CO74u6IPvt9AlSMQBr6bKf59RY EGm1EAwThG38ga+4h388/s5d/fh5K/uN8t6mIElfCHmd9sBiZCQnPolGv5PwA6fipOuo kpOSP17e/F/RFcr3n39WnVhn6V8DMQ+dz8HUsLdCRB+JIh46xx5yf1SoxAr4fDur/Eba JPeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697586766; x=1698191566; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8ijNKUZrGV/QasB3HbEVN0PUNmDp0ZQ9fTyJ7U2oDSY=; b=uJsZuVjCsWRPe4nvsxIJFFeR9iHtVTShp5OCdsLtA7wcyJmu9qQPDKZIRlElDc6iwC Z8RLvuoRlGtBvwKZlCouOnFQeHg2t0Asv0eRbqHlW4/s83+/bdxNr9Oe8kxW2uNacRf4 OeMmeQIRibYv7JgyMhCzC4sQ/wkXXscNEwlcm7B8c+7jUSLjy0t+WompupBWAvRFWWao PkS/JPV/ui9ox6nJjRpOeZg6OzBJbGrEVKQ/GEXLHsm+DtvWyCohD36NBRTr6o97Oszm Cm7RzLq5VpYtw9N9Fu7LvlbiGOI21lFfV9YwzMoQJPUHXM1ITj4NKPVQSAez95g+63GP nltg== X-Gm-Message-State: AOJu0YzpnAKuarAjqhWR6870QqaGhJc/Lujv81dURj3p71VOqrL8MFAt 0hJAc9Fw5phin8eWMCFQUh1GlWRFhxfeDWYXfjZ53g== X-Google-Smtp-Source: AGHT+IEzYA1bgwAcUa3xXt5MPooJrDGhJmuxWFHodU9x0oj0lJCyt5H9ezXwDqD75m2OTGyAg6uLlLHUJW4p500RG5o= X-Received: by 2002:a17:907:7ba0:b0:9be:ca44:87b6 with SMTP id ne32-20020a1709077ba000b009beca4487b6mr2683655ejc.3.1697586766359; Tue, 17 Oct 2023 16:52:46 -0700 (PDT) MIME-Version: 1.0 References: <20231010032117.1577496-1-yosryahmed@google.com> <20231011003646.dt5rlqmnq6ybrlnd@google.com> <20231014160831.73785b15e9b34eb6146d5497@linux-foundation.org> In-Reply-To: <20231014160831.73785b15e9b34eb6146d5497@linux-foundation.org> From: Yosry Ahmed Date: Tue, 17 Oct 2023 16:52:06 -0700 Message-ID: Subject: Re: [PATCH v2 3/5] mm: memcg: make stats flushing threshold per-memcg To: Andrew Morton Cc: Shakeel Butt , michael@phoronix.com, Feng Tang , kernel test robot , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Ivan Babrou , Tejun Heo , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Waiman Long , kernel-team@cloudflare.com, Wei Xu , Greg Thelen , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 1EA4BA0007 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: db81qjy9z5ariwzp9ngxs7kec86y9xwq X-HE-Tag: 1697586767-715481 X-HE-Meta: U2FsdGVkX19/A32NDWbZzejkOJBOAZg/QbF4t3gZgyXqYr/LXtNzW/cdI4u3YqQuyasVnS2xVMOSoqG1IbHM+m724O2VdNZ72k1UIOij+wPvR319a5k/V7PEejfBBQxcCfAfOnraHs+c8CKjuNiLNuCkY00bCXWYwjbYF7f1CKLPiqxI50vtrntzYpsfyTvvkjwoNHQ2hxG8/UdDUNPe/bN0HA+Z/Q7bMGWbiS0F7WKfJYNDeoectwD6SaPSGQtphFCLaISN8EIlJKU3qtyau0sf/NUlpdVNUXZ3Lqj0H07yBUwW9xyBZsB3F2aNgImMapCoovWoPuEPfXxKdsbHZmOqEXHMLZ90BNSLTcCR60BNQW/PeZbtSBazSrKDLWiELkqW9UgIiH1b2W0PRAuoabtzmBNj2GIcligKeDErw6po0U9fnvv0hxQqPjIWeRQJuTMloF5F9aojuLVVsYOBZKtirvOJzcW/3th5OuOtaP4O32b1Lofv8xEPshJNT7dEjev5OK1jR8XV0JCWShk12DRSkScym44927GsfBND/4JonjEIXZkHNH9SV6y9FBCXYD9ZLJeJ0macUlM9PJs9ZCMUrgY7O8hIqVTvwBH5Flw9Ov+jnCJJqDUwTfpNEvOkH11SqzEBay0dAJPaAQY4AzYla+ztpf/YptrSStrbX7uXewdTR0Jxp4hJZzKANM1FN+H6E2BnkXdLe4bc/MukLpfmpcppYwzApLOqgZFohkUPuoajx+HADEC0yx1QJbn4UP6ybffoVwGM/a6K0w9cK8Zs5V+ffea8HIDxeatmcqHZx4ZxtVwGQi9Xj+VLl3fsOiZJygBndtgiaKYpUZ4A1iYHVHacL5MaptOe/+9NEqo6/GnzwaAgE0D6Ttx5/J06eVuTbwWmMMcmK/HIQrz2kUAqqVm4ZHFnEMf/A1NGNu5ZrbvLZ2S4Edfd7RURVvWhWWUvwfnS7go5NBQvqFh Iu0TGX9g UDwYjMNhx25Zm2ew4aHunXJXQ3ukLfzVnXR3zSWrkcXY74tpLYxIOB2pxQ6KGWJAn1Bt6loIf+P8H0lXTW+5mYnb+weDeRi0bXe+SLsI1F47hg3G1s8oAsGx0vTZqaAmctNc+20o2uk/eQWBfHRBqxdOG5OZWFzu+tR8B3k1moyaHgBp74t4opXJsQpDYnhUHSGPf0Fxv/nqAtznlAa64BgjoT7O5r+cOetRiLKo4OayVhVKqT84aqkuY3t4EJ4ywqlazdnXL1BiLxhe1jR6Z/z4ltNTdmlad2nqk6VTlmWQytQk8Jk/EHEAHkA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Oct 14, 2023 at 4:08=E2=80=AFPM Andrew Morton wrote: > > On Thu, 12 Oct 2023 15:23:06 -0700 Yosry Ahmed wr= ote: > > > Meanwhile, Andrew, could you please replace the commit log of this > > patch as follows for more updated testing info: > > Done. Sorry Andrew, but could you please also take this fixlet? From: Yosry Ahmed Date: Tue, 17 Oct 2023 23:07:59 +0000 Subject: [PATCH] mm: memcg: clear percpu stats_pending during stats flush When flushing memcg stats, we clear the per-memcg count of pending stat updates, as they are captured by the flush. Also clear the percpu count for the cpu being flushed. Suggested-by: Wei Xu Signed-off-by: Yosry Ahmed --- mm/memcontrol.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 0b1377b16b3e0..fa92de780ac89 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -5653,6 +5653,7 @@ static void mem_cgroup_css_rstat_flush(struct cgroup_subsys_state *css, int cpu) } } } + statc->stats_updates =3D 0; /* We are in a per-cpu loop here, only do the atomic write once */ if (atomic64_read(&memcg->vmstats->stats_updates)) atomic64_set(&memcg->vmstats->stats_updates, 0); -- 2.42.0.655.g421f12c284-goog