From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E309C2BBCA for ; Tue, 25 Jun 2024 09:54:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79CBD6B02F4; Tue, 25 Jun 2024 05:54:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 725C36B02F9; Tue, 25 Jun 2024 05:54:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59F4A6B02FA; Tue, 25 Jun 2024 05:54:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3C1C26B02F4 for ; Tue, 25 Jun 2024 05:54:14 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BACAFC17F2 for ; Tue, 25 Jun 2024 09:54:13 +0000 (UTC) X-FDA: 82268950386.01.A05F0F8 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf09.hostedemail.com (Postfix) with ESMTP id E89E5140011 for ; Tue, 25 Jun 2024 09:54:11 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=kVxU71YN; spf=pass (imf09.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719309245; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yeDhT7EoWv2TdoSvGYalLiHtwKn/aqX3ezTK+oGJl0I=; b=bVgDn3YfdhyENi4F5KRhVHmT1Dr+XpAiD0jRbYLt6e1WwS6TcIAJUQ7wAepf5cyibfPgaq Eye6x2ySLeDbatUzYtTa58AGYd8Pl8wv1YkKyuPJ8Wn3pfwLxibSq49DihHt9dSBI0i3Ld UtGuKwucoJ7vmbUwTP/DG/nZ0Hz7U80= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=kVxU71YN; spf=pass (imf09.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719309245; a=rsa-sha256; cv=none; b=q7LJQeNskQTV9R9oGRTskBhJH3GglCbKPWBTkPv3F5LAs8nUGHqCnOgyW02gBDKqcBstlx Rcapw81zerd5RwRtBz9EzG83JHl6+Zt/+IXu2uu+qUtXdhPPUCyXXf6zvTfmXX4xR5qJ6v Jd5+IFCvQXSEPH+ZrKSrZMbYfarx2A0= Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a6fbe639a76so844442866b.1 for ; Tue, 25 Jun 2024 02:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719309250; x=1719914050; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yeDhT7EoWv2TdoSvGYalLiHtwKn/aqX3ezTK+oGJl0I=; b=kVxU71YNcbL9qbNYJH5JRUn9uxW/nzz4VRSZN/23CfyDGx7C71lGBLvoEku/w5rbCm qEzX0MAHh/khSGBtqpsrGUR0pLDFdj3Hd9BdP0ccF8jPJ3AOs2BRQ5YvJxIklKLIvGYH x4iM3Sn8ruhgSOKwC0PKii6Bq6ssHYMYsozUZOEknM6a5oeG+V1+CwjGDrjw6Wgig+nc GvSOeRGpZSWhN+NF34JzeW0M9TrYFJHCegEmlf4Aw5AjRbw1+YieTEEJrYcny5A+UxBL Z1KxK6+rn6vHUiJbOK862rGfOZYmtUYxsW1Ne50X9pM/z8qGyqDKWL5rhiLf9YrfiPIn pvew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719309250; x=1719914050; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yeDhT7EoWv2TdoSvGYalLiHtwKn/aqX3ezTK+oGJl0I=; b=Cg8+HYTbrQoPJr0+sj02m7ZrviFf0hz1r2Ey2cP6QgZV1Wrl7lDuEyvTuah88x43vk k1/V55Xdy/T07uTEGtWt9vNR9Adx2FBgUT2s4GFiwKbDi3+L51G5MF3k+Pe0wMTjtb07 Ropv5+3IQhl0/F17BV8b5+DCoUanzUeq2PoF3GXJb1e2zXH933HFNTXB20ZV5XINFzAW lhutsUE1SBdJzR1LXxidvNBxWWTrtDQNloavSEfDYafd8/pfbpT8sLRqLJZQhU3fpzFJ MkPoZ+vBCTDfkuJuAnBOyQRgSN/KZXWyja5eOljvwv/J0ULuDz14NtC2WkMqsEwgBifY NFWw== X-Forwarded-Encrypted: i=1; AJvYcCVc87o6lxxPiREBVon7gaa/0gU9p+l/VVw2lLXGqZfahBDuj4yziWBKC4aT264t1dGkYqpeBzP1yrTnLNsijeSf3ow= X-Gm-Message-State: AOJu0YxUD0M0j44xQ++V/fS5hqPkSEWgD5BJTSLSXSJg8aln3NZn3hPN kohJEm4KZwLo0eOjxz6Kx6qKMLE9FVf5gLySKISbCODt65AV+VbbZlfXu654eJjY2RBcw7a0bEW 44aRa3UCUNNX5srboj6BWpzdxKWnpPOGM13nV X-Google-Smtp-Source: AGHT+IGQr3gDvpr8JF7pmHZzOzdkUDy6Ofz3HL4FcKxDHJdY48KE95RHXANN2CuKb0IZFWJK6QYmk9mXx8vyBQulAKk= X-Received: by 2002:a17:906:3593:b0:a6f:b352:a74b with SMTP id a640c23a62f3a-a700e7334d5mr575850466b.38.1719309249848; Tue, 25 Jun 2024 02:54:09 -0700 (PDT) MIME-Version: 1.0 References: <20240625-zsmalloc-lock-mm-everything-v3-0-ad941699cb61@linux.dev> <20240625-zsmalloc-lock-mm-everything-v3-2-ad941699cb61@linux.dev> In-Reply-To: <20240625-zsmalloc-lock-mm-everything-v3-2-ad941699cb61@linux.dev> From: Yosry Ahmed Date: Tue, 25 Jun 2024 02:53:33 -0700 Message-ID: Subject: Re: [PATCH v3 2/2] mm/zswap: use only one pool in zswap To: Chengming Zhou Cc: Minchan Kim , Sergey Senozhatsky , Andrew Morton , Johannes Weiner , Nhat Pham , Yu Zhao , Takero Funaki , Chengming Zhou , Dan Carpenter , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: E89E5140011 X-Stat-Signature: k7w63mnjx8dhym6fdy4jjws6i1319xsw X-HE-Tag: 1719309251-385195 X-HE-Meta: U2FsdGVkX1+4P1JpKxbDc9x4pPAe56QXebwisGrUj9id8RXFj/9exVvyLd8o9Tx3dlI3ZOAYL6qRUFu/KjHVZ3Y3C9gYcF6raxUbtBcbwaqLRA5Vky5U2WSj8IfH2xB0PBDzKD/H8NJxTAmPF71qEAxR0KNdDZHbewsZLT5VWkgC3A4JhSX4XEXYJpDO8oQ0wPxFy1LKUBVTs+wj3agQHa7zi7q8v/kcUrDv1iH0uw4WrIXIiZQ2mkNVQkUa/YRW60VECWrachX8ElYEgfzQAo6jjT5AXQgMdMrOQHhPyzjvZJ/bqaNWtZWzVwkKOEw51q/U9ELpUZI8E70gfkxS0b+U+vqemz5TpNBM9fOqWeAa/IN3O/eSIB8HAVZmEZppmc7fi1QaxVQSUAIis1ecrtYej1U/qunR5N/9QETtqZHw0T0sKX7OXn/fBBk2E3pEC2OCbEHvoh+xNTI7DgBoCx4meDs0mYdE+Ucz9vf58px66HKwA6gjPeY9EjWSsv0LMsCY6N39/aguUdlKXPXaK696NIkNZ+jwH6TTK7ewkAV1RZQA5cBA/kPX5TT9bBaob05HyF9H/ymNHLY+sEQZnkZ1XXU97WBz3bRMYeI1zii9fu4DJRqhVaaQRa2p9wNQevFETKR0L4NJ8N7V+/hT58/CSlLsizT39o6Sd2aZYSql9aElGDLR66lCs9dd34qf5OxcttFYCoIB7a+tVfT5IwfqlW29Bx+3JX6gWAmqn3tOZu5kwl2da34Cf/qAnUF5APr6u3OCiql4A5/dc3dyYHx3e3fcO/MlRf/+QCKcvr5Jq0sGlbf9wLFEwQkK4Fur6l4I4yvcWe32EMUbG9I2Qw3gRviN2maVUrhdaf6m33tbc8DZq/bP8ZKxiWGmJcO46YUZu/oq8e5dtYawpJs2R7LvESrpD1DsckmhbWGu6JrooKUVg3ieuAswGXh/N3SJE0tdYM82HcnsIhhEVBW kioIjpQf t0P0/032NsAxyzrJ4C58/4O2Zax0Uyt8W0KQmQK2n2uH3P/CGZPU3D0bCf+EaBhFCfjwE/q/k7LoiF3W81c9Ydmh2IMXDrU44jqips0Fa0Xhb/iMx/JVv1M6WT6Hab7vH9nPnJE12XM0bS63P7UNyRqtsXUyUFP5DADUVmNJSQcygbLTTvmo+SCNhFSSWhgJxfgPCI2sByrnELokV9opqZ1r1ysw8KpHIk/9F X-Bogosity: Ham, tests=bogofilter, spamicity=0.000694, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 24, 2024 at 9:40=E2=80=AFPM Chengming Zhou wrote: > > Zswap uses 32 pools to workaround the locking scalability problem in > zswap backends (mainly zsmalloc nowadays), which brings its own problems > like memory waste and more memory fragmentation. > > Testing results show that we can have near performance with only one > pool in zswap after changing zsmalloc to use per-size_class lock instead > of pool spinlock. > > Testing kernel build (make bzImage -j32) on tmpfs with memory.max=3D1GB, > and zswap shrinker enabled with 10GB swapfile on ext4. > > real user sys > 6.10.0-rc3 138.18 1241.38 1452.73 > 6.10.0-rc3-onepool 149.45 1240.45 1844.69 > 6.10.0-rc3-onepool-perclass 138.23 1242.37 1469.71 > > And do the same testing using zbud, which shows a little worse performanc= e > as expected since we don't do any locking optimization for zbud. I think > it's acceptable since zsmalloc became a lot more popular than other > backends, and we may want to support only zsmalloc in the future. > > real user sys > 6.10.0-rc3-zbud 138.23 1239.58 1430.09 > 6.10.0-rc3-onepool-zbud 139.64 1241.37 1516.59 > > Reviewed-by: Nhat Pham > Signed-off-by: Chengming Zhou Acked-by: Yosry Ahmed