From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 115E4C3DA4A for ; Tue, 6 Aug 2024 01:08:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 559286B0083; Mon, 5 Aug 2024 21:08:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 509596B0085; Mon, 5 Aug 2024 21:08:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D2956B008C; Mon, 5 Aug 2024 21:08:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1D8E36B0083 for ; Mon, 5 Aug 2024 21:08:05 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 91DE012084C for ; Tue, 6 Aug 2024 01:08:04 +0000 (UTC) X-FDA: 82420034088.15.07BFD17 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf17.hostedemail.com (Postfix) with ESMTP id B4D3C40025 for ; Tue, 6 Aug 2024 01:08:02 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=JSnHsOBa; spf=pass (imf17.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722906420; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r6ndtU8uZ3NwtS+ORp+o4K5xii6RVoLxBCf1D4iTv9w=; b=l1u7l6N5SvD6K6ymzcnG9nelWJDIdFFbEAR8bvbBSDOBYenZaOOLxVM5hCuofE7xaWTNtz 2uKzVaR2IluFWAFlatUCjz4diLFlqdeIeZ9Kb7YB2OludWlOwTRa4T7lHZ5VExgCTOF1Tk MeQ4uUtRZhxFUwJcCeUz0Ob6uQOIs6A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722906420; a=rsa-sha256; cv=none; b=h6h/8MkfU1MKbBfeFC2vZFW6v2uD/Tbb+iGObz5s5WJ9JAKLqLEKqOjeiTDO1mNppYXBY4 yagFkxCgF7odxS+wM04PFZrHswTPW8ACcfDe27k3DY0F1lW0bUse6GcZvSViaQb/rwXHDW uyl3BwVK+uZui0vKHTGXwflxcGUyf4Y= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=JSnHsOBa; spf=pass (imf17.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a7d89bb07e7so965848166b.3 for ; Mon, 05 Aug 2024 18:08:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1722906481; x=1723511281; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=r6ndtU8uZ3NwtS+ORp+o4K5xii6RVoLxBCf1D4iTv9w=; b=JSnHsOBaV+sH73IqHDslXfYQ8kmpv6PfTK1qJmOfT3lc6w719TYSsbETWJAseaDVbo xvZiSsOde7JqX/Ai6asc4nrGf6krD5PvQzGFW5S4xGVSA2gBiGzygpsH51OurAOBNqZ+ K6RK0B2Ppc1NYqqR+Mf4dy7XF51dZzbSQePjPcxXA5JF+HMWEjES2vnKEjtQHmRqgIv3 cw1/lEpXmLrK3E0oPP5JCOn7ZYyT0Qs0rF0iChAyuGvJ6aoE8dnkR01VYDhIRenALD99 lF+FOeaUPz/l2aUslbI/dL7L5ui/gQO/2S561vLKAxaOzw424LJW00j/Lr/kP98Dzbuq psGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722906481; x=1723511281; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r6ndtU8uZ3NwtS+ORp+o4K5xii6RVoLxBCf1D4iTv9w=; b=pH2jFMkUCxPz+TlPHr9Cr9c3pmUtHzH9PnQj8QgxNV0kcdFk+YvZHt2xJ1qUAv9J7+ 19+cFucOsVccRNnLElEcVJGNB01uHvhQoVRR0mbQ1xnJD2Wk8eGFR8IRB+flQRYrC/6i ft+puLl6ylgnOgtfVLOER5T3pKbquVNxvcaD03aWBYzqctl0esaEyiwTfJkjKvViaDyJ XjuhFpHBb1JP7YpiEaDs7kx0ZzLQTUoAl513IH1yzo4377weSsMiolETd7fLTXxPJFL9 thDOiDUyb3edhBLbdPDBgijZ8Iqkw3gpf3hNiuLE3kS2NDY8gyl4cbmNUpef8vcyrL60 Hz0g== X-Forwarded-Encrypted: i=1; AJvYcCUKdr0lKjUlcnkuOeAIjOZ8o5Q2TPr9mWRPvVHH3deVCYu+8P0t7Se4MLfwuYJjubOaEvX68Tkt/HhMmayK30Bb1Zs= X-Gm-Message-State: AOJu0Yzw6HT7YDLXzEf2qgcnrMhFdHrjRyjpcY6WK2qg/4K/lC/0YqNE MvEoB0OkPELqVxASfkSX5a1TxN12rXDbo8WSQJ5FUyJpRAqzbnld4KjedfQTl45zFIMDu3l2MSD juLJuBrFYd/Ikmf/Y3uaWAY4g3pHk+QtUB+qe X-Google-Smtp-Source: AGHT+IFYsmuj2eHWrNVeUnRZvUF9JRFvdYm29RIdAQF9ytbZxgKKjw/ejQs71dC7KD6rFO3aPrr5vcCIsgOM7gqvDbE= X-Received: by 2002:a17:907:7b8a:b0:a77:cca9:b21c with SMTP id a640c23a62f3a-a7dc4e8c3e5mr1042930566b.34.1722906480523; Mon, 05 Aug 2024 18:08:00 -0700 (PDT) MIME-Version: 1.0 References: <20240805232243.2896283-2-nphamcs@gmail.com> <20240806003403.3142387-1-nphamcs@gmail.com> In-Reply-To: <20240806003403.3142387-1-nphamcs@gmail.com> From: Yosry Ahmed Date: Mon, 5 Aug 2024 18:07:24 -0700 Message-ID: Subject: Re: [PATCH v3 1/2] zswap: implement a second chance algorithm for dynamic zswap shrinker (fix) To: Nhat Pham Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, shakeel.butt@linux.dev, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, flintglass@gmail.com, chengming.zhou@linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B4D3C40025 X-Stat-Signature: 3p3pg5ir3iq5tytu1nohurz9s3smahyj X-HE-Tag: 1722906482-837599 X-HE-Meta: U2FsdGVkX19BR4+T/uEc42M5kNQhnABKz3CkOtLlMeFxirvubECXwneTuyoAw0GhVZ1CyV8/MlpAl2fbJbEPYfJuIm9y4ZEz23yz6DenNaZia3VWd5jBcPpHkhpzUAu8hSOqYxZ3NsLiwOQMQbAo+Cgdr+n3Zjl1bup/yujttMObwuhC0PnPdfnNjr3jf0iQPm7A3JnqiDu7mmMkxphit7Kigg4c7ILJZmU73K4Z/lWf2eOoooXJCjaWROO60iLbs9ErMfD2eZ7JCbk9JeITg8tkOByiQz7tNZMGlgHldnInSTwo3ZtbYKOLrnCPDg8Ru1Q4kaaGv/e01A26I9cECbIpd9nX19f/GpdoK+WipI0atexX2pyiHg79gZbUzig2NHhLRVGYtNfdmK3zCfW1YO6uHCeQn2DyjavhePewrTi3SdLjTZh5NFsT1MJght5aeLPoWgHc30DV5p2I9imbBGvTvItTQ/H7VQHYFypOw2+OzOUYwW3J4OeDqpnfsMlKg8ceWQ7c3yYxJM0ZIErmTMXjJvdOZ8iosonnwd76mHGEYJM+a7WRGSSs2TtcZc1NW+mSDYg8bBpmpwRew2x6qqWmLM5ArPW3mxSWiRIKuzieH7+NtJIRVlmI3TCGPS1UNOshqvjZVf+EH8WtyGUuAvNNL9h0Ja5KQzp7C5Dx73L9FiL3hbyp+a57pAwPF0DtYNutLxyE3u1FDatovL9VKRlwksmBNoI3g/ANilKkPEGNtHHfhFvIsFk5dhl0VJgy2MOwy2vC3YU+njCVNviTPduQpyCzrPUkFVOCxcrkjlosTT8pqULnAtytXTQq/LwSdXK/sGCc8Erj+GX8V+LKPplFp57PNITOIJgPbtFsWNlx/83fSyiXg4EIspCEoDrnEGMsM5P+ryQRYQv2WGgBObZ1lvT4X9BSfKj3eL/j0h/Zo877lk0cAZyDaajPRi7BAkHVc4bezMXUdusNGfd UpOkRq8g 0geBcFg5xlT59c38Slm0piB/0872VPU9DtFywUcmuQm0mdtaIYPReHB+BzIcMUjfaSWsXuaH83ptiCJgMCKKESL4NhFH7+rb2QRx6SEYS3Otqtm0cKrAUdxJ8M7mFxjhHqh3WcrvLUl3twoG3yYVkyf1j2iN9/S5Fk3isKMHZGOIhKsf23xvpFxkgPoPzTUQWHb0BGSF60q0PiGNHsToODyazEQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000425, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 5, 2024 at 5:34=E2=80=AFPM Nhat Pham wrote: > > Fix a small mistake in the referenced bit documentation. > > Signed-off-by: Nhat Pham Acked-by: Yosry Ahmed > --- > mm/zswap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index fb3d9cb88785..44a7234a7b11 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -188,8 +188,8 @@ static struct shrinker *zswap_shrinker; > * decompression. For a same value filled page length is 0, and= both > * pool and lru are invalid and must be ignored. > * referenced - true if the entry recently entered the zswap pool. Unset= by the > - * dynamic shrinker. The entry is only reclaimed by the dyn= amic > - * shrinker if referenced is unset. See comments in the shr= inker > + * writeback logic. The entry is only reclaimed by the writ= eback > + * logic if referenced is unset. See comments in the shrink= er > * section for context. > * pool - the zswap_pool the entry's data is in > * handle - zpool allocation handle that stores the compressed page data > -- > 2.43.0