From: Yosry Ahmed <yosryahmed@google.com>
To: Nhat Pham <nphamcs@gmail.com>
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org,
shakeel.butt@linux.dev, linux-mm@kvack.org,
kernel-team@meta.com, linux-kernel@vger.kernel.org,
flintglass@gmail.com, chengming.zhou@linux.dev
Subject: Re: [PATCH v3 1/2] zswap: implement a second chance algorithm for dynamic zswap shrinker (fix)
Date: Mon, 5 Aug 2024 18:07:24 -0700 [thread overview]
Message-ID: <CAJD7tkZACWjdr6Cow74XO+Kw1Pdt7esHQss03M5f2U6P6Ey_-w@mail.gmail.com> (raw)
In-Reply-To: <20240806003403.3142387-1-nphamcs@gmail.com>
On Mon, Aug 5, 2024 at 5:34 PM Nhat Pham <nphamcs@gmail.com> wrote:
>
> Fix a small mistake in the referenced bit documentation.
>
> Signed-off-by: Nhat Pham <nphamcs@gmail.com>
Acked-by: Yosry Ahmed <yosryahmed@google.com>
> ---
> mm/zswap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/zswap.c b/mm/zswap.c
> index fb3d9cb88785..44a7234a7b11 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -188,8 +188,8 @@ static struct shrinker *zswap_shrinker;
> * decompression. For a same value filled page length is 0, and both
> * pool and lru are invalid and must be ignored.
> * referenced - true if the entry recently entered the zswap pool. Unset by the
> - * dynamic shrinker. The entry is only reclaimed by the dynamic
> - * shrinker if referenced is unset. See comments in the shrinker
> + * writeback logic. The entry is only reclaimed by the writeback
> + * logic if referenced is unset. See comments in the shrinker
> * section for context.
> * pool - the zswap_pool the entry's data is in
> * handle - zpool allocation handle that stores the compressed page data
> --
> 2.43.0
next prev parent reply other threads:[~2024-08-06 1:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 23:22 [PATCH v3 0/2] improving dynamic zswap shrinker protection scheme Nhat Pham
2024-08-05 23:22 ` [PATCH v3 1/2] zswap: implement a second chance algorithm for dynamic zswap shrinker Nhat Pham
2024-08-06 0:13 ` Yosry Ahmed
2024-08-06 0:34 ` Nhat Pham
2024-08-06 0:34 ` [PATCH v3 1/2] zswap: implement a second chance algorithm for dynamic zswap shrinker (fix) Nhat Pham
2024-08-06 1:07 ` Yosry Ahmed [this message]
2024-08-05 23:22 ` [PATCH v3 2/2] zswap: track swapins from disk more accurately Nhat Pham
2024-08-06 0:14 ` Yosry Ahmed
2024-08-06 0:47 ` Nhat Pham
2024-08-06 0:45 ` [PATCH v3 2/2] zswap: track swapins from disk more accurately (fix) Nhat Pham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJD7tkZACWjdr6Cow74XO+Kw1Pdt7esHQss03M5f2U6P6Ey_-w@mail.gmail.com \
--to=yosryahmed@google.com \
--cc=akpm@linux-foundation.org \
--cc=chengming.zhou@linux.dev \
--cc=flintglass@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=shakeel.butt@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox