From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FF3BC7619A for ; Wed, 5 Apr 2023 08:02:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DBBFD6B0071; Wed, 5 Apr 2023 04:02:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D6C156B0072; Wed, 5 Apr 2023 04:02:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5BA16B0074; Wed, 5 Apr 2023 04:02:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B76E26B0071 for ; Wed, 5 Apr 2023 04:02:41 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7AB8DAC3C3 for ; Wed, 5 Apr 2023 08:02:41 +0000 (UTC) X-FDA: 80646595722.17.21B45D1 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf01.hostedemail.com (Postfix) with ESMTP id A54A640016 for ; Wed, 5 Apr 2023 08:02:39 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=RPHLXw9s; spf=pass (imf01.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680681759; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pEwjzYcWs+Nq2B13OiqxRc4o61ZYX+Tx79hgu5r8M58=; b=LdDlQn7yynS8BElsPNbwB51QXCmTHc5FnsBqM+vqFrdlQHnJOwdtBqUOnRAGKgK5Ht/AbS /ZTA8PBwFdlHoZH7JlgZhICtHv9tcKrsgCY/L6LCdpoaosMMRP8RvKIz52DE+VCFXq5zVy QccVjlRMnkMo60G7P1ddLOUFAa4ZshQ= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=RPHLXw9s; spf=pass (imf01.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680681759; a=rsa-sha256; cv=none; b=8SN1nWa6Vvk48Ue18rxNPfmDimfkdRvI/883Qk6fL7j27JDkZrMKeJ/OKrsC4EWLOKKTBb Vw1BnWTYstDT/ejp5ZCLtOWGPBMIJq7NSP7L2qEWtc4spqtFZysxjcbYD8xUFsc04z/BjC qbnteGbO2OJ3X0T4iSaEBWyAN8S8wD0= Received: by mail-ed1-f47.google.com with SMTP id w9so138997932edc.3 for ; Wed, 05 Apr 2023 01:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1680681758; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pEwjzYcWs+Nq2B13OiqxRc4o61ZYX+Tx79hgu5r8M58=; b=RPHLXw9sSgwpHJr/+l3qfC5nPoEvslH4Vlvp7ZohRVeJUYUwEgpmuvPKwY6/LAXZ4c UOr2vNt2IlvzNfCaVQTdzSrG/5hklqwq4qvvOX5tzuKA2xdV4XLARc3NBhi1qSAOQjD1 cAmoZtTp54aqHRdSbkkOPSuSe2DuJuiQ60d3rrjhRuEDjbeDCiCtdJofsgfVpbUXlEjX CQZYdJCMd59NPSp5JXIV8SyRsgFDebBJEr+pQBUnYDWZ3fuQ/FuyH+8DnTaPmUf7AJD/ oDSYlI8G38WcKprwnEqQcqTjojvsHbIsQB/2aZR84YGGUdCVPwVqmG5BIFmMQrVLugm6 fcSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680681758; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pEwjzYcWs+Nq2B13OiqxRc4o61ZYX+Tx79hgu5r8M58=; b=DGzyC1vNMeTKDegc1yJkY8HlSMoSTWQK4DqEEB6StuUUt9THKvGuH+K9pDn9TTsI4V MvPWZSHOMFhIDI/7pKcDQS/56kei2gKQVII2psk7IeNbg7WKvPASKm1U/EII0J4q0SNL qVz4HmbUJg+GJxGzItK6kZ3bx8636ujbVMl6he4XumtgIac/8oLQSgO31UALTOJ5AiO4 g0vcUhfVBbpYJXFQC8cz+ZrxOEE9OrEayAeW/cxYT/HxTY1nRbqeb/8lRQYBfRt0e4Y3 UILYmYU7xC5644lxTSAghBa1tKbUlmIOcXeoTE3NswYTYPfmjrrK+dO/94vVdc9/LvY6 LoPA== X-Gm-Message-State: AAQBX9e5MwBjigNdZQdBAVaG/kPiUJQFP27Jc6PLMSiz7abHm7vwa6fS nzOPd2TCcJxSz8dwVQV7AtRgQO3Zo+JHnqhSzFzbzA== X-Google-Smtp-Source: AKy350bXpxYlvw6dqDC/3+ZE/o8/JBMCNfQUvuJlpr105khYN6b3g46OQoameMWIodO45GVOZYCuDafAJ9j07z3+Rb4= X-Received: by 2002:a17:907:2075:b0:947:72cd:9325 with SMTP id qp21-20020a170907207500b0094772cd9325mr1212514ejb.15.1680681758108; Wed, 05 Apr 2023 01:02:38 -0700 (PDT) MIME-Version: 1.0 References: <20230330191801.1967435-1-yosryahmed@google.com> <20230330191801.1967435-7-yosryahmed@google.com> <20230404165305.ffs7uscqpndnfytn@blackpad> <20230405080047.5omnatjbwz46f3y5@blackpad> In-Reply-To: <20230405080047.5omnatjbwz46f3y5@blackpad> From: Yosry Ahmed Date: Wed, 5 Apr 2023 01:02:01 -0700 Message-ID: Subject: Re: [PATCH v3 6/8] workingset: memcg: sleep when flushing stats in workingset_refault() To: =?UTF-8?Q?Michal_Koutn=C3=BD?= Cc: Tejun Heo , Josef Bacik , Jens Axboe , Zefan Li , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Vasily Averin , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, Michal Hocko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A54A640016 X-Rspam-User: X-Stat-Signature: f48kmnkyii3wioziodxncf58udjpd37e X-HE-Tag: 1680681759-835109 X-HE-Meta: U2FsdGVkX1/RjoSxcY+e5RVzektoq8x5yUwsOtIJAzp55kJfEAfNqr0GcA6jvW5E7UOY5LildisGW8/VV0xgZ6kBwz+W+2JXnZY9iAfVcX+bkR8EeSEbWmV2b8M7xwviDoNDTbnsszbafNdzPqYLlryERSHw2LkCxAHmcl1vnPHO0ZLAHK6iq3Nq7+poq6ZbwTbmyeo1Fle2kmBVQsDBaUhpBI8TaTcyM8qMqUwNvLr5/9/zD88bprgsA55+bBgNYLDQFL6BoAQP8gm9qDxbPM/AldFByVxBsGNUu76kNoxnB/FdHEGUVuCoC1/dcoH6Toj/bFwV3SWKOWh/lrIOF4a0TXQB2MLwrtcWk7yo54Ra+JfQX42rNOPGqlRQk2lbBUKnXoyp76v9gBlBynfTQ+y11T73egee9qMSFUBazlzzPHPRzTUjmCOa8CWKQtUzYTzVpjIU8RTLokIFIrJNeiSuN7jDJF6n7gJoi6en/1zLmqBUFLtHLBV6EFSwxHKMx0H6/vBaaRV7kATrzVxhHAXvgISNV+X5Aiypy+7FROF37E0sIeaeNwd3Gxwbfso9UDjpWzqMxkGfbmhwMjEi6S+ajqIWqAFXCIfVIe6z1PmnQug40J7G+QjZR09rJeA30QFyv0LD+dq1xvAOUOyPJewefkMsSoF8da5WFDeSLiWgVwUrdO7uIUIb2QFfvjI84b/KctX5Rct6pOx19EefSlVqkvswQr/6NqE0nvjAJa7DUwTApAqDFT/k8sPdn3D6cj7WvNVdxWaizSdVVIR9WjffoQ9OLUYuX6s5xiNT1KIMU09CeYY+H7fZqMZG979CTdvraag5DbP+LQwSLn1vyvCZfrpBPk7nx+V0xyw/wjNxGKlHYsOsNilYq7151463Icw2wlR1HSMpu5ZcAKZlwSAACbQTAi64GZCH7izvOJPRjztUEANF8n+H4sCjM9RBlV6TbqfitmJeFWBZApO igsh39sX W/WN/4I0GVEnA9Tkc2J2bT0umuDtHb16qTU6i4a4izaBqKrxUZqQMQtvwabNlR5EeU3Y7goPstyc16Z06bgHcgg5N+mqIoXyui8Edxx14XYHZVqY5xE6kqlknV41cUW+uws0vOupQXHOb+e1mr+MDR96F65VemFKDv2Jz4j7IAD1EMf5ftrhe3du8BFKyVpyK6186AWByoPVebHXOZz1jo+e5ozr/BD+GasiJYkESyWvQD8M8/N4Jo4mbs/oh/AvOU+5ba68jAldk6fC1Vt84KBri5P/RVydSjALgfwg3uk5n/ynpDwYaLamtS9dryIOgvVZyI8b1Ry5zdco= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 5, 2023 at 1:00=E2=80=AFAM Michal Koutn=C3=BD wrote: > > On Tue, Apr 04, 2023 at 11:09:02AM -0700, Yosry Ahmed wrote: > > IIUC there are multiple places where we can sleep in this path, we can > > sleep waiting for a page to be read from disk, we can sleep during > > allocating the page to read into, and IIUC the allocations on the > > fault path can even run into reclaim, going into the vmscan code. So > > there are precedents, but I am not sure if that's enough argument. > > I expect it'd depend on the proportion of the slow/fast paths. > OK, let's see how it turns out in wider population. Agreed. It also depends on the number of memcgs and how much the periodic flusher is keeping up. I think no amount of testing will cover all or even most workloads. > > Thanks, > Michal