From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AED1DC001DF for ; Thu, 3 Aug 2023 18:53:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D314C280295; Thu, 3 Aug 2023 14:53:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE07A28022C; Thu, 3 Aug 2023 14:53:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA83E280295; Thu, 3 Aug 2023 14:53:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AB2F928022C for ; Thu, 3 Aug 2023 14:53:02 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3B11CA0750 for ; Thu, 3 Aug 2023 18:53:02 +0000 (UTC) X-FDA: 81083690604.23.412B202 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by imf05.hostedemail.com (Postfix) with ESMTP id 5BCDB10000B for ; Thu, 3 Aug 2023 18:52:59 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=GzW5xwJ4; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.169 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691088780; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=16O8o09yKlIrWJqVGKmGPXtBxRWH/JyAAhiz2PZ5hMc=; b=tO6LZCUpMM1P4ZzFiScyPTpKhMVp/toJQdFbxl6RgJmBi3H1l9C8gv/4FcUjXhIIiN0DK4 Yx1+o8uFfrRtlRH/ag+FuaDL0tY+mcsCYeuvEmllMCbLxkOQTyXPu/toKObDFxTNSLa67b R1pZg8aZClmGoTMVo2PClf589rqDgAU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=GzW5xwJ4; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.169 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691088780; a=rsa-sha256; cv=none; b=anVzmnECLNsQhbTj+nfWo3gymQQFOOjo4qKPEhnf4xzdFHhp81/uGLMi5RGXHqSwtIW5W/ 1ht4kL/exfdzQwxxCIgGRtvUt2FY0ZzrsDBQZNAVi6ODrsVdS6rezRkGSxzJr20qXNDwRE 1v7bIgUnvlyu4Xwz+T6xHBwHGtqhg9s= Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2b9d3dacb33so20647881fa.1 for ; Thu, 03 Aug 2023 11:52:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691088778; x=1691693578; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=16O8o09yKlIrWJqVGKmGPXtBxRWH/JyAAhiz2PZ5hMc=; b=GzW5xwJ4SS3NFZxvIos1RPhdVI40cJHjHyRgQFOtkhHPZz7b+nSGci357csx/1V2IB WF/FvNJGDDyqO/t3E1XggUbY9hOBM9OuzEOLda5rk/HOZdxPZ99UbIg5nx5kFScVSxEb lv/ICaBqhOvyMSyCpzHn100B4O3Xlrt3LZcr3JiV5+wHKHd6ztj7RzCygsqmrZhY6dvv pyM5Kdh2l7+Ba4qn5QYe8t68ZnsyC56FMznLyFS9c8erDQnQz5aNcCsr0vgMF5pStmOr xfMftZnQ/q87+szHwrXALvSxxMSMtils8s1jU3ZbaDbZn4DP4akZAjg2dSLbWbGm8Iig vblg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691088778; x=1691693578; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=16O8o09yKlIrWJqVGKmGPXtBxRWH/JyAAhiz2PZ5hMc=; b=VSX26m5E+QtQ5USxdILAZ01KxLUBL7CK/VEwsurBS3AsNYHQKxrysr5aIJ6PNlOgcD 9Xz2C9/H8LqjNogHtsUKbhgwcjPtZ5kj1gJquHojtc6F+zj1k1xux0BH5wLNQmPNZ/tc ybxJSp1GQ9PNm5Efrb54Wh8bQGiy8/r71F2YnOs/eUvIjAz634VwMMH+S4nzZqhxVkiV Idy1FoG2dtwLE03wT76kEvAAB6b8HCjNNoKEDi7Iphi8a092yXgo5MIzQ9r06VotrQaq zMLh7wb/skFPtXw0il4pCpuaXy3ZWgAvo+du05NlJ5DXazdDT+ZaYyAnFtjhy8PFelfO jEew== X-Gm-Message-State: ABy/qLZ08gYHIJZt3X0Mpe8CZDmVv+X8gs17U/3cr4DmxLx5qNEZTdUc WVigda1d9fQVsdFJzouPHvLp3S4C4ACBewDLXtqWvQ== X-Google-Smtp-Source: APBJJlG/Kp8wtYMBiWPpzTFP8Ihv2XMSuxMuJWKmxLJB/63skudYdK57L9Kzc8xr7IwRqG5q3hKp0UuZwpqXbfioyZs= X-Received: by 2002:a2e:9316:0:b0:2b6:c236:b040 with SMTP id e22-20020a2e9316000000b002b6c236b040mr7662784ljh.12.1691088778226; Thu, 03 Aug 2023 11:52:58 -0700 (PDT) MIME-Version: 1.0 References: <20230726153223.821757-1-yosryahmed@google.com> <20230726153223.821757-2-yosryahmed@google.com> In-Reply-To: From: Yosry Ahmed Date: Thu, 3 Aug 2023 11:52:21 -0700 Message-ID: Subject: Re: [PATCH v3] mm: memcg: use rstat for non-hierarchical stats To: Michal Hocko Cc: Johannes Weiner , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 5BCDB10000B X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: imi9x45739i1wwgbcydo3e76wf5z8a8m X-HE-Tag: 1691088779-563680 X-HE-Meta: U2FsdGVkX1/ueWeq5OQMaaKK6zDroKZV/A9rh6/ewjSBRDbZvXr57C9BGq/r8VRJDswSjEmKafag0qdPXYxcNAtRnwNSZ7cGT1vrKqiuCAW9aAqCsKeq3SDFVzmmF7TwRHXwAgqqtoYdJBRIFVdTNAz5kHn6affXSQ+fZnU6jlDWwlwK869yGPxaOovpBvv8A7y/JSLH1WZgna+G/cRXXAOkRrlVSMZ8G/En7zYt17sTvQbEHgBcTyEX/msnRNewUq///cy5QLk4f8Htdwd80Yrxys0VqiUGVhpMr2mToM0H8oZ0YfJWviw9BOGILTfKch6m65zdwb+gjDFGDOY172wwXDa1Z1SB4AcnG7y6KBOjJmrJipPWCK69tIx2fGfhQw1JecaJo82+CfG/GuJ40MfvUnksohOZmo1Ig1zqtJ19u3ameafQumJINhXDYE6rXWvLIOZw61WndHHJhnR5RaVx5CjMdBoasEGVyvyBnfs0rBJEExJzaw2SdQEmrXtVa5LU4Ga3iiTo0hRTz90rtxbMIdqLdAMpZtUWLIAHOrY3T2PcKOyq9LvoyWVa+9LOLtPcYQfyIHDdv/JWqMxAnY1XK9TXoFi6LlzV+I38t4y5RxHyLrt6FsRtTmTbpVm6AHrq7+aZE8cnXB4h/VF3eoLuZXZAqecMPdcBuKesYrDmI7W8qzjwtBRql6ZfNb4q4tWAthfzGCF8uDP92hAv3AXBZIJADlLBkDuqK/q6MwCqr1vEbj+yl5Z7Nd3gprJ9P1k3M7fuNYM8ODWXLpE1145VXZ4cnmvQsCLpk1xrOyyVIOpV5YbXMK+pDWQITTCjJS6tkY+x2mf2M35ro6gvsyy+xT0zPU8QiB2+pGLemKSj4IKkMDLM/L+kIyPxW5AT5MdU1ZOZSqxSjnrfXT1UigoRzTlu1tF2K+s54b2bl08OhJ7AOFH7KJq7QB7DTz1H1kdlSoMfSDj/D1RzD8e OFMnfrxG 8jK3oM8bh0mOgDc2jJMr7Z23XG4jADgFtC5KVVcBE/PPMymd7PvdnSKR9BfLPWtPFnyyI1JOfoL2S3xyw0Kua2wSfh3B2qq+2IBsr2ADnwZ6AfYLOBvqJ5e/QHMmzO/A9LywMFDe65Meh+in3gKWv0cc4o33ViECdPEEl8eww7KQoGw+DPtsMp4LQsvPaWzvLCcXsuEGU3GN823N3hUjzsgyDq+toZK3kZYGFW5wK/NyULfIu0ZdWrhxVz908TVevUXeQ/7bFkSrrEs4RwGC41koKiKld4pEsSwVE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 3, 2023 at 7:55=E2=80=AFAM Michal Hocko wrote= : > > On Wed 02-08-23 15:02:55, Yosry Ahmed wrote: > [...] > > Let me know if the testing is satisfactory for you. I can send an > > updated commit log accordingly with a summary of this conversation. > > Yes this should be sufficient as it exercises all the CPUs so the > overhead in flushing should be visible if this was a real deal. I would > have gone with kernel build test as that has a broader code coverage but > this artificial test should give some red flags as well. So good enough. > Amending the changelog with this would be helpful as well so that future > us and others will know what kind of testing has been done. > > Acked-by: Michal Hocko Thanks! I sent a v4 with your Ack and an amended changelog that describes the testing done and points to the script attached here. > > > > > > > -- > > > > Michal Hocko > > > > SUSE Labs > > > #!/bin/bash > > > > NR_CPUS=3D$(getconf _NPROCESSORS_ONLN) > > NR_CGROUPS=3D$(( NR_CPUS * 2 )) > > TEST_MB=3D50 > > TOTAL_MB=3D$((TEST_MB * NR_CGROUPS)) > > TMPFS=3D$(mktemp -d) > > ROOT=3D"/sys/fs/cgroup/" > > ZRAM_DEV=3D"/mnt/devtmpfs/zram0" > > > > cleanup() { > > umount $TMPFS > > rm -rf $TMPFS > > for i in $(seq $NR_CGROUPS); do > > cgroup=3D"$ROOT/cg$i" > > rmdir $cgroup > > done > > swapoff $ZRAM_DEV > > echo 1 > "/sys/block/zram0/reset" > > } > > trap cleanup INT QUIT EXIT > > > > # Setup zram > > echo $((TOTAL_MB << 20)) > "/sys/block/zram0/disksize" > > mkswap $ZRAM_DEV > > swapon $ZRAM_DEV > > echo "Setup zram done" > > > > # Create cgroups, set limits > > echo "+memory" > "$ROOT/cgroup.subtree_control" > > for i in $(seq $NR_CGROUPS); do > > cgroup=3D"$ROOT/cg$i" > > mkdir $cgroup > > echo $(( (TEST_MB << 20) / 4)) > "$cgroup/memory.max" > > done > > echo "Setup cgroups done" > > > > # Start workers to allocate tmpfs memory > > mount -t tmpfs none $TMPFS > > for i in $(seq $NR_CGROUPS); do > > cgroup=3D"$ROOT/cg$i" > > f=3D"$TMPFS/tmp$i" > > (echo 0 > "$cgroup/cgroup.procs" && > > dd if=3D/dev/zero of=3D$f bs=3D1M count=3D$TEST_MB status=3Dnone && > > cat $f > /dev/null)& > > done > > > > # Wait for workers > > wait > > > -- > Michal Hocko > SUSE Labs