From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF225C67861 for ; Fri, 5 Apr 2024 20:30:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 578B86B007B; Fri, 5 Apr 2024 16:30:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5286A6B008A; Fri, 5 Apr 2024 16:30:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 440EA6B008C; Fri, 5 Apr 2024 16:30:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 25B9A6B008A for ; Fri, 5 Apr 2024 16:30:21 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AEFA2A0257 for ; Fri, 5 Apr 2024 20:30:20 +0000 (UTC) X-FDA: 81976620600.10.B86A9B9 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by imf14.hostedemail.com (Postfix) with ESMTP id B8D4E100005 for ; Fri, 5 Apr 2024 20:30:18 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=DDSYKzCT; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of yosryahmed@google.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712349018; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M+jEmOFEjTU7lwjjt1V5FPrXRPUYL1ukEXhP8ohspNk=; b=jn1YdI9O2S80bDsPj93Z05SPvwvl5QdBQO1C9iFAe4G+z3m+f6n6UP0Qu3F+Ns2E4ml9RG +Tdk4QTp3vWytPTvpPYbQaV5b0vKSseAvw+ijsg3rucQwcqSFZLYj5AdX3HOdFfcgKLpQt unx1FV76J9uOwcg1GhjQR3IJrsE3/bw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=DDSYKzCT; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of yosryahmed@google.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712349018; a=rsa-sha256; cv=none; b=5Q9NFhL/m6n78xa3CzQ+iztn/8VVi48ra1VJPaSVS23jGxuS7Pe15k1bqJcTu4QPQIj/Au X028b3RyAfCoHgnZ+8/HznAy5ef5DyHYpuaGzFiuWVCAAOaqFs2aBAV3h0yo8OMDShHvid ZoJ6L2Cs3Rp2TfIBaU66oUE2vKDp+4w= Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-516d756eb74so855388e87.3 for ; Fri, 05 Apr 2024 13:30:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712349017; x=1712953817; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=M+jEmOFEjTU7lwjjt1V5FPrXRPUYL1ukEXhP8ohspNk=; b=DDSYKzCTx3QcDZ1TWqxihr3/OlT6KhtgCORP6gvmW35PeqfqVlRJ2HDE6aEDMGpj91 bnEGeqvb3ueqaFmkQT7sosovD6B+acBndWsIDu/sQHP5G3ceJ1k7vggAXacc4UuAq58I dZ9cq1rBkD2dnP59W5DAeys9CsIc9aIE4UbFLIDDvzwI2QNcGsNcvk1gKcd66wGK4zlB jz2H+7oco5raowqrB1pAImEwLbHGlKDSsfER/gEO7xdVgISbTIuHG1Nfj5BBNjRJIHcj WBBnsWndRAua2T/8W0BvPv0D6C8Rdq0wJGuwZUuSTGppIlx2tsRI9xZI7Abyb9xTx7ZI j6LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712349017; x=1712953817; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M+jEmOFEjTU7lwjjt1V5FPrXRPUYL1ukEXhP8ohspNk=; b=SEBEKijTK3GnkXoMOgmNleY3ewLiv7zEXUQOPVgmV70alPhcvpZTO8XLDVhwSBlbwC TIIJOH+ju8NC1KMpCiiBZmmOMSQ1+efwRRENfNuzqln1sfoSBa+vlTZlL/8OLb0ZtJ8w mPEpniLDbeHCQOYWD9YRIz4dRL4IjtohikYblJMEfRxj2FaVULf2CR5PZKqRLfK/lAxe zkLRTbWEYutzWwElu/5CupW2Yq/lMr5rD6XpgeZsIcl5XHwSUZAN/qDHDrv1Hsb00nVR ISArPlXbGREscqWwCSmJIOwILP4ews9Dc87/Ucq7PnRnUFSokGQBBn7uci5UflDnZdVP LS6Q== X-Forwarded-Encrypted: i=1; AJvYcCWFnXF3njyok3ubE5+9s+exQqYGE2LJKigoBONtzByja6u1jkl5OKBjQmlD4X2ZD2xUsNfYZ1IwVwa2Ozxhzmc3M0U= X-Gm-Message-State: AOJu0YwK8MMI1jl150ckUW5SFR/lP7HW4ICEWF2MQmaICnIah9qc+5WU wUgzOsM3MG1UYI2GLASVjyUyZBWeVwIaLSYf+Li63A4Qfe1DnQ1mt1VjLyVJvojtqKyyAAQg04t hDneRUwJWN30G8B5a5SyKCH72ZglOGGcaDW1d X-Google-Smtp-Source: AGHT+IEctCIw+qSiNBMbysTxNZa7FXusQuq+U7LwmIXIiKndMkDSxEkCWBXPlF0xCd7GX4Brs7t/yyuAjdtpKpywhjM= X-Received: by 2002:ac2:5964:0:b0:513:edf4:6f20 with SMTP id h4-20020ac25964000000b00513edf46f20mr1622327lfp.54.1712349016554; Fri, 05 Apr 2024 13:30:16 -0700 (PDT) MIME-Version: 1.0 References: <20240405053510.1948982-3-yosryahmed@google.com> <202404060445.zMPxumi9-lkp@intel.com> In-Reply-To: <202404060445.zMPxumi9-lkp@intel.com> From: Yosry Ahmed Date: Fri, 5 Apr 2024 13:29:38 -0700 Message-ID: Subject: Re: [PATCH v2 2/5] mm: zswap: calculate limits only when updated To: kernel test robot Cc: Andrew Morton , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Johannes Weiner , Nhat Pham , Chengming Zhou , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B8D4E100005 X-Stat-Signature: kqejynnq937cmqp698zph71brfqq1tk9 X-Rspam-User: X-HE-Tag: 1712349018-26607 X-HE-Meta: U2FsdGVkX1/u7EKJoWcbGUxto6ZYkNhh0f9G5bK8cuqwvP4d3KaaL+jtKVr00+JOYubDRBDdrsyweZqYj4VeMj+LrvYgxI5nTFG0s9hr5sdBOGB5xslsHDHta4HAHRmXH6HZuscxdtAdjwN2ubynJFl6stcb/1hM1HNfTzgfAD396gaezH22g9oHJ+2/ppOA9sxcuAVcJVXxcE5Aq+azZrcppnCUi8uaIj5vlz+d5TecjEO3BNEt0AilHRPqvNgpWP/OsCKxQbwgFKFEi0TNvD9vu8V60vhHbbIDDMO0kQLLZVIPiIXrmj9imwwJpIDVW5i2IJWADkM1Njon3X96uPzICz3zeEOpm2/S1bU8lBqBuG75wefsJ43l0sRxSyfw+qOfAR9fWcY9Vlp9IS9yMu1/Ntw8/41x6WTEuUvVQtWA/FoQph1z0EBmEbeWx+9o3OiadU/lQe8J0GtIVWZt87NvDzMNEODFunAyHC+qC9/syjHajXvoSwiWnxEcIuVReaaWYs40QrP8NnIXcHov1XoXmNEsxwJ/eznxXR/jYDy2hY/z7fBfTVkOgiWWVH3Hq0AqCmK2RpFYtRnmxLiMqn5TDoQ02uK+h2+qLUsAca+UDgMIs7RlrOwB+xlL11FIuAXCcu38gpoG/BR578oqKWnUdL+GzwWO2JEQ41BUM59l9c23Qi+gdhT8c6Syg9NpA0OsZd/UEEfPXMu+IlII98wTk105Mea+iMiyL4cG0W8ZQdR9JQEShnTbGmk86hPqtCflzeLrx8tUWk+WSvI44vU99oRLV4VJQamLikTha8zTtE2Roc0bju81Bk7EiVZDSrhtC5Iem5J43rzrRTYqGspyH+i5/Klet2Bc7NUfPd6wMcEXeRhY1SzmqAJ6rW0i+mdpCuvdCY/GXRyiDdP6rz5ggmrLYm0imIBV/XpwccWqDcjpFDzBbWy8YCnIaeWw1SYfBDwlni0MfEz/XxE wVN0dhjm H+OI4psYq+QKXCjBH1SL/Co3LzGZ/V/p8MbJeGZuP8Sp8TnpMAF0WATiKKHQVRpfiCUyRGnDFJcfIXsd4WZfdo9alAD+zvczfAtpSM083aRQmBNj/mpaCws/NR6GL8rPW9N54hcLQssW6LI2ju/MXmWhjrIPm7xJoy60hEd1K43CjVwOhX7qJ4Pmb4KDkgvReXUj2zUK4VTbRI1yxOlftsVuey1MIWh3sWutJsTAXh84GQEeKwaA9QsDwvh/bWBGSO3+Gui21jnI5sIqZUkuAzN/Ge/ekG2snoPUPLywtRvS+moBL45U3NoukztMbiQ+hZdrb4WOBcwj2uwRVyQ6GknZK5zYtw0KN1W1HiUM4QiCXzhLM3DqFLbom4u5tGM6e5LDFtn4MUe0jNWZODQmjt2tjRCwsibTnyaV8VKjVTRltGQ570x0E69NKBHYF+x2piIbxIrrtKiKKq0mwyLwhkOrYpz4PTqCx2Qy/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 5, 2024 at 1:24=E2=80=AFPM kernel test robot wr= ote: > > Hi Yosry, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on akpm-mm/mm-everything] > [also build test WARNING on next-20240405] > [cannot apply to linus/master v6.9-rc2] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Yosry-Ahmed/mm-zsw= ap-always-shrink-in-zswap_store-if-zswap_pool_reached_full/20240405-133623 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-ev= erything > patch link: https://lore.kernel.org/r/20240405053510.1948982-3-yosryah= med%40google.com > patch subject: [PATCH v2 2/5] mm: zswap: calculate limits only when updat= ed > config: i386-randconfig-061-20240405 (https://download.01.org/0day-ci/arc= hive/20240406/202404060445.zMPxumi9-lkp@intel.com/config) > compiler: gcc-10 (Ubuntu 10.5.0-1ubuntu1) 10.5.0 > reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/archi= ve/20240406/202404060445.zMPxumi9-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new vers= ion of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202404060445.zMPxumi9-lkp= @intel.com/ > > sparse warnings: (new ones prefixed by >>) > >> mm/zswap.c:132:15: sparse: sparse: symbol 'zswap_accept_thr_pages' was= not declared. Should it be static? Yes, I already have it static for v3, which will be sent after the discussion on this patch settles.