From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1EC4CF6494 for ; Sat, 28 Sep 2024 03:00:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 483936B00D3; Fri, 27 Sep 2024 23:00:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4336E6B00DE; Fri, 27 Sep 2024 23:00:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 322296B00D4; Fri, 27 Sep 2024 23:00:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 14EE36B017E for ; Fri, 27 Sep 2024 23:00:42 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BE5AA41630 for ; Sat, 28 Sep 2024 03:00:41 +0000 (UTC) X-FDA: 82612644282.01.D72C3DD Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf10.hostedemail.com (Postfix) with ESMTP id 04955C0005 for ; Sat, 28 Sep 2024 03:00:39 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Wp00Rj36; spf=pass (imf10.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727492402; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2k+I2VtZ/B8mr+jqBoJEI0QZjBBEFXXtfGznpaJkdZ0=; b=mJM2rP8LNs7Cz4IKzMMXivv4O/W377+K7hTAS5x5B5S8W4XL0c8hq8QPjILIAGCR09ICLM 81SudrQXKHcx61fESucEWmymOvxgMy2GSXW/nWK50skSA9gsTKTa9pWla0Bmmnsc2lJV+L 3GzwX7ErJ/geoueTmcBGWGhsFl9upOg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Wp00Rj36; spf=pass (imf10.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727492402; a=rsa-sha256; cv=none; b=yzF2BASA/TdAh2iHoQ8WcNcKDhGNJ2BODQFPN2oPA+kH8O5+PWXGdTLIxL3Spv5c5eVVbT clk9hR+EQblsipbzkKq5XOZuQ4Y+NVc+2i9Y/hN9Exk0yKuzZ/B4VH0BjuLLAqNxjWxPil B7Ve9fHEPT+QyGmJzd9CtwXm2Hj6P2U= Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a93c1cc74fdso293248166b.3 for ; Fri, 27 Sep 2024 20:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1727492438; x=1728097238; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2k+I2VtZ/B8mr+jqBoJEI0QZjBBEFXXtfGznpaJkdZ0=; b=Wp00Rj36YmbVqGXiqqC46tooT4xgvtxOlJdvO3DAikPTur/U3BLMK08uYpXLWD1R/X FDV2tLZVhvZ64845YqVxJ+r0eA3PqvZyZBwKiW4E9XwJbkadJMZ47urz1OWuXsROIp3i DL79XmfPjq7THnU2+HIgcGdI7BUwbSlUqO1S7Alylh204vAETnxd12XLzmitSmkUB43D hn6dmZUHTbHxPcryB7AAJkYji38eThbxkjHbJYPBMhNjHlMykttF5kJR6GLHqITivI+c QWA00Q7Qxz9r7Ju4kt1b4NOqH117rrFAOMmo4kc/zVKeYzqvf1boFrnHoWZ7xbHBK3dZ Ta+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727492438; x=1728097238; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2k+I2VtZ/B8mr+jqBoJEI0QZjBBEFXXtfGznpaJkdZ0=; b=I2WI9Q7/P74SaM1cW7iYIUbX08KFkF6xdLf4EmVUHAdaewGSboJAwjqlj7q4JkTcMB 1KTYAfqaRwOZYO/rsoTfPwu3H4GgtjndTqZllnSOhTsHtRRKHIvIe19euhNMy6dmoWU5 +D4CxPZgsFTolTFeQEEICdPCBHLi6rBFt4S0wh4fN6qfW7JaHMHvqqJONDsmexQm931L p7YfbphLkNTIPq8fmak5aa47o81yZyqCHhZHgf5CK6aEh9mcT/PCxju+zkpCKvGsLjEl F3SiVbHyaLB1Ucn79GiwFvrzJt6yHnQJsoKVoi8aCmH0xv7xCiBHhu/xRMwf8lZKWYzt OqfQ== X-Forwarded-Encrypted: i=1; AJvYcCXCwAREh6Y/OYqBfkeOZmMbPQ7SHy969pdwSz0p1FWcBs+YKvi3uxsW6zev9cp+dGElEVuhnnQAWA==@kvack.org X-Gm-Message-State: AOJu0YxFVjmx5xIULeBqKtMPNw6lLcTLjBEIEhGY4t0dM3z1bVrTiOPl LUp3cXTFYz+bpruA8P2nx1hEsJo+0SJgnqdmE+8qao7N9QKMClfirmJwoS9NZ5iXOOKdiBGmivh IP0bAIydB/zv1CGejwCfyC2quQOwWSGj5A56c X-Google-Smtp-Source: AGHT+IGZt4+wVCsVpg56gQBE9wdBJQWPEXP2IWOGKV8662NYWiK16ueqTIDEYhUO1aDDiCZNUqRuKRNGJA4KDP4HJyk= X-Received: by 2002:a17:907:a0b:b0:a8d:2c3e:7ece with SMTP id a640c23a62f3a-a93c492d4e1mr473127066b.31.1727492438270; Fri, 27 Sep 2024 20:00:38 -0700 (PDT) MIME-Version: 1.0 References: <20240928021620.8369-1-kanchana.p.sridhar@intel.com> In-Reply-To: From: Yosry Ahmed Date: Fri, 27 Sep 2024 20:00:02 -0700 Message-ID: Subject: Re: [PATCH v8 0/8] mm: zswap swap-out of large folios To: "Sridhar, Kanchana P" Cc: Ryan Roberts , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "hannes@cmpxchg.org" , "nphamcs@gmail.com" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "shakeel.butt@linux.dev" , "Huang, Ying" , "21cnbao@gmail.com" <21cnbao@gmail.com>, "akpm@linux-foundation.org" , "Zou, Nanhai" , "Feghali, Wajdi K" , "Gopal, Vinodh" Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Stat-Signature: esbhdg5ue3hj6syzyswu9pwqcf61zzc6 X-Rspamd-Queue-Id: 04955C0005 X-Rspamd-Server: rspam11 X-HE-Tag: 1727492439-270401 X-HE-Meta: U2FsdGVkX19OB5u2ZDJTrP2DEYAj6Q28+DY/EqtNpuHdsCiUEUO8fMbJf+CMhFue0ypUyiSgSoF72Vi1/2Me3ISa3yzLmaTpHdMz+zSjHnPaJ5rfxM3tc8awuYfy+7Xm9+gcdPzmnZD7/cOKLXjyq26Q5KqYdjOwo8lR1oXofMkOKpiLz34vaOZBu8jqovvtDF4KB4Ef89f4WpGfywCgkaI61B78AEyUuBrAD8HAHVU0lNhXssNbD2YRCN0cMUO6D6GHBcYsfNndxtGSeI4FDcgyBdkzDrtPPaowDUm6DoMrYdonzScp5OhH5LGG7St7v9ovF7NtU++Kps7jiEQ+QOrymxDf5ZIhNLISQMssNqzwJtVnLvpAdoHqz3GHSDK+LUR7FD+bT8RiCSfqF7TGHUvkR1aOPoi2gzBTZa/ypFi48TUXZIInZtKENZ2MbPZj5denxBwl6ud11L14/DNkkSmcTF/i5Lr9KFfKAAJBJ28iBe4XHPkcX+0W25dgGp9wKguN5pcR7PQmpfu1nOB5dl2O7HJyxYEp9+7kWna56NgSyryJH8UTbifn5k4a9W+VMqfuojQag4CiEdq/W8eZM22Nr8o740VQ6dXnatGtkEkj9iy59GZjhjUmKwfLsoSALxx1VviZe8XS40OSIKMzh51BgW8VQCm0SYcocO+j8PqqiYgnzhRQxaddY8tdL7+ALSGXEWrHIlGVm3YnC0E1hF+qie7JPCwJBA63+R8xs3h9PiAVf5KM76u9X0mslbMpV7WWMJAVmF26V1/kGkDUXAVRMwgMZTZd/4SjrGUUiqbyCOI5nsSosdQ8jltNc7xpL2/VqJChWqf54CR+XK3iilMAq1qXn2hGiTZBgFuUZMSmzVkxy2xQFEkUPNA42y69yfcSmGau87RsThIuLn+fYd8T2l75VPQfSWWbb/VpTnadSd5IeVtq7Mi24YD1/R0hVz9eFy4BcI1TM+SEVu1 Lo8uzXjT vvtFLRxVB3g/+n+skoN2TrSzIymcchfqLOvnaJI6oGWsTrb1fM9oozLoPrKfpPEz3l9UeiuS8pePVT5fktfnGco3cc5dxmOLCte10QISXGn9/R159DGPJM6WFjXrSwaYuUukxkKdHpAjOuuBB0y+VdKvyO83X09uJ/1L95/u75NqRvTffs9yhZniHK+dNJzDxAo4I3P/VWXduTjWxxbd+R3b/KzkumMXxEf0Opr6S1mseucI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.014694, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: [..] > > > Performance Testing: > > > ==================== > > > > > > We list the data for 64K folios with before/after data per-compressor, > > > followed by the same for 2M pmd-mappable folios. > > > > > > > > > ------------------------------------------------------------------------------- > > > 64K folios: zstd: > > > ================= > > > > > > zswap compressor zstd zstd zstd zstd v8 > > > before-case1 before-case2 after vs. vs. > > > case1 case2 > > > ------------------------------------------------------------------------------- > > > Total throughput (KB/s) 5,222,213 1,076,611 6,227,367 19% 478% > > > Average throughput (KB/s) 174,073 35,887 207,578 19% 478% > > > elapsed time (sec) 120.50 347.16 109.21 9% 69% > > > > > > The diff here is supposed to be negative, right? > > (Same for the below results) > > So this is supposed to be positive to indicate the throughput improvement > [(new-old)/old] with v8 as compared to the before-case1 and before-case2. > For latency, a positive value indicates the latency reducing, since I calculate > [(old-new)/old]. This is the metric used throughout. > > Based on this convention, positive percentages are improvements in both, > throughput and latency. But you use negative percentages for sys time, we should at least be consistent with this.