From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24AC7C43334 for ; Tue, 12 Jul 2022 23:04:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F86B9400D8; Tue, 12 Jul 2022 19:04:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 97EC5940063; Tue, 12 Jul 2022 19:04:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 821159400D8; Tue, 12 Jul 2022 19:04:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6BC32940063 for ; Tue, 12 Jul 2022 19:04:14 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 3BBBC1209FE for ; Tue, 12 Jul 2022 23:04:14 +0000 (UTC) X-FDA: 79679978028.31.4B9E78C Received: from mail-oa1-f49.google.com (mail-oa1-f49.google.com [209.85.160.49]) by imf20.hostedemail.com (Postfix) with ESMTP id C3A5C1C00AC for ; Tue, 12 Jul 2022 23:04:13 +0000 (UTC) Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-1013ecaf7e0so12097848fac.13 for ; Tue, 12 Jul 2022 16:04:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0kilpuaWkkH1jWKZwcnpv75y3bBAyVMGJWLT8pq7Zew=; b=ZBE5KGyRMkxibp5iaQK1l2yLFQs3jMAWpu5gwk0mkKX4ubei8nAy3KENVxr6zAoHjv GxxAukLzTPcow4xb39vYwDGdcaSRPa60fmvrQz7t5M+INg1M5ckPSC915vA9q2vN94AD /SGqziGRgsU+lRLMnfhy3E5QN+LwNKSm54tmpu0mNnq5YnUHuf05goqCVAxNqaaAiN6B kCkPthpHgFI7wBZw9z3V/ubta+xmhbhQHRM/O5EcP+46woLYQpwn+fg2Dj/B6KQdkz8q cxYdjJT7Re3j22yGvnr+ktEYQOKJ6wkxisMXfv/a2tIwVaodgTZvM0zkiXaKA3U/CSDX wuPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0kilpuaWkkH1jWKZwcnpv75y3bBAyVMGJWLT8pq7Zew=; b=hrBEoRi6o7xn/OxRG/RTuzp84drAh/BiMNiyb9+dERbL0cXBWsHYE2lDzVPpcJtdHB oyLKpvKJbTuoovEamGq6RRWrd0aUf6NiJ0MlL2dWzJsCzouwLWajKt9to5Qi+KQTf8lt 6mEBnG6fKETidRqmi9EuFi38ces2WHy65VmLboTVa6/Dd/EOCE74Xo+YAoV6YPb7Emik csU+uC0f5Wfg7+BXOfs+TMecznHnLbKlKjyMYeIrz8aZZ1/IyyDOHjGY6pJ/Dg/7s0Ma Avf1A3QOXIQiCaGL/qmWZ8cR56bgdGxalVJWlkJbx4KG3+FXocwyXir/1fbKOZTWrH0I ssbg== X-Gm-Message-State: AJIora++CBm2zXWIV3RmFneGR3VTBIASes/Np4zOi5jt5xmRP4OYqJhT bWAjLRLVNR1KY4L8QtbVAGBQJXd7b2G5jRim3YTRpA== X-Google-Smtp-Source: AGRyM1uYZ+G3f4X735Xr0IJWdBmvb830WjZ9bkBphZtyS8Anj7WjdMlYQpZtxJ6khjfO5cktyObZb/GpgNs5V7B3uuU= X-Received: by 2002:a05:6870:d349:b0:f5:e9ea:5200 with SMTP id h9-20020a056870d34900b000f5e9ea5200mr3194460oag.235.1657667052905; Tue, 12 Jul 2022 16:04:12 -0700 (PDT) MIME-Version: 1.0 References: <20220628220938.3657876-1-yosryahmed@google.com> <20220628220938.3657876-3-yosryahmed@google.com> In-Reply-To: From: Yosry Ahmed Date: Tue, 12 Jul 2022 16:03:37 -0700 Message-ID: Subject: Re: [PATCH v6 2/4] KVM: mmu: add a helper to account memory used by KVM MMU. To: Sean Christopherson Cc: Tejun Heo , Johannes Weiner , Zefan Li , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Andrew Morton , Michal Hocko , Roman Gushchin , Shakeel Butt , Oliver Upton , Huang@google.com, Shaoqin , Cgroups , Linux Kernel Mailing List , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Linux-MM Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657667053; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0kilpuaWkkH1jWKZwcnpv75y3bBAyVMGJWLT8pq7Zew=; b=Ai8L+kSJHOA/0glhfSDVFitZPKXmnC2bRiljDZHUzRcQkNCeu8RDRqiW0KLGZpB3+tDpmR 5F5TebXALQrQI7rpVLjh4D9K/PjuEnNu5Z5gqclsKHuzqYYXeuHmxRx1AkrKvJkCpTu+qi lFM/qZlNM4ULOXQwPoz9niRQOVKw7eM= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ZBE5KGyR; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of yosryahmed@google.com designates 209.85.160.49 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657667053; a=rsa-sha256; cv=none; b=TYU+Q09v1yiuIIAVfxB/rBkRgckXkT7OvD5AiyiHVtN7GF6s6BWbF4RMN/RP4LPby89wQu wWN28QJtAj9M4vmVU1WJSKKHHIEjH4zNG/ACo2J9cqr4LrC4VZ0i6rqnW9yrzxvkYXLnZT fPbwuHpAjoVamYJZFd3bFiOi+UaqZy4= X-Stat-Signature: 5mxe3dodzfebtofe8ns1wsjns6r1qq9g X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C3A5C1C00AC Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ZBE5KGyR; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of yosryahmed@google.com designates 209.85.160.49 as permitted sender) smtp.mailfrom=yosryahmed@google.com X-Rspam-User: X-HE-Tag: 1657667053-695495 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 7, 2022 at 2:08 PM Sean Christopherson wrote: > > On Tue, Jun 28, 2022, Yosry Ahmed wrote: > > Add a helper to account pages used by KVM for page tables in memory > > secondary pagetable stats. This function will be used by subsequent > > patches in different archs. > > > > Signed-off-by: Yosry Ahmed > > --- > > include/linux/kvm_host.h | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > > index 3b40f8d68fbb1..032821d77e920 100644 > > --- a/include/linux/kvm_host.h > > +++ b/include/linux/kvm_host.h > > @@ -2241,6 +2241,16 @@ static inline void kvm_handle_signal_exit(struct kvm_vcpu *vcpu) > > } > > #endif /* CONFIG_KVM_XFER_TO_GUEST_WORK */ > > > > +/* > > + * If more than one page is being (un)accounted, @virt must be the address of > > + * the first page of a block of pages what were allocated together (i.e > > + * accounted together). > > Sorry for the belated thoughts... > > If you spin a v7, can you add a note to call out that mod_lruvec_page_state() is > itself thread-safe? Caught my eye because the TDP MMU usage happens while holding > mmu_lock for read. > Sure! I will send a v7 anyway to address the comments on patch 1. Thanks! > > + */ > > +static inline void kvm_account_pgtable_pages(void *virt, int nr) > > +{ > > + mod_lruvec_page_state(virt_to_page(virt), NR_SECONDARY_PAGETABLE, nr); > > +} > > + > > /* > > * This defines how many reserved entries we want to keep before we > > * kick the vcpu to the userspace to avoid dirty ring full. This > > -- > > 2.37.0.rc0.161.g10f37bed90-goog > >