From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10B1CC27C65 for ; Tue, 11 Jun 2024 17:29:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A204D6B00A2; Tue, 11 Jun 2024 13:29:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D0276B00A3; Tue, 11 Jun 2024 13:29:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 897396B00A4; Tue, 11 Jun 2024 13:29:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6B00E6B00A2 for ; Tue, 11 Jun 2024 13:29:42 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E09201C0605 for ; Tue, 11 Jun 2024 17:29:41 +0000 (UTC) X-FDA: 82219294962.18.10F0D9F Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf07.hostedemail.com (Postfix) with ESMTP id E25544000B for ; Tue, 11 Jun 2024 17:29:39 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=bjJ4V1kU; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of yosryahmed@google.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718126980; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yp8LNB0GKkmC9XyBsr9Fvc4xrn1FcALdJ82VET9mehc=; b=LaVfzbpW+xf2CtADONMpn3hEMRQf+cI49CfVwugEjLPT1sqdpu26NOtl/Oifr45XW02C0N 3Enb6iKiQfyAqhVSnN5wSn5VEOLbMiP/UPyaG805GKoS87QsRa3Ov2YGgHDbshfFPhxr6U 42maKxpfYXE/jUnYs5g0D4WplwyOjYs= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=bjJ4V1kU; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of yosryahmed@google.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718126980; a=rsa-sha256; cv=none; b=zjXgLzU23Vk/2ss4bFSAGedSqEoYMyBy1vhQqNAOBXiuO4z73c2tVxkXxqq/Q1seMq0ycg Aulcd9tceCqIc1yXYVYeEM3mTok+hWp+aaZk12PWiCcUEvgma7pSGhALFztD0byGlZXv1F wOf7mVf5WieVJtoqfX991MUScFbc+R0= Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-5295e488248so6599389e87.2 for ; Tue, 11 Jun 2024 10:29:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1718126978; x=1718731778; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yp8LNB0GKkmC9XyBsr9Fvc4xrn1FcALdJ82VET9mehc=; b=bjJ4V1kUTK9zHuDIac53lZqfS4fI9o4VdnVUOsPRzuFy3qOk8pslYJ/toQPQdVmyk8 wawuazPSPLJ/x3lXJlDUQZGftbOlFH4qE2gmCvmLf5EAKQXkqum6Vw2U6uBUyg+tvkot 1gNYzXdSb7KL4C6fll7lKLnkoh1nyvWpchyjZkx+C5ZpzmtnA8c5n4Vy0aPvujZyDxcW 7c2+dDQYBtpHqsfDEjOiR9jH0zXsZNR4LL7Aj5iOWw9Wek4rGXgXgtLNBHe34a8GZ1kI aDD4IF6mYWKMT9lx6gbpugOrUS/NKP/q11JYjf/ReGMX2zkz7hyPEYOJxQsZTadyP9c5 Ktig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718126978; x=1718731778; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yp8LNB0GKkmC9XyBsr9Fvc4xrn1FcALdJ82VET9mehc=; b=XBGgG6g+th2z/+qa3xJf68IxSQ7hHfIP1GUOMo1FsuJiOfEZ+vMQnz9ToWTg9B/xs7 OR8skUJTZ20fPshq9b34hfPV4w8SzNdkIHmapmadEaRHAebUvaGd4uFvLTzdDE/g9awy eFFAmkgVDD5a2BXKmWzyhqgczg6hZZOApZbmGkHKQ+KCT+O1suDPQ8ExTNTPzfwjEBxr ixmR/aMvBPNMkNO2nhP7/LgbIVbj7pXuhoTbPOr7ryOVvQdkVz47Gf2MpWURVyw7dUwE q35DvYBJy7OPHKC0qRQj+c3ocoyIqrdfFWvrfeNYSR/EiDWvZo/H3501X+q0ZuxZsJSV lPNw== X-Forwarded-Encrypted: i=1; AJvYcCXX7CbN1lK+iIs9ua9dPQ/YTr/5zgxd++h7Ny+g5ck4kHt38FJcGhPLsHfouIFPVioRdsU2OYk2fp5M6nF04vm64AE= X-Gm-Message-State: AOJu0YwUnbKmYn8HJW/8e2QWDtAX/sQ2X1YQD5AAWDqxBkzRC+ALPzih M/EtLal8RVqMAUeZX6ZpbPQWiF24oZM3ucmSJN5PyoZz7ek2+2ngAKx9xO9UP9txXYVO5LntFbX EGNgVZmVtXPGLBYk+Ut6Du2SX0/Oit3Qsfa3H X-Google-Smtp-Source: AGHT+IHL1hLDhEaq3Esy5ZXWYpAWtACT5oztAwPrX67iPYV+FLA+aPsYxkzmVK/KOCK9+1FjZWc3fJTdN63zzKzI6XI= X-Received: by 2002:ac2:4989:0:b0:52c:7fc9:954e with SMTP id 2adb3069b0e04-52c7fc9976fmr5385958e87.41.1718126977999; Tue, 11 Jun 2024 10:29:37 -0700 (PDT) MIME-Version: 1.0 References: <20240610143037.812955-1-usamaarif642@gmail.com> In-Reply-To: From: Yosry Ahmed Date: Tue, 11 Jun 2024 10:28:59 -0700 Message-ID: Subject: Re: [PATCH] mm: Do not start/end writeback for pages stored in zswap To: Shakeel Butt Cc: Usama Arif , akpm@linux-foundation.org, willy@infradead.org, hannes@cmpxchg.org, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: E25544000B X-Stat-Signature: nj9dth3n8nxon6odxmnnkf37ts73x441 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1718126979-310387 X-HE-Meta: U2FsdGVkX1/4jwZorfe7TDINKa97tdyyCR9nntSzJR+t5sMOU03nbh5QgneQY6ak4Pr0LF1BLNMtvECIiudYnOPnQDSMz7t5VlzRgAVuzqgf3w4nntHp6mlSMEbhmaccv8rTTvnBgsMDC6G2m3UckcaaMcowR4pL6DRMDRRnjiJZYhJzBh9ziC0i2vd/NW22Tgi0HohyE/uXiXOPOGssZEAusJMfl05I/vyycUWznvzOB4MrntGrYpRaX111JnRFCbRHAscpCLs2Ie0lUBH2rDUlZOTclAenxX8gQm+/kqNTZ0CrJgbQmBqzMKpDvnW0fPTH5mat8uco+QQUtG4o2vD2nyq0Zq3P8xAIIcagKDSntbKY4YkvnYOSnWfm6wlmozOI5DoOomvlO1GBcRHMa+nc2oXiuxbKirM1A/bjIwB297nc2z5BX3U4cSqfg29EMC/giCnXv+rBqIjEYvhlud6SSPosA1ouoyXXd9dALy9LzxrvIFU2gw8NUgENkLrkCo+yfoQ8edc467w4XCKcllza9DA0NncxHZyIMdqjXaG7pHRNxKc/7Wje1ZEpLVsMF8xBVbrF51i4dnnRvQ5fyo407bk5E1C4r4q5iKjtLL6So7Vrgu87YjSjtun0Er2TqT9PsXiOtkiMoQ8hfYlc5+ZaBQleQ16p20ZowLpcrLzOf9BcCHj7zYAleGNgkky4JA/R8xZi5q4b10azvWObm9E9Ra8i0vhgOUfO1QMGqIBZmDoOF3tF/BI1QEumUFNXcRbBKNCL3kn763HxLjN8RrhN5AS4OCzyh/+3vspdcQMUKCSPvSHdxc/RdXeEeakqq25niC4F6gGOV7tAI0rmID89vZrpYXsw0sXOoi27LEGkVFswqZ+fk+m5gGGpxuTjHV2mf/CI2ubroOJv+2NNc+zM9dQoY/PoPkJMBKxuViQ/dVZjXOB+ypbjzQZ29wBG87Uq2/UvnT1DW4ILnbw C8ovv5wj O2p6yEVJGf1CyiF6Y0VFPp2ApuAd+Tgxzgb+BbXLAR6Lm9rNgofmbMeOBbwPkevBxPznaoIV2vywsXR/AYLncAly3y3q0AA0tI4tKOn/jYx9pOTDWYTu/zYurAOBZWcKyl24keDF503GKdjX5ZimWtE2xR7yM/xYFJJCp7SFUJubFkZqFB8RwE3mVHbL/jjRCaMoqPCfRqR2fCgcwNR8F5Q7n3sKZufXcQsDsLzP7gb01an7FF6fEtNTbCHoL1VQc6OKWIswvg32rKNP++BKlJRPr2mEN3gCz0B0sWB6gZsC0qiOOTTW6sbdX9X+qP0Ugb1iYlpoV50q7I0Gj7RfARr3DndIgXmsw1fGL7mf8M5jQnMU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.111830, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 11, 2024 at 10:16=E2=80=AFAM Shakeel Butt wrote: > > On Mon, Jun 10, 2024 at 03:30:37PM GMT, Usama Arif wrote: > > start/end writeback combination incorrectly increments NR_WRITTEN > > counter, eventhough the pages aren't written to disk. Pages successfull= y > > stored in zswap should just unlock folio and return from writepage. > > > > Signed-off-by: Usama Arif > > If Andrew has not picked this up, send a v2 with more detailed commit > message, particularly why it is safe apply this change. You can use the > explanation given by Yosry in response to my email. Also add text > answering the other questions raised by Yosry. > > If Andrew has already picked it up, just request him to update the > commit message. Yes please, thanks Shakeel. I wanted to ask for this but got derailed :) With the updated commit log feel free to add: Acked-by: Yosry Ahmed > > You can add: > > Reviewed-by: Shakeel Butt >