From: Yosry Ahmed <yosryahmed@google.com>
To: Shakeel Butt <shakeel.butt@linux.dev>
Cc: Usama Arif <usamaarif642@gmail.com>,
akpm@linux-foundation.org, willy@infradead.org,
hannes@cmpxchg.org, nphamcs@gmail.com, chengming.zhou@linux.dev,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com
Subject: Re: [PATCH] mm: Do not start/end writeback for pages stored in zswap
Date: Tue, 11 Jun 2024 10:28:59 -0700 [thread overview]
Message-ID: <CAJD7tkYxtfxwmVXxiDUacaPenDLU9v_MZo7vEqquA_1fVdB2wA@mail.gmail.com> (raw)
In-Reply-To: <ohcrgrlmcl7ym6dlfy524g3ht63pask2qjeqy5m242xrvxojt2@36gqaboyzmn2>
On Tue, Jun 11, 2024 at 10:16 AM Shakeel Butt <shakeel.butt@linux.dev> wrote:
>
> On Mon, Jun 10, 2024 at 03:30:37PM GMT, Usama Arif wrote:
> > start/end writeback combination incorrectly increments NR_WRITTEN
> > counter, eventhough the pages aren't written to disk. Pages successfully
> > stored in zswap should just unlock folio and return from writepage.
> >
> > Signed-off-by: Usama Arif <usamaarif642@gmail.com>
>
> If Andrew has not picked this up, send a v2 with more detailed commit
> message, particularly why it is safe apply this change. You can use the
> explanation given by Yosry in response to my email. Also add text
> answering the other questions raised by Yosry.
>
> If Andrew has already picked it up, just request him to update the
> commit message.
Yes please, thanks Shakeel. I wanted to ask for this but got derailed :)
With the updated commit log feel free to add:
Acked-by: Yosry Ahmed <yosryahmed@google.com>
>
> You can add:
>
> Reviewed-by: Shakeel Butt <shakeel.butt@linux.dev>
>
next prev parent reply other threads:[~2024-06-11 17:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 14:30 Usama Arif
2024-06-10 17:31 ` Yosry Ahmed
2024-06-10 18:11 ` Usama Arif
2024-06-10 18:29 ` Yosry Ahmed
2024-06-10 19:08 ` Shakeel Butt
2024-06-10 20:05 ` Yosry Ahmed
2024-06-10 20:15 ` Johannes Weiner
2024-06-11 9:53 ` Chengming Zhou
2024-06-11 15:59 ` Usama Arif
2024-06-11 17:16 ` Shakeel Butt
2024-06-11 17:28 ` Yosry Ahmed [this message]
2024-06-12 10:01 Usama Arif
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJD7tkYxtfxwmVXxiDUacaPenDLU9v_MZo7vEqquA_1fVdB2wA@mail.gmail.com \
--to=yosryahmed@google.com \
--cc=akpm@linux-foundation.org \
--cc=chengming.zhou@linux.dev \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=shakeel.butt@linux.dev \
--cc=usamaarif642@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox