From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A87D0C4725D for ; Fri, 19 Jan 2024 19:38:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A51F6B0080; Fri, 19 Jan 2024 14:38:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 355C46B0081; Fri, 19 Jan 2024 14:38:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21ECC6B0082; Fri, 19 Jan 2024 14:38:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 105936B0080 for ; Fri, 19 Jan 2024 14:38:24 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E10791A02F5 for ; Fri, 19 Jan 2024 19:38:23 +0000 (UTC) X-FDA: 81697072086.22.742E497 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf27.hostedemail.com (Postfix) with ESMTP id 118BA40016 for ; Fri, 19 Jan 2024 19:38:21 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tD4yBpzG; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705693102; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AGnn/MsX85yn8KUcF8f/JaW7Zm3qd9DTw9KnS3mXcVo=; b=TAY0p4XOHNk7BIiMOOkvjm53m6BH+xvk3YC+mHQIBN+tWYqoUItwEwcTa2/JdkmFlnnPiK QCMBsSnIxDPWcDzN45ir5WPw4zKfqcoIKndmqm+o4fD3aSN+k5Z+tN4Ixw/f+RogrMiaHZ UxOf8Ngq8s19+B7DrVvW7tJHd4Qfg1o= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tD4yBpzG; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705693102; a=rsa-sha256; cv=none; b=Mk1qBawsvKVPF9Zm8BE+xCo96GbgdoQQo7WLl+LlCH6bukEEdME4Rg4cGcQ++5csjLzBY9 rtT6U1FOFPzD4lQ+pfc6w/fchUSvWAQrqEl1UGE9Ku66FaIxS9GQv2P/ghaHXUWUue1FEU /Gw53Rr5A6XRGodtP9IhntBp3yvrVIU= Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a2dd05e02ffso115546766b.3 for ; Fri, 19 Jan 2024 11:38:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1705693101; x=1706297901; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=AGnn/MsX85yn8KUcF8f/JaW7Zm3qd9DTw9KnS3mXcVo=; b=tD4yBpzG35YsicciDNov5z1P96C0oBHk7bz7JCLLw9wjaRChGF6DWxdTVPF9i3qvSn 1NyDaimT6c+PIoMLzNzunAZJm5khbwq3CUJVRPRZYDbSvIsZFXnYQ5IOSNnhhLx1c2Qe ai/gWUc7F7jSIPLxrZxetDoMyzWgss3ojB8PleFoNePLX3CpWR4vImm0KaomCYH1G2cy A3PXhK46iBmWQlDVOBcvnnI9BZzze/QshMghWPJ5e5Fp6XHK09EpJQBHwKe6MrXpVO6t DNXLDyB6jFJR7cwGPH/T8twnzWmuHwVsPw/VZuQJk9Ff3TIYleurQjb3INcC2EgPEvjt uJ0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705693101; x=1706297901; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AGnn/MsX85yn8KUcF8f/JaW7Zm3qd9DTw9KnS3mXcVo=; b=vvbBl0nap4KTExiJpoASD0Lpm27U8hKdFmTRYd8T8OtB7Zm0i5Nf5aOAJqZOSu2O8b k0T+aHTm0btvxEphvYGckhFvSBdna9TUg7wV8WayEgKcyCsBPteo3/OIdYKU0aM82/wV LCOmFZr7a2OisuujzdvqqVTHkVnfSE+pk7NihXdEKlhigo7goeGO5e+sPzs2kuXW/1Ti HOle17eiW7fuNNWAE5AqSyltrXf+Pm26w8QRWvXBhD58G17PsWddsElaROgBiog1cyeZ 5dbNku9oVRr5Trq0+fqhi9oN6AydZJTL+3ZVk6rWZDQx/PqTc+7nJtGEjzSOF2R28JFn aikg== X-Gm-Message-State: AOJu0YwxsxzToX3tkmB9HAot1VdGRv+dUH7FSE5c26ODecVenQiIonbU u9XyRmMeC4SBOL356+Y+2PrO/bKw9v+G+yBPvR25nWlMIlVvsg0W2kLbIbpxNZkMBTmyk+l32lc b6D6uRd99MmfljGJxQHxKH8VzS9pWq1nyIm4U X-Google-Smtp-Source: AGHT+IEm0cj7d1omhPy8sasgNGgbLNRFamkIaWEh9FIdgrBq2tERmIXGAL4g9duxW99951YVpZ2ru8DACmu/AwVhzLg= X-Received: by 2002:a17:906:74f:b0:a2f:1588:d271 with SMTP id z15-20020a170906074f00b00a2f1588d271mr103336ejb.224.1705693100587; Fri, 19 Jan 2024 11:38:20 -0800 (PST) MIME-Version: 1.0 References: <20240117-zswap-xarray-v1-0-6daa86c08fae@kernel.org> <20240117-zswap-xarray-v1-2-6daa86c08fae@kernel.org> In-Reply-To: From: Yosry Ahmed Date: Fri, 19 Jan 2024 11:37:44 -0800 Message-ID: Subject: Re: [PATCH 2/2] mm: zswap.c: remove RB tree To: Chris Li Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, =?UTF-8?B?V2VpIFh177+8?= , Yu Zhao , Greg Thelen , Chun-Tse Shao , =?UTF-8?Q?Suren_Baghdasaryan=EF=BF=BC?= , Brain Geffon , Minchan Kim , Michal Hocko , Mel Gorman , Huang Ying , Nhat Pham , Johannes Weiner , Kairui Song , Zhongkun He , Kemeng Shi , Barry Song , "Matthew Wilcox (Oracle)" , "Liam R. Howlett" , Joel Fernandes , Chengming Zhou Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Stat-Signature: ph48ja7ay6a1at73bxi1wmdprcna34kc X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 118BA40016 X-HE-Tag: 1705693101-705181 X-HE-Meta: U2FsdGVkX1/uA6s/6BftII3X6MznNUZtyithE5mZiBN5eMr1BYoD8HOoUZX3Eli1QwA8GFftkRNI2uMIf5mjvMZs6ly7zRuXMT0CFtfjCoxbdhHg49OX9uRJVpB2xyRjWxc3CTrbXQGFpvL5gfVleXl3HYYRIkHha5uUHUBrNw70QFbfbc5QAb+Pnjn/hDDeuweSFgXviewmNR93Dshx7y/SRyW5sr07kb7fSB6Dk4y0SrhQA1VwkIIG9idH4dFOJY5+/O6Qr0ffcedqUWWS5GRssNwHFL2nsCRlLnUgRzK3YYd8jvd7Rd4B0wFXSENQY7eGPcDvfb1MDtSoXRNk01rjk56Wh7gVTz/fL3XP9zKjyNQ+OhPsrLHXZL1TEeTWfyiSbJnVRClL//clCXanLxVRDpp4pn6PLUhLgZ1FHq6MBEtCrceOm6cfUH3/caZng1qHDYxg+ifpJqLyzCcMJw8y8NYakNTc5zzQl9es5NSSTc/j+LnlwaEebsUtmMWBLZjjKIiHKX8XiBtvzjM7tdFxufWeFaxBFDLuX+kBbiFF/JBsKqe2nbv+ok3LLYWuiNSzeIXR29DI0KaQaNJgkE6Uip8McD6AhCrSNlaKaJu4ua0yVHeFMwuObbbigIzCFFyBID9xIJ5bkg0Q8d1qhU4MV0c06OuKjiByXEJMn1d1kn5Z7dSDmkXmUZBRnVgmdc0uzjeJE6Z2UB9GT6pCBNDQGeaGcTo1oNdXllZS/YnKZ+/oC9oR74zoztU7Z/vh2Ht+Qh58NARTIISPitxzwhJo6YKeNVbm0oVOhkkDmEt+Pvza/GL11hpBlaL3J3dOU64VAojqdl+jBnsqVdlLx29bAMFq4GaYUHdbB0C+pzFbyxOr7cjVqfSvngET/rWPTZw/LK9c+cKgqM2CtSdKxwPp5/IIwtcyX3KvPFFne9H12jM1NMiHYz6vvqyl7R07NFxNdiPFObS4utIGVIH 1Elv4QeY dVWfDnxEMeEQusQX4+gSkY4oGhshB4NYhW6I+BggMjV84A3LDUIGsWwRq1aV/TMl2lo/FH6ATnDZFXFC9SqG3PqVcBQLgilGFD/bwfIIzDrLacc9o5QHvuBSPZFPUTq4dvoKERf2J61eAQZuMcsmZaiIySIk4XNwR78TH+nvFQjC5sT5G+fwlpV0L865SWA7Z/TPUHLCsAUUJhYBjYX9IRFXDEhw3We+CAKSW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > If this is doable, I think we can return xa_store(..) and keep the > > logic in the caller. I think there's a chance > > zswap_{search/insert/erase} may end up being very thin wrappers around > > xa_{load/store/erase}, and we may be able to remove them completely. > > Let's see how it goes. > > > > See my other email about erasing an entry raced into a new entry. That > is the part I am not certain. > Anyway, when zswap adopte folio, then it might need to handle multi > entry, we will be back to using the XAS API. Handling large folios in zswap is a much larger topic that involves a lot more than this xa_* vs. xas_* apis dispute. Let's not worry about this for now.