From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6885ECEB2E2 for ; Wed, 2 Oct 2024 18:21:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F1AE46B02AB; Wed, 2 Oct 2024 14:21:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ECA726B02AD; Wed, 2 Oct 2024 14:21:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D6B926B02AE; Wed, 2 Oct 2024 14:21:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A1CFC6B02AB for ; Wed, 2 Oct 2024 14:21:17 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3E898ABBEC for ; Wed, 2 Oct 2024 18:21:17 +0000 (UTC) X-FDA: 82629479394.27.35BC050 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf15.hostedemail.com (Postfix) with ESMTP id 5E7D9A001C for ; Wed, 2 Oct 2024 18:21:15 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=mbG07OPz; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727893180; a=rsa-sha256; cv=none; b=111Kr5AppczLGnZzjV9jUJQIjiRd1AXkVrdUE4jaSm//DccSK5ujs8vWnHGNIYOkhdYksx yvvJk98yQTw3AB5GbBGkLFxiI/aeIilceWtk+Qzd7rLFtvI0roTBD08BXe7iz62TbabdpD pfY/8estFaauljicmjPPXUxtmqs7NpA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=mbG07OPz; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727893180; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3G6IpRXnowLGAwneNrkRT1UaiEoFlojLs48gIVxGlxo=; b=X84zq8t4XcRjXUsEZtUh5s8YDM3uwttyV/lJWbqboA0mMOzsD5G0TqzXqe599OaPq5l4Oa /3BkPVcihIs/YLZcR4BUs8C9RT8YQaGb9pC3omLkobS/TdrTldZRjHM3e4gbpeqcFZvHFR fW9Y4G8UUCNfJDu9abO0wonSRpafY/g= Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a8a6d1766a7so5178866b.3 for ; Wed, 02 Oct 2024 11:21:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1727893274; x=1728498074; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3G6IpRXnowLGAwneNrkRT1UaiEoFlojLs48gIVxGlxo=; b=mbG07OPz0odUdXJHuFM8WuszUscdCyKz4v/dHw72896ONsMUkNP/B0lUP7k5zgEff2 0rQm351vt/atfwt/c9Xo8mMX7VU75QXrMxaNHXATU8w894CDLhikm7SQTjR8VLv6mQnc 6n1hPXiKlIHDQJhShQMGPJSgNWjDt0FEqwq6iNy78HNHaUDc3JTEWeuGX7qTk74xhe+o qkhskf2BXqMNnzR+HLnKZaALBaEHQSbzf5Rt83/BLdi8khjDKxdvCOBeBAYXG4+ITEha hWIoPTETvoOI7uw7imwRaUVPLZw3VfsdMiVlSZ0V3HBiI6LAwprDal24fkIiq9VrsADQ 3Tow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727893274; x=1728498074; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3G6IpRXnowLGAwneNrkRT1UaiEoFlojLs48gIVxGlxo=; b=ssYCPJiV3wOE9MAEBx3wyjCgqRRAyCD7nR9i9M0hO0rN50h1sBZdqvwiiGufgZITrC Pd/+irb0hIkecArvVhRODZ7cEH3FPMMzn9CqiqL4Pe57WYFdmVX0QVVnt84HpgC6pnA6 4bEmy86pEqt6eO76IZXHKBUs2hSlfF9js4FadXEC4TgMbPjzMjLLGcY6o0fKsT5D/MQ/ 6PJoM3bS3n4QO6wyZmI7q0qXbKq8ozhN2idOkHPmv5iop3DwAvIGdtmRRq9G9sDYPzPR 7Bc1SArPajyg2A0up35duO6AMTzQVb8W6LUUwoForgJYto0sRSx+B65kE4VntcYoMbd+ d7AQ== X-Forwarded-Encrypted: i=1; AJvYcCWQwkssB1I9FT1sjE+xGB4X35Ak9I6gweR0QtRqa3c+8mJmJJo0Mm08bUbi7kk9EkgT2lNv+xNSXQ==@kvack.org X-Gm-Message-State: AOJu0YxGgfZ14BHGYfnB7JjXRHu5GcZoPlypbv+fiARX0dXnULJkVRIv Uq6OP/tZVgN7gtpl+QSufBf/2T8CBQkVNImUN/aC1a1Copar9WSyX1ZzrcgQDy3Z/R9iPe+7VPf YApreYp0SA4q8TPvIpcpF540gxQoIgxA7Fxw9 X-Google-Smtp-Source: AGHT+IGECmD3qqIz3bFibtSH6L0BAbg6ja0nGX7UqeRLYZC/pIXHeENPqg7ZVxdrbfMMMwSNQyjOZ+RMSruHZ/pVoLE= X-Received: by 2002:a17:907:9404:b0:a80:f6a9:c311 with SMTP id a640c23a62f3a-a98f7ffd71cmr331706266b.0.1727893273261; Wed, 02 Oct 2024 11:21:13 -0700 (PDT) MIME-Version: 1.0 References: <20241002173208.213631-1-kanchana.p.sridhar@intel.com> In-Reply-To: <20241002173208.213631-1-kanchana.p.sridhar@intel.com> From: Yosry Ahmed Date: Wed, 2 Oct 2024 11:20:35 -0700 Message-ID: Subject: Re: [PATCH v1] mm: zswap: Delete comments for "value" member of 'struct zswap_entry'. To: Kanchana P Sridhar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, akpm@linux-foundation.org, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 5E7D9A001C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 3g356ibz4hdgqjxzs4wbxdkjubcsi4ge X-HE-Tag: 1727893275-79721 X-HE-Meta: U2FsdGVkX1/BgzKtx9FAAyQZ1tQQmt16Gu/TgNO8ddNrtqImKitEqeKinjmqzb7cV83RFgfNj5l68cGXQ+Mb6IUOhv6iVQBDZWiendKaUY3+GldWHpcJzcMKYeK07l3UIGwgoclWtb/WzKdojAHUnx2FeL86tmaFvJjuYYbrWC+742N22hJ8Iquq99NFvrkPi+mplCCPyCHuGh7a1jSK2BHdnmB1cTC+EPh7HsBVExApObQHMxIMyOhr0GwmlkR7yikR4xLVxIItV+GXpZFwYXTXBv8YfRwSP0cnttMSNrjYX4ieZTxzOHpaCltiLBAZBea8WewK9PmG3F65DU0ZlBz/esvNYTlFS925/Ofba4zs+Pkday+9Eco0G720/hpyIKKdv/XQpUkyDMTFmmukdIar6hOwvslSLzSwXaLEvUR1zSTFIioUTAlpWOtwsyVbNeQQ64S76SrnF7BXc+NWFGaiHmo0RtIG2CdIZa1PxeGoS6X1B0Yt+TjW/SLRun2HWl5TRRDxXpZShSJdD/QZM2pfKc0TSf2SZc658NR2SUomU1mM8awBBfFrmoNvbHy+DgqgCRi3ziErNOCVaAVtrt4RXUCylBGtF4mkZuHWSddh1wv7X1j8jmo+08DOV/JYdHczhOnwUORmEx/LP/Soh0z0vU3bxd+Su17UpgzlbLvcFG1D+pgR7+G3vm5vU8qDv9HmL5cHBK/FUJJdtqdmjfPNf+WBX/hRFndqazq0u/oP/Nbh3hwdwQgyP+0+WAkf3QN2oFP2oaBXTDWVumHq/Jsm8ZUdMBgieQjCDwQS5HxuKyiL6FDTwXEdZTyNxfl/+ZJsgeYszlg/XqFHdGgndOAzWwAQhTU2Cr3twwaawyc2v2L42B0o/BMtZwlaFnvauQkhRbzh3b+nbRWUDRUTgbZ3XBb0OTpsmMkMBVsIS9xw1ujbaCzLnNPSNzqZ0ylHEFTcJPVpa2I55E9KUpm Ma19lh0t 8bHIFcWst9uB1/HS04pARPLfjzQ4DjHVm1zWURrCfEA8TlPUsgJ6ELXivgEvZZ8pFMDviML/IfLuNOxGh7PBns3exmpRaTz4SdUisNDWQkx8qymwEOtty4acyE6lUbTCbE/lJcs70++s3pnWwdgJ4t89TIV9ED7292o9wv83IBN1uRvmaoDYC7GHipkco7WeDb2VaDJq6CoEqyKRYPhlmJnpyTpgbSeeJZvuT2/e9GzEunq574JwYPAnyeD35EOtH+2h88K4MGlh6FhV0TGYfKf04uGRq/d0GC6q5DOboQOPmRkS/eipZLFIuhKFQpYSyPOOZ5Bt6VIW0yiHnU2doQ4ZsjVs5e02ptm6mSvceYJzKxpo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 2, 2024 at 10:32=E2=80=AFAM Kanchana P Sridhar wrote: > > Made a minor edit in the comments for 'struct zswap_entry' to delete > the description of the 'value' member that was deleted in commit > 20a5532ffa53d6ecf41ded920a7b0ff9c65a7dcf ("mm: remove code to handle > same filled pages"). FYI, usually the first 12 characters of the SHA1 are enough when referring to a commit according to [1]. [1]https://www.kernel.org/doc/html/latest/process/submitting-patches.html > > Signed-off-by: Kanchana P Sridhar Acked-by: Yosry Ahmed > --- > mm/zswap.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 09aaf70f95c6..c3e257904b36 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -190,7 +190,6 @@ static struct shrinker *zswap_shrinker; > * section for context. > * pool - the zswap_pool the entry's data is in > * handle - zpool allocation handle that stores the compressed page data > - * value - value of the same-value filled pages which have same content > * objcg - the obj_cgroup that the compressed memory is charged to > * lru - handle to the pool's lru used to evict pages. > */ > -- > 2.27.0 >