From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F4F6EB64D9 for ; Mon, 19 Jun 2023 05:19:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8C768D0002; Mon, 19 Jun 2023 01:19:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C3B718D0001; Mon, 19 Jun 2023 01:19:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B04688D0002; Mon, 19 Jun 2023 01:19:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9DDEF8D0001 for ; Mon, 19 Jun 2023 01:19:34 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7AB624036F for ; Mon, 19 Jun 2023 05:19:34 +0000 (UTC) X-FDA: 80918344668.04.5D034DD Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf04.hostedemail.com (Postfix) with ESMTP id AFF434000C for ; Mon, 19 Jun 2023 05:19:32 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=eUeNwGRZ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687151972; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xkIBRh1CRI7l1b26sTYaQ/9/gUUFxPZU0t2NyWKWH7Q=; b=boiWiIIb+ueTzT+y+AWFlBo3+Wbm3j/2vPcK50F0Exn1j7A6nD73Qd0gO0jdM0whLidEhs WeqL+9RRNHSs40goP2CCyt6NcbNgFCeOPRkev3reH/wXQxgIw/wXW/wNLntLSw8O310Fia pVHGsmE8bYZOzGr1HCT3oECotqa6ycI= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=eUeNwGRZ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687151972; a=rsa-sha256; cv=none; b=MwbVyh8/Qntyvshri6OE+Kdx3WQDl3d9Z5kZfLmPLCUzj+RDyxWTQinyqqjprJ1LiMO284 cIOf+2V1cNQ68Y5vj+1yrAmN+xqRG1Rgk+1XEdMK8btMRCReAMly4hxUUWU//bi0L9jWjn 8oBbnTEmEB0ZWrDpcBIq1JNUCzfs1i0= Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-9881b9d8cbdso265729166b.1 for ; Sun, 18 Jun 2023 22:19:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1687151971; x=1689743971; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xkIBRh1CRI7l1b26sTYaQ/9/gUUFxPZU0t2NyWKWH7Q=; b=eUeNwGRZOej+JmaNNUaJ6OPJIgJYdwORyCeMfKZTOjdOO76BnXQtHBcPlqW8xlMFQY s1nvqNLfu7R+DtrblqmhCcyNv9raxlOUrGUkijSYF2DLN/Fx1lHmAyyGItjJsLQKZ9SB GPfMkm2H1dEBHmBvUMD1gOtZO1fVM3k/h0NmiHlxO9RkzW6RQBtin+wJYQW/lxXbrH2y 2jT67uQLUKUbBewiI+qS3az+zA4/Ja0YIqT9Cp1VvKdGyGO7ldm1/RKTqK5ZdG6UMaPi c/6Ert/O4bIexYOn5ii9geuHAbjF/UjC8Wjr754r+o8/7VgLwsDMrXGWCp8mWr05623N VqbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687151971; x=1689743971; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xkIBRh1CRI7l1b26sTYaQ/9/gUUFxPZU0t2NyWKWH7Q=; b=hZ/NZMwYN6myH8Xs+FEzfiW6KTnuIlq6LvAzzIN+Ov/y1nbY+vdo7RHtZbZjNwCkPK 5kbmnVCGgmHuD3XZr5wMBvZGwu7jIKmrll7RVEfS4bi87V7dZeepkYDvdpzd1DXlRWGa K1JvaqyLsHTfxOTvFOSH83OLssduRmhoCBTtFcBYBj8eU6g7N1Fi5zJ+uzIBKngNCz9U 829w3/Es5XyuJkVFE8iqUHvk5pKaqK7hh5FPbj9QuH6QRSxKPX5hQhFawL5ekpZQdJwf WhuOlDRyyiyzzqHq/nUIweGY6gpkixSaqBwVXa/yd+jp4jPaJ40NJV2z/brBI7o/KvvW ZrrA== X-Gm-Message-State: AC+VfDzuuOJHy6K6T4SWJlSS/C9AF5iMweIVb2x/ceQVlxpI60HfxXPR dRN++r1TiJNOMxMfrfcxTt/07eSSYHTylXAuZYHFFA== X-Google-Smtp-Source: ACHHUZ71H1JCg8qVnIn2avxbwYZAfCJAhaV/i8QHAcldJFca6caRKDrrFVg7SKgaFiydxOgLaPuVe+XBQIA36QYs2Qk= X-Received: by 2002:a17:907:2d10:b0:988:7209:f42 with SMTP id gs16-20020a1709072d1000b0098872090f42mr2344570ejc.7.1687151971080; Sun, 18 Jun 2023 22:19:31 -0700 (PDT) MIME-Version: 1.0 References: <20230619051715.2306134-1-yosryahmed@google.com> In-Reply-To: <20230619051715.2306134-1-yosryahmed@google.com> From: Yosry Ahmed Date: Sun, 18 Jun 2023 22:18:54 -0700 Message-ID: Subject: Re: [PATCH] selftests/cgroup: allow running a specific test with test_memcontrol To: Roman Gushchin , Andrew Morton Cc: Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: AFF434000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: azpunwczqb6sz3s98gkeutjqfanw34wg X-HE-Tag: 1687151972-932316 X-HE-Meta: U2FsdGVkX18Py5eG59S/ixfviA7quGzrSs7Je0l7RrllB+eiWkn8pAqlzgAXqhrAUpOwcusWl5W+p+J43qYhTQewO29zJExdeo2TFLsiQy/CRB+tMPRHT4mil3qX5cxUO6AnE+9JkOPDtRfQW/DIqid+6XXeYJ4ZjFi0J2/tUx/VmBmvazzmEaUkmTS/89KnXMsHoKDL64gTZzcaHti5o2ek9sOmRzmGDDxCChLU98g/SRtTyC3nzaMXaLoXRIoI9wmANul0adGj17P5hVg7CrXI4WcDkqM7G06/ypfAn798wIQBprCiFHHcck13w73NduGwA7Zx+/GFFm4fuCktQQAitWhlzqjUq982W3+cJzWuNaBmIwIVQrXFTANEB6/Fbd8tHjV0LFGGsF67sWsbrFF1TpPxK6XtmY1R1SWFEDbPNxzQRHw9W+MPpxC1J66uSX6saWcuZap2apuM33EXc6OSWvXnjhSym5Y2AbnnPMh3nA08Jcy39mSi54Hc56mUa/Ye3ISFtoUtNC/MBhTyRsNrsnfMrOIonVN593Rcd2nuZGSmiPuqBz6thzULNhWvfgV3XFN2wdvpXWHFa5+Vu6xMnZnGc+QqhFHvub4fQCzaJw5uJQvaDn5adRBTexZtRKJJp0l2IvThTyUpTCPnuppEf/XKRvuK00dWtS0RZfTYzWcBzLOOCzQkjdTJEfwj/7DaIIf4k+/BFJYWvl3Hncu83SlO/xcQPPvVDb1ixtZcPxVkEVew7MlCbEW6Z0/WAcIMWx7d2W23Mrch3zSWbpHnrG7NufUIIqf1njgMiTVYMDA7zQuyOwrc4RKbIgYokJggkhwG2iaczq+r2q81WmC8iFbrgnSYIIOf/R9lHavHqCnOzDFvnFv1ozMDwmjQmqNjnknUJw7aHSnaN7LsURIfjRYhQWJqB34P9RIBY6RJeBB8GCk6rXPuyHFR5xQueIx/5XiHNu/frrlZfYq bmBGOvCO MbZa8NmA4flM8aLFmxwWeC7Z0wIe/bXH+PhX532vOrsywQEXffz6wkmluDb1ta4WNAji5QxsPVpoQQEfvDIOyj8qMwaorr8bvl+XeLgA2HC9OZuf0fVW+8xmll2OnqmXHbqZpTOqxLrJ5pZEljWCfN1t4Miuo7dSd/15jTlev7mtqnunL3Xh6zjPA9TN4Kt/4646j6TcFN0ZsJA2oZ6PqfGSCjH1IJelEFL9RDRXwoZd0cGCexLsD5/mWsqW1BZdPTOEl1emN1JwBTXzqbP4rQrP0yA5sx18MP86xboycg76C93lxW4nz2RambdQcDsHrMPaieESOk+o89xk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.012487, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jun 18, 2023 at 10:17=E2=80=AFPM Yosry Ahmed wrote: > > It is handy during testing and/or debugging to be able to run a single > test from test_memcontrol. Allow passing in a test name through a > command line argument (e.g. ./test_memcontrol -t test_memcg_recharge). > > Change-Id: I0e0d74d81fdd9d997987389085a816715160467f I missed removing this gerrit tag, sorry. Will fix it if/when I respin. > Signed-off-by: Yosry Ahmed > --- > .../selftests/cgroup/test_memcontrol.c | 30 +++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c b/tools/tes= ting/selftests/cgroup/test_memcontrol.c > index a2a90f4bfe9f..d8f8a13bc6c4 100644 > --- a/tools/testing/selftests/cgroup/test_memcontrol.c > +++ b/tools/testing/selftests/cgroup/test_memcontrol.c > @@ -1308,9 +1308,36 @@ struct memcg_test { > > int main(int argc, char **argv) > { > + int opt; > char root[PATH_MAX]; > + int selected_test =3D -1; > int i, proc_status, ret =3D EXIT_SUCCESS; > > + while ((opt =3D getopt(argc, argv, "ht:")) !=3D -1) { > + switch (opt) { > + case 't': > + for (i =3D 0; i < ARRAY_SIZE(tests); i++) { > + if (!strcmp(tests[i].name, optarg)) { > + selected_test =3D i; > + break; > + } > + } > + if (selected_test >=3D 0) > + break; > + fprintf(stderr, "test %s not found\n", optarg); > + return EXIT_FAILURE; > + case 'h': > + fprintf(stderr, > + "Usage: %s [-h] [-t name]\n" > + "\t-h print help\n" > + "\t-t name run specific test\n" > + , argv[0]); > + return ret; > + default: > + break; > + } > + } > + > if (cg_find_unified_root(root, sizeof(root))) > ksft_exit_skip("cgroup v2 isn't mounted\n"); > > @@ -1336,6 +1363,9 @@ int main(int argc, char **argv) > has_localevents =3D proc_status; > > for (i =3D 0; i < ARRAY_SIZE(tests); i++) { > + if (selected_test >=3D 0 && selected_test !=3D i) > + continue; > + > switch (tests[i].fn(root)) { > case KSFT_PASS: > ksft_test_result_pass("%s\n", tests[i].name); > -- > 2.41.0.162.gfafddb0af9-goog >