From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35597CF6493 for ; Sat, 28 Sep 2024 02:30:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C7EB56B0176; Fri, 27 Sep 2024 22:30:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C2DBA6B0177; Fri, 27 Sep 2024 22:30:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1C0F6B0178; Fri, 27 Sep 2024 22:30:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9292D6B0176 for ; Fri, 27 Sep 2024 22:30:45 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4FFF281719 for ; Sat, 28 Sep 2024 02:30:45 +0000 (UTC) X-FDA: 82612568850.19.7A9368E Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf15.hostedemail.com (Postfix) with ESMTP id 7B507A0007 for ; Sat, 28 Sep 2024 02:30:43 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=1Jd9LhKc; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727490606; a=rsa-sha256; cv=none; b=K/msPjG5cLqjHbIVKJ2PsfbsekdzxajcBv5+8eZwHfkVA8Yv96a0bp+sHoDSNSgI0AuCUx l77jt2akvGCsiO0mnlvAG691G3wmztZcc7aQP9glGRedW13p+iOcyn4atMGo3FTUHutuux jOIOn84JYgwOmGjnrZs5GZ6g1+rW3Tk= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=1Jd9LhKc; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727490606; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OZ/wHMNg0d+dVALsuK0UnbKStRq6V9Y0t0+9ftzzOzI=; b=q3zmuvrWOliGnUkSM78SRa7DABOInRZGtMX8jEH0MScythcM0eMtB9T/yG7JNfaj7YajQA FxdCpge3OchkbFbEGKEfzgf6UR18NCZWOsPlvWwN5PJI08FI71IjRNQMe8gM1D1hsPTx3T lPLJlrKYCqI8zgw0WCzFVTXQun82Tzg= Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a93b2070e0cso308019566b.3 for ; Fri, 27 Sep 2024 19:30:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1727490642; x=1728095442; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OZ/wHMNg0d+dVALsuK0UnbKStRq6V9Y0t0+9ftzzOzI=; b=1Jd9LhKcftKwdl8ggUHaYp6Sz0QLgEJGV9rkWA7HRLN+xB+HPzYg+cLVSvRgJ2FflP gk0LDvCAbGYv6UK/qYX3z6QfLMtOIhYCLFl65ZGCL3IhrQvUTIyGc43y8qA6oZbWnYr+ 5q6xX9SmdhGZk98gzRqo5UcfKuWESX48zktOkP9XOCFJk2A7EwNN0DcC+d+DhXyHDk9K 16u0nWwWKvesE/u56xdSvhALyCwa/l2n/QfweUL+a7TP3Bbf0jd91ItMDmlB/8r60nhC 8AQd2LSCP9HNivJZmXINPX2tEBp7Vxjxg+gwPSFHvtuvKOa2Tw7YjZpf9ruZRxT8h5XZ samg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727490642; x=1728095442; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OZ/wHMNg0d+dVALsuK0UnbKStRq6V9Y0t0+9ftzzOzI=; b=h1yy2jhO8igDVh7AvmoTgsF+HdXawajlVOgdE6ZjjESeoQhlkTdMFQSB7bp40svXnZ LR+GUfdS2QKhIILGnDd+4xMkQinmU/AAKOQ3SxfPG32wwMjufAIVnjpvnFCP7/wINHqz 0D8g0XcZ9j1R29UX+qGOebnppcARktoA2CMODUpGLPxBPDd20vmbrBTFdH7NCkahV4bY 1MnWjiwu4xlKw4C1iyKP+inQJNi5inK6XHUlRH7f6BXQZO5wA2KaaZ6LV3/M2mWR5YgP ySfne4qKv96kYEORBR6AvVc5TSLpLs6KbNMoDAkmgf9X54fIIaF4Gv6vR3X2MmPGGcPa rvUA== X-Forwarded-Encrypted: i=1; AJvYcCUdBm3kaUl7ISv+5SxOKwmpIJCDFn6b9c8H2rGYLBEjjNZZxJpTU3lZfVSJdc0LZ7aHM/h7BJfONQ==@kvack.org X-Gm-Message-State: AOJu0YwTtrXMD9z556+6Z95s2IcoKfGsYtF9OIbgrV9MWhKhdx36Lhj8 3KOpJaujw/pmFVa4y2pJ5ZicvfajxeSPFvth2seaKhPc+7b3KEkc1te0SCf7HSMrtIF3UgfqtvU yUqQ6GW6COBRewXGevFcfRb/T8+T8lNvSQcM+ X-Google-Smtp-Source: AGHT+IEckE1V7emNRJoahGMNy6LaBiiwJXt/HE2bsdWFZ8PKiaKO8kTBJzYFXUhiDlBPaxpQF3bRj2SzBSKg6Z8lSBY= X-Received: by 2002:a17:906:794d:b0:a8e:a578:29df with SMTP id a640c23a62f3a-a93c48f0c1cmr534977766b.6.1727490641730; Fri, 27 Sep 2024 19:30:41 -0700 (PDT) MIME-Version: 1.0 References: <20240928021620.8369-1-kanchana.p.sridhar@intel.com> <20240928021620.8369-2-kanchana.p.sridhar@intel.com> In-Reply-To: <20240928021620.8369-2-kanchana.p.sridhar@intel.com> From: Yosry Ahmed Date: Fri, 27 Sep 2024 19:30:06 -0700 Message-ID: Subject: Re: [PATCH v8 1/8] mm: Define obj_cgroup_get() if CONFIG_MEMCG is not defined. To: Kanchana P Sridhar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, shakeel.butt@linux.dev, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, akpm@linux-foundation.org, nanhai.zou@intel.com, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 7B507A0007 X-Rspamd-Server: rspam01 X-Stat-Signature: abatzcif8baxuuktjio3nqj9p9t81cuz X-HE-Tag: 1727490643-456429 X-HE-Meta: U2FsdGVkX1/fX1DmiRGNiPtMVKw+NDtU+Wg6f8mRpJeDjcAY3zOvHGlFCTTPGcI6fPA0tZTMf32UCcufpNBLag6kZ4BtlHXX/NpsS6QPuNPvABfESB22TyVbxBfSayqMMQEHDeD0VXgzvRlcB8PDQGaiSLO0TxKP2HQWvC1yMvq/MT2oF1BzIa0ykhBB9LTJ1ZojvvUvtkIPq4gMJAmirNvBr6Kf3v/VMbkepffYIRc3CgnHbqGPK2OgdWoiyQIb5zJBOxitZYh9Q3tMpFFOyp1ivbEYk3VXxHLzoxtyYH9xQoV9IJAJcjNIbdol/hKZBnjX8JQpjjW6c8CSi8y4U0nqc4c6cPZXHiLWWodBRhn74g8i6GmZ1xqYPETQjajhEnXU1ewlT8oEV8nx4pYYog1u/uzW8ZQVQtrWxH2M4YSwA+9vSDNtf3QHWLoqYo/nlbnYB/L1E17sfj+rJ7q2bM2mxceAqkweM+OSc8s2YxQeEdutylH8c4qAAxnpxjt32DpGs5A0/NOzapBS4csyuzoOL10LfmyQ42GyEUVgiHtOf3QJTzwqc8RgIc06ibx57QYc7Uk7nxFJHwZRIMHCmRBztrNiu3CJ6kHgKlsTcqZ+jmEdwK3r4s8Qa3NW9p/uvYmq3G3BDlRH+nHrNjsNHYU9emZezXR+1VzY/3zFrL/wciaNAqttMijdLlnZguFWaNBvO7eDf9cja/2p795+p++/YYlxP1V+p0zO78nuc/ga3Qz1eqI5fUoNbC/ConGukB/TKZO86OMhAr/JjhzHQxRrjNyCZmnlPDz5JeqYkGW4cXTdFb7bdSH5cPMtZAJvMywfd/Wmo+W9tmSD0Ir3puvly1kilwQLrF5edU1jNpbam4OM4BizzLzHYmNIozJKTBG1AcAOisw8WFMv42SWuCVHZG6qQhiJYu0G1P9d/CCkRgE28hq+RnzFGXcUGe99CkmuqVgaQT7bqk+0fJ2 D4l9arRI MJcUYQSzpELt0ZN4oal0ujigMZwsXb4k/dtpvghAbOmn/kOKQb/uVzUrODANkY8Znr0u9bWJuk1KGeJ+rsELPBuCHciDQUt9KxDtjUwlnJfajUYEqqDOTRSZ0tDiNDKJ1aNj4lZhBbrOjxmPd2DG4er/UEtC3crld6cuSV1WJfoRQXAQpqTqBUPFMhc8ov3nBXOw/3x+ftuqLxYxtmI1GxD4o45e/jtiOsjDztZ0+7SaMq4fL3OiL3JSX5JdEqteHj1Q4X4ORTQlw/Gq9oaKFl4DQAKklQEPQEwANZ8JxeAhmiTpo4TR+6ZTaYQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.008077, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Sep 27, 2024 at 7:16=E2=80=AFPM Kanchana P Sridhar wrote: > > This resolves an issue with obj_cgroup_get() not being defined if > CONFIG_MEMCG is not defined. > > Before this patch, we would see build errors if obj_cgroup_get() is > called from code that is agnostic of CONFIG_MEMCG. > > The zswap_store() changes for large folios in subsequent commits will > require the use of obj_cgroup_get() in zswap code that falls into this > category. > > Signed-off-by: Kanchana P Sridhar > Reviewed-by: Nhat Pham ' Reviewed-by: Yosry Ahmed > --- > include/linux/memcontrol.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 34d2da05f2f1..15c2716f9aa3 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -1282,6 +1282,10 @@ struct mem_cgroup *mem_cgroup_from_css(struct cgro= up_subsys_state *css) > return NULL; > } > > +static inline void obj_cgroup_get(struct obj_cgroup *objcg) > +{ > +} > + > static inline void obj_cgroup_put(struct obj_cgroup *objcg) > { > } > -- > 2.27.0 >